Re: [PATCH] svm: Fix MISRA 8.2 violation

2024-04-26 Thread George Dunlap
On Thu, Apr 25, 2024 at 5:00 PM Andrew Cooper wrote: > > On 25/04/2024 10:12 am, George Dunlap wrote: > > Misra 8.2 requires named parameters in prototypes. Use the name from > > the implementaiton. > > > > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). > > Nit. We treat

Re: [PATCH] svm: Fix MISRA 8.2 violation

2024-04-25 Thread Andrew Cooper
On 25/04/2024 10:12 am, George Dunlap wrote: > Misra 8.2 requires named parameters in prototypes. Use the name from > the implementaiton. > > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). Nit.  We treat Fixes: as a tag. Also you might want to include the Reported-by's.

Re: [PATCH] svm: Fix MISRA 8.2 violation

2024-04-25 Thread Jan Beulich
On 25.04.2024 11:12, George Dunlap wrote: > Misra 8.2 requires named parameters in prototypes. Use the name from > the implementaiton. > > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). > > Signed-off-by: George Dunlap Acked-by: Jan Beulich

[PATCH] svm: Fix MISRA 8.2 violation

2024-04-25 Thread George Dunlap
Misra 8.2 requires named parameters in prototypes. Use the name from the implementaiton. Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). Signed-off-by: George Dunlap --- CC: Andrew Cooper CC: Jan Beulich CC: Roger Pau Monne CC: Nicola Vetrini --- xen/arch/x86/include