Re: [PATCH] public/domctl: Fix the struct xen_domctl ABI in 32bit builds

2020-07-28 Thread Jan Beulich
On 28.07.2020 12:15, Andrew Cooper wrote: The Xen domctl ABI currently relies on the union containing a field with alignment of 8. 32bit projects which only copy the used subset of functionality end up with an ABI breakage if they don't have at least one uint64_aligned_t field copied. I'm enti

Re: [PATCH] public/domctl: Fix the struct xen_domctl ABI in 32bit builds

2020-07-28 Thread Julien Grall
Hi Andrew, On 28/07/2020 11:15, Andrew Cooper wrote: The Xen domctl ABI currently relies on the union containing a field with alignment of 8. 32bit projects which only copy the used subset of functionality end up with an ABI breakage if they don't have at least one uint64_aligned_t field copied

[PATCH] public/domctl: Fix the struct xen_domctl ABI in 32bit builds

2020-07-28 Thread Andrew Cooper
The Xen domctl ABI currently relies on the union containing a field with alignment of 8. 32bit projects which only copy the used subset of functionality end up with an ABI breakage if they don't have at least one uint64_aligned_t field copied. Insert explicit padding, and some build assertions to