Re: [PATCH] libxl: Always set ao for qmp_proxy_spawn_outcome

2022-03-31 Thread Jason Andryuk
On Thu, Mar 31, 2022 at 9:24 AM Anthony PERARD wrote: > > On Wed, Mar 30, 2022 at 02:16:58PM -0400, Jason Andryuk wrote: > > diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c > > index 9a8ddbe188..59a8dcf3a9 100644 > > --- a/tools/libs/light/libxl_dm.c > > +++ b/tools/libs/lig

Re: [PATCH] libxl: Always set ao for qmp_proxy_spawn_outcome

2022-03-31 Thread Anthony PERARD
On Wed, Mar 30, 2022 at 02:16:58PM -0400, Jason Andryuk wrote: > diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c > index 9a8ddbe188..59a8dcf3a9 100644 > --- a/tools/libs/light/libxl_dm.c > +++ b/tools/libs/light/libxl_dm.c > @@ -2468,6 +2468,9 @@ static void spawn_stub_launch

[PATCH] libxl: Always set ao for qmp_proxy_spawn_outcome

2022-03-30 Thread Jason Andryuk
I've observed this failed assertion: libxl_event.c:2057: libxl__ao_inprogress_gc: Assertion `ao' failed. AFAICT, this is happening in qmp_proxy_spawn_outcome where sdss->qmp_proxy_spawn.ao is NULL. The out label of spawn_stub_launch_dm calls qmp_proxy_spawn_outcome, but it is only in the success