Re: [PATCH] libs/light: make it build without setresuid()

2021-01-30 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 11:39:03AM +, Ian Jackson wrote: > [...] > Taking a step back, I think this series is very close to going in, if > not actually ready. Do you have a git branch version of this ? Actually no. I'm not used to git, and I find it quite hard to use (and is a large part of t

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-28 Thread Ian Jackson
Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without setresuid()"): > On Wed, Jan 27, 2021 at 04:03:04PM +, Ian Jackson wrote: > > How about I write a patch splitting the relevant part up into a > > version for systems with setresuid and systems with

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-27 Thread Manuel Bouyer
On Wed, Jan 27, 2021 at 04:03:04PM +, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without > > setresuid()"): > > >

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-27 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH] libs/light: make it build without setresuid()"): > Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > On Wed, Jan 20, 2021 at 05:10:36PM +, Ian Jackson wrote: > > > My last m

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Ian Jackson
Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without setresuid()"): > On Wed, Jan 20, 2021 at 05:10:36PM +, Ian Jackson wrote: > > My last mail had in it a thing that claims to be a proof that this is > > not possible. > > This code: &g

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Manuel Bouyer
On Wed, Jan 20, 2021 at 05:10:36PM +, Ian Jackson wrote: > Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > On Wed, Jan 20, 2021 at 03:32:29PM +, Ian Jackson wrote: > > > Yes, the dm is qemu. If qemu restricti

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Ian Jackson
Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without setresuid()"): > On Wed, Jan 20, 2021 at 03:32:29PM +, Ian Jackson wrote: > > Yes, the dm is qemu. If qemu restriction is not supported, that makes > > a big difference. The complex situation her

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Manuel Bouyer
On Wed, Jan 20, 2021 at 03:32:29PM +, Ian Jackson wrote: > Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > On Wed, Jan 20, 2021 at 02:52:06PM +, Ian Jackson wrote: > > > I don't think setuid is safe - at

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Ian Jackson
Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without setresuid()"): > On Wed, Jan 20, 2021 at 02:52:06PM +, Ian Jackson wrote: > > I don't think setuid is safe - at least, if we are trying to restrict > > the dm. Since I think after the libxl c

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Manuel Bouyer
On Wed, Jan 20, 2021 at 02:52:06PM +, Ian Jackson wrote: > Roger Pau Monné writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > On Tue, Jan 12, 2021 at 07:12:36PM +0100, Manuel Bouyer wrote: > > > From: Manuel Bouyer > > > >

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH] libs/light: make it build without setresuid()"): > On Tue, Jan 12, 2021 at 07:12:36PM +0100, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > NetBSD doesn't have setresuid(). Add a configure check for it, > >

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:36PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > NetBSD doesn't have setresuid(). Add a configure check for it, > and use plain setuid() if !HAVE_SETRESUID > > Signed-off-by: Manuel Bouyer LGTM from a code PoV, but I think George/Ian should take a look,

[PATCH] libs/light: make it build without setresuid()

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer NetBSD doesn't have setresuid(). Add a configure check for it, and use plain setuid() if !HAVE_SETRESUID Signed-off-by: Manuel Bouyer --- tools/configure | 13 + tools/configure.ac | 3 +++ tools/libs/light/libxl_dm.c | 10 ++ 3 fil