Re: [PATCH] hw/display/xenfb: Replace unreachable code by abort()

2025-07-29 Thread Daniel P . Berrangé
On Tue, Jul 29, 2025 at 02:59:46PM +0200, Philippe Mathieu-Daudé wrote: > On 29/7/25 14:16, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > > > On 29/7/25 13:12, Markus Armbruster wrote: > > > > xenfb_mouse_event() has a switch statement whose controlling > > > > expression move

Re: [PATCH] hw/display/xenfb: Replace unreachable code by abort()

2025-07-29 Thread Philippe Mathieu-Daudé
On 29/7/25 14:16, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 29/7/25 13:12, Markus Armbruster wrote: xenfb_mouse_event() has a switch statement whose controlling expression move->axis is an enum InputAxis. The enum values are INPUT_AXIS_X and INPUT_AXIS_Y, encoded as 0 and 1.

Re: [PATCH] hw/display/xenfb: Replace unreachable code by abort()

2025-07-29 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 29/7/25 13:12, Markus Armbruster wrote: >> xenfb_mouse_event() has a switch statement whose controlling >> expression move->axis is an enum InputAxis. The enum values are >> INPUT_AXIS_X and INPUT_AXIS_Y, encoded as 0 and 1. The switch has a >> case for both

Re: [PATCH] hw/display/xenfb: Replace unreachable code by abort()

2025-07-29 Thread Philippe Mathieu-Daudé
On 29/7/25 13:12, Markus Armbruster wrote: xenfb_mouse_event() has a switch statement whose controlling expression move->axis is an enum InputAxis. The enum values are INPUT_AXIS_X and INPUT_AXIS_Y, encoded as 0 and 1. The switch has a case for both axes. In addition, it has an unreachable def

[PATCH] hw/display/xenfb: Replace unreachable code by abort()

2025-07-29 Thread Markus Armbruster
xenfb_mouse_event() has a switch statement whose controlling expression move->axis is an enum InputAxis. The enum values are INPUT_AXIS_X and INPUT_AXIS_Y, encoded as 0 and 1. The switch has a case for both axes. In addition, it has an unreachable default label. This convinces Coverity that move