Re: [PATCH] fix invalid frontend path for set_mtu

2022-04-27 Thread Anthony PERARD
On Wed, Apr 27, 2022 at 02:20:53PM +0100, James Dingwall wrote: > commit f6ec92717522e74b4cc3aa4160b8ad6884e0b50c > Author: James Dingwall > Date: Tue Apr 19 12:45:31 2022 +0100 > > The set_mtu() function of xen-network-common.sh currently has this code: > > if [ ${type_if}

Re: [PATCH] fix invalid frontend path for set_mtu

2022-04-27 Thread James Dingwall
On 2022-04-27 10:17, Anthony PERARD wrote: On Tue, Apr 19, 2022 at 01:04:18PM +0100, James Dingwall wrote: Thank you for your feedback. I've updated the patch as suggested. I've also incorporated two other changes, one is a simple style change for consistency, the other is to change a the tes

Re: [PATCH] fix invalid frontend path for set_mtu

2022-04-27 Thread Anthony PERARD
On Tue, Apr 19, 2022 at 01:04:18PM +0100, James Dingwall wrote: > Thank you for your feedback. I've updated the patch as suggested. I've also > incorporated two other changes, one is a simple style change for consistency, > the other is to change a the test for a valid mtu from > 0 to >= 68. I c

Re: [PATCH] fix invalid frontend path for set_mtu

2022-04-19 Thread James Dingwall
Hi Anthony, On Tue, Apr 12, 2022 at 02:03:17PM +0100, Anthony PERARD wrote: > Hi James, > > On Tue, Mar 01, 2022 at 09:35:13AM +, James Dingwall wrote: > > The set_mtu() function of xen-network-common.sh currently has this code: > > > > if [ ${type_if} = vif ] > > then > >

Re: [PATCH] fix invalid frontend path for set_mtu

2022-04-12 Thread Anthony PERARD
Hi James, On Tue, Mar 01, 2022 at 09:35:13AM +, James Dingwall wrote: > The set_mtu() function of xen-network-common.sh currently has this code: > > if [ ${type_if} = vif ] > then > local dev_=${dev#vif} > local domid=${dev_%.*} > local devi

[PATCH] fix invalid frontend path for set_mtu

2022-03-01 Thread James Dingwall
Hi, The set_mtu() function of xen-network-common.sh currently has this code: if [ ${type_if} = vif ] then local dev_=${dev#vif} local domid=${dev_%.*} local devid=${dev_#*.} local FRONTEND_PATH="/local/domain/$domid/device/vif/$devi