Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-04-03 Thread George Dunlap
On Tue, Mar 19, 2024 at 3:39 AM Stefano Stabellini wrote: > > The main use of fixed width types, to me, is in interface structure > > definitions - between Xen and hardware / firmware, or in hypercall > > structures. I'm afraid I have a hard time seeing good uses outside of > > that. Even in inlin

Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-03-18 Thread Stefano Stabellini
On Mon, 18 Mar 2024, Jan Beulich wrote: > The named reasons simply aren't convincing to me, at all. There's no > loss towards the "end goals" when "unsigned int" is used instead of > "uint32_t". Plus I recall Andrew putting under question use of > "unsigned int" for various hypercall parameter decl

Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-03-18 Thread Jan Beulich
On 15.03.2024 15:45, George Dunlap wrote: > On Fri, Mar 15, 2024 at 2:13 PM Jan Beulich wrote: >> On 15.03.2024 14:55, Julien Grall wrote: >>> On 15/03/2024 13:24, Jan Beulich wrote: On 15.03.2024 13:17, George Dunlap wrote: > On Fri, Mar 15, 2024 at 11:57 AM Jan Beulich wrote: >>> I

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-15 Thread Stefano Stabellini
On Fri, 15 Mar 2024, George Dunlap wrote: > On Fri, Mar 15, 2024 at 2:13 PM Jan Beulich wrote: > > > > On 15.03.2024 14:55, Julien Grall wrote: > > > Hi Jan, > > > > > > On 15/03/2024 13:24, Jan Beulich wrote: > > >> On 15.03.2024 13:17, George Dunlap wrote: > > >>> On Fri, Mar 15, 2024 at 11:57 A

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-15 Thread George Dunlap
On Fri, Mar 15, 2024 at 2:13 PM Jan Beulich wrote: > > On 15.03.2024 14:55, Julien Grall wrote: > > Hi Jan, > > > > On 15/03/2024 13:24, Jan Beulich wrote: > >> On 15.03.2024 13:17, George Dunlap wrote: > >>> On Fri, Mar 15, 2024 at 11:57 AM Jan Beulich wrote: > > It sounds like Andy and Stef

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-15 Thread Jan Beulich
On 15.03.2024 14:55, Julien Grall wrote: > Hi Jan, > > On 15/03/2024 13:24, Jan Beulich wrote: >> On 15.03.2024 13:17, George Dunlap wrote: >>> On Fri, Mar 15, 2024 at 11:57 AM Jan Beulich wrote: > It sounds like Andy and Stefano feel like this is a situation where "a > fixed width quanti

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-15 Thread Julien Grall
Hi Jan, On 15/03/2024 13:24, Jan Beulich wrote: On 15.03.2024 13:17, George Dunlap wrote: On Fri, Mar 15, 2024 at 11:57 AM Jan Beulich wrote: It sounds like Andy and Stefano feel like this is a situation where "a fixed width quantity is meant"; absent any further guidance from the CODING_STYL

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-15 Thread Jan Beulich
On 15.03.2024 13:17, George Dunlap wrote: > On Fri, Mar 15, 2024 at 11:57 AM Jan Beulich wrote: >>> It sounds like Andy and Stefano feel like this is a situation where "a >>> fixed width quantity is meant"; absent any further guidance from the >>> CODING_STYLE about when fixed widths should or sho

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-15 Thread George Dunlap
On Fri, Mar 15, 2024 at 11:57 AM Jan Beulich wrote: > > It sounds like Andy and Stefano feel like this is a situation where "a > > fixed width quantity is meant"; absent any further guidance from the > > CODING_STYLE about when fixed widths should or should not be used, I > > don't think this chan

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-15 Thread Jan Beulich
On 15.03.2024 11:59, George Dunlap wrote: > On Fri, Mar 15, 2024 at 6:54 AM Jan Beulich wrote: >> On 15.03.2024 01:21, Stefano Stabellini wrote: >>> On Mon, 11 Mar 2024, Julien Grall wrote: On 11/03/2024 11:32, George Dunlap wrote: > On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini >

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-15 Thread George Dunlap
On Fri, Mar 15, 2024 at 6:54 AM Jan Beulich wrote: > > On 15.03.2024 01:21, Stefano Stabellini wrote: > > On Mon, 11 Mar 2024, Julien Grall wrote: > >> On 11/03/2024 11:32, George Dunlap wrote: > >>> On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini > >>> wrote: > > I would like to resu

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-14 Thread Jan Beulich
On 15.03.2024 01:21, Stefano Stabellini wrote: > On Mon, 11 Mar 2024, Julien Grall wrote: >> On 11/03/2024 11:32, George Dunlap wrote: >>> On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini >>> wrote: I would like to resurrect this thread and ask other opinions. On Thu, 23

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Julien Grall wrote: > On 11/03/2024 11:32, George Dunlap wrote: > > On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini > > wrote: > > > > > > I would like to resurrect this thread and ask other opinions. > > > > > > > > > On Thu, 23 Nov 2023, Jan Beulich wrote: > > > > On 22

Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-03-11 Thread Julien Grall
Hi, On 11/03/2024 11:32, George Dunlap wrote: On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini wrote: I would like to resurrect this thread and ask other opinions. On Thu, 23 Nov 2023, Jan Beulich wrote: On 22.11.2023 22:46, Stefano Stabellini wrote: Two out of three do_multicall definit

Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-03-11 Thread George Dunlap
On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini wrote: > > I would like to resurrect this thread and ask other opinions. > > > On Thu, 23 Nov 2023, Jan Beulich wrote: > > On 22.11.2023 22:46, Stefano Stabellini wrote: > > > Two out of three do_multicall definitions/declarations use uint32_t as >

Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-03-08 Thread Stefano Stabellini
I would like to resurrect this thread and ask other opinions. On Thu, 23 Nov 2023, Jan Beulich wrote: > On 22.11.2023 22:46, Stefano Stabellini wrote: > > Two out of three do_multicall definitions/declarations use uint32_t as > > type for the "nr_calls" parameters. Change the third one to be > >

Re: [PATCH] do_multicall and MISRA Rule 8.3

2023-11-23 Thread Jan Beulich
On 22.11.2023 22:46, Stefano Stabellini wrote: > Two out of three do_multicall definitions/declarations use uint32_t as > type for the "nr_calls" parameters. Change the third one to be > consistent with the other two. > > Link: > https://lore.kernel.org/xen-devel/7e3abd4c0ef5127a07a60de1bf090a8a

[PATCH] do_multicall and MISRA Rule 8.3

2023-11-22 Thread Stefano Stabellini
Two out of three do_multicall definitions/declarations use uint32_t as type for the "nr_calls" parameters. Change the third one to be consistent with the other two. Link: https://lore.kernel.org/xen-devel/7e3abd4c0ef5127a07a60de1bf090a8aefac8e5c.1692717906.git.federico.seraf...@bugseng.com/ Link