Re: [PATCH] common: don't require use of DOMID_SELF

2021-01-15 Thread Jan Beulich
On 14.01.2021 16:01, Andrew Cooper wrote: > On 14/01/2021 14:02, Jan Beulich wrote: >> --- a/xen/common/page_alloc.c >> +++ b/xen/common/page_alloc.c >> @@ -2566,13 +2566,7 @@ __initcall(register_heap_trigger); >> >> struct domain *get_pg_owner(domid_t domid) >> { >> -struct domain *pg_owne

Re: [PATCH] common: don't require use of DOMID_SELF

2021-01-15 Thread Jan Beulich
On 15.01.2021 10:59, Julien Grall wrote: > On 14/01/2021 15:30, Jan Beulich wrote: >> On 14.01.2021 15:43, Julien Grall wrote: >>> On 14/01/2021 14:02, Jan Beulich wrote: It's not overly difficult for a domain to figure out its ID, so requiring the use of DOMID_SELF in a very limited set

Re: [PATCH] common: don't require use of DOMID_SELF

2021-01-15 Thread Julien Grall
Hi Jan, On 14/01/2021 15:30, Jan Beulich wrote: On 14.01.2021 15:43, Julien Grall wrote: On 14/01/2021 14:02, Jan Beulich wrote: It's not overly difficult for a domain to figure out its ID, so requiring the use of DOMID_SELF in a very limited set of places isn't really helpful towards keeping

Re: [PATCH] common: don't require use of DOMID_SELF

2021-01-14 Thread Jan Beulich
On 14.01.2021 16:01, Andrew Cooper wrote: > On 14/01/2021 14:02, Jan Beulich wrote: >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -2776,15 +2776,19 @@ struct gnttab_copy_buf { >> static int gnttab_copy_lock_domain(domid_t domid, bool is_gref, >>

Re: [PATCH] common: don't require use of DOMID_SELF

2021-01-14 Thread Andrew Cooper
On 14/01/2021 15:30, Jan Beulich wrote: > On 14.01.2021 15:43, Julien Grall wrote: >> On 14/01/2021 14:02, Jan Beulich wrote: >>> It's not overly difficult for a domain to figure out its ID, so >>> requiring the use of DOMID_SELF in a very limited set of places isn't >>> really helpful towards keep

Re: [PATCH] common: don't require use of DOMID_SELF

2021-01-14 Thread Jan Beulich
On 14.01.2021 15:43, Julien Grall wrote: > On 14/01/2021 14:02, Jan Beulich wrote: >> It's not overly difficult for a domain to figure out its ID, so >> requiring the use of DOMID_SELF in a very limited set of places isn't >> really helpful towards keeping the ID opaque to the guest. > > So I agre

Re: [PATCH] common: don't require use of DOMID_SELF

2021-01-14 Thread Andrew Cooper
On 14/01/2021 14:02, Jan Beulich wrote: > It's not overly difficult for a domain to figure out its ID, so > requiring the use of DOMID_SELF in a very limited set of places isn't > really helpful towards keeping the ID opaque to the guest. > > Signed-off-by: Jan Beulich > > --- a/xen/common/grant_t

Re: [PATCH] common: don't require use of DOMID_SELF

2021-01-14 Thread Julien Grall
Hi Jan, On 14/01/2021 14:02, Jan Beulich wrote: It's not overly difficult for a domain to figure out its ID, so requiring the use of DOMID_SELF in a very limited set of places isn't really helpful towards keeping the ID opaque to the guest. So I agree that a domid can be figured out really eas

[PATCH] common: don't require use of DOMID_SELF

2021-01-14 Thread Jan Beulich
It's not overly difficult for a domain to figure out its ID, so requiring the use of DOMID_SELF in a very limited set of places isn't really helpful towards keeping the ID opaque to the guest. Signed-off-by: Jan Beulich --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -2776,15 +2