Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Julien Grall
Hi Jan, On 06/12/2023 11:08, Jan Beulich wrote: On 06.12.2023 12:07, Julien Grall wrote: Hi Jan, On 06/12/2023 11:05, Jan Beulich wrote: On 06.12.2023 11:52, Julien Grall wrote: Hi Jan, On 06/12/2023 08:52, Jan Beulich wrote: On 05.12.2023 19:32, Julien Grall wrote: From: Julien Grall R

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Jason Andryuk
On Tue, Dec 5, 2023 at 4:49 PM Julien Grall wrote: > > From: Julien Grall > > Right now, all tools and hypervisor will be complied with the option > -Wdeclaration-after-statement. While most of the code in the hypervisor > is controlled by us, for tools we may import external libraries. > > The b

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Anthony PERARD
On Tue, Dec 05, 2023 at 06:32:26PM +, Julien Grall wrote: > From: Julien Grall > > Right now, all tools and hypervisor will be complied with the option > -Wdeclaration-after-statement. While most of the code in the hypervisor > is controlled by us, for tools we may import external libraries.

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Andrew Cooper
On 06/12/2023 8:52 am, Jan Beulich wrote: > On 05.12.2023 19:32, Julien Grall wrote: >> From: Julien Grall >> >> Right now, all tools and hypervisor will be complied with the option >> -Wdeclaration-after-statement. While most of the code in the hypervisor >> is controlled by us, for tools we may

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Jan Beulich
On 06.12.2023 12:07, Julien Grall wrote: > Hi Jan, > > On 06/12/2023 11:05, Jan Beulich wrote: >> On 06.12.2023 11:52, Julien Grall wrote: >>> Hi Jan, >>> >>> On 06/12/2023 08:52, Jan Beulich wrote: On 05.12.2023 19:32, Julien Grall wrote: > From: Julien Grall > > Right now, all

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Julien Grall
Hi Jan, On 06/12/2023 11:05, Jan Beulich wrote: On 06.12.2023 11:52, Julien Grall wrote: Hi Jan, On 06/12/2023 08:52, Jan Beulich wrote: On 05.12.2023 19:32, Julien Grall wrote: From: Julien Grall Right now, all tools and hypervisor will be complied with the option -Wdeclaration-after-stat

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Jan Beulich
On 06.12.2023 11:52, Julien Grall wrote: > Hi Jan, > > On 06/12/2023 08:52, Jan Beulich wrote: >> On 05.12.2023 19:32, Julien Grall wrote: >>> From: Julien Grall >>> >>> Right now, all tools and hypervisor will be complied with the option >>> -Wdeclaration-after-statement. While most of the code

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Julien Grall
Hi Jan, On 06/12/2023 08:52, Jan Beulich wrote: On 05.12.2023 19:32, Julien Grall wrote: From: Julien Grall Right now, all tools and hypervisor will be complied with the option -Wdeclaration-after-statement. While most of the code in the hypervisor is controlled by us, for tools we may import

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-06 Thread Jan Beulich
On 05.12.2023 19:32, Julien Grall wrote: > From: Julien Grall > > Right now, all tools and hypervisor will be complied with the option > -Wdeclaration-after-statement. While most of the code in the hypervisor > is controlled by us, for tools we may import external libraries. > > The build will f

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-05 Thread Julien Grall
Hi Andrew, On 05/12/2023 19:49, Andrew Cooper wrote: On 05/12/2023 6:32 pm, Julien Grall wrote: diff --git a/xen/Makefile b/xen/Makefile index ca571103c868..360fb6dcae57 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -393,6 +393,7 @@ CFLAGS-$(CONFIG_CC_SPLIT_SECTIONS) += -ffunction-sections -

Re: [PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-05 Thread Andrew Cooper
On 05/12/2023 6:32 pm, Julien Grall wrote: > diff --git a/xen/Makefile b/xen/Makefile > index ca571103c868..360fb6dcae57 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -393,6 +393,7 @@ CFLAGS-$(CONFIG_CC_SPLIT_SECTIONS) += -ffunction-sections > -fdata-sections > > CFLAGS += -nostdinc -fn

[PATCH] Only compile the hypervisor with -Wdeclaration-after-statement

2023-12-05 Thread Julien Grall
From: Julien Grall Right now, all tools and hypervisor will be complied with the option -Wdeclaration-after-statement. While most of the code in the hypervisor is controlled by us, for tools we may import external libraries. The build will fail if one of them are using the construct we are tryin