Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-21 Thread Andrew Cooper
On 20/04/2022 06:52, Jan Beulich wrote: > On 19.04.2022 18:06, Andrew Cooper wrote: >> On 19/04/2022 16:52, Juergen Gross wrote: >>> On 19.04.22 17:48, Andrew Cooper wrote: On 19/04/2022 10:39, Jan Beulich wrote: > Besides the reporter's issue of hitting a NULL deref when > !CONFIG_GDB

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Jan Beulich
On 19.04.2022 18:06, Andrew Cooper wrote: > On 19/04/2022 16:52, Juergen Gross wrote: >> On 19.04.22 17:48, Andrew Cooper wrote: >>> On 19/04/2022 10:39, Jan Beulich wrote: Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, XEN_DOMCTL_test_assign_device can legi

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Jan Beulich
On 19.04.2022 17:39, Andrew Cooper wrote: > On 19/04/2022 11:59, Jan Beulich wrote: >> On 19.04.2022 12:49, Andrew Cooper wrote: >>> On 19/04/2022 10:39, Jan Beulich wrote: >>> Furthermore, under what circumstances is test_assign_device legitimate >>> when passing DOMID_INVALID ?  This has been bro

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Andrew Cooper
On 19/04/2022 16:52, Juergen Gross wrote: > On 19.04.22 17:48, Andrew Cooper wrote: >> On 19/04/2022 10:39, Jan Beulich wrote: >>> Besides the reporter's issue of hitting a NULL deref when >>> !CONFIG_GDBSX, >>> XEN_DOMCTL_test_assign_device can legitimately end up having NULL >>> passed >>> here,

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Juergen Gross
On 19.04.22 17:48, Andrew Cooper wrote: On 19/04/2022 10:39, Jan Beulich wrote: Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed here, when the domctl was passed DOMID_INVALID. Fixes: 71e617a6b8f6 (

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Andrew Cooper
On 19/04/2022 10:39, Jan Beulich wrote: > Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, > XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed > here, when the domctl was passed DOMID_INVALID. > > Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appr

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Andrew Cooper
On 19/04/2022 11:59, Jan Beulich wrote: > On 19.04.2022 12:49, Andrew Cooper wrote: >> On 19/04/2022 10:39, Jan Beulich wrote: >> Furthermore, under what circumstances is test_assign_device legitimate >> when passing DOMID_INVALID ?  This has been broken for 3 years now >> without report, so it's c

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Jan Beulich
On 19.04.2022 12:49, Andrew Cooper wrote: > On 19/04/2022 10:39, Jan Beulich wrote: >> Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, >> XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed >> here, when the domctl was passed DOMID_INVALID. >> >> Fixes:

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Andrew Cooper
On 19/04/2022 10:39, Jan Beulich wrote: > Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, > XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed > here, when the domctl was passed DOMID_INVALID. > > Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appr

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Juergen Gross
On 19.04.22 11:39, Jan Beulich wrote: Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed here, when the domctl was passed DOMID_INVALID. Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate..

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Durrant, Paul
On 19/04/2022 10:39, Jan Beulich wrote: Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed here, when the domctl was passed DOMID_INVALID. Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate

[PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Jan Beulich
Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed here, when the domctl was passed DOMID_INVALID. Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...") Reported-by: Cheyenne Wills Signed-