Re: [PATCH] Arm64: fix build with gcc 10

2020-09-08 Thread Bertrand Marquis
> On 8 Sep 2020, at 15:08, Jan Beulich wrote: > > On 08.09.2020 15:05, Bertrand Marquis wrote: >>> On 8 Sep 2020, at 13:53, Jan Beulich wrote: >>> >>> With gcc10 inlining is (no longer?) the default for certain atomics. >>> >>> Suggested-by: Julien Grall >>> Signed-off-by: Jan Beulich >>>

Re: [PATCH] Arm64: fix build with gcc 10

2020-09-08 Thread Jan Beulich
On 08.09.2020 15:03, Julien Grall wrote: > I would suggest: "xen/arm64: Force GCC to always inline generic atomics > helpers". > > On 08/09/2020 13:53, Jan Beulich wrote: >> With gcc10 inlining is (no longer?) the default for certain atomics. > > How about the following: > > "Recent versions of

Re: [PATCH] Arm64: fix build with gcc 10

2020-09-08 Thread Jan Beulich
On 08.09.2020 15:05, Bertrand Marquis wrote: >> On 8 Sep 2020, at 13:53, Jan Beulich wrote: >> >> With gcc10 inlining is (no longer?) the default for certain atomics. >> >> Suggested-by: Julien Grall >> Signed-off-by: Jan Beulich >> --- a/xen/arch/arm/arch.mk >> +++ b/xen/arch/arm/arch.mk >> @@

Re: [PATCH] Arm64: fix build with gcc 10

2020-09-08 Thread Bertrand Marquis
> On 8 Sep 2020, at 13:53, Jan Beulich wrote: > > With gcc10 inlining is (no longer?) the default for certain atomics. > > Suggested-by: Julien Grall > Signed-off-by: Jan Beulich > --- a/xen/arch/arm/arch.mk > +++ b/xen/arch/arm/arch.mk > @@ -12,6 +12,7 @@ CFLAGS-$(CONFIG_ARM_32) += -mcpu=co

Re: [PATCH] Arm64: fix build with gcc 10

2020-09-08 Thread Julien Grall
Hi Jan, I would suggest: "xen/arm64: Force GCC to always inline generic atomics helpers". On 08/09/2020 13:53, Jan Beulich wrote: With gcc10 inlining is (no longer?) the default for certain atomics. How about the following: "Recent versions of GCC (at least GCC10) will not inline generic a

[PATCH] Arm64: fix build with gcc 10

2020-09-08 Thread Jan Beulich
With gcc10 inlining is (no longer?) the default for certain atomics. Suggested-by: Julien Grall Signed-off-by: Jan Beulich --- a/xen/arch/arm/arch.mk +++ b/xen/arch/arm/arch.mk @@ -12,6 +12,7 @@ CFLAGS-$(CONFIG_ARM_32) += -mcpu=cortex- CFLAGS-$(CONFIG_ARM_64) += -mcpu=generic CFLAGS-$(CONFI