Re: [PATCH] AMD/IOMMU: drop remaining guest-IOMMU bits too

2024-03-21 Thread Roger Pau Monné
On Wed, Mar 20, 2024 at 03:51:55PM +0100, Jan Beulich wrote: > On 20.03.2024 15:06, Roger Pau Monné wrote: > > On Wed, Mar 20, 2024 at 11:58:50AM +0100, Jan Beulich wrote: > >> On 20.03.2024 11:46, Roger Pau Monné wrote: > >>> On Tue, Mar 19, 2024 at 02:28:12PM +0100, Jan Beulich wrote: > With

Re: [PATCH] AMD/IOMMU: drop remaining guest-IOMMU bits too

2024-03-20 Thread Jan Beulich
On 20.03.2024 15:06, Roger Pau Monné wrote: > On Wed, Mar 20, 2024 at 11:58:50AM +0100, Jan Beulich wrote: >> On 20.03.2024 11:46, Roger Pau Monné wrote: >>> On Tue, Mar 19, 2024 at 02:28:12PM +0100, Jan Beulich wrote: With a02174c6c885 ("amd/iommu: clean up unused guest iommu related fun

Re: [PATCH] AMD/IOMMU: drop remaining guest-IOMMU bits too

2024-03-20 Thread Roger Pau Monné
On Wed, Mar 20, 2024 at 11:58:50AM +0100, Jan Beulich wrote: > On 20.03.2024 11:46, Roger Pau Monné wrote: > > On Tue, Mar 19, 2024 at 02:28:12PM +0100, Jan Beulich wrote: > >> With a02174c6c885 ("amd/iommu: clean up unused guest iommu related > >> functions") having removed the sole place where d-

Re: [PATCH] AMD/IOMMU: drop remaining guest-IOMMU bits too

2024-03-20 Thread Jan Beulich
On 20.03.2024 11:46, Roger Pau Monné wrote: > On Tue, Mar 19, 2024 at 02:28:12PM +0100, Jan Beulich wrote: >> With a02174c6c885 ("amd/iommu: clean up unused guest iommu related >> functions") having removed the sole place where d->g_iommu would be set >> to non-NULL, guest_iommu_add_ppr_log() will

Re: [PATCH] AMD/IOMMU: drop remaining guest-IOMMU bits too

2024-03-20 Thread Roger Pau Monné
On Tue, Mar 19, 2024 at 02:28:12PM +0100, Jan Beulich wrote: > With a02174c6c885 ("amd/iommu: clean up unused guest iommu related > functions") having removed the sole place where d->g_iommu would be set > to non-NULL, guest_iommu_add_ppr_log() will unconditionally bail the > latest from its 2nd if

[PATCH] AMD/IOMMU: drop remaining guest-IOMMU bits too

2024-03-19 Thread Jan Beulich
With a02174c6c885 ("amd/iommu: clean up unused guest iommu related functions") having removed the sole place where d->g_iommu would be set to non-NULL, guest_iommu_add_ppr_log() will unconditionally bail the latest from its 2nd if(). With it dropped, all other stuff in the file is unused, too. Dele