Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-24 Thread Andrew Cooper
On 23/02/2021 07:13, Jan Beulich wrote: > On 22.02.2021 17:47, Andrew Cooper wrote: >> On 22/02/2021 14:22, Jan Beulich wrote: >>> On 22.02.2021 15:14, Andrew Cooper wrote: On 22/02/2021 10:27, Jan Beulich wrote: > Now that we guard the entire Xen VA space against speculative abuse > t

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Jan Beulich
On 22.02.2021 17:47, Andrew Cooper wrote: > On 22/02/2021 14:22, Jan Beulich wrote: >> On 22.02.2021 15:14, Andrew Cooper wrote: >>> On 22/02/2021 10:27, Jan Beulich wrote: Now that we guard the entire Xen VA space against speculative abuse through hypervisor accesses to guest memory, the

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Roger Pau Monné
On Mon, Feb 22, 2021 at 04:47:38PM +, Andrew Cooper wrote: > On 22/02/2021 14:22, Jan Beulich wrote: > > On 22.02.2021 15:14, Andrew Cooper wrote: > >> On 22/02/2021 10:27, Jan Beulich wrote: > >>> Now that we guard the entire Xen VA space against speculative abuse > >>> through hypervisor acce

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Andrew Cooper
On 22/02/2021 14:22, Jan Beulich wrote: > On 22.02.2021 15:14, Andrew Cooper wrote: >> On 22/02/2021 10:27, Jan Beulich wrote: >>> Now that we guard the entire Xen VA space against speculative abuse >>> through hypervisor accesses to guest memory, the argument translation >>> area's VA also needs t

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Roger Pau Monné
On Mon, Feb 22, 2021 at 03:20:24PM +0100, Jan Beulich wrote: > On 22.02.2021 15:13, Roger Pau Monné wrote: > > On Mon, Feb 22, 2021 at 12:35:21PM +0100, Roger Pau Monné wrote: > >> On Mon, Feb 22, 2021 at 11:27:07AM +0100, Jan Beulich wrote: > >>> Now that we guard the entire Xen VA space against s

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Jan Beulich
On 22.02.2021 15:14, Andrew Cooper wrote: > On 22/02/2021 10:27, Jan Beulich wrote: >> Now that we guard the entire Xen VA space against speculative abuse >> through hypervisor accesses to guest memory, the argument translation >> area's VA also needs to live outside this range, at least for 32-bit

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Jan Beulich
On 22.02.2021 15:13, Roger Pau Monné wrote: > On Mon, Feb 22, 2021 at 12:35:21PM +0100, Roger Pau Monné wrote: >> On Mon, Feb 22, 2021 at 11:27:07AM +0100, Jan Beulich wrote: >>> Now that we guard the entire Xen VA space against speculative abuse >>> through hypervisor accesses to guest memory, the

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Andrew Cooper
On 22/02/2021 10:27, Jan Beulich wrote: > Now that we guard the entire Xen VA space against speculative abuse > through hypervisor accesses to guest memory, the argument translation > area's VA also needs to live outside this range, at least for 32-bit PV > guests. To avoid extra is_hvm_*() conditi

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Roger Pau Monné
On Mon, Feb 22, 2021 at 12:35:21PM +0100, Roger Pau Monné wrote: > On Mon, Feb 22, 2021 at 11:27:07AM +0100, Jan Beulich wrote: > > Now that we guard the entire Xen VA space against speculative abuse > > through hypervisor accesses to guest memory, the argument translation > > area's VA also needs

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Jan Beulich
On 22.02.2021 12:35, Roger Pau Monné wrote: > On Mon, Feb 22, 2021 at 11:27:07AM +0100, Jan Beulich wrote: >> Now that we guard the entire Xen VA space against speculative abuse >> through hypervisor accesses to guest memory, the argument translation >> area's VA also needs to live outside this ran

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Roger Pau Monné
On Mon, Feb 22, 2021 at 11:27:07AM +0100, Jan Beulich wrote: > Now that we guard the entire Xen VA space against speculative abuse > through hypervisor accesses to guest memory, the argument translation > area's VA also needs to live outside this range, at least for 32-bit PV > guests. To avoid ext

Re: [PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Ian Jackson
Jan Beulich writes ("[PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV"): > Now that we guard the entire Xen VA space against speculative abuse > through hypervisor accesses to guest memory, the argument translation > area's VA also needs to liv

[PATCH][4.15] x86: mirror compat argument translation area for 32-bit PV

2021-02-22 Thread Jan Beulich
Now that we guard the entire Xen VA space against speculative abuse through hypervisor accesses to guest memory, the argument translation area's VA also needs to live outside this range, at least for 32-bit PV guests. To avoid extra is_hvm_*() conditionals, use the alternative VA uniformly. While