[Xen-devel] [PATCH v4 0/4] Support for reading runtime hypervisor parameters

2019-05-28 Thread Vasilis Liaskovitis
(OPT_CUSTOM) are not supported yet. I'd like to do this in a follow-up series. See also discussion at https://lists.xenproject.org/archives/html/xen-devel/2019-03/msg01383.html - For integer parameters (OPT_UINT), only unsigned parameters are printed correctly at the moment. Vas

[Xen-devel] [PATCH v4 1/4] xen: add hypercall for reading runtime parameters

2019-05-28 Thread Vasilis Liaskovitis
be changed to read all hypervisor parameters if needed. Signed-off-by: Vasilis Liaskovitis --- tools/flask/policy/modules/dom0.te | 2 +- xen/common/kernel.c | 118 xen/common/sysctl.c | 52 +++- xen/include/public

[Xen-devel] [PATCH v4 2/4] libxc: add function to get hypervisor parameters

2019-05-28 Thread Vasilis Liaskovitis
Add a new libxc function to get hypervisor parameters. Signed-off-by: Vasilis Liaskovitis --- tools/libxc/include/xenctrl.h | 1 + tools/libxc/xc_misc.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include

[Xen-devel] [PATCH v4 3/4] libxl: add libxl_get_parameters() function

2019-05-28 Thread Vasilis Liaskovitis
Add a new libxl function to get hypervisor parameters. Signed-off-by: Vasilis Liaskovitis --- tools/libxl/libxl.c | 19 +++ tools/libxl/libxl.h | 1 + 2 files changed, 20 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index ec71574e99..9bb0382c38 100644

[Xen-devel] [PATCH v4 4/4] xl: add new xl command get-parameters

2019-05-28 Thread Vasilis Liaskovitis
rs gnttab_max_frames gnttab_max_frames : 128 xl get-parameters "gnttab_max_frames gnttab_max_maptrack_frames" gnttab_max_frames gnttab_max_maptrack_frames : 128 1024 Signed-off-by: Vasilis Liaskovitis --- docs/man/xl.1.pod.in | 5 + tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c

[Xen-devel] [PATCH v3 1/4] xen: add hypercall for reading runtime parameters

2019-05-09 Thread Vasilis Liaskovitis
be changed to read all hypervisor parameters if needed. Signed-off-by: Vasilis Liaskovitis --- tools/flask/policy/modules/dom0.te | 2 +- xen/common/kernel.c | 118 xen/common/sysctl.c | 52 +++- xen/include/public

[Xen-devel] [PATCH v3 2/4] libxc: add function to get hypervisor parameters

2019-05-09 Thread Vasilis Liaskovitis
Add a new libxc function to get hypervisor parameters. Signed-off-by: Vasilis Liaskovitis --- tools/libxc/include/xenctrl.h | 1 + tools/libxc/xc_misc.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include

[Xen-devel] [PATCH v3 4/4] xl: add new xl command get-parameters

2019-05-09 Thread Vasilis Liaskovitis
rs gnttab_max_frames gnttab_max_frames : 128 xl get-parameters "gnttab_max_frames gnttab_max_maptrack_frames" gnttab_max_frames gnttab_max_maptrack_frames : 128 1024 Signed-off-by: Vasilis Liaskovitis --- docs/man/xl.1.pod.in | 5 + tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c

[Xen-devel] [PATCH v3 0/4] Support for reading runtime hypervisor parameters

2019-05-09 Thread Vasilis Liaskovitis
gnttab_max_frames=128 xl get-parameters gnttab_max_frames gnttab_max_frames : 128 xl get-parameters "gnttab_max_frames gnttab_max_maptrack_frames" gnttab_max_frames gnttab_max_maptrack_frames : 128 1024 Vasilis Liaskovitis (4): xen: add hypercall for getting parameters at runtime libxc

[Xen-devel] [PATCH v3 3/4] libxl: add libxl_get_parameters() function

2019-05-09 Thread Vasilis Liaskovitis
Add a new libxl function to get hypervisor parameters. Signed-off-by: Vasilis Liaskovitis --- tools/libxl/libxl.c | 15 +++ tools/libxl/libxl.h | 1 + 2 files changed, 16 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index ec71574e99..124033e5a3 100644 --- a

Re: [Xen-devel] [PATCH v2 1/4] xen: add hypercall for getting parameters at runtime

2019-04-30 Thread Vasilis Liaskovitis
Sorry for the delay, I was on a long vacation. On Fri, 2019-04-05 at 17:01 +0200, Jan Beulich wrote:On 22.03.19 at 20:28, wrote: > > Limitations: > > - Custom runtime parameters (OPT_CUSTOM) are not supported yet. > > - For integer parameters (OPT_UINT), only unsigned parameters are > > printed >

[Xen-devel] [PATCH v2 3/4] libxl: add libxl_get_parameters() function

2019-03-22 Thread Vasilis Liaskovitis
Add a new libxl function to get hypervisor parameters at runtime. Signed-off-by: Vasilis Liaskovitis --- tools/libxl/libxl.c | 15 +++ tools/libxl/libxl.h | 1 + 2 files changed, 16 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index ec71574e99..124033e5a3

[Xen-devel] [PATCH v2 2/4] libxc: add function to get hypervisor parameters

2019-03-22 Thread Vasilis Liaskovitis
Add a new libxc function to get hypervisor parameters at runtime. Signed-off-by: Vasilis Liaskovitis --- tools/libxc/include/xenctrl.h | 1 + tools/libxc/xc_misc.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/tools/libxc/include/xenctrl.h b/tools

[Xen-devel] [PATCH v2 4/4] xl: add new xl command get-parameters

2019-03-22 Thread Vasilis Liaskovitis
Add a new xl command "get-parameters" to get hypervisor parameters at runtime. Signed-off-by: Vasilis Liaskovitis --- docs/man/xl.1.pod.in | 5 + tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 5 + tools/xl/xl_misc.c | 25 + 4 files c

[Xen-devel] [PATCH v2 0/4] Support for reading hypervisor parameters at runtime

2019-03-22 Thread Vasilis Liaskovitis
max_frames gnttab_max_maptrack_frames : 128 1024 Vasilis Liaskovitis (4): xen: add hypercall for getting parameters at runtime libxc: add function to get hypervisor parameters libxl: add libxl_get_parameters() function xl: add new xl command get-parameters docs/man/xl.1.pod.in

[Xen-devel] [PATCH v2 1/4] xen: add hypercall for getting parameters at runtime

2019-03-22 Thread Vasilis Liaskovitis
Add a sysctl hypercall to support getting hypervisor parameters at runtime. Limitations: - Custom runtime parameters (OPT_CUSTOM) are not supported yet. - For integer parameters (OPT_UINT), only unsigned parameters are printed correctly. Signed-off-by: Vasilis Liaskovitis --- tools/flask

Re: [Xen-devel] [PATCH v1 1/4] xen: add hypercall for getting parameters at runtime

2019-03-22 Thread Vasilis Liaskovitis
On Mon, 2019-03-18 at 18:01 +0100, Jan Beulich wrote: > > > > An alternative prototype could be: > > > > int (*get_func)(char *output); > > > > if we want the function to write the current parameter value > > > > into a > > > > caller-provided buffer, and possibly return error codes. >

Re: [Xen-devel] [PATCH v1 1/4] xen: add hypercall for getting parameters at runtime

2019-03-18 Thread Vasilis Liaskovitis
On Mon, 2019-03-18 at 15:02 +0100, Jan Beulich wrote: > > > > From the return value of strcmp()? I don't think so, because > > > > you > may have run past all table entries. Instead it's that property > that you can use, i.e. checking whether ... > > > > > +for ( param = start; param < end

Re: [Xen-devel] [PATCH v1 1/4] xen: add hypercall for getting parameters at runtime

2019-03-18 Thread Vasilis Liaskovitis
thanks for the review. On Wed, 2019-03-13 at 17:35 +0100, Jan Beulich wrote: > > > > On 06.03.19 at 13:58, wrote: > > +static int get_params(const char *cmdline, char *values, > > + const struct kernel_param *start, > > + const struct kernel_param *end) >

[Xen-devel] [PATCH v1 1/4] xen: add hypercall for getting parameters at runtime

2019-03-06 Thread Vasilis Liaskovitis
Add a sysctl hypercall to support getting hypervisor parameters at runtime. Signed-off-by: Vasilis Liaskovitis --- tools/flask/policy/modules/dom0.te | 2 +- xen/common/kernel.c | 109 xen/common/sysctl.c | 45 xen

[Xen-devel] [PATCH v1 4/4] xl: add new xl command get-parameters

2019-03-06 Thread Vasilis Liaskovitis
Add a new xl command "get-parameters" to get hypervisor parameters at runtime. Signed-off-by: Vasilis Liaskovitis --- docs/man/xl.1.pod.in | 5 + tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 5 + tools/xl/xl_misc.c | 25 + 4 files c

[Xen-devel] [PATCH v1 0/4] Support for reading hypervisor parameters at runtime

2019-03-06 Thread Vasilis Liaskovitis
t-parameters gnttab_max_frames gnttab_max_frames : 128 xl get-parameters "gnttab_max_frames gnttab_max_maptrack_frames" gnttab_max_frames gnttab_max_maptrack_frames : 128 1024 Vasilis Liaskovitis (4): xen: add hypercall for getting parameters at runtime libxc: add function to get hypervisor para

[Xen-devel] [PATCH v1 2/4] libxc: add function to get hypervisor parameters

2019-03-06 Thread Vasilis Liaskovitis
Add a new libxc function to get hypervisor parameters at runtime. Signed-off-by: Vasilis Liaskovitis --- tools/libxc/include/xenctrl.h | 1 + tools/libxc/xc_misc.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/tools/libxc/include/xenctrl.h b/tools

[Xen-devel] [PATCH v1 3/4] libxl: add libxl_get_parameters() function

2019-03-06 Thread Vasilis Liaskovitis
Add a new libxl function to get hypervisor parameters at runtime. Signed-off-by: Vasilis Liaskovitis --- tools/libxl/libxl.c | 15 +++ tools/libxl/libxl.h | 1 + 2 files changed, 16 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index ec71574e99..124033e5a3

Re: [Xen-devel] [PATCH v2] xen/blkfront: avoid NULL blkfront_info dereference on device removal

2018-10-15 Thread Vasilis Liaskovitis
On Mon, 2018-10-15 at 16:02 +0200, Roger Pau Monné wrote: > > > This results in a NULL pointer BUG when blkfront_remove and > > blkif_free > > try to access the failing device's NULL struct blkfront_info. > > > > > I guess this is a candidate for backporting? > yes, I think so. At least for ke

[Xen-devel] [PATCH v2] xen/blkfront: avoid NULL blkfront_info dereference on device removal

2018-10-15 Thread Vasilis Liaskovitis
ev, NULL); This results in a NULL pointer BUG when blkfront_remove and blkif_free try to access the failing device's NULL struct blkfront_info. Signed-off-by: Vasilis Liaskovitis --- drivers/block/xen-blkfront.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/block/xen-blkfront

Re: [Xen-devel] [PATCH] xen/blkfront: avoid NULL blkfront_info dereference on device removal

2018-10-15 Thread Vasilis Liaskovitis
On Thu, 2018-10-11 at 18:34 +0200, Roger Pau Monné wrote: > --- a/drivers/block/xen-blkfront.c > > +++ b/drivers/block/xen-blkfront.c > > @@ -2493,6 +2493,9 @@ static int blkfront_remove(struct > > xenbus_device *xbdev) > > > > dev_dbg(&xbdev->dev, "%s removed", xbdev->nodename); > > > > +

[Xen-devel] [PATCH] xen/blkfront: avoid NULL blkfront_info dereference on device removal

2018-10-11 Thread Vasilis Liaskovitis
ev, NULL); This results in a NULL pointer BUG when blkfront_remove and blkif_free try to access the failing device's NULL struct blkfront_info. Signed-off-by: Vasilis Liaskovitis --- drivers/block/xen-blkfront.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/block/xen-blkfront