[PATCH] xen/grant-dma-iommu: Convert to platform remove callback returning void

lways returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/xen/grant-dma-iommu.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/xen/grant-dma-iommu.c b/drivers/xen/grant-dma-iommu.c index 6a9fe02

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

On Thu, Jul 13, 2023 at 10:41:45AM -0400, Sean Paul wrote: > On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König > > But even with the one-patch-per-rename approach I'd consider the > > renaming a net win, because ease of understanding code has a big value. > > It's val

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

alue. It's value is not so easy measurable as "conflicts when backporting", but it also matters in say two years from now, while backporting shouldn't be an issue then any more. Thanks for your input, best regards Uwe -- Pengutronix e.K. | Uwe Kleine-Köni

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

On Thu, Jul 13, 2023 at 08:52:12AM +0200, Geert Uytterhoeven wrote: > Hi Uwe, > > Let's add some fuel to keep the thread alive ;-) > > On Wed, Jul 12, 2023 at 6:13 PM Uwe Kleine-König > wrote: > > On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > &g

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

On Thu, Jul 13, 2023 at 12:03:05PM +0300, Jani Nikula wrote: > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > Hello Jani, > > > > On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > >> On Wed, 12 Jul 2023, Uwe Kleine-König > >> wrote: > >

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

Hello Jani, On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > Hello, > > > > while I debugged an issue in the imx-lcdc driver I was constantly > > irritated about struct drm_device pointer variables being n

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

Hello Maxime, On Wed, Jul 12, 2023 at 02:52:38PM +0200, Maxime Ripard wrote: > On Wed, Jul 12, 2023 at 01:02:53PM +0200, Uwe Kleine-König wrote: > > > Background is that this makes merge conflicts easier to handle and detect. > > > > Really? > > FWIW, I agree wi

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

On Wed, Jul 12, 2023 at 12:46:33PM +0200, Christian König wrote: > Am 12.07.23 um 11:46 schrieb Uwe Kleine-König: > > Hello, > > > > while I debugged an issue in the imx-lcdc driver I was constantly > > irritated about struct drm_device pointer variables being named

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

Hello Thomas, On Wed, Jul 12, 2023 at 12:19:37PM +0200, Thomas Zimmermann wrote: > Am 12.07.23 um 11:46 schrieb Uwe Kleine-König: > > Hello, > > > > while I debugged an issue in the imx-lcdc driver I was constantly > > irritated about struct drm_device pointer

[PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

4 using an allmodconfig (though I only build drivers/gpu/). Best regards Uwe Uwe Kleine-König (52): drm/crtc: Start renaming struct drm_crtc::dev to drm_dev drm/core: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev drm/amd: Use struct drm_crtc::drm_dev instead of struct drm_crtc:

[PATCH RFC v1 50/52] drm/xen: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/xen/xen_drm_front_kms.c | 10 +- 1 fi

Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's bound driver

Hello, On Wed, Oct 13, 2021 at 05:54:28AM -0500, Bjorn Helgaas wrote: > On Wed, Oct 13, 2021 at 10:51:31AM +0200, Uwe Kleine-König wrote: > > On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote: > > > diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/g

Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's bound driver

On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote: > On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-König wrote: > > Hello, > > > > this is v6 of the quest to drop the "driver" member from struct pci_dev > > which tracks the same data (apart

[PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's bound driver

properly handle that to_pci_driver(X) is wrong if X is NULL. This should fix the problem reported by Ido Schimmel. Full range diff below. This patch stack survived an allmodconfig build on arm64, m68k, powerpc, riscv, s390, sparc64 and x86_64 on top of v5.15-rc3. Best regards Uwe Uwe Klei

[PATCH v6 10/11] PCI: Replace pci_dev::driver usage by pci_dev::dev.driver

struct pci_dev::driver contains (apart from a constant offset) the same data as struct pci_dev::dev->driver. Replace all remaining users of the former pointer by the latter to allow removing the former. Reviewed-by: Boris Ostrovsky Signed-off-by: Uwe Kleine-König --- arch/powerpc/ker

[PATCH v6 03/11] xen/pci: Drop some checks that are always true

pcifront_common_process() has a check at the start that exits early if pcidev or pdidev->driver are NULL. So simplify the following code by not checking these two again. Reviewed-by: Boris Ostrovsky Reviewed-by: Christoph Hellwig Signed-off-by: Uwe Kleine-König --- drivers/pci/xen-pcifron

Re: [PATCH v5 10/11] PCI: Replace pci_dev::driver usage by pci_dev::dev.driver

On Wed, Sep 29, 2021 at 11:15:37PM +1000, Andrew Donnellan wrote: > On 29/9/21 6:53 pm, Uwe Kleine-König wrote:> > list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list) { > > - if (afu_dev->driver

[PATCH v5 00/11] PCI: Drop duplicated tracking of a pci_dev's bound driver

ggested fix. I didn't replace :: by . as suggested by Bjorn as I'm unsure if his preference is stronger than mine. This patch stack survived an allmodconfig build on arm64, m68k, powerpc, riscv, s390, sparc64 and x86_64 on top of v5.15-rc3. Best regards Uwe Uwe Kleine-König (11): PCI:

[PATCH v5 10/11] PCI: Replace pci_dev::driver usage by pci_dev::dev.driver

struct pci_dev::driver contains (apart from a constant offset) the same data as struct pci_dev::dev->driver. Replace all remaining users of the former pointer by the latter to allow removing the former. Reviewed-by: Boris Ostrovsky Signed-off-by: Uwe Kleine-König --- arch/powerpc/ker

[PATCH v5 03/11] xen/pci: Drop some checks that are always true

pcifront_common_process() has a check at the start that exits early if pcidev or pdidev->driver are NULL. So simplify the following code by not checking these two again. Reviewed-by: Boris Ostrovsky Reviewed-by: Christoph Hellwig Signed-off-by: Uwe Kleine-König --- drivers/pci/xen-pcifron

[PATCH v4 7/8] PCI: Replace pci_dev::driver usage by pci_dev::dev.driver

From: Uwe Kleine-König struct pci_dev::driver contains (apart from a constant offset) the same data as struct pci_dev::dev->driver. Replace all remaining users of the former pointer by the latter to allow removing the former. Reviewed-by: Boris Ostrovsky Signed-off-by: Uwe Kleine-Kö

[PATCH v4 0/8] PCI: Drop duplicated tracking of a pci_dev's bound driver

From: Uwe Kleine-König Hello, this is v4 of the quest to drop the "driver" member from struct pci_dev which tracks the same data (apart from a constant offset) as dev.driver. Changes since v3: - Add some Reviewed-by and Acked-by tags - Rebase to v5.15-rc3 (no conflicts) - Change

[PATCH v4 3/8] xen/pci: Drop some checks that are always true

From: Uwe Kleine-König pcifront_common_process() has a check at the start that exits early if pcidev or pdidev->driver are NULL. So simplify the following code by not checking these two again. Reviewed-by: Boris Ostrovsky Reviewed-by: Christoph Hellwig Signed-off-by: Uwe Kleine-Kö

Re: [PATCH v4 0/8] PCI: Drop duplicated tracking of a pci_dev's bound driver

Hello, On Mon, Sep 27, 2021 at 10:43:18PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König I sent the series from the wrong email address :-\ I should have used the above address as sender. Also I failed to add Christoph Hellwig to Cc: (fixed for this mail). I guess I'll have t

Re: [PATCH v3 3/8] xen/pci: Drop some checks that are always true

tent below to facilitate replying. Sorry for the inconvenience, Uwe On Wed, Aug 11, 2021 at 10:06:32AM +0200, Uwe Kleine-König wrote: > pcifront_common_process() has a check at the start that exits early if > pcidev or pdidev->driver are NULL. So simplify the following code by not > ch

[PATCH v3 0/8] PCI: Drop duplicated tracking of a pci_dev's bound driver

From: Uwe Kleine-König Hello, Today the following is always true for a struct pci_dev *pdev: pdev->driver == pdev->dev.driver ? to_pci_driver(pdev->dev.driver) : NULL This series is about getting rid of struct pci_dev::driver. The first three patches are u

[PATCH v3 7/8] PCI: Replace pci_dev::driver usage by pci_dev::dev.driver

struct pci_dev::driver contains (apart from a constant offset) the same data as struct pci_dev::dev->driver. Replace all remaining users of the former pointer by the latter to allow removing the former. Signed-off-by: Uwe Kleine-König --- arch/powerpc/kernel/eeh_driver.c | 10 - a

Re: [PATCH v2 0/6] PCI: Drop duplicated tracking of a pci_dev's bound driver

On Fri, Aug 06, 2021 at 04:24:52PM -0500, Bjorn Helgaas wrote: > On Fri, Aug 06, 2021 at 08:46:23AM +0200, Uwe Kleine-König wrote: > > On Thu, Aug 05, 2021 at 06:42:34PM -0500, Bjorn Helgaas wrote: > > > > I looked at all the bus_type.probe() methods, it looks like pci_dev

Re: [PATCH v2 0/6] PCI: Drop duplicated tracking of a pci_dev's bound driver

Hello Bjorn, On Thu, Aug 05, 2021 at 06:42:34PM -0500, Bjorn Helgaas wrote: > On Tue, Aug 03, 2021 at 12:01:44PM +0200, Uwe Kleine-König wrote: > > Hello, > > > > changes since v1 > > (https://lore.kernel.org/linux-pci/20210729203740.1377045-1-u.kleine-koe...@peng

[PATCH v2 6/6] PCI: Drop duplicated tracking of a pci_dev's bound driver

from struct pci_dev. Signed-off-by: Uwe Kleine-König --- drivers/pci/pci-driver.c | 4 include/linux/pci.h | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 740d5bf5d411..5d950eb476e2 100644 --- a/drivers/pc

[PATCH v2 5/6] PCI: Adapt all code locations to not use struct pci_dev::driver directly

This prepares removing the driver member of struct pci_dev which holds the same information than struct pci_dev::dev->driver. Signed-off-by: Uwe Kleine-König --- arch/powerpc/include/asm/ppc-pci.h| 3 +- arch/powerpc/kernel/eeh_driver.c | 12 --- arch/x86/eve

[PATCH v2 0/6] PCI: Drop duplicated tracking of a pci_dev's bound driver

introduced abstracting access to struct pci_dev->driver. All users are then converted to use this and in the last patch the macro is changed to make use of struct pci_dev::dev->driver to get rid of the duplicated tracking. Best regards Uwe Uwe Kleine-König (6): PCI: Simplify pci_device_

[PATCH v2 4/6] PCI: Provide wrapper to access a pci_dev's bound driver

er using pci_dev::dev->driver. Signed-off-by: Uwe Kleine-König --- include/linux/pci.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/pci.h b/include/linux/pci.h index 540b377ca8f6..778f3b5e6f23 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -887,6 +887,7 @@ struct

[PATCH v2 3/6] xen/pci: Drop some checks that are always true

pcifront_common_process() has a check at the start that exits early if pcidev or pdidev->driver are NULL. So simplify the following code by not checking these two again. Signed-off-by: Uwe Kleine-König --- drivers/pci/xen-pcifront.c | 57 +- 1 file chan

Re: [PATCH v1 4/5] PCI: Adapt all code locations to not use struct pci_dev::driver directly

Hello Boris, On Fri, Jul 30, 2021 at 04:37:31PM -0400, Boris Ostrovsky wrote: > On 7/29/21 4:37 PM, Uwe Kleine-König wrote: > > --- a/drivers/pci/xen-pcifront.c > > +++ b/drivers/pci/xen-pcifront.c > > @@ -599,12 +599,12 @@ static pci_ers_result_t pcifront_common

Re: [PATCH v1 0/5] PCI: Drop duplicated tracking of a pci_dev's bound driver

Hi Andy, On Fri, Jul 30, 2021 at 11:06:20AM +0300, Andy Shevchenko wrote: > On Thu, Jul 29, 2021 at 10:37:35PM +0200, Uwe Kleine-König wrote: > > struct pci_dev tracks the bound pci driver twice. This series is about > > removing this duplication. > > > > The first tw

[PATCH v1 0/5] PCI: Drop duplicated tracking of a pci_dev's bound driver

he patch introducing the wrapper. Patch 4 could be split by maintainer tree or squashed into patch 3 completely. Best regards Uwe Uwe Kleine-König (5): PCI: Simplify pci_device_remove() PCI: Drop useless check from pci_device_probe() PCI: Provide wrapper to access a pci_dev's bound driver PCI: A

[PATCH v1 4/5] PCI: Adapt all code locations to not use struct pci_dev::driver directly

This prepares removing the driver member of struct pci_dev which holds the same information than struct pci_dev::dev->driver. Signed-off-by: Uwe Kleine-König --- arch/powerpc/include/asm/ppc-pci.h| 3 +- arch/powerpc/kernel/eeh_driver.c | 12 --- arch/x86/eve

[PATCH v4 5/5] bus: Make remove callback return void

ewire) Acked-by: Benjamin Tissoires (For hid) Acked-by: Thorsten Scherer (For siox) Acked-by: Sven Van Asbroeck (For anybuss) Acked-by: Ulf Hansson (For MMC) Signed-off-by: Uwe Kleine-König --- arch/arm/common/locomo.c | 3 +-- arch/arm/common/sa.c | 4 +--- ar

[PATCH v4 0/5] bus: Make remove callback return void

zorro-driver.c sound/ac97/bus.c Best regards Uwe Uwe Kleine-König (5): PCI: endpoint: Make struct pci_epf_driver::remove return void s390/cio: Make struct css_driver::remove return void s390/ccwgroup: Drop if with an always false condition s390/scm: Make struct scm_driver::remove return void

[PATCH v3 5/5] bus: Make remove callback return void

ewire) Acked-by: Benjamin Tissoires (For hid) Acked-by: Thorsten Scherer (For siox) Acked-by: Sven Van Asbroeck (For anybuss) Acked-by: Ulf Hansson (For MMC) Signed-off-by: Uwe Kleine-König --- arch/arm/common/locomo.c | 3 +-- arch/arm/common/sa.c | 4 +--- ar

[PATCH v3 0/5] bus: Make remove callback return void

that, this should be fixed now. Best regards Uwe Changes since v2: - Add several acks/review tags - Include patch #1 explicitly - rebase to v5.14-rc1, build test on amd64, arm64 and s390 using allmodconfig Uwe Kleine-König (5): PCI: endpoint: Make struct pci_epf_driver::remove return void

Re: [PATCH v2 0/4] bus: Make remove callback return void

On Wed, Jul 07, 2021 at 10:08:53PM -0400, Sven Van Asbroeck wrote: > On Tue, Jul 6, 2021 at 11:50 AM Uwe Kleine-König > wrote: > > > > drivers/staging/fieldbus/anybuss/host.c | 4 +--- > > Awesome ! > > Acked-by: Sven Van Asbroeck I note that as an Ack for pat

[PATCH v2 0/4] bus: Make remove callback return void

1-u.kleine-koe...@pengutronix.de. Best regards Uwe Uwe Kleine-König (4): s390/cio: Make struct css_driver::remove return void s390/ccwgroup: Drop if with an always false condition s390/scm: Make struct scm_driver::remove return void bus: Make remove callback return void arch/arm/commo

Re: [PATCH v2 4/4] bus: Make remove callback return void

Hello, v1 was acked by some more after I stopped looking in my mailbox while preparing v2: On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. >

[PATCH v2 4/4] bus: Make remove callback return void

cked-by: Heikki Krogerus (For ulpi and typec) Acked-by: Samuel Iglesias Gonsálvez (For ipack) Reviewed-by: Tom Rix (For fpga) Acked-by: Geoff Levand (For ps3) Signed-off-by: Uwe Kleine-König --- arch/arm/common/locomo.c | 3 +-- arch/arm/common/sa.c | 4 +---

Re: [PATCH v2 4/4] bus: Make remove callback return void

ice_ops virtio_rpmsg_ops = { though it's not obvious for me that the last hunk is sensible. (OTOH the return code is ignored anyhow as rpmsg_dev_remove() is the only caller. Best regards and thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | https://www.pengutronix.de/ | signature.asc Description: PGP signature

Re: [PATCH] bus: Make remove callback return void

On Tue, Jul 06, 2021 at 01:17:37PM +0200, Cornelia Huck wrote: > On Tue, Jul 06 2021, Cornelia Huck wrote: > > > On Tue, Jul 06 2021, Uwe Kleine-König > > wrote: > > > >> The driver core ignores the return value of this callback because there > >&

[PATCH] bus: Make remove callback return void

uthors. Signed-off-by: Uwe Kleine-König --- Hello, this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove return void" that is not yet applied, see https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koe...@pengutronix.de. I tested it using allmodconfig on amd64 a