Re: [PATCH v2 18/26] xen/domctl: wrap xsm_getdomaininfo() with CONFIG_MGMT_HYPERCALLS

2025-10-02 Thread Stefano Stabellini
On Sun, 28 Sep 2025, Jan Beulich wrote: > On 26.09.2025 21:24, Stefano Stabellini wrote: > > On Thu, 25 Sep 2025, Penny, Zheng wrote: > >>> -Original Message- > >>> From: Jan Beulich > >>> Sent: Friday, September 26, 2025 2:53 PM > >&

RE: [PATCH v2 18/26] xen/domctl: wrap xsm_getdomaininfo() with CONFIG_MGMT_HYPERCALLS

2025-09-26 Thread Stefano Stabellini
On Thu, 25 Sep 2025, Penny, Zheng wrote: > > -Original Message- > > From: Jan Beulich > > Sent: Friday, September 26, 2025 2:53 PM > > To: Penny, Zheng > > Cc: Huang, Ray ; Daniel P. Smith > > ; xen-devel@lists.xenproject.org; Stabellini, > > Stefano ; Andryuk, Jason > > > > Subject: Re:

Re: [RFC PATCH] xen/arm: Introduce GICV3 Self Tests

2025-09-22 Thread Stefano Stabellini
On Fri, 12 Sep 2025, Ayan Kumar Halder wrote: > Introduce CONFIG_GICV3_SELFTEST to enclose tests for GICv3 driver. > Test that Xen is able to generate SGIs. > > Signed-off-by: Ayan Kumar Halder > --- > One of the aim of functional safety is to test hw/sw interface. This means > that > Xen is abl

Re: [PATCH] MAINTAINERS: add myself as vPCI reviewer

2025-09-22 Thread Stefano Stabellini
On Mon, 22 Sep 2025, Stewart Hildebrand wrote: > I'd like to take a more active role in reviewing vPCI bits. > > Signed-off-by: Stewart Hildebrand Acked-by: Stefano Stabellini > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAIN

Re: [PATCH TEST-ARTEFACTS] Be explicit about root in scripts/alpine-rootfs.sh

2025-09-20 Thread Stefano Stabellini
On Tue, 9 Sep 2025, dmuk...@xen.org wrote: > On Tue, Sep 09, 2025 at 06:01:11PM +0100, Andrew Cooper wrote: > > The container is running as root, but be explicit anyway. > > > > No functional change. > > > > Signed-off-by: Andrew Cooper > > Reviewe

Re: [XEN][PATCH] xen/arm: restrict cpu_up_send_sgi() to arm32

2025-09-20 Thread Stefano Stabellini
On Fri, 12 Sep 2025, Julien Grall wrote: > Hi Grygorii, > > On 11/09/2025 09:12, Grygorii Strashko wrote: > > From: Grygorii Strashko > > > > Restrict cpu_up_send_sgi() function to arm32 code as it's used by arm32 > > platforms only and unreachable on arm64 (Misra rule 2.1). > > > > Signed-off-

Re: [PATCH v9 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support

2025-09-17 Thread Stefano Stabellini
; >>>> - reneregated {helpers/types}.gen.go, dropped unneeded parameters > >>>> > >>>> Changes in v7: > >>>> - fix sci_handl_call to make changes more readable > >>>> - fix build error when DOM0LESS_BUILD is disabled (removed >

Re: [PATCH v4 0/8] CI: Add Debian Trixie

2025-09-12 Thread Stefano Stabellini
/2036687955 Acked-by: Stefano Stabellini

Re: [PATCH v2 11/26] xen/domctl: wrap domain_set_node_affinity() with CONFIG_MGMT_HYPERCALLS

2025-09-11 Thread Stefano Stabellini
ransiently with CONFIG_MGMT_HYPERCALLS, and it will be removed when > introducing CONFIG_MGMT_HYPERCALLS on the common/domctl.c in the last. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini

Re: [PATCH v2 14/26] xen/domctl: wrap arch-specific arch_get_info_guest() with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
and it will be removed when introducing CONFIG_MGMT_HYPERCALLS on the > common/domctl.c in the last. > > Signed-off-by: Penny Zheng There is arch_get_info_guest under riscv but it is only a stub so: Reviewed-by: Stefano Stabellini

Re: [PATCH v2 06/26] xen/xsm: wrap xsm_vm_event_control() with CONFIG_VM_EVENT

2025-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2025, Penny Zheng wrote: > Function xsm_vm_event_control() is only invoked under CONFIG_VM_EVENT, so > it shall be wrapped with it > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini

Re: [PATCH v2 19/26] xen/domctl: wrap set_global_virq_handler() with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2025, Penny Zheng wrote: > Function set_global_virq_handler() is reponsible for > XEN_DOMCTL_set_virq_handler domctl-op, and shall be wrapped with > CONFIG_MGMT_HYPERCALLS. > Wrap XEN_DOMCTL_set_virq_handler-case transiently with CONFIG_MGMT_HYPERCALLS, > and it will be removed when

Re: [PATCH v2 23/26] xen/x86: make CONFIG_X86_PSR depend on CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
ff-by: Penny Zheng Reviewed-by: Stefano Stabellini

Re: [PATCH v2 22/26] xen/domctl: wrap arch_{get,set}_paging_mempool_size() with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
siently with > CONFIG_MGMT_HYPERCALLS, and it will be removed when introducing > CONFIG_MGMT_HYPERCALLS on the common/domctl.c in the last. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini

Re: [PATCH v2 20/26] xen/domctl: wrap iommu-related domctl op with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2025, Penny Zheng wrote: > Function iommu_do_domctl() is the main entry for all iommu-related domctl-op, > and shall be wrapped with CONFIG_MGMT_HYPERCALLS. > Tracking its calling chain, the following functions shall all be wrapped > with CONFIG_MGMT_HYPERCALLS: > - iommu_do_pci_domc

Re: [PATCH v2 13/26] xen/domctl: wrap sched_adjust() with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
igned-off-by: Penny Zheng Reviewed-by: Stefano Stabellini

Re: [PATCH v2 17/26] xen/domctl: wrap xsm_set_target() with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2025, Penny Zheng wrote: > Function xsm_set_target() is only invoked under XEN_DOMCTL_set_target > domctl-op, and shall be wrapped with CONFIG_MGMT_HYPERCALLS. > > Signed-off-by: Penny Zheng > --- > v1 -> v2: > - adapt to changes of "unify DOMCTL to MGMT_HYPERCALLS" > --- > xen/in

Re: [PATCH v2 10/26] xen/domctl: wrap domain_kill() with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
CONFIG_MGMT_HYPERCALLS on the > common/domctl.c in the last. > > Signed-off-by: Penny Zheng There are RISC-V and PPC functions we could #ifdef out, although they are only stubs. Given that: Reviewed-by: Stefano Stabellini

Re: [PATCH v2 16/26] xen/domctl: wrap arch-specific domain_set_time_offset() with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
be removed when introducing CONFIG_MGMT_HYPERCALLS on the > common/domctl.c in the last. > > Signed-off-by: Penny Zheng riscv has only a stub so: Reviewed-by: Stefano Stabellini

Re: [PATCH v2 15/26] xen/domctl: wrap xsm_{irq_permission,iomem_permission} with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2025, Penny Zheng wrote: > The following functions are invoked only under > XEN_DOMCTL_{irq_permission,iomem_permission} domctl-op, and shall be wrapped > with CONFIG_MGMT_HYPERCALLS: > - xsm_irq_permission > - xsm_iomem_permission > > Signed-off-by: Penny Zheng > --- > v1 -> v2: >

Re: [PATCH v2 09/26] xen/domctl: wrap domain_resume() with CONFIG_MGMT_HYPERCALLS

2025-09-10 Thread Stefano Stabellini
S. > > Wrap XEN_DOMCTL_resumedomain-case transiently with CONFIG_MGMT_HYPERCALLS, and > it will be removed when introducing CONFIG_MGMT_HYPERCALLS on the > common/domctl.c in the last. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini

Re: [PATCH v2 02/26] xen/sysctl: replace CONFIG_SYSCTL with CONFIG_MGMT_DOMCTL

2025-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2025, Stefano Stabellini wrote: > On Wed, 10 Sep 2025, Penny Zheng wrote: > > Rename all the CONFIG_SYSCTL into a single CONFIG_MGMT_HYPERCALLS to help > > provide a single option to manage all unnecessary hypercalls, including > > sysctl, domctl, etc, in dom0le

Re: [PATCH v2 06/26] xen/xsm: wrap xsm_vm_event_control() with CONFIG_VM_EVENT

2025-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2025, Jan Beulich wrote: > On 10.09.2025 09:38, Penny Zheng wrote: > > Function xsm_vm_event_control() is only invoked under CONFIG_VM_EVENT, so > > it shall be wrapped with it > > Isn't this addressing a Misra violation then? Whether it's "unreachable code" > or "dead code" I can't

Re: [PATCH v2 02/26] xen/sysctl: replace CONFIG_SYSCTL with CONFIG_MGMT_DOMCTL

2025-09-10 Thread Stefano Stabellini
r to support randconfigs. > > Suggested-by: Stefano Stabellini > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini

Re: [ImageBuilder] Use LOAD_CMD by default if not specified in load_file()

2025-09-09 Thread Stefano Stabellini
On Tue, 9 Sep 2025, Orzel, Michal wrote: > On 09/09/2025 11:22, Mykola Kvach wrote: > > Hi Michal, > > > > Thank you for the patch and the detailed explanation. > > > > On Tue, Sep 9, 2025 at 10:42 AM Michal Orzel wrote: > >> > >> Commit 061d6782756f modified load_file() to take load command as

Re: [PATCH] CI: Create initrd fragments explicitly as root

2025-09-09 Thread Stefano Stabellini
practical change. > > > > Signed-off-by: Andrew Cooper > > > Reviewed-by: Denis Mukhin Acked-by: Stefano Stabellini

Re: [PATCH for-4.21 0/5] CI: Add Debian Trixie

2025-09-09 Thread Stefano Stabellini
On Tue, 9 Sep 2025, Marek Marczykowski-Górecki wrote: > On Sat, Aug 09, 2025 at 11:12:01PM +0100, Andrew Cooper wrote: > > I know it's past the last-post deadline, but Trixie was only released today. > > > > In terms of backports, we should at least go back to the bugfix branches. > > What is the

Re: [ImageBuilder] Use LOAD_CMD by default if not specified in load_file()

2025-09-09 Thread Stefano Stabellini
etc.) which broke the output script (load command > > empty). Fix it by defaulting to LOAD_CMD if not specified. > > > > Fixes: 061d6782756f ("Add config option to use separate load commands for > > Xen, DOM0 and DOMU binaries") > > Signed-off-by: Mich

Re: [PATCH v6 00/15] x86: introduce NS16550-compatible UART emulator

2025-09-09 Thread Stefano Stabellini
> > On Sat, Sep 6, 2025 at 5:02 AM Stefano Stabellini > wrote: > > Oleksii and all, > > I would like to consider patches 1-12 of this patch series for 4.21, > pending the few minor comments I made addressed. > > Although I am neither a maintainer nor an official r

Re: [PATCH v7 00/12] Introduce eSPI support

2025-09-08 Thread Stefano Stabellini
On Sun, 7 Sep 2025, Leonid Komarianskyi wrote: > Hello Stefano, > > Thank you for your comments and for providing the Eclair reports. > > On 06.09.25 03:17, Stefano Stabellini wrote: > > Hi Leonid, > > > > I was about to commit this but unfortunately it is intro

Re: [PATCH v6 11/15] emul/ns16x50: implement FCR register (write-only)

2025-09-07 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add emulation logic for FCR register. > > Note, that does not hook FIFO interrupt moderation to the FIFO management > code for simplicity. > > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini

Re: [PATCH v6 02/15] xen/8250-uart: update definitions

2025-09-07 Thread Stefano Stabellini
https://www.ti.com/lit/ds/symlink/tl16c550c.pdf > See "7.7.2 FIFO Control Register (FCR)". > > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini

Re: [PATCH v6 00/15] x86: introduce NS16550-compatible UART emulator

2025-09-06 Thread Stefano Stabellini
Oleksii and all, I would like to consider patches 1-12 of this patch series for 4.21, pending the few minor comments I made addressed. On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > x86 port of Xen lacks vUART facility similar to Arm's vpl011 to support x86 > guest OS bring up in the embedded setu

Re: [PATCH v6 05/15] emul/ns16x50: implement SCR register

2025-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add SCR register emulation to the I/O port handler. > Firmware (e.g. OVMF) may use SCR during the guest OS boot. > > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini

Re: [PATCH v6 07/15] emul/ns16x50: implement LCR/LSR registers

2025-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add LCR/LSR registers implementation to the I/O port handler. > > Add implementation of ns16x50_dlab_get() and ns16x50_iir_check_lsi(). > > Signed-off-by: Denis Mukhin > --- > Changes since v5: > - Moved earlier in the series

Re: [PATCH v6 01/15] emul/vuart: introduce framework for UART emulators

2025-09-05 Thread Stefano Stabellini
now. > > Note: existing vUARTs are deliberately *not* hooked to the new framework to > minimize the scope of the patch: vpl011 (i.e. SBSA) emulator and "vuart" (i.e. > minimalistic MMIO-mapped dtuart for hwdoms on Arm) are kept unmodified. > > No functional changes

Re: [PATCH v6 09/15] emul/ns16x50: implement RBR register

2025-09-05 Thread Stefano Stabellini
d NS16550. > > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini

Re: [PATCH v6 04/15] emul/ns16x50: implement DLL/DLM registers

2025-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add DLL/DLM registers emulation. > > DLL/DLM registers report hardcoded 115200 baud rate to the guest OS. > > Add stub for ns16x50_dlab_get() helper. > > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini

Re: [PATCH v6 03/15] emul/ns16x50: implement emulator stub

2025-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > The change is the first on the way on introducing minimally functional > NS16550-compatible UART emulator. > > Define UART state and a set of emulated registers. > > Implement alloc/free vUART hooks. > > Stub out I/O port han

Re: [PATCH v6 10/15] emul/ns16x50: implement THR register

2025-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add THR register emulation to the I/O port handlder. > > Add TX FIFO management code since THR depends on TX FIFO. > > TX FIFOs is not emulated as per UART specs for simplicity (not need to emulate > baud rate). Emulator does

Re: [PATCH v6 08/15] emul/ns16x50: implement MCR/MSR registers

2025-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add MCR/MSR registers emulation to the I/O port handler. > > Add implementation of ns16x50_iir_check_msi(). > > Signed-off-by: Denis Mukhin > --- > Changes in v5: > - Moved earlier in the series > - Link to v5: > https://lor

Re: [PATCH v6 06/15] emul/ns16x50: implement IER/IIR registers

2025-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > +/* > + * Get the interrupt identity reason. > + * > + * IIR is re-calculated once called, because ns16x50 always reports high > + * priority events first. > + * regs[NS16X50_REGS_NUM + UART_IIR] is used to store THR reason only. > + */ > +static uint8_t

Re: [PATCH v7 00/12] Introduce eSPI support

2025-09-05 Thread Stefano Stabellini
Hi Leonid, I was about to commit this but unfortunately it is introducing MISRA regressions. See: https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/ppp6?ref_type=heads https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/11265005118 Compared this result: https://eclair-analysi

Re: [PATCH v5 15/15] emul/ns16x50: implement IRQ emulation via vIOAPIC

2025-09-05 Thread Stefano Stabellini
On Fri, 5 Sep 2025, dmuk...@xen.org wrote: > On Fri, Aug 29, 2025 at 03:21:13PM -0700, Stefano Stabellini wrote: > > On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > > > From: Denis Mukhin > > > > > > PVH domains use vIOAPIC, not vPIC and NS16550 emulates I

Re: [PATCH v1 1/2] automation: call expect script with redirected standard error

2025-09-03 Thread Stefano Stabellini
ometimes appear hidden in the > middle of the test logs. > > Redirect also standard error to clearly show when a test has timed out or hit > EOF. > > Signed-off-by: Victor Lira Reviewed-by: Stefano Stabellini > --- > example of the problem: > - > https://gitlab.co

Re: [PATCH v1 2/2] automation: edit expect script to separate error message lines

2025-09-03 Thread Stefano Stabellini
: Victor Lira Reviewed-by: Stefano Stabellini > --- > example of the problem: > - https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/11220478458 > - line 652 > --- > pipeline: > - > https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/2017

Re: [PATCH v17 0/4] xen/domain: domain ID allocation

2025-09-03 Thread Stefano Stabellini
This series is fully acked except for: - a minimal change to xen/arch/x86/setup.c - the self test tools/tests/domid/ Based on this, I plan to commit it in the next couple of days. Please let me know if you have any thoughts on that. On Fri, 29 Aug 2025, dmuk...@xen.org wrote: > Patch 1 introdu

Re: [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support

2025-09-03 Thread Stefano Stabellini
ile. Set role as a Reviewer > - rebased on the latest master branch > - Introduce arch_handle_passthrough_prop call to handle arm specific nodes > - rename dom0_scmi_smc_passthrough to scmi_smc_passthrough > - rename dom0_scmi_smc_passthrough in documentation > > Changes in v4:

Domctl series as a fix to PV_SHIM_EXCLUSIVE, was: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-09-02 Thread Stefano Stabellini
Hi Oleksii, We previously discussed the PV_SHIM_EXCLUSIVE build issue on Matrix and agreed on resolving it after the feature freeze as a fix. This conversation took place before the feature freeze was rescheduled to September 5. I am documenting this on xen-devel both for record-keeping and becaus

Re: [PATCH v7 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support

2025-09-02 Thread Stefano Stabellini
I was going to commit this series but this patch breaks compilation on x86: https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/11223159836

Re: [PATCH v7 3/4] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent

2025-09-02 Thread Stefano Stabellini
In general, the configuration is similar to any other HW > passthrough, except explicitly enabling SCMI with "arm_sci" xl.cfg option. > > Note that "arm,scmi-smc" and "arm,scmi-shmem" nodes will be removed from > dom0/hwdom DT when "scmi-smc-passthrough" cmdline parameter was provided. > > Signed-off-by: Grygorii Strashko > Signed-off-by: Oleksii Moisieiev > Acked-by: Anthony PERARD # tools Reviewed-by: Stefano Stabellini

Re: [PATCH v5 15/15] emul/ns16x50: implement IRQ emulation via vIOAPIC

2025-08-29 Thread Stefano Stabellini
On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > PVH domains use vIOAPIC, not vPIC and NS16550 emulates ISA IRQs which cannot > be asserted on vIOAPIC. One option is to enable the vPIT for PVH domains when the NS16550 emulator is enabled. Would that resolve the problem? That

Re: [PATCH v11] xen/console: introduce domain_console struct

2025-08-29 Thread Stefano Stabellini
e future. > > Finally, update the domain_console allocation and initialization code. Make > sure domain_console is not allocated for system domains. > > No functional change. > > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini

Re: [PATCH v5 14/15] xen/domain: allocate d->irq_caps before arch-specific initialization

2025-08-29 Thread Stefano Stabellini
On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Make sure that NS16550 emulator does not share virtual device IRQ with the > physical one. This is needed for enabling NS16550 emulator for PVH hwdom > (dom0). > > To do that, move per-domain interrupt rangeset allocation befo

Re: [PATCH v5 13/15] x86/domain: enable per-domain I/O port bitmaps

2025-08-29 Thread Stefano Stabellini
On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Current design enables all HVM domains share the same I/O port bitmap. > > It is necessary for domains crafting its own I/O port address space depending > on the user configuration. > > Ensure NS16550 emulator does not share

Re: [PATCH v5 07/15] emul/ns16x50: implement FCR register (write-only)

2025-08-29 Thread Stefano Stabellini
On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add emulation logic for FCR register. > > Note, that does not hooks FIFO interrupt moderation to the FIFO management > code. > > Signed-off-by: Denis Mukhin > --- > Changes since v4: > - new patch > --- > xen/common/emul/vu

Re: [PATCH v5 06/15] emul/ns16x50: implement THR/RBR registers

2025-08-29 Thread Stefano Stabellini
On Fri, 29 Aug 2025, Stefano Stabellini wrote: > On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > > From: Denis Mukhin > > > > Add RBR/THR registers emulation to the I/O port handlder. > > > > Also, add RX/TX FIFO management code since RBR depends on RX FI

Re: [PATCH v5 06/15] emul/ns16x50: implement THR/RBR registers

2025-08-29 Thread Stefano Stabellini
On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add RBR/THR registers emulation to the I/O port handlder. > > Also, add RX/TX FIFO management code since RBR depends on RX FIFO and > THR depends on TX FIFO. > > FIFOs are not emulated as per UART specs for simplicity (not ne

Re: [PATCH v5 05/15] emul/ns16x50: implement EIR/IIR registers

2025-08-29 Thread Stefano Stabellini
On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add interrupt enable register emulation (EIR) and interrupt identity reason EIR->IER > (IIR) register emulation to the I/O port handler. > > Also add routines for asserting/deasserting the virtual ns16x50 interrupt > line as

Re: [PATCH v5 03/15] emul/ns16x50: implement emulator stub

2025-08-29 Thread Stefano Stabellini
On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > The change is the first on the way on introducing minimally functional > NS16550-compatible UART emulator. > > Define UART state and a set of emulated registers. > > Implement alloc/free vUART hooks. > > Stub out I/O port ha

Re: [PATCH v5 02/15] xen/8250-uart: update definitions

2025-08-29 Thread Stefano Stabellini
On Thu, 27 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Added missing definitions needed for NS16550 UART emulator. > > Newly introduced MSR definitions re-used in the existing ns16550 driver. > > Also, corrected FCR DMA definition bit#3 (0x08) as per: > https://www.ti.com/lit/d

Re: [PATCH v5 01/15] emul/vuart: introduce framework for UART emulators

2025-08-29 Thread Stefano Stabellini
On Thu, 28 Aug 2025, dmuk...@xen.org wrote: > From: Denis Mukhin > > Introduce a driver framework to abstract UART emulators in the hypervisor. > > That allows for architecture-independent handling of virtual UARTs in the > console driver and simplifies enabling new UART emulators. > > The fra

Re: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-08-28 Thread Stefano Stabellini
On Thu, 28 Aug 2025, Jan Beulich wrote: > On 28.08.2025 02:52, Stefano Stabellini wrote: > > On Wed, 27 Aug 2025, Jan Beulich wrote: > >> On 27.08.2025 02:33, Stefano Stabellini wrote: > >>> So I ran a test and the appended change, which is based on [1] and &

Re: [PATCH v6 2/4] xen/arm: scmi-smc: update to be used under sci subsystem

2025-08-28 Thread Stefano Stabellini
gt; commit 3e322bef8bc0 ("xen/arm: firmware: Add SCMI over SMC calls handling > layer"), to be SCI driver: > - convert to DT device; > - convert to SCI Xen interface. > > There are no functional changes in general, the driver is just adopted > to the SCI interface.

Re: [PATCH v6 1/4] xen/arm: add generic SCI subsystem

2025-08-28 Thread Stefano Stabellini
) > - sci_dt_handle_node() > - sci_dt_finalize() called from handle_node() (Dom0 DT) > > Signed-off-by: Oleksii Moisieiev > Signed-off-by: Grygorii Strashko > Reviewed-by: Stefano Stabellini I just want to say that R-b from me is OK

Re: [PATCH v6 3/4] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent

2025-08-28 Thread Stefano Stabellini
em"; > reg = <0x00 0x22001000 0x00 0x1000>; > ->xen,reg = <0x0 0x47ff 0x0 0x1000 0x0 0x22001000>; > ->xen,force-assign-without-iommu; > }; > > The SCMI SMC single agent interface can be enabled for one and only one > domain. In general, the configuration is similar to any other HW > passthrough, except explicitly enabling SCMI with "arm_sci" xl.cfg option. > > Note that "arm,scmi-smc" and "arm,scmi-shmem" nodes will be removed from > dom0/hwdom DT in case of > > Signed-off-by: Grygorii Strashko > Signed-off-by: Oleksii Moisieiev > Acked-by: Anthony PERARD # tools Reviewed-by: Stefano Stabellini

Re: [PATCH v6 4/4] docs: arm: add docs for SCMI over SMC calls forwarding driver

2025-08-28 Thread Stefano Stabellini
can be done on commit. Reviewed-by: Stefano Stabellini > --- > > Changes in v6: > - add link to the scmi bindings used in the doc > - remove mentions about HVC calls from doc > - rename cmdline parameter to scmi-smc-passthrough > > Changes in v5: > - rename dom0_scm

Re: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-08-27 Thread Stefano Stabellini
On Wed, 27 Aug 2025, Jan Beulich wrote: > On 27.08.2025 02:33, Stefano Stabellini wrote: > > So I ran a test and the appended change, which is based on [1] and > > renaming CONFIG_DOMCTL to CONFIG_SYSCTL, is sufficient to resolve the > > build issue. > > > > F

Re: [RFC PATCH v5 02/10] xen/arm: scmi-smc: update to be used under sci subsystem

2025-08-27 Thread Stefano Stabellini
On Wed, 27 Aug 2025, Oleksii Moisieiev wrote: > On 23/08/2025 03:26, Stefano Stabellini wrote: > > On Tue, 22 Jul 2025, Oleksii Moisieiev wrote: > >> From: Grygorii Strashko > >> > >> The introduced SCI (System Control Interface) subsystem provides unified &g

Re: [RFC PATCH v5 00/10] xen/arm: scmi: introduce SCI SCMI SMC multi-agent support

2025-08-27 Thread Stefano Stabellini
last two patches. Cheers, Stefano On Wed, 27 Aug 2025, Oleksii Moisieiev wrote: > Hi Stefano, > > Our use-case imply using scmi-smc-multiagent to be able to split scmi > between the domains, > so we would like to apply all patch series in the release. > > On 23/08/2025

Re: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-08-26 Thread Stefano Stabellini
On Tue, 26 Aug 2025, Stefano Stabellini wrote: > Hi all, > > So I ran a test and the appended change, which is based on [1] and > renaming CONFIG_DOMCTL to CONFIG_SYSCTL, is sufficient to resolve the > build issue. > > For 4.21, I suggest we go with two patches:

Re: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-08-26 Thread Stefano Stabellini
Hi all, So I ran a test and the appended change, which is based on [1] and renaming CONFIG_DOMCTL to CONFIG_SYSCTL, is sufficient to resolve the build issue. For 4.21, I suggest we go with two patches: 1) global rename of CONFIG_SYSCTL to CONFIG_MGMT_HYPERCALLS 2) stub domctl_lock_acquire/release

Re: [PATCH] misra: add deviation of Rule 2.1 for BUG() macro

2025-08-26 Thread Stefano Stabellini
On Tue, 26 Aug 2025, Nicola Vetrini wrote: > On 2025-08-26 20:07, Dmytro Prokopchuk1 wrote: > > On 8/25/25 13:07, Jan Beulich wrote: > > > On 24.08.2025 16:56, Dmytro Prokopchuk1 wrote: > > > > --- a/docs/misra/deviations.rst > > > > +++ b/docs/misra/deviations.rst > > > > @@ -97,6 +97,19 @@ Deviat

Re: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-08-25 Thread Stefano Stabellini
On Mon, 25 Aug 2025, Jan Beulich wrote: > On 19.08.2025 01:51, Stefano Stabellini wrote: > > On Mon, 18 Aug 2025, Jan Beulich wrote: > >> On 18.08.2025 15:28, Oleksii Kurochko wrote: > >>> On 8/18/25 10:31 AM, Jan Beulich wrote: > >>>> On 15.08.2025

Re: [RFC PATCH v5 10/10] docs: arm: add SCI SCMI SMC multi-agent driver docs

2025-08-25 Thread Stefano Stabellini
On Tue, 22 Jul 2025, Oleksii Moisieiev wrote: > From: Grygorii Strashko > > Add SCI SCMI SMC multi-agent driver documentation. > It includes a detailed description of the SCMI multi-agent driver. > This document explains the driver's functionality, configuration, > and the compilation process. Th

Re: [RFC PATCH v5 09/10] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-08-25 Thread Stefano Stabellini
On Tue, 22 Jul 2025, Oleksii Moisieiev wrote: > This patch introduces SCI driver to support for ARM EL3 Trusted Firmware-A > (TF-A) which provides SCMI interface with multi-agnet support, as shown multi-agent > below. > > +-+ > |

Re: [RFC PATCH v5 08/10] lib/arm: Add I/O memory copy helpers

2025-08-22 Thread Stefano Stabellini
On Tue, 22 Jul 2025, Oleksii Moisieiev wrote: > This commit introduces two helper functions, `__memcpy_fromio` and > `__memcpy_toio`, to provide a robust mechanism for copying data between > standard memory and memory-mapped I/O (MMIO) space for the ARM > architecture. > > These functions are desi

Re: [RFC PATCH v5 00/10] xen/arm: scmi: introduce SCI SCMI SMC multi-agent support

2025-08-22 Thread Stefano Stabellini
secondary-agents-cells" parameter to set if > agent_id was provided > - reanme xen,scmi-secondary-agents property to scmi-secondary-agents > - move memcpu_toio/fromio for the generic place > - update Xen to get management channel from /chosen/xen,config node > - get hypervisor chan

Re: [RFC PATCH v5 07/10] xen: arm: smccc: add INVALID_PARAMETER error code

2025-08-22 Thread Stefano Stabellini
file. > > [1]: https://documentation-service.arm.com/static/5f8edaeff86e16515cdbe4c6 > > Signed-off-by: Oleksii Moisieiev Acked-by: Stefano Stabellini > --- > > > > xen/arch/arm/include/asm/smccc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm

Re: [RFC PATCH v5 04/10] docs: arm: add docs for SCMI over SMC calls forwarding driver

2025-08-22 Thread Stefano Stabellini
On Tue, 22 Jul 2025, Oleksii Moisieiev wrote: > From: Grygorii Strashko > > Add documentation section for Simple Arm SCMI over SMC/HVC calls forwarding > driver (EL3). > > Signed-off-by: Grygorii Strashko > Signed-off-by: Oleksii Moisieiev This doc looks good, a couple of minor suggestions: -

Re: [RFC PATCH v5 01/10] xen/arm: add generic SCI subsystem

2025-08-22 Thread Stefano Stabellini
On Tue, 22 Jul 2025, Oleksii Moisieiev wrote: > This patch adds the basic framework for ARM SCI mediator. SCI is System > Control Interface, which is designed to redirect requests from the Domains > to ARM specific Firmware (for example SCMI). This will allow the devices, > passed-through to the di

Re: [RFC PATCH v5 02/10] xen/arm: scmi-smc: update to be used under sci subsystem

2025-08-22 Thread Stefano Stabellini
On Tue, 22 Jul 2025, Oleksii Moisieiev wrote: > From: Grygorii Strashko > > The introduced SCI (System Control Interface) subsystem provides unified > interface to integrate in Xen SCI drivers which adds support for ARM > firmware (EL3, SCP) based software interfaces (like SCMI) that are used in

Re: [RFC PATCH v5 03/10] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent

2025-08-22 Thread Stefano Stabellini
On Tue, 22 Jul 2025, Oleksii Moisieiev wrote: > From: Grygorii Strashko > > The commit 3e322bef8bc0 ("xen/arm: firmware: Add SCMI over SMC calls > handling layer") introduces simple driver which forwards SCMI over SMC > calls from hwdom/dom0 to EL3 firmware (TF-A) with a single SCMI OSPM agent >

Re: [PATCH v2 3/3] xen/pci: add discovered PCI device at boot

2025-08-22 Thread Stefano Stabellini
On Fri, 22 Aug 2025, Jan Beulich wrote: > On 22.08.2025 10:03, Mykyta Poturai wrote: > > On 21.08.25 12:08, Jan Beulich wrote: > >> On 20.08.2025 14:28, Mykyta Poturai wrote: > >>> From: Luca Fancellu > >>> > >>> In dom0less mode, there is no dom0 that can call PCI physdev ops to > >>> register PC

Re: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-08-22 Thread Stefano Stabellini
On Fri, 22 Aug 2025, Jan Beulich wrote: > >> I'm sorry if my request was unclear, but with "full round of testing" I in > >> particular > >> meant a full CI pipeline, plus (given the issue that's being fixed) some > >> extra > >> randconfig testing. > > > > https://gitlab.com/xen-project/people/

Re: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-08-21 Thread Stefano Stabellini
; >> > >> Cc: Huang, Ray ; Andrew Cooper > >> ; Roger Pau Monné ; > >> Anthony PERARD ; Orzel, Michal > >> ; Julien Grall ; Stefano Stabellini > >> ; xen-devel@lists.xenproject.org > >> Subject: Re: [PATCH] xen/x86: move domctl.o out of

Re: [PATCH] CI: Use 'watchdog' for x86 hardware

2025-08-21 Thread Stefano Stabellini
in-QEMU tests? > > Anyway: > > Reviewed-by: Marek Marczykowski-Górecki Acked-by: Stefano Stabellini

Re: [PATCH v2] iommu/ipmmu-vmsa: Fix build with HAS_PCI=n

2025-08-21 Thread Stefano Stabellini
On Thu, 21 Aug 2025, Jan Beulich wrote: > On 21.08.2025 13:23, Mykyta Poturai wrote: > > With PCI disabled the build fails due to undefined struct > > pci_host_bridge. > > > > Add ifdef guard to pci-host-rcar4.h to not require the stuct being > > defined when PCI support is disabled. All call site

Re: [PATCH v2 2/3] xen/pci: modify pci_add_device to handle device add by Xen

2025-08-20 Thread Stefano Stabellini
ancellu > Signed-off-by: Mykyta Poturai Reviewed-by: Stefano Stabellini

Re: [PATCH v2 1/3] arm/pci: Add pci-scan boot argument

2025-08-20 Thread Stefano Stabellini
ssthrough on > arm. > > Signed-off-by: Luca Fancellu > Signed-off-by: Mykyta Poturai Acked-by: Stefano Stabellini > --- > (cherry picked from commit bce463e1588a45e1bfdf59fc0d5f88b16604e439 from > the downstream branch poc/pci-passthrough from > https://gitlab.com/xen-project/pe

Re: [PATCH v2 3/3] iommu/ipmmu-vmsa: Implement basic PCIE-IPMMU OSID support

2025-08-20 Thread Stefano Stabellini
gt; domains at the same time. Programmed OSID is emmited as sideband data on > the AXI bus during PCI DMA transactions and then used by IPMMU to match > the transaction to the corresponding uTLB. > > Signed-off-by: Oleksandr Tyshchenko > Signed-off-by: Mykyta Poturai Acked-by: Stefano Stabellini

Re: [RFC] Next steps for MISRA C Rule 17.7 in XEN

2025-08-19 Thread Stefano Stabellini
On Tue, 18 Aug 2025, Jan Beulich wrote: > On 19.08.2025 01:45, Stefano Stabellini wrote: > > On Mon, 18 Aug 2025, Dmytro Prokopchuk1 wrote: > >> On 8/4/25 11:02, Jan Beulich wrote: > >>> On 02.08.2025 19:48, Dmytro Prokopchuk1 wrote: > >>>> There are

Re: [PATCH] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE

2025-08-18 Thread Stefano Stabellini
On Mon, 18 Aug 2025, Jan Beulich wrote: > On 18.08.2025 15:28, Oleksii Kurochko wrote: > > On 8/18/25 10:31 AM, Jan Beulich wrote: > >> On 15.08.2025 12:27, Penny Zheng wrote: > >>> In order to fix CI error of a randconfig picking both PV_SHIM_EXCLUSIVE=y > >>> and > >>> HVM=y results in hvm.c bei

Re: [RFC] Next steps for MISRA C Rule 17.7 in XEN

2025-08-18 Thread Stefano Stabellini
On Mon, 18 Aug 2025, Dmytro Prokopchuk1 wrote: > On 8/4/25 11:02, Jan Beulich wrote: > > On 02.08.2025 19:48, Dmytro Prokopchuk1 wrote: > >> There are a lot of MISRA C R17.7 violations in the XEN. > >> This rule states: "The value returned by a function having non-void > >> return type shall be use

[PATCH v2] docs/sending-patches: add GitLab pipeline link

2025-08-18 Thread Stefano Stabellini
When submitting patches to xen-devel, add a link to a successful pipeline run. Signed-off-by: Stefano Stabellini --- Changes in v2: - address Julien's comments diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc index 1991932b68..13bb3bf47a 100644 --- a

Re: [PATCH] docs/sending-patches: add GitLab pipeline link

2025-08-18 Thread Stefano Stabellini
On Mon, 18 Aug 2025, Julien Grall wrote: > Hi Stefano, > > On 15/08/2025 21:12, Stefano Stabellini wrote: > > When submitting patches to xen-devel, add a link to a successful > > pipeline run. > > Does this mean we have enough capacity to handle normal CI job + submis

[PATCH] docs/sending-patches: add GitLab pipeline link

2025-08-15 Thread Stefano Stabellini
When submitting patches to xen-devel, add a link to a successful pipeline run. Signed-off-by: Stefano Stabellini diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc index 1991932b68..6e1401ea22 100644 --- a/docs/process/sending-patches.pandoc +++ b/docs

Re: [PATCH] misra: address Rule 11.1 violation in cmpxchgptr()

2025-08-15 Thread Stefano Stabellini
On Thu, 14 Aug 2025, Teddy Astie wrote: > Hello, > > Le 13/08/2025 à 20:07, Dmytro Prokopchuk1 a écrit : > > Misra Rule 11.1 states: "Conversions shall not be performed between a > > pointer to a function and any other type." > > > > The violation occurs in the macro: > > __typeof__(**(ptr))

Re: [PATCH] misra: add missing noreturn attribute for __div0()

2025-08-15 Thread Stefano Stabellini
ribute to fix this. > > > > I was convinced that this was already upstream, as I made a patch a while ago, > but evidently I forgot to send it. > > > Signed-off-by: Dmytro Prokopchuk > > Reviewed-by: Nicola Vetrini Acked-by: Stefano Stabellini

Re: [XEN PATCH 2/2] Address violation of MISRA C Rule 13.1 involving asm side effects.

2025-08-15 Thread Stefano Stabellini
gned-off-by: Nicola Vetrini Acked-by: Stefano Stabellini Ideally, with the improved doc as suggested by Dmytro. > --- > Not yet tested on the Xen ECLAIR runner, as the syntax used in the deviation > is only supported after updating the runner. > > What the tool is reporting is t

  1   2   3   4   5   6   7   8   9   10   >