Re: [PATCH v3 5/6] block/linux-aio: convert to blk_io_plug_call() API

2023-05-31 Thread Stefano Garzarella
: Eric Blake --- include/block/raw-aio.h | 7 --- block/file-posix.c | 28 block/linux-aio.c | 41 +++-- 3 files changed, 11 insertions(+), 65 deletions(-) LGTM! Reviewed-by: Stefano Garzarella

Re: [PATCH v2 5/6] block/linux-aio: convert to blk_io_plug_call() API

2023-05-29 Thread Stefano Garzarella
On Wed, May 24, 2023 at 03:36:34PM -0400, Stefan Hajnoczi wrote: On Wed, May 24, 2023 at 10:52:03AM +0200, Stefano Garzarella wrote: On Tue, May 23, 2023 at 01:12:59PM -0400, Stefan Hajnoczi wrote: > Stop using the .bdrv_co_io_plug() API because it is not multi-queue > block layer friendl

Re: [PATCH v2 5/6] block/linux-aio: convert to blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 01:12:59PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- include/bloc

Re: [PATCH v2 6/6] block: remove bdrv_co_io_plug() API

2023-05-24 Thread Stefano Garzarella
-- block/io.c | 37 3 files changed, 51 deletions(-) Reviewed-by: Stefano Garzarella

Re: [PATCH v2 4/6] block/io_uring: convert to blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
- Removed whitespace hunk [Eric] --- include/block/raw-aio.h | 7 --- block/file-posix.c | 10 -- block/io_uring.c| 44 - block/trace-events | 5 ++--- 4 files changed, 19 insertions(+), 47 deletions(-) Reviewed-by: Stefano Garzarella

Re: [PATCH v2 3/6] block/blkio: convert to blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
missing #include and fix blkio_unplug_fn() prototype [Stefano] --- block/blkio.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) Reviewed-by: Stefano Garzarella

Re: [PATCH v2 2/6] block/nvme: convert to blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
unused nvme_process_completion_queue_plugged trace event [Stefano] --- block/nvme.c | 44 block/trace-events | 1 - 2 files changed, 12 insertions(+), 33 deletions(-) Reviewed-by: Stefano Garzarella

Re: [PATCH v2 1/6] block: add blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
100644 block/plug.c Reviewed-by: Stefano Garzarella

Re: [PATCH 1/6] block: add blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 11:47:08AM -0400, Stefan Hajnoczi wrote: On Fri, May 19, 2023 at 10:45:57AM +0200, Stefano Garzarella wrote: On Wed, May 17, 2023 at 06:10:17PM -0400, Stefan Hajnoczi wrote: > Introduce a new API for thread-local blk_io_plug() that does not > traverse the block

Re: [PATCH 3/6] block/blkio: convert to blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:19PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- block/blkio.c | 40 ++

Re: [PATCH 2/6] block/nvme: convert to blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:18PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- block/nvme.c | 44 ---

Re: [PATCH 1/6] block: add blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:17PM -0400, Stefan Hajnoczi wrote: Introduce a new API for thread-local blk_io_plug() that does not traverse the block graph. The goal is to make blk_io_plug() multi-queue friendly. Instead of having block drivers track whether or not we're in a plugged section, pro

Re: [PATCH v3 0/6] aio-posix: split poll check from ready handler

2021-12-09 Thread Stefano Garzarella
ndler function. Stefano Garzarella prompted me to make this refactoring. Great clean up! Thanks for doing this, everything LGTM: Reviewed-by: Stefano Garzarella

Re: An error due to installation that require binutils package

2021-03-30 Thread Stefano Garzarella
Hi John, On Mon, Mar 29, 2021 at 09:46:49PM +0300, John Simpson wrote: Hello, Kindly ask you to have a look at this bug. Thank you for your replies. It's already fixed in QEMU upstream and the fix will be released with the 6.0 version next month (the rc0 is already available): https://gitla

Re: [Xen-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2019-01-10 Thread Stefano Garzarella
On Wed, Jan 09, 2019 at 01:18:12PM -0800, Maran Wilson wrote: > On 1/9/2019 11:53 AM, Boris Ostrovsky wrote: > > On 1/9/19 6:53 AM, Stefano Garzarella wrote: > > > Hi Liam, > > > > > > On Tue, Jan 8, 2019 at 3:47 PM Liam Merwick > > > wrote: > >

Re: [Xen-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2019-01-09 Thread Stefano Garzarella
Then we can load the initrd in qboot or in the optionrom that I'm writing. What do you think? Thanks, Stefano > I'm checking to see if that has any implications for the kernel side. > > Regards, > Liam > -- Stefano Garzarella Red Hat _

Re: [Xen-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2019-01-03 Thread Stefano Garzarella
gt; hw/sparc/leon3.c | 3 +- > hw/sparc/sun4m.c | 6 +- > hw/sparc64/sun4u.c | 4 +- > hw/tricore/tricore_testboard.c | 2 +- > hw/xtensa/sim.c| 12 ++-- > hw/xtensa/xtfpga.c

Re: [Xen-devel] [RFC 3/3] pvh: Boot uncompressed kernel using direct boot ABI

2018-12-13 Thread Stefano Garzarella
->device_memory->mr); > + > +fw_cfg_add_bytes(fw_cfg, FW_CFG_KERNEL_DATA, &ramdisk_mod, > + sizeof(ramdisk_mod)); > + fw_cfg_add_i32(fw_cfg, FW_CFG_SETUP_SIZE, sizeof(header)); > +fw_cfg_add_b

Re: [Xen-devel] [RFC 3/3] pvh: Boot uncompressed kernel using direct boot ABI

2018-12-13 Thread Stefano Garzarella
On Tue, Dec 11, 2018 at 7:35 PM Maran Wilson wrote: > > On 12/11/2018 9:11 AM, Stefano Garzarella wrote: > > Hi Liam, > > in order to support PVH also with SeaBIOS, I'm going to work on a new > > option rom (like linuxboot/multiboot) that can be used in this case. >