Re: [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead()

2023-02-14 Thread Srivatsa S. Bhat
Hi, On 1/27/23 4:37 PM, Srivatsa S. Bhat wrote: > From: "Srivatsa S. Bhat (VMware)" > > The comment that says mwait_play_dead() returns only on failure is a > bit misleading because mwait_play_dead() could actually return for > valid reasons (such as mwait not being

Re: [PATCH v2] x86/paravirt: merge activate_mm and dup_mmap callbacks

2023-02-07 Thread Srivatsa S. Bhat
gt; > As the first parameter of the old callbacks isn't used, drop it from > the replacement one. > > Signed-off-by: Juergen Gross > Reviewed-by: Boris Ostrovsky Reviewed-by: Srivatsa S. Bhat (VMware) Regards, Srivatsa VMware Photon OS > --- > V2: > - expan

[PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead()

2023-01-27 Thread Srivatsa S. Bhat
From: "Srivatsa S. Bhat (VMware)" The comment that says mwait_play_dead() returns only on failure is a bit misleading because mwait_play_dead() could actually return for valid reasons (such as mwait not being supported by the platform) that do not indicate a failure of the CPU offline

Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-25 Thread Srivatsa S. Bhat
Hi Igor and Sean, On 1/20/23 10:35 AM, Sean Christopherson wrote: > On Fri, Jan 20, 2023, Igor Mammedov wrote: >> On Fri, 20 Jan 2023 05:55:11 -0800 >> "Srivatsa S. Bhat" wrote: >> >>> Hi Igor and Thomas, >>> >>> Thank you for your

Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-20 Thread Srivatsa S. Bhat
Hi Igor and Thomas, Thank you for your review! On 1/19/23 1:12 PM, Thomas Gleixner wrote: > On Mon, Jan 16 2023 at 15:55, Igor Mammedov wrote: >> "Srivatsa S. Bhat" wrote: >>> Fix this by preventing the use of mwait idle state in the vCPU offline >>> play

Re: [PATCH] x86/paravirt: merge activate_mm and dup_mmap callbacks

2023-01-16 Thread Srivatsa S. Bhat
On 1/15/23 10:43 PM, Juergen Gross wrote: > On 16.01.23 05:27, Srivatsa S. Bhat wrote: >> >> Hi Juergen, >> >> On 1/12/23 7:21 AM, Juergen Gross wrote: >>> The two paravirt callbacks .mmu.activate_mm and .mmu.dup_mmap are >>> sharing the same impleme

[PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state

2023-01-15 Thread Srivatsa S. Bhat
From: "Srivatsa S. Bhat (VMware)" Under hypervisors that support mwait passthrough, a vCPU in mwait CPU-idle state remains in guest context (instead of yielding to the hypervisor via VMEXIT), which helps speed up wakeups from idle. However, this runs into problems with CPU hotplug, b

Re: [PATCH] x86/paravirt: merge activate_mm and dup_mmap callbacks

2023-01-15 Thread Srivatsa S. Bhat
Hi Juergen, On 1/12/23 7:21 AM, Juergen Gross wrote: > The two paravirt callbacks .mmu.activate_mm and .mmu.dup_mmap are > sharing the same implementations in all cases: for Xen PV guests they > are pinning the PGD of the new mm_struct, and for all other cases > they are a NOP. > I was expecti

Re: [PATCH 29/36] cpuidle,xenpv: Make more PARAVIRT_XXL noinstr clean

2022-06-13 Thread Srivatsa S. Bhat
arning: objtool: xen_safe_halt+0xa: call to > HYPERVISOR_sched_op.constprop.0() leaves .noinstr.text section > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Srivatsa S. Bhat (VMware) Regards, Srivatsa VMware Photon OS > --- > arch/x86/include/asm/paravirt.h |6

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-08-07 Thread Srivatsa S. Bhat
On 8/7/18 12:15 PM, Greg KH wrote: > On Tue, Aug 07, 2018 at 12:08:07PM -0700, Srivatsa S. Bhat wrote: >> Also, upstream commit e01e80634ecdde1 (fork: unconditionally clear >> stack on fork) applies cleanly on 4.14 stable, so it would be great to >> cherry-pick it to 4.14 st

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-08-07 Thread Srivatsa S. Bhat
On 8/7/18 6:49 AM, Greg KH wrote: > On Fri, Aug 03, 2018 at 04:20:31PM -0700, Srivatsa S. Bhat wrote: >> On 8/2/18 3:22 PM, Kees Cook wrote: >>> On Thu, Aug 2, 2018 at 12:22 PM, Srivatsa S. Bhat >>> wrote: >>>> On 7/26/18 4:09 PM, Kees Cook wrote: >

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-08-03 Thread Srivatsa S. Bhat
On 8/2/18 3:22 PM, Kees Cook wrote: > On Thu, Aug 2, 2018 at 12:22 PM, Srivatsa S. Bhat > wrote: >> On 7/26/18 4:09 PM, Kees Cook wrote: >>> On Tue, Jul 24, 2018 at 3:02 PM, Jiri Kosina wrote: >>>> On Tue, 24 Jul 2018, Srivatsa S. Bhat wrote: >>>> &

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-08-02 Thread Srivatsa S. Bhat
On 7/26/18 4:09 PM, Kees Cook wrote: > On Tue, Jul 24, 2018 at 3:02 PM, Jiri Kosina wrote: >> On Tue, 24 Jul 2018, Srivatsa S. Bhat wrote: >> >>> However, if you are proposing that you'd like to contribute the enhanced >>> PTI/Spectre (upstream) patches fro

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-07-24 Thread Srivatsa S. Bhat
On 7/23/18 3:06 PM, Jiri Kosina wrote: > On Sat, 14 Jul 2018, Srivatsa S. Bhat wrote: > >> This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) >> and patches for the Speculative Store Bypass vulnerability to 4.4.y >> (they apply cleanly on top of 4.4.140

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-07-23 Thread Srivatsa S. Bhat
On 7/23/18 4:26 AM, Greg KH wrote: > On Sat, Jul 14, 2018 at 02:25:43AM -0700, Srivatsa S. Bhat wrote: >> Hi Greg, >> >> This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) >> and patches for the Speculative Store Bypass vulnerability to 4.4.y >&

Re: [Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-07-16 Thread Srivatsa S. Bhat
On 7/15/18 4:26 AM, Greg KH wrote: > On Sat, Jul 14, 2018 at 02:25:43AM -0700, Srivatsa S. Bhat wrote: >> Hi Greg, >> >> This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) >> and patches for the Speculative Store Bypass vulnerability to 4.4.y >&

[Xen-devel] [PATCH 4.4.y 040/101] x86/xen: Zero MSR_IA32_SPEC_CTRL before suspend

2018-07-14 Thread Srivatsa S. Bhat
: Juergen Gross Signed-off-by: Thomas Gleixner Reviewed-by: Jan Beulich Cc: sta...@vger.kernel.org Cc: xen-devel@lists.xenproject.org Cc: boris.ostrov...@oracle.com Link: https://lkml.kernel.org/r/20180226140818.4849-1-jgr...@suse.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Srivatsa S. Bhat

[Xen-devel] [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y

2018-07-14 Thread Srivatsa S. Bhat
Hi Greg, This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) and patches for the Speculative Store Bypass vulnerability to 4.4.y (they apply cleanly on top of 4.4.140). I used 4.9.y as my reference when backporting to 4.4.y (as I thought that would minimize the amount of fixing up