On Mi, 2018-02-28 at 09:19 +, Roger Pau Monne wrote:
> Current cleanup in the error path of xen_bind_pirq_msi_to_irq is
> wrong. First of all there's an off-by-one in the cleanup loop, which
> can lead to unbinding wrong IRQs.
>
> Secondly IRQs not bound won't be freed, thus leaking IRQ numbe
d_pirq_msi_to_irq(struct pci_dev *dev,
> struct msi_desc *msidesc,
> mutex_unlock(&irq_mapping_update_lock);
> return irq;
> error_irq:
> - for (; i >= 0; i--)
> - __unbind_from_irq(irq + i);
> + while (nvec--)
>
On Mi, 2018-02-28 at 08:16 +, Roger Pau Monné wrote:
> On Tue, Feb 27, 2018 at 05:32:53PM +0000, Shah, Amit wrote:
> >
> >
> > On Di, 2018-02-27 at 17:07 +, Roger Pau Monné wrote:
> > >
> > > On Tue, Feb 27, 2018 at 03:55:58PM +, Amit Shah w
On Di, 2018-02-27 at 17:07 +, Roger Pau Monné wrote:
> On Tue, Feb 27, 2018 at 03:55:58PM +, Amit Shah wrote:
> >
> > In case of errors in irq setup for MSI, free up the allocated irqs.
> >
> > Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups")
> > Reported-by: Hooman Mirh
On Di, 2018-02-27 at 08:14 +, Roger Pau Monné wrote:
> On Mon, Feb 26, 2018 at 06:57:03PM +0000, Shah, Amit wrote:
> >
> >
> > On Mo, 2018-02-26 at 18:14 +, Roger Pau Monné wrote:
> > >
> > > On Mon, Feb 26, 2018 at 05:36:35PM +, Amit Shah w
On Mo, 2018-02-26 at 18:14 +, Roger Pau Monné wrote:
> On Mon, Feb 26, 2018 at 05:36:35PM +, Amit Shah wrote:
> >
> > In case of errors in irq setup for MSI, free up the allocated irqs.
> >
> > Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups")
> > Reported-by: Hooman Mirh
we Dannowski
> Reviewed-by: Stefan Nuernberger
> Reviewed-by: Martin Pohlack
> CC: David Woodhouse
> CC: Amit Shah
> CC: Jan Beulich
> CC: Andrew Cooper
Reviewed-by: Amit Shah
--
Amit
Amazon Development Center Germany GmbH
Berlin - Dr
