Re: [PATCH v3 01/22] x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heap

2025-07-02 Thread ross . philipson
On 7/2/25 7:29 AM, 'Jan Beulich' via trenchboot-devel wrote: On 30.05.2025 15:17, Sergii Dmytruk wrote: From: Krystian Hebel The file contains base address of TXT register spaces, offsets of registers within them, error codes and inline functions for accessing structures stored on TXT heap. x

Re: [PATCH v3 04/22] x86/boot/slaunch-early: implement early initialization

2025-06-12 Thread ross . philipson
On 6/11/25 3:14 PM, Sergii Dmytruk wrote: On Tue, Jun 03, 2025 at 09:17:29AM -0700, ross.philip...@oracle.com wrote: +void asmlinkage slaunch_early_init(uint32_t load_base_addr, + uint32_t tgt_base_addr, + uint32_t tgt_end_addr,

Re: [PATCH v3 10/22] x86/tpm.c: code for early hashing and extending PCRs (for TPM1.2)

2025-06-05 Thread ross . philipson
On 5/30/25 6:17 AM, Sergii Dmytruk wrote: From: Krystian Hebel This file is built twice: for early 32b mode without paging to measure MBI and for 64b code to measure dom0 kernel and initramfs. Since MBI is small, the first case uses TPM to do the hashing. Kernel and initramfs on the other hand

Re: [PATCH v3 08/22] x86/slaunch: restore boot MTRRs after Intel TXT DRTM

2025-06-03 Thread ross . philipson
On 5/30/25 6:17 AM, Sergii Dmytruk wrote: From: Krystian Hebel In preparation for TXT SENTER call, GRUB had to modify MTRR settings to be UC for everything except SINIT ACM. Old values are restored from SLRT where they were saved by the bootloader. Signed-off-by: Krystian Hebel Signed-off-by:

Re: [PATCH v3 05/22] x86/boot/slaunch-early: early TXT checks and boot data retrieval

2025-06-03 Thread ross . philipson
On 5/30/25 6:17 AM, Sergii Dmytruk wrote: From: Krystian Hebel The tests validate that important parts of memory are protected against DMA attacks, including Xen and MBI. Modules can be tested later, when it is possible to report issues to a user before invoking TXT reset. TPM event log valida

Re: [PATCH v3 04/22] x86/boot/slaunch-early: implement early initialization

2025-06-03 Thread ross . philipson
On 5/30/25 6:17 AM, Sergii Dmytruk wrote: Make head.S invoke a C function to retrieve MBI and SLRT addresses in a platform-specific way. This is also the place to perform sanity checks of DRTM. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- xen/arch/x86/Makefile

Re: [PATCH 02/21] include/xen/slr_table.h: Secure Launch Resource Table definitions

2025-04-23 Thread ross . philipson
On 4/23/25 7:47 AM, Sergii Dmytruk wrote: On Tue, Apr 22, 2025 at 01:46:14PM -0700, ross.philip...@oracle.com wrote: + +/* + * ARM DRTM Info table + */ +struct slr_entry_arm_info +{ +struct slr_entry_hdr hdr; +} __packed; You can probably ditch this for now. Right, it has no value at thi

Re: [PATCH 02/21] include/xen/slr_table.h: Secure Launch Resource Table definitions

2025-04-22 Thread ross . philipson
On 4/22/25 8:06 AM, Sergii Dmytruk wrote: The file provides constants, structures and several helper functions for parsing SLRT. Signed-off-by: Sergii Dmytruk --- xen/include/xen/slr_table.h | 274 1 file changed, 274 insertions(+) create mode 100644 xe

Re: [PATCH v2 0/2] x86: Check return values for early memory/IO remap calls

2023-01-03 Thread Ross Philipson
On 11/10/22 10:45, Ross Philipson wrote: While sending an earlier patch set it was discovered that there are a number of places in early x86 code were the functions early_memremap() and early_ioremap() are called but the returned pointer is not checked for NULL. Since NULL can be returned for a

Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls

2022-11-10 Thread Ross Philipson
On 11/10/22 11:07, Dave Hansen wrote: On 11/10/22 07:45, Ross Philipson wrote: dt = early_memremap(initial_dtb, map_len); + if (!dt) { + pr_warn("failed to memremap initial dtb\n"); + return; + } Are all of these new pr_warn/err(

Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls

2022-11-10 Thread Ross Philipson
On 11/10/22 13:07, Peter Zijlstra wrote: On Thu, Nov 10, 2022 at 03:45:21PM +, Ross Philipson wrote: On allocation failures, panic() was used since this seemed to be the action taken on other failures in the modules touched by this patch. How is the panic() more useful than the obvious

[PATCH v2 0/2] x86: Check return values for early memory/IO remap calls

2022-11-10 Thread Ross Philipson
proper usage of pr_* printing macros. Ross Philipson (2): x86: Check return values from early_memremap calls x86: Check return values from early_ioremap calls arch/x86/kernel/apic/x2apic_uv_x.c | 2 ++ arch/x86/kernel/devicetree.c | 13 ++ arch/x86/kernel/e820.c

[PATCH v2 2/2] x86: Check return values from early_ioremap calls

2022-11-10 Thread Ross Philipson
touched by this patch. Signed-off-by: Ross Philipson --- arch/x86/kernel/apic/x2apic_uv_x.c | 2 ++ arch/x86/kernel/early_printk.c | 2 ++ arch/x86/kernel/vsmp_64.c | 3 +++ 3 files changed, 7 insertions(+) diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic

[PATCH v2 1/2] x86: Check return values from early_memremap calls

2022-11-10 Thread Ross Philipson
failures. In addition to checking the return values, a bit of extra cleanup of pr_* usages was done since the pr_fmt macro was introduced in the modules touched by this patch. Signed-off-by: Ross Philipson --- arch/x86/kernel/devicetree.c | 13 +++ arch/x86/kernel/e820.c | 12

Re: Xen vs Trenchboot: TXT AP bringup

2022-11-07 Thread Ross Philipson
On 11/3/22 05:29, 'Jan Beulich' via trenchboot-devel wrote: On 27.10.2022 21:37, Andrew Cooper wrote: However, we're also very close to supporting parallel boot.  The serialising point we currently have is __high_start loading %rsp from stack_start, because that's a single pointer adjusted by do

Re: [PATCH 1/2] x86: Check return values from early_memremap calls

2022-10-12 Thread Ross Philipson
On 10/8/22 11:12, Borislav Petkov wrote: Adding Xen and Jailhouse people and MLs to Cc. Folks, thread starts here: https://lore.kernel.org/r/1650035401-22855-1-git-send-email-ross.philip...@oracle.com On Fri, Apr 15, 2022 at 11:10:00AM -0400, Ross Philipson wrote: There are a number of

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-08 Thread Ross Philipson
CK also confirms that Citrix is happy for the header files to > be published under a BSD license in this series (which is based on [1]). > > Signed-off-by: Christopher Clark > Acked-by: Lars Kurth Other than an indentation issue in domain_rings_remove_all, this LGTM. Reviewed-by: Ros

Re: [Xen-devel] [GRUB PATCH 1/2] verifiers: Xen fallout cleanup

2018-12-06 Thread Ross Philipson
On 12/06/2018 10:40 AM, Daniel Kiper wrote: > On Thu, Dec 06, 2018 at 10:37:43AM -0500, Ross Philipson wrote: >> On 12/06/2018 08:40 AM, Daniel Kiper wrote: >>> Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for >>> fine-grained signature-verification c

Re: [Xen-devel] [GRUB PATCH 2/2] verifiers: ARM Xen fallout cleanup

2018-12-06 Thread Ross Philipson
On 12/06/2018 08:40 AM, Daniel Kiper wrote: > ARM Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for > fine-grained signature-verification controlling). > > Signed-off-by: Daniel Kiper > --- > grub-core/loader/arm64/xen_boot.c | 8 > include/grub/file.h |

Re: [Xen-devel] [GRUB PATCH 1/2] verifiers: Xen fallout cleanup

2018-12-06 Thread Ross Philipson
On 12/06/2018 08:40 AM, Daniel Kiper wrote: > Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for > fine-grained signature-verification controlling). > > Signed-off-by: Daniel Kiper > --- > grub-core/loader/i386/xen.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 del

Re: [Xen-devel] [PATCH v2] x86/boot: enable NMIs after traps init

2018-10-23 Thread Ross Philipson
On 10/23/2018 12:58 PM, Andrew Cooper wrote: > On 23/10/18 17:42, Ross Philipson wrote: >> On 10/23/2018 11:31 AM, Jason Andryuk wrote: >>> On Tue, Oct 23, 2018 at 10:46 AM Andrew Cooper >>> wrote: >>>> On 23/10/18 15:01, Jason Andryuk wrote: >>>

Re: [Xen-devel] [PATCH v2] x86/boot: enable NMIs after traps init

2018-10-23 Thread Ross Philipson
On 10/23/2018 11:31 AM, Jason Andryuk wrote: > On Tue, Oct 23, 2018 at 10:46 AM Andrew Cooper > wrote: >> On 23/10/18 15:01, Jason Andryuk wrote: >>> On Tue, Oct 23, 2018 at 7:15 AM Andrew Cooper >>> wrote: On 23/10/18 11:59, Sergey Dyasli wrote: > In certain scenarios, NMIs might be