#x27;ll be absorbed within cpu_common_[un]realizefn().
---
cpu-target.c | 30 --
hw/core/cpu-common.c | 26 ++
2 files changed, 26 insertions(+), 30 deletions(-)
Reviewed-by: Richard Henderson
r~
manually.
Only 2 more CONFIG_USER_ONLY to go.
Reviewed-by: Richard Henderson
--- a/hw/core/cpu-system.c
+++ b/hw/core/cpu-system.c
@@ -22,10 +22,21 @@
#include "qapi/error.h"
#include "exec/address-spaces.h"
#include "exec/memory.h"
+#include "exec/t
/core/cpu-system.c | 7 +++
hw/core/cpu-user.c | 5 +
3 files changed, 12 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson
r~
hw/core/cpu-system.c | 40 ++
hw/core/cpu-user.c | 27 +
hw/core/meson.build | 5 +++-
4 files changed, 71 insertions(+), 59 deletions(-)
create mode 100644 hw/core/cpu-user.c
Reviewed-by: Richard Henderson
r~
On 1/23/25 15:44, Philippe Mathieu-Daudé wrote:
CPU_INTERRUPT_EXIT was removed in commit 3098dba01c7
("Use a dedicated function to request exit from execution
loop"), tlb_flush() and tb_flush() are related to TCG
accelerator.
Signed-off-by: Philippe Mathieu-Daudé
---
cpu-target.c | 33 +++
ing the
* usual mechanisms that ensure we flush TBs for writes to
* memory we've translated code from. So we must flush all TBs,
* which will now be stale.
Reviewed-by: Richard Henderson
r~
On 1/23/25 15:44, Philippe Mathieu-Daudé wrote:
cpu_memory_rw_debug() system implementation is defined in
system/physmem.c. Move the user one to accel/tcg/user-exec.c
to simplify cpu-target.c maintenance.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/user-exec.c | 92 ++
/kvm.c | 2 +-
target/riscv/kvm/kvm-cpu.c| 2 +-
target/riscv/tcg/tcg-cpu.c| 2 +-
10 files changed, 11 insertions(+), 11 deletions(-)
rename include/{hw/core/accel-cpu.h => accel/accel-cpu-target.h} (95%)
Reviewed-by: Richard Henderson
r~
mm-accel-ops.c | 1 +
target/i386/whpx/whpx-accel-ops.c | 1 +
19 files changed, 12 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson
r~
4:74: note: expanded from macro 'OBJECT_CLASS_CHECK'
544 | ((class_type
*)object_class_dynamic_cast_assert(OBJECT_CLASS(class), (name), \
|
^
Signed-off-by: Philippe Mathieu-Daudé
---
include/accel/accel-cpu-target.h | 3 +++
1 file changed, 3 insertions(+)
Acked-by: Richard Henderson
r~
On 1/26/25 12:36, Richard Henderson wrote:
On 1/23/25 15:44, Philippe Mathieu-Daudé wrote:
TCGCPUOps structure makes more sense in the accelerator context
rather than hardware emulation. Move it under the accel/tcg/ scope.
Mechanical change doing:
$ sed -i -e 's,hw/core/tcg-cpu-ops.h,
On 1/23/25 15:44, Philippe Mathieu-Daudé wrote:
TCGCPUOps structure makes more sense in the accelerator context
rather than hardware emulation. Move it under the accel/tcg/ scope.
Mechanical change doing:
$ sed -i -e 's,hw/core/tcg-cpu-ops.h,accel/tcg/cpu-ops.h,g' \
$(git grep -l hw/core
-off-by: Philippe Mathieu-Daudé
---
accel/tcg/internal-common.h | 2 ++
include/system/cpus.h | 2 --
accel/tcg/icount-common.c | 2 ++
system/globals.c| 1 -
4 files changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
On 1/23/25 15:44, Philippe Mathieu-Daudé wrote:
Move CPU TLB related methods to accel/tcg/ scope,
in "internal-common.h".
Suggested-by: Richard Henderson
Reviewed-by: Pierrick Bouvier
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/internal-common.h | 11 +++
include
| 33 +
accel/tcg/cpu-exec.c| 32
2 files changed, 33 insertions(+), 32 deletions(-)
Reviewed-by: Richard Henderson
r~
;
int kvm_cpu_exec(CPUState *cpu);
void kvm_destroy_vcpu(CPUState *cpu);
Reviewed-by: Richard Henderson
r~
---
cpu-target.c | 3 ---
hw/core/cpu-common.c | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
-
2 files changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson
r~
/user/mmap.h| 32
linux-user/user-mmap.h | 19 ++-
3 files changed, 35 insertions(+), 28 deletions(-)
create mode 100644 include/user/mmap.h
Reviewed-by: Richard Henderson
r~
On 12/17/24 09:13, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (3):
hw/xen: Remove unnecessary 'exec/cpu-common.h' header
system/numa: Remove unnecessary 'exec/cpu-common.h' header
system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header
On 12/16/24 00:14, CLEMENT MATHIEU--DRIF wrote:
Hi Rihard.
Good idea, LGTM.
Just out of curiosity, what was the motivation for such a patch?
It it simply about cleaning the code or is it intended to solve a deeper
problem.
Simply cleaning the code, prompted by a change to core QAPI code for R
Signed-off-by: Richard Henderson
---
hw/xen/xen-bus.c| 2 +-
hw/xen/xen-legacy-backend.c | 4 ++--
hw/xen/xen_pt.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
index 95b207ac8b..0d7defb8cd 100644
--- a/hw/xen
Signed-off-by: Richard Henderson
---
hw/xen/xen-legacy-backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c
index b15393e934..f6ad58fe13 100644
--- a/hw/xen/xen-legacy-backend.c
+++ b/hw/xen/xen-legacy-backend.c
Signed-off-by: Richard Henderson
---
hw/net/allwinner-sun8i-emac.c | 2 +-
hw/net/allwinner_emac.c| 2 +-
hw/net/cadence_gem.c | 2 +-
hw/net/can/xlnx-versal-canfd.c | 2 +-
hw/net/can/xlnx-zynqmp-can.c | 2 +-
hw/net/dp8393x.c | 2 +-
hw/net/e1000.c
Signed-off-by: Richard Henderson
---
hw/i386/amd_iommu.c| 2 +-
hw/i386/intel_iommu.c | 2 +-
hw/i386/kvm/clock.c| 2 +-
hw/i386/kvm/i8254.c| 2 +-
hw/i386/kvm/ioapic.c | 2 +-
hw/i386/sgx-epc.c | 2 +-
hw/i386/vmmouse.c | 2 +-
hw/i386
Signed-off-by: Richard Henderson
---
hw/block/fdc-isa.c| 2 +-
hw/block/fdc-sysbus.c | 4 ++--
hw/block/fdc.c| 2 +-
hw/block/m25p80.c | 2 +-
hw/block/nand.c | 2 +-
hw/block/pflash_cfi01.c | 2 +-
hw/block/pflash_cfi02.c | 2 +-
hw/block/swim.c
xen_block_prop_vdev is not used outside the file.
Signed-off-by: Richard Henderson
---
hw/block/xen-block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index aed1d5c330..72cfd6893a 100644
--- a/hw/block/xen-block.c
+++ b/hw
Signed-off-by: Richard Henderson
---
hw/char/avr_usart.c | 2 +-
hw/char/bcm2835_aux.c | 2 +-
hw/char/cadence_uart.c | 2 +-
hw/char/cmsdk-apb-uart.c| 2 +-
hw/char/debugcon.c | 2 +-
hw/char/digic-uart.c| 2 +-
hw/char/escc.c | 2 +-
hw/char
-common.h" *common* header.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-hvm-common.h | 1 -
hw/arm/xen_arm.c| 1 +
hw/i386/xen/xen-hvm.c | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
(-)
Reviewed-by: Richard Henderson
r~
On 11/13/23 07:21, Philippe Mathieu-Daudé wrote:
diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c
index c028c1b541..03f9417e7e 100644
--- a/hw/xen/xen-hvm-common.c
+++ b/hw/xen/xen-hvm-common.c
@@ -426,10 +426,7 @@ static void handle_ioreq(XenIOState *state, ioreq_t *req)
trac
iles changed, 6 insertions(+), 28 deletions(-)
delete mode 100644 include/hw/arm/xen_arch_hvm.h
delete mode 100644 include/hw/i386/xen_arch_hvm.h
delete mode 100644 include/hw/xen/arch_hvm.h
Reviewed-by: Richard Henderson
r~
arch_hvm.h | 4 ++--
hw/arm/xen_arm.c | 4 ++--
hw/i386/xen/xen-hvm.c | 6 +++---
hw/xen/xen-hvm-common.c| 4 ++--
5 files changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson
r~
: Richard Henderson
r~
On 8/31/23 06:25, Markus Armbruster wrote:
+#define PASTE(a, b) a##b
We already have glue() in qemu/compiler.h.
The rest of it looks quite sensible.
r~
target/i386/hax/hax-posix.c | 4 ++--
target/i386/hax/hax-windows.c | 4 ++--
target/i386/nvmm/nvmm-all.c | 2 +-
target/i386/whpx/whpx-all.c | 2 +-
8 files changed, 22 insertions(+), 21 deletions(-)
Reviewed-by: Richard Henderson
r~
Daudé
I would have chosen 'cs', since 'cpu' is often used for ArchCPU. But ok.
Acked-by: Richard Henderson
r~
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote:
g_new0() can not fail. Remove the unreachable error path.
https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description
Reported-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
1 file changed, 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote:
|+ struct AccelvCPUState *accel;|
...
+typedef struct AccelCPUState {
hax_fd fd;
int vcpu_id;
struct hax_tunnel *tunnel;
unsigned char *iobuf;
-};
+} hax_vcpu_state;
Discussed face to face, but for the record:
Put the typed
| 3 +++
target/i386/hax/hax-all.c | 1 +
2 files changed, 4 insertions(+)
Reviewed-by: Richard Henderson
r~
0() by g_new0() for readability.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 3 --
include/sysemu/hvf_int.h | 2 +-
accel/hvf/hvf-accel-ops.c | 16 -
target/arm/hvf/hvf.c | 70 +++
4 files changed, 44 insertions(+)
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
No need for this helper to access the CPUState::accel field.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/whpx/whpx-all.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
Reviewed-by: Richard
cpu)
+static struct AccelvCPUState *get_whpx_vcpu(CPUState *cpu)
{
-return (struct whpx_vcpu *)cpu->accel;
+return (struct AccelvCPUState *)cpu->accel;
Same comment about removing 'struct'.
Reviewed-by: Richard Henderson
-vcpu = g_new0(struct whpx_vcpu, 1);
+vc
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
No need for this helper to access the CPUState::accel field.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/nvmm/nvmm-all.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
Reviewed-by: Richard
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
-struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu);
+struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu);
With the typedef in hw/core/cpu.h, you can drop the 'struct' at the same time.
Otherwise,
Reviewed-by: Richard Henderson
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
+struct AccelvCPUState;
Missing typedef?
r~
-accel-ops.c | 2 +-
target/i386/hax/hax-all.c | 2 +-
target/i386/hax/hax-windows.c | 2 +-
5 files changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
We want all accelerators to share the same opaque pointer in
CPUState. Start with the HAX context, renaming its forward
declarated structure 'hax_vcpu_state' as 'AccelvCPUState'.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
All accelerators will share a single opaque context
in CPUState. Start by renaming 'hax_vcpu' as 'accelCPUState'.
Pasto in 'accel' here.
Reviewed-by: Richard Henderson
r~
insertions(+)
Reviewed-by: Richard Henderson
r~
| 3 ---
3 files changed, 10 deletions(-)
Reviewed-by: Richard Henderson
r~
/nvmm.h | 2 ++
include/sysemu/tcg.h | 2 ++
include/sysemu/whpx.h | 2 ++
include/sysemu/xen.h | 2 ++
6 files changed, 12 insertions(+)
Acked-by: Richard Henderson
r~
On 3/6/23 00:46, Thomas Huth wrote:
+continuous to be supported on 32-bit arm hosts, too)
"continues"
Acked-by: Richard Henderson
r~
On 2/27/23 23:00, Michael S. Tsirkin wrote:
On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote:
Removing support for building on 32 bit systems seems like a pity - it's
one of a small number of ways to run 64 bit binaries on 32 bit systems,
and the maintainance overhead is
On 2/27/23 01:50, Daniel P. Berrangé wrote:
On Mon, Feb 27, 2023 at 12:10:49PM +0100, Thomas Huth wrote:
Hardly anybody still uses 32-bit x86 hosts today, so we should
start deprecating them to finally have less test efforts.
With regards to 32-bit KVM support in the x86 Linux kernel,
the develo
On 2/27/23 10:12, Michael S. Tsirkin wrote:
On Mon, Feb 27, 2023 at 11:50:07AM +, Daniel P. Berrangé wrote:
I feel like we should have separate deprecation entries for the
i686 host support, and for qemu-system-i386 emulator binary, as
although they're related they are independant features w
On 6/14/22 05:15, Gerd Hoffmann wrote:
The following changes since commit debd0753663bc89c86f5462a53268f2e3f680f60:
Merge tag 'pull-testing-next-140622-1' of https://github.com/stsquad/qemu
into staging (2022-06-13 21:10:57 -0700)
are available in the Git repository at:
git://git.kraxel
On 6/13/22 08:52, Richard Henderson wrote:
On 6/13/22 04:36, Gerd Hoffmann wrote:
The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac:
Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging (2022-06-11
21:13:27 -0700)
are available
On 6/13/22 04:36, Gerd Hoffmann wrote:
The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac:
Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging
(2022-06-11 21:13:27 -0700)
are available in the Git repository at:
git://git.kraxel.org/qemu tags
On 6/10/22 02:20, Gerd Hoffmann wrote:
The following changes since commit 9cc1bf1ebca550f8d90f967ccd2b6d2e00e81387:
Merge tag 'pull-xen-20220609' of
https://xenbits.xen.org/git-http/people/aperard/qemu-dm into staging
(2022-06-09 08:25:17 -0700)
are available in the Git repository at:
On 11/1/21 6:08 PM, Juan Quintela wrote:
The following changes since commit af531756d25541a1b3b3d9a14e72e7fedd941a2e:
Merge remote-tracking branch 'remotes/philmd/tags/renesas-20211030' into
staging (2021-10-30 11:31:41 -0700)
are available in the Git repository at:
https://github.com/j
On 9/11/21 3:31 PM, Philippe Mathieu-Daudé wrote:
On 9/3/21 11:11 PM, Philippe Mathieu-Daudé wrote:
On 9/3/21 10:42 PM, Richard Henderson wrote:
On 9/3/21 2:50 AM, David Gibson wrote:
On Thu, Sep 02, 2021 at 06:15:34PM +0200, Philippe Mathieu-Daudé wrote:
Each POWER cpu has its own has_work
w/core/cpu-common.c | 6 --
softmmu/cpus.c| 9 ++---
target/i386/hax/hax-accel-ops.c | 6 ++
target/i386/nvmm/nvmm-accel-ops.c | 6 ++
8 files changed, 32 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson
r~
/target/rx/cpu.c
+++ b/target/rx/cpu.c
@@ -41,11 +41,13 @@ static void rx_cpu_synchronize_from_tb(CPUState *cs,
cpu->env.pc = tb->pc;
}
+#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY)
static bool rx_cpu_has_work(CPUState *cs)
No CONFIG_TCG, otherwise,
Review
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/ppc/cpu_init.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/riscv/cpu.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
The common ppc_cpu_has_work() handler already checks for cs->halted,
so we can simplify all callees.
Signed-off-by: Philippe Mathieu-Daudé
---
target/ppc/cpu_init.c | 294 --
1 file changed, 138 insertion
On 9/3/21 2:50 AM, David Gibson wrote:
On Thu, Sep 02, 2021 at 06:15:34PM +0200, Philippe Mathieu-Daudé wrote:
Each POWER cpu has its own has_work() implementation. Instead of
overloading CPUClass on each PowerPCCPUClass init, register the
generic ppc_cpu_has_work() handler, and have it call the
On 9/3/21 10:34 PM, Philippe Mathieu-Daudé wrote:
Drop CONFIG_TCG for alpha; it's always true.
What is the rational? "Old" architectures (with no active /
official hw development) are unlikely to add hardware
acceleration, so TCG is the single one possible? Thus no
need to clutter the code with
e *cs)
No CONFIG_TCG, otherwise,
Reviewed-by: Richard Henderson
r~
, otherwise,
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
u_has_work(CPUState *cs)
No CONFIG_TCG, otherwise,
Reviewed-by: Richard Henderson
r~
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.c | 6 --
target/i386/tcg/tcg-cpu.c | 8 +++-
2 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson
r~
s)
No CONFIG_TCG, otherwise
Reviewed-by: Richard Henderson
r~
(-)
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
+#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY)
static bool cris_cpu_has_work(CPUState *cs)
No CONFIG_TCG for cris. Otherwise,
Reviewed-by: Richard Henderson
r~
e *cs)
No CONFIG_TCG or CONFIG_USER_ONLY test for avr.
Otherwise,
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/arm/cpu.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
alpha; it's always true.
Otherwise,
Reviewed-by: Richard Henderson
r~
| 12
2 files changed, 16 insertions(+)
Reviewed-by: Richard Henderson
r~
-accel-ops.c | 6 ++
2 files changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
+-
2 files changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
(+)
Reviewed-by: Richard Henderson
r~
changed, 9 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
cpu_has_work() is only called from system emulation code.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Richard Henderson
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
+#ifndef CONFIG_USER_ONLY
static inline bool cpu_handle_halt(CPUState *cpu)
{
Hmm, slightly better to move the ifdef just inside here,
@@ -607,6 +608,7 @@ static inline bool cpu_handle_halt(CPUState *cpu)
and here,
return false
On 2/26/21 8:40 AM, Philippe Mathieu-Daudé wrote:
> +++ b/include/hw/core/cpu-system-ops.h
> @@ -0,0 +1,89 @@
> +/*
> + * CPU operations specific to system emulation
> + *
> + * Copyright (c) 2012 SUSE LINUX Products GmbH
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 o
On 9/20/20 4:44 AM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (2):
> qdev: Document qbus_realize() and qbus_unrealize()
> qdev: Let BusRealize() return a boolean value to indicate error
Reviewed-by: Richard Henderson
r~
On 6/1/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On 6/1/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/hppa/dino.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
On 6/1/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/i386/xen/xen-hvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
On 6/1/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/pci/pci_bridge.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
pci-host/versatile.c | 5 +++--
> 3 files changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
eu-Daudé
> ---
> hw/pci/pci_bridge.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
ippe Mathieu-Daudé
> ---
> hw/pci-host/prep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
0bfff (prio 0, ram): ram
> c000- (prio 0, i/o): max_ram
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
ove unnecessary CPU() cast
> various: Remove unnecessary OBJECT() cast
> hw: Remove unnecessary DEVICE() cast
Reviewed-by: Richard Henderson
r~
1 - 100 of 126 matches
Mail list logo
