Re: [RFC] x86/HVM: stdvga caching mode

2024-09-05 Thread Paul Durrant
On 05/09/2024 11:41, Andrew Cooper wrote: STDVGA caching is primarily (exclusively?) an optimisation for Windows XP. I think it was originally for Win2K (white splash screen). Paul

Re: [PATCH] blkif: reconcile protocol specification with in-use implementations

2024-09-04 Thread Paul Durrant
On 04/09/2024 09:21, Roger Pau Monné wrote: In the absence of that I'm afraid it is a little harder to judge whether the proposal here is the best we can do at this point. While I don't mind looking at what we can do to better handle 4K sector disks, we need IMO to revert to the specification b

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Paul Durrant
On 02/09/2024 16:23, Roger Pau Monné wrote: On Mon, Sep 02, 2024 at 03:19:56PM +0100, Paul Durrant wrote: On 02/09/2024 09:55, Roger Pau Monné wrote: [snip] Thanks for your input. I would also like to hear from the blktap and Windows PV drivers maintainers, as the change that I'm prop

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Paul Durrant
On 02/09/2024 09:55, Roger Pau Monné wrote: [snip] Thanks for your input. I would also like to hear from the blktap and Windows PV drivers maintainers, as the change that I'm proposing here will require changes to their implementations. So IIUC you are proposing to refuse to connect to a fro

Re: [PATCH] x86/viridian: Clarify some viridian logging strings

2024-07-26 Thread Paul Durrant
t val) d->shutdown_code = SHUTDOWN_crash; spin_unlock(&d->shutdown_lock); -gprintk(XENLOG_WARNING, "VIRIDIAN CRASH: %lx %lx %lx %lx %lx\n", +gprintk(XENLOG_WARNING, +"VIRIDIAN GUEST_CRASH: %#lx %#lx %#lx %#lx %#l

Re: [XEN PATCH v4 10/14] x86/vmx: guard access to cpu_has_vmx_* in common code

2024-07-10 Thread Paul Durrant
| 2 +- xen/arch/x86/hvm/viridian/viridian.c| 4 ++-- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 17 +++-- xen/arch/x86/traps.c| 5 +++-- 4 files changed, 17 insertions(+), 11 deletions(-) Viridian changes... Acked-by: Paul Durrant

Re: [PATCH v3 3/3] ui+display: rename is_buffer_shared() -> surface_is_allocated()

2024-06-06 Thread Paul Durrant
: Gerd Hoffmann --- include/ui/surface.h| 4 ++-- hw/display/qxl-render.c | 2 +- hw/display/vga.c| 20 ++-- hw/display/xenfb.c | 5 +++-- ui/console.c| 3 ++- 5 files changed, 18 insertions(+), 16 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 7/7] hw/xen: Register framebuffer backend via xen_backend_init()

2024-05-31 Thread Paul Durrant
alized the vga_interface_type variable. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen-legacy-backend.h | 3 --- hw/display/xenfb.c | 9 +++-- hw/xenpv/xen_machine_pv.c | 2 -- 3 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 6/7] hw/xen: register legacy backends via xen_backend_init

2024-05-31 Thread Paul Durrant
kend.c | 16 6 files changed, 20 insertions(+), 38 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 5/7] hw/xen: initialize legacy backends from xen_bus_init()

2024-05-31 Thread Paul Durrant
(+), 7 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 4/7] hw/xen: Make XenDevOps structures const

2024-05-31 Thread Paul Durrant
| 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 3/7] hw/xen: Constify xenstore_be::XenDevOps

2024-05-31 Thread Paul Durrant
(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 2/7] hw/xen: Constify XenLegacyDevice::XenDevOps

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: XenDevOps @ops is not updated, mark it const. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen_pvdev.h | 2 +- hw/xen/xen-legacy-backend.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 1/7] hw/xen: Remove declarations left over in 'xen-legacy-backend.h'

2024-05-31 Thread Paul Durrant
;xen_console_ops' in commit 9b77374690 ("hw/xen: update Xen console to XenDevice model"). Remove them. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen-legacy-backend.h | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] xen-hvm: Avoid livelock while handling buffered ioreqs

2024-04-08 Thread Paul Durrant
continue processing them. This lets QEMU go back to the main loop and catch up. Signed-off-by: Ross Lagerwall --- hw/xen/xen-hvm-common.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] xen-hvm: Avoid livelock while handling buffered ioreqs

2024-04-08 Thread Paul Durrant
On 08/04/2024 14:00, Ross Lagerwall wrote: On Sat, Apr 6, 2024 at 11:58 AM Durrant, Paul wrote: On 04/04/2024 15:08, Ross Lagerwall wrote: A malicious or buggy guest may generated buffered ioreqs faster than QEMU can process them in handle_buffered_iopage(). The result is a livelock - QEMU co

Re: Xen NIC driver have page_pool memory leaks

2024-03-25 Thread Paul Durrant
On 25/03/2024 12:21, Jesper Dangaard Brouer wrote: Hi Arthur, (Answer inlined below, which is custom on this mailing list) On 23/03/2024 14.23, Arthur Borsboom wrote: Hi Jesper, After a recent kernel upgrade 6.7.6 > 6.8.1 all my Xen guests on Arch Linux are dumping kernel traces. It seems to

[PATCH] MAINTAINERS: Remove myself from several subsystems

2024-03-13 Thread Paul Durrant
From: Paul Durrant I am not as actively involved with the Xen project as I once was so I need to relinquish some of my maintainer responsibilities: IOMMU and I/O emulation. NOTE: Since I am sole maintainer for I/O EMULATION (IOREQ) and X86 I/O EMULATION, these sections are removed

Re: [PATCH net 1/7] net: fill in MODULE_DESCRIPTION()s for xen-netback

2024-02-13 Thread Paul Durrant
On 13/02/2024 11:21, Breno Leitao wrote: W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the Xen backend network module. Signed-off-by: Breno Leitao --- drivers/net/xen-netback/netback.c | 1 + 1 file changed, 1 insertion(+) Acked-by: Paul

Re: [PATCH] x86/HVM: tidy state on hvmemul_map_linear_addr()'s error path

2024-02-08 Thread Paul Durrant
entinel... it's just a question of having a #define for it). Either way... Acked-by: Paul Durrant --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -696,7 +696,12 @@ static void *hvmemul_map_linear_addr( out: /* Drop all held references. */

Re: Ping: [PATCH] x86/guest: finish conversion to altcall

2024-02-02 Thread Paul Durrant
k (or otherwise)? Thanks, Jan Yes, no objections. Acked-by: Paul Durrant --- a/xen/arch/x86/guest/hyperv/hyperv.c +++ b/xen/arch/x86/guest/hyperv/hyperv.c @@ -207,7 +207,7 @@ static int cf_check flush_tlb( return hyperv_flush_tlb(mask, va, flags); } -static const struct hypervisor_ops

Re: [PATCH net] xen-netback: properly sync TX responses

2024-02-01 Thread Paul Durrant
y xenvif_tx_build_gops() works precludes an ADD and a DEL coming together in a single dummy request (the DEL would be ignored). It appears the Solaris backend never coped with multiple extra_info so what the 'correct' semantic would be is unclear. Anyway... Reviewed-by: Paul Durrant

Re: [PATCH net] xen-netback: properly sync TX responses

2024-02-01 Thread Paul Durrant
On 01/02/2024 00:23, Jakub Kicinski wrote: On Mon, 29 Jan 2024 14:03:08 +0100 Jan Beulich wrote: Invoking the make_tx_response() / push_tx_responses() pair with no lock held would be acceptable only if all such invocations happened from the same context (NAPI instance or dealloc thread). Since t

Re: [PATCH v5 3/3] x86/iommu: cleanup unused functions

2024-01-29 Thread Paul Durrant
| 53 ++- xen/arch/x86/tboot.c | 2 +- 5 files changed, 3 insertions(+), 61 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v5 2/3] x86/iommu: switch hwdom IOMMU to use a rangeset

2024-01-29 Thread Paul Durrant
ase. x86/iommu: add CHANGELOG entry for hwdom setup time improvements Signed-off-by: Roger Pau Monné Reviewed-by: Paul Durrant

Re: [PATCH v6 1/3] x86/iommu: remove regions not to be mapped

2024-01-29 Thread Paul Durrant
/x86/include/asm/hvm/io.h | 3 ++ xen/arch/x86/include/asm/setup.h| 1 + xen/arch/x86/setup.c| 48 +++ xen/drivers/passthrough/x86/iommu.c | 61 + 5 files changed, 129 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH v4 3/6] xen: decouple generic xen code from legacy backends codebase

2023-12-04 Thread Paul Durrant
: add option to disable legacy backends" - Do not move xenstore global variable from xen-legacy-backend.c, instead use a local variable. --- accel/xen/xen-all.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 05/12] block: remove AioContext locking

2023-11-30 Thread Paul Durrant
/test-replication.c | 11 -- util/async.c | 4 - util/vhost-user-server.c | 3 - scripts/block-coroutine-wrapper.py | 3 - tests/tsan/suppressions.tsan | 1 - 41 files changed, 102 insertions(+), 1202 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 2/6] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to QEMU_BQL_LOCK_GUARD

2023-11-30 Thread Paul Durrant
ons(+), 25 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 1/6] system/cpus: rename qemu_mutex_lock_iothread() to qemu_bql_lock()

2023-11-30 Thread Paul Durrant
les changed, 502 insertions(+), 502 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory

2023-11-23 Thread Paul Durrant
On 23/11/2023 12:27, David Woodhouse wrote: On 23 November 2023 12:17:57 GMT, Volodymyr Babchuk wrote: Hi David, David Woodhouse writes: Which PV backends do you care about? We already have net, block and console converted. Well, this is all what we need, actually. Even console only wil

Re: [PATCH v2 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2023-11-23 Thread Paul Durrant
On 22/11/2023 23:04, David Woodhouse wrote: On Wed, 2023-11-22 at 22:56 +, Volodymyr Babchuk wrote: Paul Durrant writes: On 21/11/2023 22:10, Volodymyr Babchuk wrote: From: David Woodhouse This allows a XenDevice implementation to know whether it was created by QEMU, or merely

Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory

2023-11-23 Thread Paul Durrant
at 14:29 -0800, Stefano Stabellini wrote: On Wed, 22 Nov 2023, Paul Durrant wrote: On 21/11/2023 22:10, Volodymyr Babchuk wrote: From: Oleksandr Tyshchenko Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to inherit the owner of the directory. Ah... so that's why the pre

Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory

2023-11-22 Thread Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote: From: Oleksandr Tyshchenko Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to inherit the owner of the directory. Ah... so that's why the previous patch is there. This is not the right way to fix it. The QEMU Xen support is *assumi

Re: [PATCH v2 3/6] xen: xenstore: add possibility to preserve owner

2023-11-22 Thread Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote: Add option to preserve owner when creating an entry in Xen Store. This may be needed in cases when Qemu is working as device model in a *may* be needed? I don't undertstand why this patch is necessary and the commit comment isn't really helping me

Re: [PATCH v2 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2023-11-22 Thread Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote: From: David Woodhouse This allows a XenDevice implementation to know whether it was created by QEMU, or merely discovered in XenStore after the toolstack created it. This will allow us to create frontend/backend nodes only when we should, rather tha

Re: [PATCH v2 2/6] xen: backends: touch some XenStore nodes only if device...

2023-11-22 Thread Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote: was created by QEMU Xen PV devices in QEMU can be created in two ways: either by QEMU itself, if they were passed via command line, or by Xen toolstack. In the latter case, QEMU scans XenStore entries and configures devices accordingly. In the secon

Re: [PATCH v2 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2023-11-22 Thread Paul Durrant
/xen_nic.c | 2 +- hw/xen/xen-bus.c | 4 include/hw/xen/xen-backend.h | 2 -- include/hw/xen/xen-bus.h | 2 ++ 6 files changed, 9 insertions(+), 6 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 2/3] vl: disable default serial when xen-console is enabled

2023-11-21 Thread Paul Durrant
On 15/11/2023 17:24, David Woodhouse wrote: From: David Woodhouse If a Xen console is configured on the command line, do not add a default serial port. Signed-off-by: David Woodhouse --- system/vl.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Paul Durrant

Re: [PATCH 3/3] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

2023-11-15 Thread Paul Durrant
de to hopefully make it clearer to Coverity and human reviewers alike. Signed-off-by: David Woodhouse --- hw/block/xen-block.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v1 3/7] xen: xenstore: add possibility to preserve owner

2023-11-12 Thread Paul Durrant
On 10/11/2023 15:42, Volodymyr Babchuk wrote: Add option to preserve owner when creating an entry in Xen Store. This may be needed in cases when Qemu is working as device model in a domain that is Domain-0, e.g. in driver domain. "owner" parameter for qemu_xen_xs_create() function can have speci

Re: [PATCH v1 5/7] xen-bus: Set offline if backend's state is XenbusStateClosed

2023-11-12 Thread Paul Durrant
On 10/11/2023 15:42, Volodymyr Babchuk wrote: From: Oleksandr Tyshchenko Both state (XenbusStateClosed) and online (0) are expected by toolstack/xl devd to completely destroy the device. But "offline" is never being set by the backend resulting in timeout during domain destruction, garbage in X

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-12 Thread Paul Durrant
On 10/11/2023 15:42, Volodymyr Babchuk wrote: From: Oleksandr Tyshchenko The PV backend running in other than Dom0 domain (non toolstack domain) is not allowed to write frontend nodes. The more, the backend does not need to do that at all, this is purely toolstack/xl devd business. I do not kn

Re: [PATCH] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

2023-11-09 Thread Paul Durrant
de to hopefully make it clearer to Coverity and human reviewers alike. Signed-off-by: David Woodhouse ---  hw/block/xen-block.c | 24 +---  1 file changed, 21 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v4 17/17] docs: update Xen-on-KVM documentation

2023-11-06 Thread Paul Durrant
.rst | 107 +-- qemu-options.hx | 14 +++-- 3 files changed, 91 insertions(+), 32 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v4 16/17] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2023-11-06 Thread Paul Durrant
fs option is set. Signed-off-by: David Woodhouse --- docs/sphinx/hxtool.py | 18 +- docs/system/invocation.rst | 1 + 2 files changed, 18 insertions(+), 1 deletion(-) Reviewed-by: Paul Durrant

Re: [PATCH v4 13/17] hw/i386/pc: support '-nic' for xen-net-device

2023-11-06 Thread Paul Durrant
2 +- hw/i386/pc_q35.c | 2 +- hw/xen/xen-bus.c | 4 +++- include/hw/i386/pc.h | 4 +++- include/hw/xen/xen-bus.h | 2 +- 6 files changed, 17 insertions(+), 8 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v4 06/17] hw/xen: automatically assign device index to block devices

2023-11-06 Thread Paul Durrant
ed, 125 insertions(+), 46 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] xen/pt: Emulate multifunction bit in header type

2023-11-06 Thread Paul Durrant
using QAPI). This allows making passthrough devices appear as functions in a Xen guest. Signed-off-by: Ross Lagerwall Reviewed-by: Paul Durrant

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-25 Thread Paul Durrant
On 25/10/2023 10:00, David Woodhouse wrote: On Wed, 2023-10-25 at 09:31 +0100, Paul Durrant wrote: On 24/10/2023 17:34, David Woodhouse wrote: On Tue, 2023-10-24 at 17:25 +0100, Paul Durrant wrote: On 24/10/2023 16:49, David Woodhouse wrote: On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-25 Thread Paul Durrant
On 24/10/2023 17:34, David Woodhouse wrote: On Tue, 2023-10-24 at 17:25 +0100, Paul Durrant wrote: On 24/10/2023 16:49, David Woodhouse wrote: On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant wrote: On 24/10/2023 16:37, David Woodhouse wrote: On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-24 Thread Paul Durrant
On 24/10/2023 16:49, David Woodhouse wrote: On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant wrote: On 24/10/2023 16:37, David Woodhouse wrote: On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant wrote: On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse The primary console is

Re: [PATCH v2 16/24] hw/xen: handle soft reset for primary console

2023-10-24 Thread Paul Durrant
On 24/10/2023 16:48, David Woodhouse wrote: On Tue, 2023-10-24 at 16:44 +0100, Paul Durrant wrote: On 19/10/2023 16:40, David Woodhouse wrote: From: David Woodhouse On soft reset, the prinary console event channel needs to be rebound to the backend port (in the xen-console driver). We could

Re: [PATCH 2/4] hw/xen: update Xen PV NIC to XenDevice model

2023-10-24 Thread Paul Durrant
On 24/10/2023 16:17, David Woodhouse wrote: [snip] I don't think that's really a valid state for a network frontend. Linux netback just ignores it. Must we? I was thinking of making the ->frontend_changed() methods optional and allowing backends to just provide ->connect() and ->disconnect() m

Re: [PATCH v2 16/24] hw/xen: handle soft reset for primary console

2023-10-24 Thread Paul Durrant
On 19/10/2023 16:40, David Woodhouse wrote: From: David Woodhouse On soft reset, the prinary console event channel needs to be rebound to the backend port (in the xen-console driver). We could put that into the xen-console driver itself, but it's slightly less ugly to keep it within the KVM/Xen

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-24 Thread Paul Durrant
On 24/10/2023 16:37, David Woodhouse wrote: On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant wrote: On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse The primary console is special because the toolstack maps a page at a fixed GFN and also allocates the guest-side event channel

Re: [PATCH v2 10/24] hw/xen: populate store frontend nodes with XenStore PFN/port

2023-10-24 Thread Paul Durrant
ts to *rebind* to the event channel port after a reset. Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 11 +++ 1 file changed, 11 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH v2 05/24] hw/xen: fix XenStore watch delivery to guest

2023-10-24 Thread Paul Durrant
On 19/10/2023 16:40, David Woodhouse wrote: From: David Woodhouse When fire_watch_cb() found the response buffer empty, it would call deliver_watch() to generate the XS_WATCH_EVENT message in the response buffer and send an event channel notification to the guest… without actually *copying* the

Re: [PATCH v2 04/24] hw/xen: don't clear map_track[] in xen_gnttab_reset()

2023-10-24 Thread Paul Durrant
: de26b2619789 ("hw/xen: Implement soft reset for emulated gnttab") Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_gnttab.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 03/24] hw/xen: select kernel mode for per-vCPU event channel upcall vector

2023-10-24 Thread Paul Durrant
+++ 3 files changed, 14 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH 2/4] hw/xen: update Xen PV NIC to XenDevice model

2023-10-24 Thread Paul Durrant
On 17/10/2023 19:25, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/net/meson.build| 2 +- hw/net/trace-events | 9 + hw/net/xen_nic.c | 426 +- hw/xenpv/xen_machine_pv.c | 1 - 4 files c

Re: [PATCH 1/4] hw/xen: only remove peers of PCI NICs on unplug

2023-10-24 Thread Paul Durrant
On 17/10/2023 19:25, David Woodhouse wrote: From: David Woodhouse When the Xen guest asks to unplug *emulated* NICs, it's kind of unhelpful also to unplug the peer of the *Xen* PV NIC. Signed-off-by: David Woodhouse --- hw/i386/xen/xen_platform.c | 9 +++-- 1 file changed, 7 insertions

Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode

2023-10-24 Thread Paul Durrant
On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse The primary console is special because the toolstack maps a page at a fixed GFN and also allocates the guest-side event channel. Add support for that in emulated mode, so that we can have a primary console. Add a *very* rudiment

Re: [PATCH 09/12] hw/xen: prevent duplicate device registrations

2023-10-24 Thread Paul Durrant
On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse Ensure that we have a XenBackendInstance for every device regardless of whether it was "discovered" in XenStore or created directly in QEMU. This allows the backend_list to be a source of truth about whether a given backend exis

Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-10-24 Thread Paul Durrant
On 24/10/2023 14:29, David Woodhouse wrote: On Tue, 2023-10-24 at 13:59 +0100, Paul Durrant wrote: On 24/10/2023 13:56, David Woodhouse wrote: On Tue, 2023-10-24 at 13:42 +0100, Paul Durrant wrote: --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -711,8 +711,16 @@ static void

Re: [PATCH 08/12] hw/xen: do not repeatedly try to create a failing backend device

2023-10-24 Thread Paul Durrant
/xen-backend.h | 1 + 3 files changed, 24 insertions(+), 7 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 07/12] hw/xen: update Xen console to XenDevice model

2023-10-24 Thread Paul Durrant
|= xencons_send(con); } +return done_something; +} -path = g_string_new(dom_path); -free(dom_path); +/* */ -if (con->xendev.dev) { -g_string_append_printf(path, "/device/console/%d", con->xendev.dev); -} else { -g_string_append(path, "/console"); +static void xen_console_disconnect(XenDevice *xendev, Error **errp) +{ +XenConsole *con = XEN_CONSOLE_DEVICE(xendev); + +qemu_chr_fe_set_handlers(&con->chr, NULL, NULL, NULL, NULL, + con, NULL, true); + nit: extraneous blank line by the looks of it. With that fixed... Reviewed-by: Paul Durrant

Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-10-24 Thread Paul Durrant
On 24/10/2023 13:56, David Woodhouse wrote: On Tue, 2023-10-24 at 13:42 +0100, Paul Durrant wrote: --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -711,8 +711,16 @@ static void xen_device_frontend_create(XenDevice *xendev, Error **errp)    {    ERRP_GUARD();    XenBus *xenbus

Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-10-24 Thread Paul Durrant
On 16/10/2023 16:19, David Woodhouse wrote: From: David Woodhouse The primary Xen console is special. The guest's side is set up for it by the toolstack automatically and not by the standard PV init sequence. Accordingly, its *frontend* doesn't appear in …/device/console/0 either; instead it a

Re: [PATCH 05/12] hw/xen: populate store frontend nodes with XenStore PFN/port

2023-10-24 Thread Paul Durrant
allow guests to *rebind* to the event channel port after a reset. ... although this can also be done by querying the remote end of the port before reset. Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 10 ++ 1 file changed, 10 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH 04/12] i386/xen: advertise XEN_HVM_CPUID_UPCALL_VECTOR in CPUID

2023-10-24 Thread Paul Durrant
(+) Reviewed-by: Paul Durrant

Re: [PATCH 03/12] include: update Xen public headers to Xen 4.17.2 release

2023-10-24 Thread Paul Durrant
/interface/vcpu.h | 19 +-- include/hw/xen/interface/version.h| 19 +-- include/hw/xen/interface/xen-compat.h | 19 +-- include/hw/xen/interface/xen.h| 19 +-- 29 files changed, 124 insertions(+), 523 deletions(-) Acked-by: Paul

Re: [PATCH 02/12] hw/xen: select kernel mode for per-vCPU event channel upcall vector

2023-10-24 Thread Paul Durrant
On 16/10/2023 16:18, David Woodhouse wrote: From: David Woodhouse A guest which has configured the per-vCPU upcall vector may set the HVM_PARAM_CALLBACK_IRQ param to fairly much anything other than zero. For example, Linux v6.0+ after commit b1c3497e604 ("x86/xen: Add support for HVMOP_set_evt

Re: [PATCH 01/12] i386/xen: fix per-vCPU upcall vector for Xen emulation

2023-10-24 Thread Paul Durrant
d, 2 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1

2023-09-27 Thread Paul Durrant
direction which necessitates this patch. Signed-off-by: David Kahurani Acked-by: Paul Durrant

Re: [XEN PATCH 08/13] xen/hvm: address violations of MISRA C:2012 Rule 7.3

2023-09-12 Thread Paul Durrant
late.c | 2 +- xen/arch/x86/hvm/io.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Paul Durrant

Re: [XEN PATCH 05/13] xen/ioreq: address violations of MISRA C:2012 Rule 7.3

2023-09-12 Thread Paul Durrant
2 +- xen/include/xen/ioreq.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Paul Durrant

Re: [XEN PATCH 10/13] x86/viridian: address violations of MISRA C:2012 Rule 7.3

2023-09-11 Thread Paul Durrant
ynic.c | 2 +- xen/arch/x86/hvm/viridian/time.c | 10 +----- 2 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Paul Durrant

Re: [XEN PATCH v5 3/4] x86/viridian: address violations of MISRA C:2012 Rule 7.2

2023-09-11 Thread Paul Durrant
yperv-tlfs.h | 28 ++-- 2 files changed, 15 insertions(+), 15 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 1/4] block: rename blk_io_plug_call() API to defer_call()

2023-08-18 Thread Paul Durrant
/plug.c | 109 +++--- hw/block/dataplane/xen-block.c| 10 +-- hw/block/virtio-blk.c | 4 +- hw/scsi/virtio-scsi.c | 6 +- 9 files changed, 76 insertions(+), 79 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v1] xen-platform: do full PCI reset during unplug of IDE devices

2023-07-27 Thread Paul Durrant
/xen/xen_platform.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] hw/xen: Clarify (lack of) error handling in transaction_commit()

2023-07-26 Thread Paul Durrant
1 deletion(-) Reviewed-by: Paul Durrant

Re: [XEN PATCH] x86: I/O emulation: fix violations of MISRA C:2012 Rules 8.2 and 8.3

2023-07-19 Thread Paul Durrant
include/asm/hvm/io.h | 14 +++--- 2 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] xen-block: Avoid leaks on new error path

2023-07-06 Thread Paul Durrant
f-by: Anthony PERARD --- hw/block/xen-block.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v1] x86/hvm/ioreq: remove empty line after function declaration

2023-05-25 Thread Paul Durrant
On 25/05/2023 16:25, Olaf Hering wrote: Introduced in commit 6ddfaabceeec3c31bc97a7208c46f581de55f71d ("x86/hvm/ioreq: simplify code and use consistent naming"). Signed-off-by: Olaf Hering --- xen/arch/x86/hvm/ioreq.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Paul Durrant
On 24/04/2023 14:17, Tim Smith wrote: On Mon, Apr 24, 2023 at 1:08 PM Mark Syms wrote: Copying in Tim who did the final phase of the changes. On Mon, 24 Apr 2023 at 11:32, Paul Durrant wrote: On 20/04/2023 12:02, mark.s...@citrix.com wrote: From: Mark Syms Ensure the PV ring is drained

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Paul Durrant
: Anthony Perard CC: Paul Durrant CC: xen-devel@lists.xenproject.org v2: * Ensure all inflight requests are completed before teardown * RESEND to fix formatting --- hw/block/dataplane/xen-block.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff

Re: [PATCH v2 08/16] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore

2023-04-20 Thread Paul Durrant
David Woodhouse Signed-off-by: Stefan Hajnoczi --- hw/i386/kvm/xen_xenstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Paul Durrant

Re: [PATCH 5/5] hw/xen: Fix broken check for invalid state in xs_be_open()

2023-04-17 Thread Paul Durrant
David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Paul Durrant

Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()

2023-04-17 Thread Paul Durrant
("hw/xen: Move xenstore_store_pv_console_info to xen_console.c") Signed-off-by: David Woodhouse --- hw/char/xen_console.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 3/5] xen: Drop support for Xen versions below 4.7.1

2023-04-17 Thread Paul Durrant
ve.h | 107 +--- meson.build | 5 +- scripts/xen-detect.c| 60 4 files changed, 3 insertions(+), 226 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 2/5] hw/xen: Fix memory leak in libxenstore_open() for Xen

2023-04-17 Thread Paul Durrant
: Add xenstore operations to allow redirection to internal emulation") Suggested-by: Peter Maydell Signed-off-by: David Woodhouse Reviewed-by: Peter Maydell Reviewed-by: Paul Durrant

Re: [PATCH 2/2] xen/netback: remove not needed test in xenvif_tx_build_gops()

2023-03-27 Thread Paul Durrant
s, as XEN_RING_NR_UNCONSUMED_REQUESTS() is taking unsent responses into consideration, too. Remove the tests. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross --- drivers/net/xen-netback/netback.c | 4 1 file changed, 4 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Paul Durrant
2 files changed, 24 insertions(+), 3 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH] hw/xenpv: Initialize Xen backend operations

2023-03-23 Thread Paul Durrant
. Add the missing call to setup_xen_backend_ops(). Fixes: b6cacfea0b38 ("hw/xen: Add evtchn operations to allow redirection to internal emulation") Reported-by: Anthony PERARD Signed-off-by: David Woodhouse --- hw/xenpv/xen_machine_pv.c | 2 ++ 1 file changed, 2 insertions(+) Reviewe

Re: [PATCH] Fix PCI hotplug AML

2023-03-20 Thread Paul Durrant
On 20/03/2023 10:34, Jan Beulich wrote: On 20.03.2023 10:04, Paul Durrant wrote: On 17/03/2023 10:32, David Woodhouse wrote: From: David Woodhouse The emulated PIIX3 uses a nybble for the status of each PCI function, so the status for e.g. slot 0 functions 0 and 1 respectively can be read as

Re: [PATCH] Fix PCI hotplug AML

2023-03-20 Thread Paul Durrant
On 17/03/2023 10:32, David Woodhouse wrote: From: David Woodhouse The emulated PIIX3 uses a nybble for the status of each PCI function, so the status for e.g. slot 0 functions 0 and 1 respectively can be read as (\_GPE.PH00 & 0x0F), and (\_GPE.PH00 >> 0x04). The AML that Xen gives to a guest g

Re: [PATCH] accel/xen: Fix DM state change notification in dm_restrict mode

2023-03-14 Thread Paul Durrant
Andryuk --- accel/xen/xen-all.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH v2 00/27] Enable PV backends with Xen/KVM emulation

2023-03-07 Thread Paul Durrant
tion of XenStore operations hw/xen: Map guest XENSTORE_PFN grant in emulated Xenstore hw/xen: Implement soft reset for emulated gnttab i386/xen: Initialize Xen backends from pc_basic_device_init() for emulation MAINTAINERS: Add entry for Xen on KVM emulation docs:

Re: [PATCH v2 25/27] i386/xen: Initialize Xen backends from pc_basic_device_init() for emulation

2023-03-07 Thread Paul Durrant
device xen-disk,drive=disk,vdev=xvda If we use -M pc instead of q35, we can even add an IDE disk and boot a guest image normally through grub. But q35 gives us AHCI and that isn't unplugged by the Xen magic, so the guests ends up seeing "both" disks. Signed-off-by: David Woodhouse

  1   2   3   4   5   6   7   8   9   10   >