[PATCH] arm/vgic-v3: Fix GICD_ICPENDR read access in __vgic_v3_distr_common_mmio_read()

2025-05-26 Thread Oleksandr Tyshchenko
Properly emulate the full register") Signed-off-by: Oleksandr Tyshchenko --- xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index f20249f731..4369c55177 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arc

[PATCH V2] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()

2025-05-20 Thread Oleksandr Tyshchenko
: c4d6bbdc12e5 ("xen/arm: vgic-v3: Support 32-bit access for 64-bit registers") Signed-off-by: Oleksandr Tyshchenko Acked-by: Julien Grall --- V2: - s/data about/guest data abort in the description - add A-b - move goto to the next line --- --- xen/arch/arm/vgic-v3.c | 3 ++- 1 fi

Re: [PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()

2025-05-20 Thread Oleksandr Tyshchenko
On 20.05.25 18:02, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 20/05/2025 14:47, Oleksandr Tyshchenko wrote: >> An attempt to write access the register (i.e. GICR_PROPBASER, >> GICR_PENDBASER) >> which should be ignored (i.e. no virtual ITS present

Re: [PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()

2025-05-20 Thread Oleksandr Tyshchenko
On 20.05.25 17:24, Andrew Cooper wrote: Hello Andrew > On 20/05/2025 2:47 pm, Oleksandr Tyshchenko wrote: >> An attempt to write access the register (i.e. GICR_PROPBASER, GICR_PENDBASER) >> which should be ignored (i.e. no virtual ITS present) causes the data about > > Do

[PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()

2025-05-20 Thread Oleksandr Tyshchenko
2-bit access for 64-bit registers") Signed-off-by: Oleksandr Tyshchenko --- xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 2eaa48fadb..b366b046a2 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm

Re: [PATCH V2] xen/arm: Initialize acpi_disabled to true during declaration

2025-04-04 Thread Oleksandr Tyshchenko
On 27.03.25 00:39, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 26/03/2025 11:45, Oleksandr Tyshchenko wrote: >> Also it is not entirely clear what we should do with acpi_disabled=true >> during declaration (what current patch does), even if we decided to

Re: [PATCH V2] xen/arm: Initialize acpi_disabled to true during declaration

2025-03-31 Thread Oleksandr Tyshchenko
On 27.03.25 00:33, Julien Grall wrote: Hello Julien > Hi, > > On 26/03/2025 08:57, Orzel, Michal wrote: >> >> >> On 25/03/2025 17:54, Oleksandr Tyshchenko wrote: >>> >>> >>> On 25.03.25 18:09, Julien Grall wrote: >>> >>>

Re: [PATCH V2] xen/arm: Initialize acpi_disabled to true during declaration

2025-03-26 Thread Oleksandr Tyshchenko
On 26.03.25 10:57, Orzel, Michal wrote: Hello Michal, Julien > > > On 25/03/2025 17:54, Oleksandr Tyshchenko wrote: >> >> >> On 25.03.25 18:09, Julien Grall wrote: >> >> >>> Hi Oleksandr, >> >> Hello Julien >> >>&g

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2025-03-26 Thread Oleksandr Tyshchenko
On 19.03.25 14:37, Jan Beulich wrote: Hello Jan, all. On 19.03.2025 13:05, Mykyta Poturai wrote: On 18.03.25 16:26, Jan Beulich wrote: On 18.03.2025 14:31, Mykyta Poturai wrote: On 18.03.25 12:11, Jan Beulich wrote: On 18.03.2025 10:10, Mykyta Poturai wrote: On 15.01.24 11:35, Jan Beul

[RFC PATCH] xen/device-tree: Switch back to dt_unreserved_regions() in boot allocator

2025-03-25 Thread Oleksandr Tyshchenko
en(). Signed-off-by: Oleksandr Tyshchenko --- The RFC since I am not sure whether the description is precise and the fix is correct. Below the dump, w/o and w/ the fix applied. I also added prints for the processed memory ranges with "OT:" for the visibility:

Re: [PATCH V2] xen/arm: Initialize acpi_disabled to true during declaration

2025-03-25 Thread Oleksandr Tyshchenko
On 25.03.25 18:09, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 25/03/2025 16:05, Oleksandr Tyshchenko wrote: >>>>> Furthermore, what happen if we decide to use ACPI afterwards? Wouldn't >>>>> this mean that the static regions w

Re: [PATCH V2] xen/arm: Initialize acpi_disabled to true during declaration

2025-03-25 Thread Oleksandr Tyshchenko
On 25.03.25 17:47, Julien Grall wrote: Hello Julien, Michal. > Hi Michal, > > On 25/03/2025 15:35, Orzel, Michal wrote: >> >> >> On 25/03/2025 16:23, Julien Grall wrote: >>> >>> >>> Hi Oleksandr, Michal, >>> >>> On 25/

[PATCH V2] xen/arm: Initialize acpi_disabled to true during declaration

2025-03-25 Thread Oleksandr Tyshchenko
an issue and match to acpi_boot_table_init(). Suggested-by: Michal Orzel Signed-off-by: Oleksandr Tyshchenko --- V2: - drop post-commit remark - use the approach suggested by Michal - update commit subject (WAS xen/device-tree: Switch back to dt_unreserved_regions() in boot allocator

Re: [RFC PATCH] xen/device-tree: Switch back to dt_unreserved_regions() in boot allocator

2025-03-25 Thread Oleksandr Tyshchenko
On 25.03.25 10:46, Orzel, Michal wrote: Hello Michal > > > On 24/03/2025 22:27, Oleksandr Tyshchenko wrote: >> >> >> On the device-tree-based Arm64 system, if Xen is built with >> CONFIG_ACPI=y, CONFIG_STATIC_MEMORY=y, and the static memory range >> i

Re: [RFC PATCH] xen/device-tree: Switch back to dt_unreserved_regions() in boot allocator

2025-03-25 Thread Oleksandr Tyshchenko
Hello all. Please, ignore this second email, it was sent by mistake. -- Regards, Oleksandr Tyshchenko

[RFC PATCH] xen/device-tree: Switch back to dt_unreserved_regions() in boot allocator

2025-03-24 Thread Oleksandr Tyshchenko
en(). Signed-off-by: Oleksandr Tyshchenko --- The RFC since I am not sure whether the description is precise and the fix is correct. Below the dump, w/o and w/ the fix applied. I also added prints for the processed memory ranges with "OT:" for the visibility:

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2025-03-20 Thread Oleksandr Tyshchenko
On 20.03.25 09:30, Jan Beulich wrote: Hello Jan, Mykyta, all On 19.03.2025 21:42, Oleksandr Tyshchenko wrote: On 19.03.25 14:37, Jan Beulich wrote: On 19.03.2025 13:05, Mykyta Poturai wrote: On 18.03.25 16:26, Jan Beulich wrote: On 18.03.2025 14:31, Mykyta Poturai wrote: On 18.03.25

Re: [PATCH 1/4] Add .clang-format files to enable manual coding style checks

2025-03-04 Thread Oleksandr Andrushchenko
Hello, Roger! On 04.03.25 10:17, Roger Pau Monné wrote: On Mon, Mar 03, 2025 at 09:23:57PM +0200, Oleksandr Andrushchenko wrote: Hello, Roger! On 03.03.25 17:05, Roger Pau Monné wrote: On Sat, Mar 01, 2025 at 01:42:39PM +0200, Oleksandr Andrushchenko wrote: Disable coding style checks for

Re: [PATCH 1/4] Add .clang-format files to enable manual coding style checks

2025-03-03 Thread Oleksandr Andrushchenko
Hello, Roger! On 03.03.25 17:05, Roger Pau Monné wrote: On Sat, Mar 01, 2025 at 01:42:39PM +0200, Oleksandr Andrushchenko wrote: Disable coding style checks for the project, but xen/ folder: this is done by providing a global .clang-format at the top level which disables clang-format and only

[PATCH 3/4] [EXAMPLE] Changes done by clang-format to the previous commit

2025-03-01 Thread Oleksandr Andrushchenko
: xen/drivers/char/ns16550.c It is seen that only xen/ part of the patch was touched. The result can still be manually adjusted before committing. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/char/ns16550.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a

[PATCH 4/4] [EXAMPLE] Whole file code style formatting

2025-03-01 Thread Oleksandr Andrushchenko
This patch was produced by running clang-format on a file: clang-format -i xen/drivers/pci/pci.c Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/pci/pci.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/xen/drivers/pci/pci.c b/xen/drivers/pci/pci.c index

[PATCH 0/4] clang-format with examples

2025-03-01 Thread Oleksandr Andrushchenko
are accepted all those comments can be removed. Stay safe, Oleksandr Andrushchenko [1] https://lists.xen.org/archives/html/xen-devel/2025-02/msg00800.html Oleksandr Andrushchenko (4): Add .clang-format files to enable manual coding style checks [EXAMPLE] Provide an example of a malformed pa

[PATCH 2/4] [EXAMPLE] Provide an example of a malformed patch

2025-03-01 Thread Oleksandr Andrushchenko
This patch touches tools/xl and xen/. clang-format, if applied, will only change xen/ part. Signed-off-by: Oleksandr Andrushchenko --- tools/xl/xl_info.c | 6 ++ xen/drivers/char/ns16550.c | 12 +--- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/tools/xl

[PATCH 1/4] Add .clang-format files to enable manual coding style checks

2025-03-01 Thread Oleksandr Andrushchenko
-by: Oleksandr Andrushchenko Signed-off-by: Luca Fancellu --- .clang-format |5 + xen/.clang-format | 1380 + 2 files changed, 1385 insertions(+) create mode 100644 .clang-format create mode 100644 xen/.clang-format diff --git a/.clang-format b/.cl

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-25 Thread Oleksandr Andrushchenko
Hello, Jan! On 24.02.25 12:55, Jan Beulich wrote: On 23.02.2025 08:42, Oleksandr Andrushchenko wrote: On 20.02.25 03:34, Stefano Stabellini wrote: On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote: Yes, I do agree. But only if we talk about having an automated code style check now (which is

Re: [PATCH 1/2] code style: Format ns16550 driver

2025-02-22 Thread Oleksandr Andrushchenko
Hello, Jan! On 19.02.25 18:01, Jan Beulich wrote: On 19.02.2025 16:40, Oleksandr Andrushchenko wrote: On 19.02.25 16:05, Jan Beulich wrote: On 19.02.2025 14:52, Oleksandr Andrushchenko wrote: On 19.02.25 15:18, Jan Beulich wrote: On 19.02.2025 13:39, Oleksandr Andrushchenko wrote: On

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-22 Thread Oleksandr Andrushchenko
Hello, Stefano! On 20.02.25 03:34, Stefano Stabellini wrote: On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote: Yes, I do agree. But only if we talk about having an automated code style check now (which is definitely the goal at some time). Before that we could still use the tool to take all

Re: [PATCH 1/2] code style: Format ns16550 driver

2025-02-19 Thread Oleksandr Andrushchenko
On 19.02.25 16:05, Jan Beulich wrote: On 19.02.2025 14:52, Oleksandr Andrushchenko wrote: On 19.02.25 15:18, Jan Beulich wrote: On 19.02.2025 13:39, Oleksandr Andrushchenko wrote: On 17.02.25 12:20, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: @@ -248,8 +249,9

Re: [PATCH 1/2] code style: Format ns16550 driver

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Jan! On 19.02.25 14:39, Oleksandr Andrushchenko wrote: Hello, Jan! On 17.02.25 12:20, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -14,7 +14,7 @@    * abstracted.    */   #if defined

Re: [PATCH 1/2] code style: Format ns16550 driver

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Jan! On 19.02.25 15:18, Jan Beulich wrote: On 19.02.2025 13:39, Oleksandr Andrushchenko wrote: On 17.02.25 12:20, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: @@ -43,12 +43,12 @@ static struct ns16550 { int baud, clock_hz, data_bits, parity

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
On 19.02.25 14:51, Oleksandr Andrushchenko wrote: Hello, Andrew! On 19.02.25 14:49, Andrew Cooper wrote: On 16/02/2025 5:11 pm, Oleksandr Andrushchenko wrote: Hello, Roger! Please find the branch with all the conversions [1]. Unfortunately I cannot provide a branch as seen with diff

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Jan! On 19.02.25 14:49, Jan Beulich wrote: On 19.02.2025 13:43, Oleksandr Andrushchenko wrote: Hello, Jan, Stefano! On 18.02.25 13:34, Jan Beulich wrote: On 18.02.2025 03:36, Stefano Stabellini wrote: On Mon, 17 Feb 2025, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Andrew! On 19.02.25 14:49, Andrew Cooper wrote: On 16/02/2025 5:11 pm, Oleksandr Andrushchenko wrote: Hello, Roger! Please find the branch with all the conversions [1]. Unfortunately I cannot provide a branch as seen with diff --ignore-all-space as such a patch will not simply apply

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Grygorii! On 18.02.25 11:56, Grygorii Strashko wrote: On 16.02.25 12:21, Oleksandr Andrushchenko wrote: Hello, everybody! As agreed before [1] I am sending a series to show two samples of the formatting done with clang-format. The clang-format configuration can be found at [2]. It

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Jan, Stefano! On 18.02.25 13:34, Jan Beulich wrote: On 18.02.2025 03:36, Stefano Stabellini wrote: On Mon, 17 Feb 2025, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: 1. Const string arrays reformatting In case the length of items change we might need to

Re: [PATCH 1/2] code style: Format ns16550 driver

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Jan! On 17.02.25 12:20, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -14,7 +14,7 @@ * abstracted. */ #if defined(CONFIG_HAS_PCI) && defined(CONFIG_X86) -# define NS16550_PCI

[PATCH V3 for-4.20] xen/memory: Make resource_max_frames() to return 0 on unknown type

2025-02-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko This is actually what the caller acquire_resource() expects on any kind of error (the comment on top of resource_max_frames() also suggests that). Otherwise, the caller will treat -errno as a valid value and propagate incorrect nr_frames to the VM. As a possible

Re: [PATCH] tests/resource: Verify that Xen can deal with invalid resource type

2025-02-17 Thread Oleksandr Tyshchenko
On 17.02.25 23:09, Andrew Cooper wrote: Hello. On 17/02/2025 8:48 pm, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The sign of the presence of a corresponding bugfix is an error returned on querying the size of an unknown for Xen resource type. Signed-off-by: Oleksandr

[PATCH] tests/resource: Verify that Xen can deal with invalid resource type

2025-02-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko The sign of the presence of a corresponding bugfix is an error returned on querying the size of an unknown for Xen resource type. Signed-off-by: Oleksandr Tyshchenko --- Refer https://patchew.org/Xen/20250217102741.4122367-1-olekst...@gmail.com/ Current patch should

Re: [PATCH V2] xen/memory: Make resource_max_frames() to return 0 on unknown type

2025-02-17 Thread Oleksandr Tyshchenko
On 17.02.25 15:52, Andrew Cooper wrote: Hello On 17/02/2025 1:11 pm, Oleksandr Tyshchenko wrote: On 17.02.25 13:09, Andrew Cooper wrote: Hello Andrew On 17/02/2025 10:27 am, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This is actually what the caller acquire_resource

Re: [PATCH V2] xen/memory: Make resource_max_frames() to return 0 on unknown type

2025-02-17 Thread Oleksandr Tyshchenko
On 17.02.25 13:09, Andrew Cooper wrote: Hello Andrew On 17/02/2025 10:27 am, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This is actually what the caller acquire_resource() expects on any kind of error (the comment on top of resource_max_frames() also suggests that

[PATCH V2] xen/memory: Make resource_max_frames() to return 0 on unknown type

2025-02-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko This is actually what the caller acquire_resource() expects on any kind of error (the comment on top of resource_max_frames() also suggests that). Otherwise, the caller will treat -errno as a valid value and propagate incorrect nr_frames to the VM. As a possible

Re: [PATCH] xen/memory: Make resource_max_frames() to return 0 on unknown type

2025-02-17 Thread Oleksandr Tyshchenko
On 17.02.25 11:18, Jan Beulich wrote: Hello Jan On 16.02.2025 22:19, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This is actually what the caller acquire_resource() expects on any kind of error (the comment on top of resource_max_frames() also suggests that). Otherwise, the

[PATCH] xen/memory: Make resource_max_frames() to return 0 on unknown type

2025-02-16 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko This is actually what the caller acquire_resource() expects on any kind of error (the comment on top of resource_max_frames() also suggests that). Otherwise, the caller will treat -errno as a valid value and propagate incorrect nr_frames to the VM. As a possible

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-16 Thread Oleksandr Andrushchenko
Hello, Roger! Please find the branch with all the conversions [1]. Unfortunately I cannot provide a branch as seen with diff --ignore-all-space as such a patch will not simply apply. Stay safe, Oleksandr Andrushchenko On 16.02.25 13:58, Andrew Cooper wrote: On 16/02/2025 10:21 am, Oleksandr

[PATCH 1/2] code style: Format ns16550 driver

2025-02-16 Thread Oleksandr Andrushchenko
Use .clang-format to format ns16550 driver. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/char/ns16550.c | 761 ++--- 1 file changed, 378 insertions(+), 383 deletions(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index

[PATCH 0/2] code style exercise: Drivers folder samples

2025-02-16 Thread Oleksandr Andrushchenko
which cannot be handled by the tool now. Stay safe, Oleksandr Andrushchenko 1. Const string arrays reformatting In case the length of items change we might need to introduce a bigger change wrt new formatting of unaffected lines ==

[PATCH 2/2] code style: Format ACPI tables

2025-02-16 Thread Oleksandr Andrushchenko
Use .clang-format to format ACPI tables. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/acpi/tables.c | 809 -- 1 file changed, 435 insertions(+), 374 deletions(-) diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c index 20aed8929b86

Re: Coding Style Review and Automation

2025-02-12 Thread Oleksandr Andrushchenko
Hi, Grygorii, On 12.02.25 13:14, Grygorii Strashko wrote: Hi On 12.02.25 11:14, Roger Pau Monné wrote: On Tue, Feb 11, 2025 at 02:33:08PM -0800, Stefano Stabellini wrote: Hi Oleksandr, This morning, we had a discussion among maintainers, and the suggested approach moving forward is as

Re: Coding Style Review and Automation

2025-02-12 Thread Oleksandr Andrushchenko
Hello, everybody! On 12.02.25 00:33, Stefano Stabellini wrote: Hi Oleksandr, This morning, we had a discussion among maintainers, and the suggested approach moving forward is as follows: Great news!! - First, it would be helpful to see a sample of the proposed changes applied to a single

Coding Style Review and Automation

2025-02-10 Thread Oleksandr Andrushchenko
becomes and will require a new round as new code comes in. I would love to hear from the community on this approach and finally get it done. Not busted. Stay safe, Oleksandr Andrushchenko [1] https://lore.kernel.org/xen-devel/1130763396.5603480.1492372859631.javamail.zim...@research.iiit.ac.in/T/

[PATCH V2] docs: fusa: Add requirements for Device Passthrough

2024-11-05 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Add common requirements for a physical device assignment to Arm64 and AMD64 PVH domains. Signed-off-by: Oleksandr Tyshchenko --- Previous discussion (V1) here: https://lists.xenproject.org/archives/html/xen-devel/2024-10/msg00534.html V2: A lot of changes

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-09 Thread Oleksandr Tyshchenko
On 09.10.24 10:26, Julien Grall wrote: Hi, Hello Julien On 07/10/2024 19:55, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Add common requirements for a physical device assignment to Arm64 and AMD64 PVH domains. Signed-off-by: Oleksandr Tyshchenko --- Based on: [PATCH

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-09 Thread Oleksandr Tyshchenko
On 09.10.24 09:36, Bertrand Marquis wrote: Hi Oleksandr, Hello Bertrand On 8 Oct 2024, at 20:53, Oleksandr Tyshchenko wrote: On 08.10.24 09:17, Bertrand Marquis wrote: Hi, Hello Bertrand On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Add

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-09 Thread Oleksandr Tyshchenko
On 09.10.24 01:46, Stefano Stabellini wrote: Hello Stefano On Tue, 8 Oct 2024, Oleksandr Tyshchenko wrote: On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Add common requirements for a physical device assignment to Arm64 and AMD64 PVH domains. Signed

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-08 Thread Oleksandr Tyshchenko
On 08.10.24 09:17, Bertrand Marquis wrote: Hi, Hello Bertrand On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Add common requirements for a physical device assignment to Arm64 and AMD64 PVH domains. Signed-off-by: Oleksandr Tyshchenko --- Based on

[PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-07 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Add common requirements for a physical device assignment to Arm64 and AMD64 PVH domains. Signed-off-by: Oleksandr Tyshchenko --- Based on: [PATCH] docs: fusa: Replace VM with domain https://patchew.org/Xen/20241007182603.826807-1-ayan.kumar.hal...@amd.com

Re: [PATCH 2/2] xen/arm: Add i.MX UART driver

2024-04-18 Thread Oleksandr Tyshchenko
On 07.04.24 05:43, Peng Fan wrote: Hi Oleksandr, Hello Peng Subject: [PATCH 2/2] xen/arm: Add i.MX UART driver From: Oleksandr Tyshchenko The i.MX UART Documentation: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww. nxp.com%2Fwebapp%2FDownload%3FcolCode

Re: [PATCH 2/2] xen/arm: Add i.MX UART driver

2024-04-18 Thread Oleksandr Tyshchenko
On 04.04.24 09:54, Michal Orzel wrote: Hi Oleksandr, Hello Michal sorry for the late response On 02/04/2024 14:05, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The i.MX UART Documentation: https://www.nxp.com/webapp/Download?colCode=IMX8MMRM Chapter 16.2 Universal

Re: [PATCH 1/2] xen/arm: Add i.MX UART early printk support

2024-04-18 Thread Oleksandr Tyshchenko
On 03.04.24 13:11, Michal Orzel wrote: Hi Oleksandr, Hello Michal sorry for the late response On 02/04/2024 14:05, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Tested on i.MX 8M Mini only, but I guess, it should be suitable for other i.MX8M* SoCs (those UART device tree

[ImageBuilder 5/5] uboot-script-gen: Add ability to specify "nr_spis"

2024-04-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko This is needed to have a possibility of assigning a specified number of shared peripheral interrupts (SPIs) to domain. Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Stefano Stabellini --- README.md| 5 + scripts/uboot-script-gen | 4 2

[ImageBuilder 1/5] uboot-script-gen: Update to deal with uImage which is not executable

2024-04-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko uImage is the Image that has a U-Boot wrapper, it doesn't contain "executable" string which subsequent "file" command is looking for when inspecting it. Below the proof: otyshchenko@EPUAKYIW03DD:~/work/xen_tests/input$ file -L binaries/uImage

[ImageBuilder 3/5] uboot-script-gen: Add ability to specify grant table params

2024-04-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Use DOMU_GRANT_VER to set "max_grant_version" dt property. Use DOMU_GRANT_FRAMES to set "max_grant_frames" dt property. Use DOMU_MAPTRACK_FRAMES to set "max_maptrack_frames" dt property. Signed-off-by: Oleksandr Tyshchenko ---

[ImageBuilder 4/5] uboot-script-gen: Add ability to unselect "vpl011"

2024-04-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Introduce new option DOMU_VPL011[nr] that can be set to 0 or 1 (default). Also align "console=ttyAMA0" Linux cmd arg setting with "vpl011" presense. Suggested-by: Michal Orzel Signed-off-by: Oleksandr Tyshchenko --- README.md

[ImageBuilder 0/5] Misc updates for the dom0less support

2024-04-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Hello all, this is a collection of patches (#2-5) for improving the dom0less support and a patch (#1) for dealing with uImage. Oleksandr Tyshchenko (5): uboot-script-gen: Update to deal with uImage which is not executable uboot-script-gen: Extend DOMU_ENHANCED

[ImageBuilder 2/5] uboot-script-gen: Extend DOMU_ENHANCED to specify "no-xenstore"

2024-04-17 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko We need some Xen services to be available within single dom0less DomU. Just using "enabled" will lead to Xen panic because of no Dom0. (XEN) (XEN) Panic on CPU 0: (XEN) At the moment, Xenstore support requires

Re: [amd-xen-safety] [PATCH V4] Add requirements for Device Passthrough

2024-04-08 Thread Oleksandr Tyshchenko
On 08.04.24 20:38, Hildebrand, Stewart via groups.io wrote: > On 4/8/24 09:19, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> Please refer to chapter "Device Passthrough": >> https://urldefense.com/v3/__https://groups.io/g/amd-xen-s

[PATCH V4] Add requirements for Device Passthrough

2024-04-08 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Please refer to chapter "Device Passthrough": https://groups.io/g/amd-xen-safety/message/1300 Create corresponding directory and README file. Signed-off-by: Oleksandr Tyshchenko --- V2: - add R-b - update README - lower case for platform, s/

[PATCH 2/2] xen/arm: Add i.MX UART driver

2024-04-02 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko The i.MX UART Documentation: https://www.nxp.com/webapp/Download?colCode=IMX8MMRM Chapter 16.2 Universal Asynchronous Receiver/Transmitter (UART) Tested on i.MX 8M Mini only, but I guess, it should be suitable for other i.MX8M* SoCs (those UART device tree nodes

[PATCH 0/2] Add UART support for i.MX 8M Mini EVKB

2024-04-02 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Hello all. This small series contains early printk and full UART support for i.MX 8M Mini EVKB [1]. Tested on i.MX 8M Mini only to which I had an access, but from my understanding, this UART support should be suitable for other i.MX8M* SoCs (those UART device tree

[PATCH 1/2] xen/arm: Add i.MX UART early printk support

2024-04-02 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Tested on i.MX 8M Mini only, but I guess, it should be suitable for other i.MX8M* SoCs (those UART device tree nodes contain "fsl,imx6q-uart" compatible string). Signed-off-by: Oleksandr Tyshchenko --- I selected the following configs for enabling ea

Re: [PATCH 2/2] xen/events: increment refcnt only if event channel is refcounted

2024-03-17 Thread Oleksandr Tyshchenko
ncrement only if the > caller has specified IRQF_SHARED in the irqflags parameter. > > Fixes: 9e90e58c11b7 ("xen: evtchn: Allow shared registration of IRQ handers") > Signed-off-by: Juergen Gross Reviewed-by: Oleksandr Tyshchenko > --- > drivers/xen/events/even

Re: [PATCH 1/2] xen/evtchn: avoid WARN() when unbinding an event channel

2024-03-17 Thread Oleksandr Tyshchenko
t;unbinding" flag to struct user_event which > will short circuit the handler. > > Fixes: 9e90e58c11b7 ("xen: evtchn: Allow shared registration of IRQ handers") > Reported-by: Demi Marie Obenour > Tested-by: Demi Marie Obenour > Signed-off-by: Juergen Gross Revie

Re: question about virtio-vsock on xen

2024-02-26 Thread Oleksandr Tyshchenko
On 26.02.24 05:09, Peng Fan wrote: > Hi Oleksandr, Hello Peng [snip] >> >> ... Peng, we have vhost-vsock (and vhost-net) Xen PoC. Although it is >> non- >> upstreamable in its current shape (based on old Linux version, requires some >> rework and proper

Re: question about virtio-vsock on xen

2024-02-24 Thread Oleksandr Tyshchenko
On 23.02.24 23:42, Stefano Stabellini wrote: > Hi Peng, Hello Peng, Stefano > > We haven't tried to setup virtio-vsock yet. > > In general, I am very supportive of using QEMU for virtio backends. We > use QEMU to provide virtio-net, virtio-block, virtio-console and more. > > However, typica

[PATCH V3] libxl: Add "grant_usage" parameter for virtio disk devices

2024-02-15 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Allow administrators to control whether Xen grant mappings for the virtio disk devices should be used. By default (when new parameter is not specified), the existing behavior is retained (we enable grants if backend-domid != 0). Signed-off-by: Oleksandr Tyshchenko

Re: [PATCH V2] libxl: Add "grant_usage" parameter for virtio disk devices

2024-02-15 Thread Oleksandr Tyshchenko
On 13.02.24 14:14, Anthony PERARD wrote: Hello Anthony > On Tue, Feb 06, 2024 at 02:38:14PM +0200, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> Allow administrators to control whether Xen grant mappings for >> the virtio disk devices should be

[PATCH V2] libxl: Add "grant_usage" parameter for virtio disk devices

2024-02-06 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Allow administrators to control whether Xen grant mappings for the virtio disk devices should be used. By default (when new parameter is not specified), the existing behavior is retained (we enable grants if backend-domid != 0). Signed-off-by: Oleksandr Tyshchenko

Re: [PATCH] libxl: Add "grant_usage" parameter for virtio disk devices

2024-02-06 Thread Oleksandr Tyshchenko
On 06.02.24 12:27, Anthony PERARD wrote: Hello Anthony [snip] diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in index bc945cc517..3c035456d5 100644 --- a/docs/man/xl-disk-configuration.5.pod.in +++ b/docs/man/xl-disk-confi

Re: [PATCH] libxl: Add "grant_usage" parameter for virtio disk devices

2024-02-05 Thread Oleksandr Tyshchenko
On 05.02.24 17:10, Anthony PERARD wrote: Hello Anthony > On Fri, Feb 02, 2024 at 12:49:03PM +0200, Oleksandr Tyshchenko wrote: >> diff --git a/tools/libs/util/libxlu_disk_l.l >> b/tools/libs/util/libxlu_disk_l.l >> index 6d53c093a3..f37dd443bd 100644 >> --- a/tool

Re: [PATCH] libxl: Add "grant_usage" parameter for virtio disk devices

2024-02-02 Thread Oleksandr Tyshchenko
On 02.02.24 13:03, Viresh Kumar wrote: Hello Viresh > On 02-02-24, 12:49, Oleksandr Tyshchenko wrote: >> diff --git a/docs/man/xl-disk-configuration.5.pod.in >> b/docs/man/xl-disk-configuration.5.pod.in >> index bc945cc517..3c035456d5 100644 >> --- a/docs/man/xl-

[PATCH] libxl: Add "grant_usage" parameter for virtio disk devices

2024-02-02 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Allow administrators to control whether Xen grant mappings for the virtio disk devices should be used. By default (when new parameter is not specified), the existing behavior is retained (we enable grants if backend-domid != 0). Signed-off-by: Oleksandr Tyshchenko

Re: [PATCH] xen/arm: Properly clean update to init_ttbr and smp_up_cpu

2024-01-30 Thread Oleksandr Tyshchenko
gt; Fixes: a5ed59e62c6f ("arm/mmu: Move init_ttbr to a new section .data.idmap") > Fixes: 9a5114074b04 ("arm/smpboot: Move smp_up_cpu to a new section > .data.idmap) > > Reported-by: Oleksandr Tyshchenko > Signed-off-by: Julien Grall [on Renesas R-Car Gen3 SoC with 8 cor

[PATCH v3] xen/gntdev: Fix the abuse of underlying struct page in DMA-buf import

2024-01-09 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko DO NOT access the underlying struct page of an sg table exported by DMA-buf in dmabuf_imp_to_refs(), this is not allowed. Please see drivers/dma-buf/dma-buf.c:mangle_sg_table() for details. Fortunately, here (for special Xen device) we can avoid using pages and

Re: [PATCH v2] xen/gntdev: Fix the abuse of underlying struct page in DMA-buf import

2024-01-09 Thread Oleksandr Tyshchenko
On 08.01.24 14:05, Daniel Vetter wrote: Hello Daniel > On Sun, 7 Jan 2024 at 11:35, Oleksandr Tyshchenko wrote: >> >> From: Oleksandr Tyshchenko >> >> DO NOT access the underlying struct page of an sg table exported >> by DMA-buf in dmabuf_imp_to_refs(), t

[PATCH v2] xen/gntdev: Fix the abuse of underlying struct page in DMA-buf import

2024-01-07 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko DO NOT access the underlying struct page of an sg table exported by DMA-buf in dmabuf_imp_to_refs(), this is not allowed. Please see drivers/dma-buf/dma-buf.c:mangle_sg_table() for details. Fortunately, here (for special Xen device) we can avoid using pages and

[PATCH] xen/gntdev: Fix the abuse of underlying struct page in DMA-buf import

2024-01-04 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko DO NOT access the underlying struct page of an sg table exported by DMA-buf in dmabuf_imp_to_refs(), this is not allowed. Please see drivers/dma-buf/dma-buf.c:mangle_sg_table() for details. Fortunately, here (for special Xen device) we can avoid using pages and

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-17 Thread Oleksandr Tyshchenko
On 17.11.23 05:31, Stewart Hildebrand wrote: Hello Stewart [answering only for virtio-pci bits as for vPCI I am only familiar with code responsible for trapping config space accesses] [snip] >> >> >> Let me start by saying that if we can get away with it, I think that a >> single PCI Root Co

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 20:33, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 15/11/2023 18:14, Oleksandr Tyshchenko wrote: >> On 15.11.23 19:31, Julien Grall wrote: >>> On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: >>>> On 15.11.23 14:33, Julien Grall wr

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 19:31, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: >> >> >> On 15.11.23 14:33, Julien Grall wrote: >>> Hi, >> >> >> Hello Julien >> >> Let me please try

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 14:33, Julien Grall wrote: > Hi, Hello Julien Let me please try to explain some bits. > > Thanks for adding support for virtio-pci in Xen. I have some questions. > > On 15/11/2023 11:26, Sergiy Kibrik wrote: >> From: Oleksandr Tyshchenko >> >

Re: [PATCH 5/7] xen/events: drop xen_allocate_irqs_dynamic()

2023-11-14 Thread Oleksandr Tyshchenko
On 14.11.23 10:35, Juergen Gross wrote: Hello Juergen > On 14.11.23 09:20, Oleksandr Tyshchenko wrote: >> >> >> On 16.10.23 09:28, Juergen Gross wrote: >> >> >> Hello Juergen >> >>> Instead of having a common function for allocating a si

Re: [PATCH 7/7] xen/events: remove some info_for_irq() calls in pirq handling

2023-11-14 Thread Oleksandr Tyshchenko
so Reviewed-by: Oleksandr Tyshchenko Just one NIT below ... [snip] > > -static void pirq_query_unmask(int irq) > +static void pirq_query_unmask(struct irq_info *info) > { > struct physdev_irq_status_query irq_status; > - struct irq_info *info = info_for_irq(irq

Re: [PATCH 6/7] xen/events: modify internal [un]bind interfaces

2023-11-14 Thread Oleksandr Tyshchenko
xen_send_IPI_one()" went in). I was going to ask why "pirq_query_unmask()/pirq_from_irq()" wasn't converted to take a struct irq_info parameter as well, but looking at the rest I noticed this was already done in subsequent commit. With proper rebasing: Reviewed-by: Oleksandr Tyshchenko [snip]

Re: [PATCH 5/7] xen/events: drop xen_allocate_irqs_dynamic()

2023-11-14 Thread Oleksandr Tyshchenko
On 16.10.23 09:28, Juergen Gross wrote: Hello Juergen > Instead of having a common function for allocating a single IRQ or a > consecutive number of IRQs, split up the functionality into the callers > of xen_allocate_irqs_dynamic(). > > This allows to handle any allocation error in xen_irq_in

Re: [PATCH 4/7] xen/events: remove some simple helpers from events_base.c

2023-11-13 Thread Oleksandr Tyshchenko
IRQT_EVTCHN); > + WARN_ON(info->type != IRQT_EVTCHN); > + irq = info->irq; > } This hunk doesn't apply clearly to the latest state, because of "9e90e58c11b7 xen: evtchn: Allow shared registration of IRQ handers" went in. Please rebase.

Re: [PATCH 3/7] xen/events: reduce externally visible helper functions

2023-11-13 Thread Oleksandr Tyshchenko
: Juergen Gross Reviewed-by: Oleksandr Tyshchenko Two NITs *NOT* directly related to current patch below. > --- > drivers/xen/events/events_2l.c | 8 > drivers/xen/events/events_base.c | 13 + > drivers/xen/events/events_internal.h | 1 - >

Re: [PATCH 2/7] xen/events: remove unused functions

2023-11-13 Thread Oleksandr Tyshchenko
On 16.10.23 09:28, Juergen Gross wrote: Hello Juergen > There are no users of xen_irq_from_pirq() and xen_set_irq_pending(). > > Remove those functions. > > Signed-off-by: Juergen Gross Reviewed-by: Oleksandr Tyshchenko > --- > drivers/xen/even

Re: [PATCH 1/7] xen/events: fix delayed eoi list handling

2023-11-13 Thread Oleksandr Tyshchenko
ich Signed-off-by: Juergen Gross Reviewed-by: Oleksandr Tyshchenko --- drivers/xen/events/events_base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 1b2136fe0fa5..0e458b1c0c8c 100644 --

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Oleksandr Tyshchenko
On 04.10.23 15:59, Roger Pau Monné wrote: Hello Roger > On Wed, Oct 04, 2023 at 11:42:32AM +0000, Oleksandr Tyshchenko wrote: >> >> >> On 04.10.23 13:55, Julien Grall wrote: >> >> Hello all. >> >>> Hi Roger, >>> >>> On 04/10/

  1   2   3   4   5   6   7   8   9   10   >