Philippe Mathieu-Daudé writes:
> On 29/7/25 13:12, Markus Armbruster wrote:
>> xenfb_mouse_event() has a switch statement whose controlling
>> expression move->axis is an enum InputAxis. The enum values are
>> INPUT_AXIS_X and INPUT_AXIS_Y, encoded as 0 and 1. The switc
hat move->axis can be greater than 1. It
duly reports a buffer overrun when it is used to subscript an array
with two elements.
Replace the unreachable code by abort().
Resolves: Coverity CID 1613906
Signed-off-by: Markus Armbruster
---
hw/display/xenfb.c | 3 +--
1 file changed, 1 insertion
Daniel P. Berrangé writes:
> On Fri, Jul 18, 2025 at 07:59:50AM +0200, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>> > Adam Williamson writes:
>> >
>> >> In cfcacba an `error_report` was added to this file, but the
>> >>
Markus Armbruster writes:
> Adam Williamson writes:
>
>> In cfcacba an `error_report` was added to this file, but the
>> corresponding include of `qemu/error-report.h` was missed. This
>> only becomes apparent when building against Xen 4.20+.
>>
>> Signed-of
Adam Williamson writes:
> In cfcacba an `error_report` was added to this file, but the
> corresponding include of `qemu/error-report.h` was missed. This
> only becomes apparent when building against Xen 4.20+.
>
> Signed-off-by: Adam Williamson
> ---
> hw/xen/xen_pt.c | 1 +
> 1 file changed, 1
Queued for 10.0.
Philippe Mathieu-Daudé writes:
> Hi,
>
> On 14/3/25 19:39, Pierrick Bouvier wrote:
>> On 3/14/25 11:34, Anthony PERARD wrote:
>>> On Fri, Mar 14, 2025 at 10:33:08AM -0700, Pierrick Bouvier wrote:
Hi,
one patch is missing review:
[PATCH v5 12/17] hw/xen: add stubs for various f
Question to reviewers: should PATCH 2 downgrade to warning, to info,
or delete the report entirely?
Markus Armbruster (2):
hw/xen: Fix xen_bus_realize() error handling
hw/xen: Downgrade a xen_bus_realize() non-error to warning
hw/xen/xen-bus.c | 8
1 file changed, 4 insertions
xen_bus_realize() reports a failure to set up a watch as error, but it
doesn't treat it as one: it simply continues. Report a warning
instead.
Signed-off-by: Markus Armbruster
---
hw/xen/xen-bus.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen-bus.c
ize() is wrong that way: it passes &local_err to
xs_node_watch() in a loop. If this fails in more than one iteration,
it can trip error_setv()'s assertion.
Fix by clearing @local_err.
Fixes: c4583c8c394e (xen-bus: reduce scope of backend watch)
Signed-off-by: Markus Armbruster
---
hw/
Stefan Hajnoczi writes:
> The term "QEMU global mutex" is identical to the more widely used Big
> QEMU Lock ("BQL"). Update the code comments and documentation to use
> "BQL" instead of "QEMU global mutex".
>
> Signed-off-by: Stefan Hajnoczi
For QAPI
Acked-by: Markus Armbruster
Markus Armbruster writes:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Bugs love to hide in such code.
> Evidence: PATCH 1.
>
> Enabling -Wshadow would prevent bugs like this one. But we'd have to
> cle
Wolf
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
---
block/monitor/bitmap-qmp-cmds.c | 19 ++-
block/qcow2-bitmap.c| 3 +--
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/monitor/bitmap-qmp-cmds.c b/block/monitor/bitmap-qmp
o make the macros that give us this
problem use different variable names on every call.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
include/qapi/qmp/qobject.h | 10 --
include/qemu/atomic.h | 17 -
include/qemu/compiler.h| 3 +++
include/qemu/osde
TCH 6: Rename local @tran instead of the parameter [Kevin]
* PATCH 7: Drop PASTE(), use glue() instead [Richard]; pass
identifiers instead of __COUNTER__ for readability [Eric]; add
comments
Markus Armbruster (7):
migration/rdma: Fix save_page method to fail on polling error
migration: C
: core logic)
Fixes: b390afd8c50b (migration/rdma: Fix out of order wrid)
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
---
migration/rdma.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration/rdma.c b
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
Reviewed-by: Peter Xu
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
Reviewed-by: Peter Maydell
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
Reviewed-by: Stefan Hajnoczi
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
Reviewed-by: Stefan Hajnoczi
Kevin Wolf writes:
> Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben:
[...]
>> diff --git a/include/qapi/qmp/qobject.h b/include/qapi/qmp/qobject.h
>> index 9003b71fd3..d36cc97805 100644
>> --- a/include/qapi/qmp/qobject.h
>> +++ b/include/qapi/qmp/qo
Eric Blake writes:
> On Wed, Sep 20, 2023 at 08:31:49PM +0200, Markus Armbruster wrote:
> ...
>> The only reliable way to prevent unintended variable name capture is
>> -Wshadow.
>>
>> One blocker for enabling it is shadowing hiding in function-like
>> ma
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
Reviewed-by: Peter Maydell
pass
identifiers instead of __COUNTER__ for readability [Eric]; add
comments
Markus Armbruster (7):
migration/rdma: Fix save_page method to fail on polling error
migration: Clean up local variable shadowing
ui: Clean up local variable shadowing
block/dirty-bitmap: Clean up local variable
Wolf
Signed-off-by: Markus Armbruster
---
block/monitor/bitmap-qmp-cmds.c | 19 ++-
block/qcow2-bitmap.c| 3 +--
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/monitor/bitmap-qmp-cmds.c b/block/monitor/bitmap-qmp-cmds.c
index 55f778f5af
o make the macros that give us this
problem use different variable names on every call.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
include/qapi/qmp/qobject.h | 11 +--
include/qemu/atomic.h | 17 -
include/qemu/compiler.h| 3 +++
include/qemu/o
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
Reviewed-by: Peter Xu
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
Reviewed-by: Stefan Hajnoczi
: core logic)
Fixes: b390afd8c50b (migration/rdma: Fix out of order wrid)
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
---
migration/rdma.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration/rdma.c b
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
Reviewed-by: Stefan Hajnoczi
Kevin Wolf writes:
> Am 19.09.2023 um 07:48 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 31.08.2023 um 15:25 hat Markus Armbruster geschrieben:
>> >> Local variables shadowing other local variables or parameters make the
>> >&
Eric Blake writes:
> On Fri, Sep 01, 2023 at 10:48:26AM +0200, Markus Armbruster wrote:
>> > Indeed, not fully understanding the preprocessor makes for some
>> > interesting death traps.
>>
>> We use ALL_CAPS for macros to signal "watch out for tr
Kevin Wolf writes:
> Am 31.08.2023 um 15:25 hat Markus Armbruster geschrieben:
>> Local variables shadowing other local variables or parameters make the
>> code needlessly hard to understand. Tracked down with -Wshadow=local.
>> Clean up: delete inner declarations w
Eric Blake writes:
> On Thu, Aug 31, 2023 at 03:25:40PM +0200, Markus Armbruster wrote:
>> qemu_rdma_save_page() reports polling error with error_report(), then
>> succeeds anyway. This is because the variable holding the polling
>> status *shadows* the variable the f
Kevin Wolf writes:
> Am 31.08.2023 um 15:25 hat Markus Armbruster geschrieben:
>> Local variables shadowing other local variables or parameters make the
>> code needlessly hard to understand. Tracked down with -Wshadow=local.
>> Clean up: delete inner declarations w
Kevin Wolf writes:
> Am 31.08.2023 um 15:25 hat Markus Armbruster geschrieben:
>> Local variables shadowing other local variables or parameters make the
>> code needlessly hard to understand. Tracked down with -Wshadow=local.
>> Clean up: delete inner declarations w
Cédric Le Goater writes:
> On 8/31/23 16:30, Eric Blake wrote:
>> On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
>> [This paragraph written last: Bear with my stream of consciousness
>> review below, where I end up duplicating some of the conslusions you
Eric Blake writes:
> On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
>
> [This paragraph written last: Bear with my stream of consciousness
> review below, where I end up duplicating some of the conslusions you
> reached before the point where I saw where the p
Richard Henderson writes:
> On 8/31/23 06:25, Markus Armbruster wrote:
>> +#define PASTE(a, b) a##b
>
> We already have glue() in qemu/compiler.h.
Missed it, will fix.
> The rest of it looks quite sensible.
Thanks!
Peter Maydell writes:
> On Thu, 31 Aug 2023 at 14:25, Markus Armbruster wrote:
>>
>> Local variables shadowing other local variables or parameters make the
>> code needlessly hard to understand. Tracked down with -Wshadow=local.
>> Clean up: delete inner declarat
Markus Armbruster writes:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Bugs love to hide in such code.
> Evidence: PATCH 1.
>
> Enabling -Wshadow would prevent bugs like this one. But we'd have to
> cle
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
---
block.c
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
---
block/monitor/bitmap
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
---
block/vdi.c | 7
.c
target/riscv/vector_helper.c
target/tricore/translate.c
tcg/tcg.c
tests/qtest/m48t59-test.c
tests/qtest/pflash-cfi02-test.c
tests/unit/test-throttle.c
util/vhost-user-server.c
Markus Armbruster (7):
migration/rdma: Fix save_page method to fail on polling error
migr
: core logic)
Fixes: b390afd8c50b (migration/rdma: Fix out of order wrid)
Signed-off-by: Markus Armbruster
---
migration/rdma.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index ca430d319d..b2e869aced 100644
--- a/migration/rdma.c
+++ b
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
---
ui/gtk.c
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Tracked down with -Wshadow=local.
Clean up: delete inner declarations when they are actually redundant,
else rename variables.
Signed-off-by: Markus Armbruster
---
migration/block.c | 4
o make the macros that give us this
problem use different variable names on every call.
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qobject.h | 8 +---
include/qemu/atomic.h | 11 ++-
include/qemu/osdep.h | 34 +++---
3 files changed, 30
"Michael S. Tsirkin" writes:
> On Tue, Feb 28, 2023 at 09:05:16PM +0100, Thomas Huth wrote:
>> Well, without CI, I assume that the code will bitrot quite fast (considering
>> that there are continuous improvements to TCG, for example).
>
> We have lots of hosts which we don't test with CI. They
"Michael S. Tsirkin" writes:
> On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote:
>> The question to answer: Is 32 bit x86 worth its upkeep? Two
>> sub-questions: 1. Is it worth the human attention? 2. Is it worth
>> (scarce!) CI minutes?
>
&
"Michael S. Tsirkin" writes:
> On Tue, Feb 28, 2023 at 09:40:49AM +, Daniel P. Berrangé wrote:
>> On Tue, Feb 28, 2023 at 10:14:52AM +0100, Thomas Huth wrote:
>> > On 28/02/2023 10.03, Michael S. Tsirkin wrote:
>> > > On Tue, Feb 28, 2023 at 08:59:52AM +, Daniel P. Berrangé wrote:
>> > >
Philippe Mathieu-Daudé writes:
> On 2/12/22 03:59, Vikram Garhwal wrote:
>> Replace g_malloc with g_new and perror with error_setg_errno.
>>
>> Signed-off-by: Vikram Garhwal
>> ---
>> hw/xen/xen-hvm-common.c | 15 ---
>> 1 file changed, 8 insertions(+), 7 deletions(-)
>
>
>> @@ -
Stefano Brivio writes:
> On Mon, 24 Oct 2022 13:00:09 +0200
> Markus Armbruster wrote:
>
>> Markus Armbruster writes:
>>
>> > Cc: Stefano Brivio
>> >
>> > Laurent Vivier writes:
>> >
>> >> On 10/21/22 07:48, Markus Arm
;: { "seconds": 1666341430, "microseconds": 968694 },
> "event": "NETDEV_STREAM_DISCONNECTED",
> "data": { "netdev-id": "netdev0" } }
>
> Signed-off-by: Laurent Vivier
> Acked-by: Michael S. Tsirkin
QAPI schema
Acked-by: Markus Armbruster
Markus Armbruster writes:
> Cc: Stefano Brivio
>
> Laurent Vivier writes:
>
>> On 10/21/22 07:48, Markus Armbruster wrote:
>>> Laurent Vivier writes:
>>>
>>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>>
Laurent Vivier writes:
> On 10/21/22 12:35, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> On 21/10/22 11:09, Laurent Vivier wrote:
>>>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>>>> This allows net/stream
Stefano Brivio writes:
> [Cc: Laine, full quote]
>
> On Fri, 21 Oct 2022 11:12:20 +0200
> Markus Armbruster wrote:
>
>> Cc: Stefano Brivio
>>
>> Laurent Vivier writes:
>>
>> > On 10/21/22 07:48, Markus Armbruster wrote:
>> >>
Philippe Mathieu-Daudé writes:
> On 21/10/22 11:09, Laurent Vivier wrote:
>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>> This allows net/stream to use all the available parameters provided by
>> SocketAddress.
>> Signed-off-by: Laurent Vivier
>> Acked-by: Michael S. Tsirkin
>> ---
>
Laurent Vivier writes:
> On 10/21/22 11:12, Markus Armbruster wrote:
>> Cc: Stefano Brivio
>>
>> Laurent Vivier writes:
>>
>>> On 10/21/22 07:48, Markus Armbruster wrote:
>>>> Laurent Vivier writes:
>>>>
>>>>>
Cc: Stefano Brivio
Laurent Vivier writes:
> On 10/21/22 07:48, Markus Armbruster wrote:
>> Laurent Vivier writes:
>>
>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnec
Jason Wang writes:
> I've queued this version and will send pull requests shortly.
>
> Any future comment we can do patches on top.
Please give Laurent and me a few hours to try to improve PATCH 17's
commit message. Which you could then integrate without a respin.
Laurent Vivier writes:
> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
Use cases?
Could similar event signalling be useful for other kinds of netdev
backends?
> The NETDEV_STREAM_CONNECTED event include
Sorry for the slow replay, too many distractions...
Laurent Vivier writes:
> On 10/17/22 15:23, Markus Armbruster wrote:
>> Laurent Vivier writes:
>>
>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>> is connected, and NETDEV_S
Laurent Vivier writes:
> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> is connected, and NETDEV_STREAM_EOC when it is disconnected.
>
> The NETDEV_STREAM_CONNECTED event includes the URI of the destination
> address.
>
> Signed-off-by: Laurent Vivier
> Acked-by: Michael S.
Laurent Vivier writes:
> Signed-off-by: Laurent Vivier
> Reviewed-by: Stefano Brivio
> Reviewed-by: David Gibson
> Acked-by: Michael S. Tsirkin
QAPI schema
Acked-by: Markus Armbruster
Laurent Vivier writes:
> Signed-off-by: Laurent Vivier
> Reviewed-by: Stefano Brivio
> Acked-by: Michael S. Tsirkin
QAPI schema
Acked-by: Markus Armbruster
Bernhard Beschow writes:
> Am 20. September 2022 11:36:47 UTC schrieb Markus Armbruster
> :
>>Alistair Francis writes:
>>
>>> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote:
>>>>
>>>> SiFiveEState inherits from SysBusDevice
Alistair Francis writes:
> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote:
>>
>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to
>> inherit from TYPE_MACHINE. This is an inconsistency which can cause
>> undefined behavior such as memory corruption.
>>
>> Change S
Philippe Mathieu-Daudé writes:
> On 15/3/22 14:59, Markus Armbruster wrote:
>> Alex Bennée writes:
>>
>>> Markus Armbruster writes:
>>>
>>>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
>>>> for two reasons
form
sizeof(T).
Patch created mechanically with:
$ spatch --in-place --sp-file scripts/coccinelle/use-g_new-etc.cocci \
--macro-file scripts/cocci-macro-file.h FILES...
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Cédric Le Goater
Review
ATCH 3: Change to scripts/coverity-scan/model.c dropped [Eric]
* PATCH 3: Change to semihosting/config.c dropped [Alex]
* Commit messages tweaked
Markus Armbruster (3):
scripts/coccinelle: New use-g_new-etc.cocci
9pfs: Use g_new() & friends where that makes obvious sense
U
.
Cc: Greg Kurz
Cc: Christian Schoenebeck
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Christian Schoenebeck
Reviewed-by: Alex Bennée
Reviewed-by: Greg Kurz
---
hw/9pfs/9p-proxy.c | 2 +-
hw/9pfs/9p-synth.c | 4 ++--
hw/9pfs
This is the semantic patch from commit b45c03f585 "arm: Use g_new() &
friends where that makes obvious sense".
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
---
scripts/coccinelle/use-g_new-
Eric Blake writes:
> On Mon, Mar 14, 2022 at 05:01:08PM +0100, Markus Armbruster wrote:
>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
>> for two reasons. One, it catches multiplication overflowing size_t.
>> Two, it returns T * rather t
Alex Bennée writes:
> Markus Armbruster writes:
>
>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
>> for two reasons. One, it catches multiplication overflowing size_t.
>> Two, it returns T * rather than void *, which lets the compi
Alex Bennée writes:
> Markus Armbruster writes:
>
>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
>> for two reasons. One, it catches multiplication overflowing size_t.
>> Two, it returns T * rather than void *, which lets the compi
Peter Maydell writes:
> On Mon, 14 Mar 2022 at 16:01, Markus Armbruster wrote:
>>
>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
>> for two reasons. One, it catches multiplication overflowing size_t.
>> Two, it returns T * rather than
This is the semantic patch from commit b45c03f585 "arm: Use g_new() &
friends where that makes obvious sense".
Signed-off-by: Markus Armbruster
---
scripts/coccinelle/use-g_new-etc.cocci | 75 ++
1 file changed, 75 insertions(+)
create mode 100644 scripts/
Cc: Christian Schoenebeck
Signed-off-by: Markus Armbruster
---
hw/9pfs/9p-proxy.c | 2 +-
hw/9pfs/9p-synth.c | 4 ++--
hw/9pfs/9p.c | 8
hw/9pfs/codir.c | 6 +++---
tests/qtest/virtio-9p-test.c | 4 ++--
5 files changed, 12 insertions(+), 12 d
form
sizeof(T).
Patch created mechanically with:
$ spatch --in-place --sp-file scripts/coccinelle/use-g_new-etc.cocci \
--macro-file scripts/cocci-macro-file.h FILES...
Signed-off-by: Markus Armbruster
---
include/qemu/timer.h | 2 +-
accel/kvm/kvm-
can deal with conflicts by dropping conflicting
hunks, with "git-pull -s recursive -X ours". Or drop entire files
with conflicts.
If you want me to split off certain parts, please tell me exactly what
you want split off, and I'll gladly do the splitting. I don't mind
the splitt
It's been a while...
Daniel P. Berrangé writes:
> On Thu, Sep 09, 2021 at 01:20:16AM +0200, Philippe Mathieu-Daudé wrote:
>> Add the AccelClass::secure_policy_supported field to classify
>> safe (within security boundary) vs unsafe accelerators.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> -
Paolo Bonzini writes:
> On 05/10/20 10:01, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> Reduce the machine code pulled into qemu-storage-daemon.
>> I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and
>&g
Philippe Mathieu-Daudé writes:
> Reduce the machine code pulled into qemu-storage-daemon.
I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and
Juan for PATCH 5. David already ACKed.
Can do the pull request.
Philippe Mathieu-Daudé writes:
> On 9/21/20 10:19 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize()
>>> with the ability to return a boolean value if an error occured,
>>&
Philippe Mathieu-Daudé writes:
> Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize()
> with the ability to return a boolean value if an error occured,
> thus the caller does not need to check if the Error* pointer is
> set.
> Provide the same ability to the BusRealize type.
>
> Signed
Daniel P. Berrangé writes:
> On Thu, Jul 16, 2020 at 02:37:04PM +0200, Philippe Mathieu-Daudé wrote:
>> Let blk_attach_dev() take an Error* object to return helpful
>> information. Adapt the callers.
>>
>> $ qemu-system-arm -M n800
>> qemu-system-arm: sd_init failed: cannot attach blk 'sd0'
obably better to
> split the patch approx into subsystems. That will make it much easier
> to cherry-pick for people doing backports.
I doubt that's worth the trouble.
Acked-by: Markus Armbruster
Vladimir Sementsov-Ogievskiy writes:
> 07.07.2020 19:50, Markus Armbruster wrote:
>> From: Vladimir Sementsov-Ogievskiy
>>
>> Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of
>> functions with an errp OUT parameter.
>>
>> It has three goa
Eric Blake writes:
> On 7/7/20 11:50 AM, Markus Armbruster wrote:
>> From: Vladimir Sementsov-Ogievskiy
>>
>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
>> does corresponding changes in code (look for details in
>> include/qapi/error.
Eric Blake writes:
> On 7/7/20 11:50 AM, Markus Armbruster wrote:
>> From: Vladimir Sementsov-Ogievskiy
>>
>> Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of
>> functions with an errp OUT parameter.
>>
>> It has three goals:
Wolf
Reported-by: Greg Kurz
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Markus Armbruster
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
include/block/nbd.h | 1 +
block/nbd.c | 7 +++
nbd/client.c| 5 +
nbd/server.c| 5 +
4 files chan
Wolf
Reported-by: Greg Kurz
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/block/pflash_cfi01.c | 7 +++
hw/block/pflash_cfi02.c | 7 +++
2 files changed, 6 insertions(+), 8 deletions(-)
diff
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/block/dataplane/xen-block.c | 17 +++---
hw/block/xen-block.c | 102 ++---
hw/pci-host/xen_igd_pt.c |
-macro-file.h --in-place --no-show-diff \
--max-width 80 FILES...
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
scripts/coccinelle/auto-propagated-errp.cocci | 337 ++
include/qapi/error.h
rted-by: Greg Kurz
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/sd/sdhci-pci.c | 7 +++
hw/sd/sdhci.c | 21 +
hw/sd/ssi-sd.c| 10 +-
3 files changed, 17 inserti
ed for clarity. Put ERRP_AUTO_PROPAGATE()
before its helpers, and touch up style. Commit message tweaked.]
Signed-off-by: Markus Armbruster
---
include/qapi/error.h | 160 ++-
1 file changed, 141 insertions(+), 19 deletions(-)
diff --git a/include/qapi/er
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/9pfs/9p-local.c | 12 +---
hw/9pfs/9p.c | 1 +
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw
To speed things up, I'm taking the liberty to respin Vladimir's series
with my documentation amendments.
After my documentation work, I'm very much inclined to rename
ERRP_AUTO_PROPAGATE() to ERRP_GUARD(). The fact that it propagates
below the hood is detail. What matters to its users is that it
1 - 100 of 189 matches
Mail list logo
