On Thu, Jan 30, 2025 at 03:31:23PM -0600, Bjorn Helgaas wrote:
> On Thu, Jan 30, 2025 at 10:30:33AM +0100, Jan Beulich wrote:
> > On 30.01.2025 05:55, Marek Marczykowski-Górecki wrote:
> > > I've added logging of all config read/write to this device. Full log at
> >
On Fri, Jan 31, 2025 at 08:13:37AM +0100, Jan Beulich wrote:
> On 30.01.2025 22:31, Bjorn Helgaas wrote:
> > On Thu, Jan 30, 2025 at 10:30:33AM +0100, Jan Beulich wrote:
> >> On 30.01.2025 05:55, Marek Marczykowski-Górecki wrote:
> >>> (XEN) d0v1 conf read cf8 0x8001
On Wed, Jan 29, 2025 at 12:48:25PM -0600, Bjorn Helgaas wrote:
> On Wed, Jan 29, 2025 at 03:10:49AM +0100, Marek Marczykowski-Górecki wrote:
> > On Tue, Jan 28, 2025 at 07:15:26PM -0600, Bjorn Helgaas wrote:
> > > On Fri, Jan 17, 2025 at 01:05:30PM +0100, Marek Marczykowski-Gó
On Wed, Jan 29, 2025 at 10:17:20AM +0100, Jan Beulich wrote:
> On 29.01.2025 04:22, Marek Marczykowski-Górecki wrote:
> > On Tue, Jan 28, 2025 at 09:03:15PM -0600, Bjorn Helgaas wrote:
> >> The report claims the problem only happens with Xen. I'm not a Xen
> >>
nbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/x86/pv/emul-priv-op.c;h=70150c27227661baa253af8693ff00f2ab640a98;hb=HEAD#l295
>
> [3]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/probe.c?id=v6.13#n1208
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
On Tue, Jan 28, 2025 at 09:03:15PM -0600, Bjorn Helgaas wrote:
> [+cc linux-pci]
>
> On Wed, Jan 29, 2025 at 03:10:49AM +0100, Marek Marczykowski-Górecki wrote:
> > On Tue, Jan 28, 2025 at 07:15:26PM -0600, Bjorn Helgaas wrote:
> > > On Fri, Jan 17, 2025 at 01:05:30PM +
On Tue, Jan 28, 2025 at 07:15:26PM -0600, Bjorn Helgaas wrote:
> On Fri, Jan 17, 2025 at 01:05:30PM +0100, Marek Marczykowski-Górecki wrote:
> > After updating PV dom0 to Linux 6.12, The Mediatek MT7922 device reports
> > all 0xff when accessing its config space. This happens on
On Thu, Jan 23, 2025 at 01:45:40PM +0100, Marek Marczykowski-Górecki wrote:
> On Tue, Jan 21, 2025 at 04:13:20PM +, Teddy Astie wrote:
> > This work has been presented at Xen Summit 2024 during the
> > IOMMU paravirtualization and Xen IOMMU subsystem rework
>
On Thu, Jan 23, 2025 at 01:48:29PM +0100, Jan Beulich wrote:
> On 23.01.2025 13:45, Marek Marczykowski-Górecki wrote:
> > BTW Linux says it detected "Xen version 4.19." - shouldn't it report
> > 4.20 already at this point in release cycle?
>
> Not only at th
several
> contexts per domain and provide a new hypercall interface to allow guests
> to manage IOMMU contexts.
>
> The VT-d driver is updated to support these new features.
>
> [1] Using SPDK with the Xen hypervisor - FOSDEM 2023
> ---
> Cc: Marek Marczykowski-Górecki
>
ially reported at https://github.com/QubesOS/qubes-issues/issues/9689
#regzbot introduced: d591f6804e7e1310881c9224d72247a2b65039af
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
gt;
> The `xen` and `efi` options require being booted as a Xen guest (with Xen
> guest
> supported built-in) or from UEFI firmware respectively.
>
> Signed-off-by: Roger Pau Monné
Reviewed-by: Marek Marczykowski-Górecki
> ---
> Changes since v6:
> - Clarify d
e
cycle)
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
raise Exception('File sizes do not match')
Exception: File sizes do not match: 70160 != 4080 + 66048
Adjust the numbers as suggested by Frediano to work with 64-bytes and
even 128-bytes alignment.
Suggested-by: Frediano Ziglio
Signed-off-by: Marek Marczykowski-Górecki
---
xen/ar
egards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
01-09 06:53:39] (XEN) :00:07.2 - d0 - node -1 - MSIs < 129 >
[2025-01-09 06:53:39] (XEN) :00:07.1 - d0 - node -1 - MSIs < 128 >
[2025-01-09 06:53:39] (XEN) :00:07.0 - d0 - node -1 - MSIs < 127 >
[2025-01-09 06:53:39] (XEN) :00:06.0 - d0 - node -1 - MSIs < 126 >
[2025-01-09 06:53:39] (XEN) :00:04.0 - d0 - node -1
[2025-01-09 06:53:39] (XEN) :00:02.0 - d0 - node -1 - MSIs < 137 >
[2025-01-09 06:53:39] (XEN) :00:00.0 - d0 - node -1
I don't see any errors from toolstack this time.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
he box. On the other hand, changelog for v4 says
some parts are moved to the toolstack, but I don't see any changes in
tools/ in this series...
FWIW The exact version I tried is this (this series, on top of staging +
qubes patches):
https://github.com/QubesOS/qubes-vmm-xen/pull/200
At this
On Fri, Jan 03, 2025 at 02:00:28AM +, Andrew Cooper wrote:
> On 03/01/2025 12:42 am, Marek Marczykowski-Górecki wrote:
> > On Fri, Jan 03, 2025 at 01:18:31AM +0100, Marek Marczykowski-Górecki wrote:
> >> On Thu, Jan 02, 2025 at 08:39:16PM +0100, Marek Marczykowski-Górecki w
On Fri, Jan 03, 2025 at 01:18:31AM +0100, Marek Marczykowski-Górecki wrote:
> On Thu, Jan 02, 2025 at 08:39:16PM +0100, Marek Marczykowski-Górecki wrote:
> > On Thu, Jan 02, 2025 at 08:17:00PM +0100, Jürgen Groß wrote:
> > > On 02.01.25 19:54, Marek Marczykowski-Górecki wrote:
&
On Thu, Jan 02, 2025 at 08:39:16PM +0100, Marek Marczykowski-Górecki wrote:
> On Thu, Jan 02, 2025 at 08:17:00PM +0100, Jürgen Groß wrote:
> > On 02.01.25 19:54, Marek Marczykowski-Górecki wrote:
> > > On Thu, Jan 02, 2025 at 01:24:21PM +0100, Marek Marczykowski-Górecki
>
On Thu, Jan 02, 2025 at 08:17:00PM +0100, Jürgen Groß wrote:
> On 02.01.25 19:54, Marek Marczykowski-Górecki wrote:
> > On Thu, Jan 02, 2025 at 01:24:21PM +0100, Marek Marczykowski-Górecki wrote:
> > > On Thu, Jan 02, 2025 at 12:30:10PM +0100, Juergen Gross wrote:
> > >
On Thu, Jan 02, 2025 at 01:24:21PM +0100, Marek Marczykowski-Górecki wrote:
> On Thu, Jan 02, 2025 at 12:30:10PM +0100, Juergen Gross wrote:
> > On 02.01.25 11:20, Jürgen Groß wrote:
> > > On 19.12.24 17:14, Marek Marczykowski-Górecki wrote:
> > > > Hi,
> >
and the scratch space in the
> trampoline, and instead have a range in initdata to stash the bootloader
> metadata, and use virtual pointers rather than physical. This also
> avoids us double/triple handling the bootloader metadata, simplifying
> all aspects of the startup logic.
This obviously
On Thu, Jan 02, 2025 at 12:30:10PM +0100, Juergen Gross wrote:
> On 02.01.25 11:20, Jürgen Groß wrote:
> > On 19.12.24 17:14, Marek Marczykowski-Górecki wrote:
> > > Hi,
> > >
> > > It crashes on boot like below, most of the times. But sometimes (rarely)
>
t; }
> }
>
> +init_ler();
> +
> /* Cache {,compat_}gdt_l1e now that physically relocation is done. */
> this_cpu(gdt_l1e) =
> l1e_from_pfn(virt_to_mfn(boot_gdt), __PAGE_HYPERVISOR_RW);
> --
> 2.39.5
>
>
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
On Fri, Dec 20, 2024 at 02:48:52AM +0100, Marek Marczykowski-Górecki wrote:
> On Thu, Dec 19, 2024 at 05:14:52PM +0100, Marek Marczykowski-Górecki wrote:
> > Hi,
> >
> > It crashes on boot like below, most of the times. But sometimes (rarely)
> > it manages to stay aliv
On Thu, Dec 19, 2024 at 05:14:52PM +0100, Marek Marczykowski-Górecki wrote:
> Hi,
>
> It crashes on boot like below, most of the times. But sometimes (rarely)
> it manages to stay alive. Below I'm pasting few of the crashes that look
> distinctly different, if you follow the
.qubes-os.org/tests/122877/logfile?filename=serial0.txt
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
On Mon, Dec 16, 2024 at 09:35:37AM +0100, Roger Pau Monné wrote:
> Adding Oleksii, as this IMO wants to be a blocker for 4.20.
>
> On Wed, Oct 09, 2024 at 03:03:28PM +0200, Marek Marczykowski-Górecki wrote:
> > On Wed, Oct 09, 2024 at 01:38:32PM +0200, Jürgen Groß wrote:
> >
d by default.
On a high level, why the mechanism used by earlyprintk=xen (IIUC i/o
port 0xe9) isn't enough?
Hyperlaunch can't start full (Xen-unaware) HVM domains anyway, so
a requirement to use a Xen-specific interface for the console shouldn't be
an issue, no?
--
Best Regard
On Wed, Dec 11, 2024 at 01:37:52PM +0100, Ard Biesheuvel wrote:
> (cc Greg)
>
> On Wed, 11 Dec 2024 at 13:30, Marek Marczykowski-Górecki
> wrote:
> >
> > On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> > > On Wed, 11 Dec 2024 at 12:53, Jürgen G
On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> On Wed, 11 Dec 2024 at 12:53, Jürgen Groß wrote:
> >
> > Jason, Ard,
> >
> > I guess there are some prereq patches missing in stable 6.6.y branch?
> >
> >
> > Juergen
> >
>
haven't tested this hypothesis yet.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
ee_memory is the resource available to safely assign without having to
> allow for some unknown overhead and if I do ask for too much then I
> get a 'safe' failure.
FWIW Qubes OS tries to always keep at least 50MB free for Xen. So, our
formula is (free_memory - 50MB).
--
Best Regards
Consider also "Display controller" an IGD, not only "VGA compatible
controller". Specifically, IGD on Raptor Lake has 0x038000 class, not
0x030000.
Signed-off-by: Marek Marczykowski-Górecki
---
tools/libs/light/libxl_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
, checks if stuff still builds etc. It
can probably be limited to 1min fuzzing or such.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
s sounds like it disables HAP completely, but actually it looks like
disabling sharing HAP page tables with IOMMU ones, right? That (HAP
sharing) is relevant for PVH dom0 only, correct?
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
ted-by: David Woodhouse
> Fixes: 2ca9fbd739b8 ('AMD IOMMU: allocate IRTE entries instead of using a
> static mapping')
> Signed-off-by: Roger Pau Monné
Very lightly, but
Tested-by: Marek Marczykowski-Górecki
with this patch, touchpad works on Framework AMD, _without_ ioap
Xen 4.17.5
(XEN) Xen version 4.17.5 (mockbuild@[unknown]) (gcc (GCC) 12.3.1 20230508 (Red
Hat 12.3.1-1)) debug=n Sun
Sep 29 12:27:22 GMT 2024
And the whole report: https://github.com/QubesOS/qubes-issues/issues/9552
Any ideas?
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
si
+#define DOMID_RUN_QEMU 0
Please, don't hardcode dom0 here, QEMU can be running in a stubdomain
too (in which case, this will hilariously explode, as it will check what
dom0 is, instead of where QEMU is running).
Stewart already provided an alternative.
--
Best Regards,
Marek Marczykowski
x27;
> >
> > ?
> >
> > These are just minor cosmetics.
>
> Again, refactoring from before pulling out domU_type.
>
> I'm not fussed - I can shrink this to one line.
Either is fine for me. The short one is more readable now, while the
long one is easier to extend in the future.
Anyway, for the series (c80e9241209cc9ed7f66c3f45275f837ddafc21c and
previous two):
Reviewed-by: Marek Marczykowski-Górecki
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
> }
> else
> {
>
> base-commit: e9f227685e7204cb2293576ee5b745b828cb3cd7
> --
> 2.39.5
>
>
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
chpad issue on Framework 13 AMD,
it works without ioapic_ack=new now, thanks!
Tested-by: Marek Marczykowski-Górecki
> ---
> xen/arch/x86/io_apic.c | 47 ++
> 1 file changed, 47 insertions(+)
>
> diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86
is sounds like a good idea. It may also help with rebuilding
containers when needed?
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
Frediano Ziglio
> Reviewed-by: Andrew Cooper
For the EFI part:
Acked-by: Marek Marczykowski-Górecki
> ---
> Changes since v3:
> - fixed a typo in comment;
> - added Reviewed-by.
>
> Changes since v5:
> - do not add obj64 to targets, already done adding it to obj-bin-y.
> ---
&g
Reflect changed default mode, and fix formatting of `efi` value.
Fixes: d81dd3130351 ("x86/shutdown: change default reboot method preference")
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- wrap
- update Default: line too
---
docs/misc/xen-command-line.pandoc | 8 +
Reflect changed default mode, and fix formatting of `efi` value.
Fixes: d81dd3130351 ("x86/shutdown: change default reboot method preference")
Signed-off-by: Marek Marczykowski-Górecki
---
docs/misc/xen-command-line.pandoc | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
di
On Tue, Oct 15, 2024 at 09:25:11AM +0100, Frediano Ziglio wrote:
> This series came from part of the work of removing duplications between
> boot code and rewriting part of code from assembly to C.
Acked-by: Marek Marczykowski-Górecki
> Changes since v1, more details in specifi
On Mon, Oct 14, 2024 at 09:05:58PM +0100, Andrew Cooper wrote:
> On 14/10/2024 7:26 pm, Marek Marczykowski-Górecki wrote:
> > Hi,
> >
> > It looks like we've identified the second buggy driver that somewhere
> > assumes PAT is configured as Linux normally do nativ
S/qubes-vmm-xen/blob/44e9fd9f3b1ebf1cf43674b5a1c2669f7dd253f5/1019-Use-Linux-s-PAT.patch
[3] https://github.com/QubesOS/qubes-issues/issues/9501
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
xt time we simply won't get a report, the user will try Xen,
> see it's not working and move to something else.
>
> I've taken a quick look at Linux, and when parsing the IVMD blocks
> there's no checking that referred devices are behind an IOMMU, the
> regi
> On 09.10.2024 11:52, Marek Marczykowski-Górecki wrote:
> > > > > > On Wed, Oct 09, 2024 at 09:19:57AM +0200, Jan Beulich wrote:
> > > > > > > On 08.10.2024 23:32, Marek Marczykowski-Górecki wrote:
> > > > > > > >
On Wed, Oct 09, 2024 at 09:19:57AM +0200, Jan Beulich wrote:
> On 08.10.2024 23:32, Marek Marczykowski-Górecki wrote:
> > --- a/tools/libs/guest/xg_dom_bzimageloader.c
> > +++ b/tools/libs/guest/xg_dom_bzimageloader.c
> > @@ -272,8 +272,7 @@ static int _xc_try_lzma_decode(
&
Reviewed-by: Stefano Stabellini
Message-ID: <20240924061437.2636766-4-jiqian.c...@amd.com>
Signed-off-by: Juergen Gross
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
ngle-threaded mode")
Fix this by increasing the block size to 256MiB. And remove the
misleading comment (from lack of better ideas).
Signed-off-by: Marek Marczykowski-Górecki
---
tools/libs/guest/xg_dom_bzimageloader.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
ve omitted non-technical
> > parts:
> >
> > "Initialization of an object is never a side effect of the initialization
> > by itself. Of course expressions used for initialization can themselves have
> > side effects on other objects.
> >
> > @Andreas: Do you agree? C after all has a far simpler object model than C++.
> > The (potential) change in object representation (i.e. the bytes underlying
> > the object) is not a side effect of object initialization, but its primary
> > purpose."
> >
> > Further for Misra she added a reference to a Swiss person, but I think with
> > Bugseng we have sufficient expertise there.
>
> Unfortunately, the (translation of the) answer you received adds
> confusion to previous confusion: who answered has highlighted the
> "side" part of the term, which is indeed relevant in computer science,
> but not for the C standard. To the point that the same argument could
> be used to deny that ++i has a side effect because the increment is
> the "primary" effect...
>
> Part of the confusion is maybe in the the following paragraph Jan
> wrote earlier:
>
> > Hmm, that's interesting: There's indeed an example with an initializer
> > there. Yet to me the text you quote from the C standard does not say
> > that initialization is a side effect - it would be "modifying an
> > object" aiui, yet ahead of initialization being complete the object
> > doesn't "exist" imo, and hence can be "modified" only afterwards.
>
> In C, it is not true that the object does not exist ahead of
> initialization. Try the following:
>
> extern int f(int* p);
>
> int main() {
> int i = f(&i);
> }
This is interesting discussion, but I don't think it needs to block
anything. The proposed change doesn't violate any other rule/code style,
and I'd argue it's more readable. Taking more strict interpretation in
this case doesn't really hurt. I already acked this patch.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
.
>
> No functional change.
>
> Signed-off-by: Federico Serafini
Acked-by: Marek Marczykowski-Górecki
> ---
> xen/common/efi/runtime.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
&g
ot
> > contain any expression which has potential side effect).
> >
> > Refactor the code to address the rule violation.
> >
> > Suggested-by: Andrew Cooper
> > Signed-off-by: Federico Serafini
>
> Reviewed-by: Stefano Stabellini
Acked-by: Marek M
eless, it
looks like it might have uncovered some issue that would be silently
ignored otherwise.
[1] https://github.com/QubesOS/qubes-issues/issues/9488#issuecomment-2389152014
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
It will be useful for further tests.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- deduplicate via collect_xen_artifacts function
---
automation/scripts/build | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/automation/scripts/build b
Check if xen.efi is bootable with an XTF dom0.
The multiboot2+EFI path is tested on hardware tests already.
Signed-off-by: Marek Marczykowski-Górecki
---
This requires rebuilding debian:bookworm container.
Changes in v2:
- drop forcing TEST_TIMEOUT in the script - now can be set from test.yml
Marek Marczykowski-Górecki (3):
automation: preserve built xen.efi
automation: add a smoke test for xen.efi on X86
automation: shorten the timeout for smoke tests
automation/build/debian/bookworm.dockerfile | 1 +-
automation/gitlab-ci/test.yaml | 20 --
automation
The smoke tests when successful complete in about 5s. Don't waste
20min+ on failure, shorten the timeout to 120s
Signed-off-by: Marek Marczykowski-Górecki
---
automation/gitlab-ci/test.yaml | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/automation/gitl
>
> Signed-off-by: Stefano Stabellini
with commit message fixed:
Reviewed-by: Marek Marczykowski-Górecki
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index 8675016b6a..e947736195 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/au
es.
>
> Reviewed-by: Daniel P. Smith
Since it seems it's only the other patch causing issues, for this one:
Acked-by: Marek Marczykowski-Górecki
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
On Thu, Oct 03, 2024 at 10:27:15AM +0100, Frediano Ziglio wrote:
> On Thu, Oct 3, 2024 at 2:11 AM Marek Marczykowski-Górecki
> wrote:
> >
> > On Wed, Oct 02, 2024 at 04:27:19PM +0100, Frediano Ziglio wrote:
> > > On Wed, Oct 2, 2024 at 3:04 PM Marek Marczy
On Wed, Oct 02, 2024 at 04:27:19PM +0100, Frediano Ziglio wrote:
> On Wed, Oct 2, 2024 at 3:04 PM Marek Marczykowski-Górecki
> wrote:
> >
> > On Tue, Oct 01, 2024 at 11:22:37AM +0100, Frediano Ziglio wrote:
> > > This series came from part of the work of removing dupl
On Wed, Oct 02, 2024 at 04:30:25PM -0700, Stefano Stabellini wrote:
> On Thu, 3 Oct 2024, Marek Marczykowski-Górecki wrote:
> > The problem is this doesn't work. The group-level variable overrides the
> > one in yaml. See the commit message and the link there...
>
> No
On Wed, Oct 02, 2024 at 03:22:59PM -0700, Stefano Stabellini wrote:
> I forgot to reply to one important part below
>
>
> On Wed, 2 Oct 2024, Stefano Stabellini wrote:
> > On Wed, 2 Oct 2024, Marek Marczykowski-Górecki wrote:
> > > Check if xen.efi is bootable with an
On Wed, Oct 02, 2024 at 09:42:13PM +0100, Andrew Cooper wrote:
> On 02/10/2024 1:42 pm, Marek Marczykowski-Górecki wrote:
> > It will be useful for further tests.
> >
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > automation/scripts/build | 7 ++-
en/arch/x86/efi/mbi2.c| 66 +++
> xen/arch/x86/efi/stub.c| 10 +--
> xen/arch/x86/include/asm/efi.h | 18
> 6 files changed, 123 insertions(+), 125 deletions(-)
> create mode 100644 xen/arch/x86/efi/mbi2.c
> create mode 100644 xen/arch/x86/include/asm/efi.h
>
> --
> 2.34.1
>
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
On Wed, Oct 02, 2024 at 02:41:55PM +0200, Marek Marczykowski-Górecki wrote:
> Check if xen.efi is bootable with an XTF dom0.
>
> The TEST_TIMEOUT is set in the script to override project-global value.
> Setting it in the gitlab yaml file doesn't work, as it's too l
is tested on hardware tests already.
Signed-off-by: Marek Marczykowski-Górecki
---
This requires rebuilding debian:bookworm container.
The TEST_TIMEOUT issue mentioned above applies to xilix-* jobs too. It's
not clear to me why the default TEST_TIMEOUT is set at the group level
instead of i
It will be useful for further tests.
Signed-off-by: Marek Marczykowski-Górecki
---
automation/scripts/build | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/automation/scripts/build b/automation/scripts/build
index b3c71fb6fb60..4cd41cb2c471 100755
--- a/automation
is tested on hardware tests already.
Signed-off-by: Marek Marczykowski-Górecki
---
This requires rebuilding debian:bookworm container.
The TEST_TIMEOUT issue mentioned above applies to xilix-* jobs too. It's
not clear to me why the default TEST_TIMEOUT is set at the group level
instead of i
iano Ziglio
I was hoping it would fix also an issue with xen.efi as the crash is
pretty similar
(https://github.com/QubesOS/qubes-issues/issues/8206#issuecomment-2366835136),
but it seems to be something different.
Anyway,
Acked-by: Marek Marczykowski-Górecki
> ---
> xen/common/efi/boot.c |
f the function
> logic, so that panic messages with workaround suggestions are suitably
> printed.
>
> Signed-off-by: Roger Pau Monné
Since this changes behavior for running on EFI,
Acked-by: Marek Marczykowski-Górecki
> ---
> Changes since v2:
> - Updated to match previous
gt; It's a bit awkward, but this should do:
>
> {
> #ifdef CONFIG_XEN_GUEST
> wallclock_source = WALLCLOCK_XEN;
> #else
> no_config_param("XEN_GUEST", "wallclock", s, ss);
> #endif
> }
Can you boot the binary build with CONFIG_XEN_GUEST=y as native? If so,
the above will not be enough, a runtime check is needed anyway.
> There probably wants to be something similar for EFI, although it's not
> a plain CONFIG so it might be more tricky.
It needs to be runtime check here even more. Not only because of
different boot modes, but due to interaction with efi=no-rs (or any
other reason for not having runtime services). See the comment there.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
On Thu, Sep 12, 2024 at 03:47:53PM +0200, Roger Pau Monné wrote:
> On Thu, Sep 12, 2024 at 03:30:29PM +0200, Marek Marczykowski-Górecki wrote:
> > On Thu, Sep 12, 2024 at 02:56:55PM +0200, Roger Pau Monné wrote:
> > > On Thu, Sep 12, 2024 at 01:57:00PM +0200, Jan Beulich
> the last option overrides any previous one, and hence if that last
> option is not valid the logic will fallback to the default selection
> (in this case to probing).
That would be my expectation too. If some kind of preference would be
expected, it should looks like wallclock=efi,cmos, but I don't think we
need that.
> Thinking about this, it might make sense to unconditionally set
> wallclock_source = WALLCLOCK_UNSET at the start of parse_wallclock()
> to avoid previous instances carrying over if later ones are not valid.
This may be a good idea. But more importantly, the behavior should be
included in the option documentation (that if a selected value is not
available, it fallback to auto). And maybe a log message when that
happens (but I'm okay with skipping this one, as selected wallclock
source is logged already)?
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
/ property in descriptions of such patches.
I guess it's because guest_handle_cast() is a macro, yet it's lowercase
so looks like a function? Wasn't there some other MISRA rule about
lowercase/uppercase for macro names?
And yes, I don't really see why this would violate the side effect rule
either.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
On Fri, Sep 06, 2024 at 12:30:03PM +0200, Linux regression tracking (Thorsten
Leemhuis) wrote:
> On 08.08.24 12:31, Marek Marczykowski-Górecki wrote:
> >
> > When testing Linux 6.11-rc2, I've got the crash like below. It's a PVH
> > guest started with 400MB me
levant for Xen.
> >
> > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > 36e4fc57fc16
> >
> > Signed-off-by: Nikola Jelic
> > Signed-off-by: Milan Djokic
Acked-by: Marek Marczykowski-Górecki
> This looks okay to me now, but
On Thu, Aug 08, 2024 at 01:22:30PM +0200, Jan Beulich wrote:
> On 23.07.2024 16:28, Marek Marczykowski-Górecki wrote:
> > I'm observing a crash like the one below when trying to resume from S3.
> > It happens on Xen nested in KVM (QEMU 9.0, Linux 6.9.3) but only on AMD.
> &
ps://github.com/QubesOS/qubes-linux-kernel/blob/005ae1ac3819d957379e48fb2cfd33f511a47275/config-qubes
(options set in the latter takes precedence)
Especially, it has:
CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=y
CONFIG_XEN_UNPOPULATED_ALLOC=y
#regzbot introduced: v6.10..v6.11-rc2
--
Best Regards,
Marek Marczykowski-Górecki
Invisi
On Wed, Aug 07, 2024 at 12:26:26PM +0200, Jürgen Groß wrote:
> On 07.08.24 12:23, Marek Marczykowski-Górecki wrote:
> > On Tue, Aug 06, 2024 at 05:24:22PM +0200, Jürgen Groß wrote:
> > > On 06.08.24 17:21, Marek Marczykowski-Górecki wrote:
> > > > On Tue, Aug 06, 20
On Tue, Aug 06, 2024 at 05:24:22PM +0200, Jürgen Groß wrote:
> On 06.08.24 17:21, Marek Marczykowski-Górecki wrote:
> > On Tue, Aug 06, 2024 at 04:12:32PM +0200, Jürgen Groß wrote:
> > > Marek,
> > >
> > > On 17.06.24 16:03, Marek Marczykowski-Górecki wrote:
&
On Tue, Aug 06, 2024 at 04:12:32PM +0200, Jürgen Groß wrote:
> Marek,
>
> On 17.06.24 16:03, Marek Marczykowski-Górecki wrote:
> > On Mon, Jun 17, 2024 at 01:22:37PM +0200, Jan Beulich wrote:
> > > Hello,
> > >
> > > while it feels like we had a si
On Tue, Jul 30, 2024 at 03:01:52PM +0100, Andrew Cooper wrote:
> On 30/07/2024 2:46 pm, Marek Marczykowski-Górecki wrote:
> > On Fri, Jul 26, 2024 at 05:19:42PM -0700, Stefano Stabellini wrote:
> >> Upgrade Yocto to a newer version. Use ext4 as image format for testing
> &g
ilename for the rootfs.
>
> Signed-off-by: Stefano Stabellini
Reviewed-by: Marek Marczykowski-Górecki
> ---
>
> all yocto tests pass:
> https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/1390081173
>
> Changes in v2:
> - s/EXT4/IMAGE_FMT/
> - s
still can be worked around
with a cmdline option). But might warrant adjusting commit message.
> Signed-off-by: Roger Pau Monné
Other points still stand, and I think this generally is an improvement,
so, preferably with adjusted commit message:
Acked-by: Marek Marczykowski-Górecki
> ---
> C
or paths may
result in incorrect state (like pages removed from mmio_ro_ranges too
early). Debug build has asserts for relevant cases.
Signed-off-by: Marek Marczykowski-Górecki
---
Shadow mode is not tested, but I don't expect it to work differently than
HAP in areas related to this patch.
Change
a generic API for making just parts of an MMIO page R/O and use it to fix
USB3 console with share=yes or share=hwdom options. More details in commit
messages.
Marek Marczykowski-Górecki (2):
x86/mm: add API for marking only part of a MMIO page read only
drivers/char: Use sub-page ro API to make
plenty of it). This
configuration is already documented as unsafe with untrusted guests and
not security supported.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jan Beulich
---
Changes in v4:
- restore mmio_ro_ranges in the fallback case
- set XHCI_SHARE_NONE in the fallback case
Changes
On Thu, Jul 25, 2024 at 11:26:31AM +0200, Jan Beulich wrote:
> On 23.07.2024 05:24, Marek Marczykowski-Górecki wrote:
> > + * so tolerate it.
> > + * But unaligned size would result in smaller area, so deny it.
> > + */
> > +ASSERT(IS_ALIGNED(
On Thu, Jul 25, 2024 at 02:06:04PM +, Anthony PERARD wrote:
> On Thu, May 16, 2024 at 03:58:28PM +0200, Marek Marczykowski-Górecki wrote:
> > Especially allow it to control MSI/MSI-X enabling bits. This part only
> > writes a flag to a sysfs, the actual implementation is on the
reason
> given by gitlab for the failures: "There has been a timeout failure or
> the job got stuck." (That message can be seen when going to the url,
> removing "/raw" part, and scrolling to the top. Or looking at the side
> bar and seen a duration that well above 1h)
>
> Communication between gitlab and the runner might be broken in those
> cases, or the runner stop working.
This time the runner VM got hit with
https://lore.kernel.org/xen-devel/ZO0WrR5J0xuwDIxW@mail-itl/ . So, I
guess the failure is warranted, just not the one you'd expect...
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
ssertion didn't
fail (or it crashed before reaching that part).
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c
index 371dd100c742..fe8e664e1b63 100644
--- a/xen/arch/x86/genapic/x2apic.c
+++ b/xen/a
On Tue, Jul 23, 2024 at 12:25:32PM +0200, Marek Marczykowski-Górecki wrote:
> On Mon, Jul 22, 2024 at 11:18:38AM +0100, Andrew Cooper wrote:
> > EFI systems can run with NX disabled, as has been discovered on a Broadwell
> > Supermicro X10SRM-TF system.
> >
> > Prior t
DISABLE from the early boot path")
> Link: https://xcp-ng.org/forum/post/80520
> Reported-by: Gene Bright
> Signed-off-by: Andrew Cooper
Acked-by: Andrew Cooper
> ---
> CC: Jan Beulich
> CC: Roger Pau Monné
> CC: Daniel P. Smith
> CC: Marek Marczykowski-Górecki
1 - 100 of 1041 matches
Mail list logo
