On 06/04/21 16:02, Anthony PERARD via groups.io wrote:
> On Wed, Jun 02, 2021 at 10:36:49AM +0200, Laszlo Ersek wrote:
>> Anthony, Julien,
>>
>> (or anyone else subscribed to xen-devel -- CC'd now),
>>
>> On 05/26/21 22:14, Laszlo Ersek wrote:
>&g
On 06/04/21 16:02, Anthony PERARD wrote:
> On Wed, Jun 02, 2021 at 10:36:49AM +0200, Laszlo Ersek wrote:
>> Anthony, Julien,
>>
>> (or anyone else subscribed to xen-devel -- CC'd now),
>>
>> On 05/26/21 22:14, Laszlo Ersek wrote:
>>> Bugzilla: http
Anthony, Julien,
(or anyone else subscribed to xen-devel -- CC'd now),
On 05/26/21 22:14, Laszlo Ersek wrote:
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> Repo: https://pagure.io/lersek/edk2.git
> Branch: xen_split_bz_2122
can you please build the OvmfX
e.org/show_bug.cgi?id=2490
Signed-off-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
-Reviewed-by: Liming Gao
Message-Id: <20210412133003.146438-3-anthony.per...@citrix.com>
+Reviewed-by: Liming Gao
diff --git a/MdePkg/MdePkg.dec b/MdePkg/M
>> 收件人: de...@edk2.groups.io
>> 抄送: Laszlo Ersek ; Jordan Justen
>> ; Ard Biesheuvel ;
>> xen-devel@lists.xenproject.org; Anthony PERARD
>> ; Julien Grall ; Michael D
>> Kinney ; Liming Gao
>> ; Zhiguang Liu ; Liming
>> Gao
>> 主题: [edk2-devel] [PATC
lock which would be
> uninitialised.
>
> A simple runtime test showed that TimerLib doesn't use PcdFSBClock
> value before it is set.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
gt; in a following patch.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> CC: Roger Pau Monné
>
> v3:
> - fix debug format strings
> - fix coding style
Thank
--
> .../BaseMemEncryptSevLib/X64/VirtualMemory.h | 143 +-
> 2 files changed, 5 insertions(+), 255 deletions(-)
> copy OvmfPkg/{Library/BaseMemEncryptSevLib/X64/VirtualMemory.h =>
> Include/IndustryStandard/PageTable.h} (60%)
Reviewed-by: Laszlo Ersek
T
On 03/25/21 16:47, Anthony PERARD via groups.io wrote:
> Patch series available in this git branch:
> git://xenbits.xen.org/people/aperard/ovmf.git br.apic-timer-freq-v2
>
> Changes in v2:
> - main change is to allow mapping of Xen pages outside of the RAM
> see patch: "OvmfPkg/XenPlatformPei: M
gt; OvmfXen could use are actually using the *Delay functions in TimerLib,
> and so would not use the value from PcdFSBClock which would be
> uninitialised.
>
> A simple runtime test showed that TimerLib doesn't use PcdFSBClock
> value before it is set.
OK.
>
> Ref: ht
urn;
> + }
> +
> + VcpuTimeInfo = &SharedInfo->VcpuInfo[0].Time;
> +
> + InitializeApicTimer (1, MAX_UINT32, TRUE, 0);
> + DisableApicTimerInterrupt ();
> +
> + TimerTick = GetApicTimerCurrentCount ();
> + TscTick = AsmReadTsc ();
> + XenDelay (VcpuTimeInfo, 100ULL);
> + TimerTick2 = GetApicTimerCurrentCount ();
> + TscTick2 = AsmReadTsc ();
> +
> +
> + DiffTimer = TimerTick - TimerTick2;
> + Status = SafeUint64Mult (GetCpuFreq (VcpuTimeInfo), DiffTimer, &Dividend);
> + ASSERT_EFI_ERROR (Status);
> + if (EFI_ERROR (Status)) {
> +DEBUG ((DEBUG_ERROR, "overflow while calculating APIC frequency\n"));
> +DEBUG ((DEBUG_ERROR, "CPU freq: %ld Hz; APIC timer tick count for 1 ms:
> %d\n",
> +GetCpuFreq (VcpuTimeInfo), DiffTimer));
(6) Please use %lu and %u for formatting the UINT64 retval of
GetCpuFreq(), and the UINT32 variable DiffTimer, respectively.
All trivial feedback of course, so:
Acked-by: Laszlo Ersek
Thanks
Laszlo
> +CpuDeadLoop ();
> + }
> +
> + Freq = DivU64x64Remainder (Dividend, TscTick2 - TscTick, NULL);
> + DEBUG ((DEBUG_INFO, "APIC Freq % 8lu Hz\n", Freq));
> +
> + UnmapXenPage (SharedInfo);
> +}
>
ring the PEI phase so we
> can map the Xen shared pages outside of memory that can be used by
> guest, and as high as possible.
>
> Signed-off-by: Anthony PERARD
> ---
>
> Notes:
> v2:
> - new patch
With the typo fixes:
Acked-by: Laszlo Ersek
Than
On 03/25/21 16:47, Anthony PERARD via groups.io wrote:
> We are going to use the page table structure in yet another place,
> collect the types and macro that can be used from another module
> rather that making yet another copy.
s/rather that/rather than/
On 03/25/21 16:47, Anthony PERARD via groups.io wrote:
> We are going to use the page table structure in yet another place,
> collect the types and macro that can be used from another module
> rather that making yet another copy.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490
> Signe
On 03/26/21 15:16, Lendacky, Thomas wrote:
> On 3/25/21 10:47 AM, Anthony PERARD wrote:
>> We are going to use the page table structure in yet another place,
>> collect the types and macro that can be used from another module
>> rather that making yet another copy.
>>
>> Ref: https://bugzilla.tiano
On 03/25/21 16:47, Anthony PERARD wrote:
> Patch series available in this git branch:
> git://xenbits.xen.org/people/aperard/ovmf.git br.apic-timer-freq-v2
I'll get to this sometime in April, possibly after the SEV-SNP series.
That shouldn't discourage others from reviewing sooner, of course.
Tha
On 01/19/21 16:52, Anthony PERARD via groups.io wrote:
> On Tue, Jan 19, 2021 at 03:49:34PM +0100, Laszlo Ersek wrote:
>> On 01/19/21 10:37, Julien Grall wrote:
>>> Hi Igor,
>>>
>>> On 13/01/2021 03:42, Igor Druzhinin wrote:
>>>> We faced a problem
On 01/19/21 10:37, Julien Grall wrote:
> Hi Igor,
>
> On 13/01/2021 03:42, Igor Druzhinin wrote:
>> We faced a problem with passing through a PCI device with 64GB BAR to
>> UEFI guest. The BAR is expectedly programmed into 64-bit PCI aperture at
>> 64G address which pushes physical address space t
gt; OvmfPkg/OvmfXen.dsc| 3 +
> OvmfPkg/XenPlatformPei/MemDetect.c | 166
> +++------
> 2 files changed, 15 insertions(+), 154 deletions(-)
Acked-by: Laszlo Ersek
Anthony and/or Julien should also approve this patch (and anyone from
the Xen community is wel
On 01/11/21 17:31, Igor Druzhinin wrote:
> On 11/01/2021 15:35, Laszlo Ersek wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
>> unless you have verified the sender and know the content is safe.
>>
>> On 01/11/21 16:26, Igor Druzhinin
On 01/11/21 16:26, Igor Druzhinin wrote:
> On 11/01/2021 15:21, Jan Beulich wrote:
>> On 11.01.2021 15:49, Laszlo Ersek wrote:
>>> On 01/11/21 15:00, Igor Druzhinin wrote:
>>>> On 11/01/2021 09:27, Jan Beulich wrote:
>>>>> On 11.01.2021 05:53, Igor Dr
On 01/11/21 16:21, Jan Beulich wrote:
> On 11.01.2021 15:49, Laszlo Ersek wrote:
>> On 01/11/21 15:00, Igor Druzhinin wrote:
>>> On 11/01/2021 09:27, Jan Beulich wrote:
>>>> On 11.01.2021 05:53, Igor Druzhinin wrote:
>>>>> We faced a problem with
On 01/11/21 15:00, Igor Druzhinin wrote:
> On 11/01/2021 09:27, Jan Beulich wrote:
>> On 11.01.2021 05:53, Igor Druzhinin wrote:
>>> We faced a problem with passing through a PCI device with 64GB BAR to
>>> UEFI guest. The BAR is expectedly programmed into 64-bit PCI aperture at
>>> 64G address whi
ciInfo = (EFI_XEN_OVMF_PCI_INFO *) Tables[OVMF_INFO_PCI_TABLE];
> +
> + ASSERT (PciInfo && (EFI_PHYSICAL_ADDRESS) PciInfo < MAX_ADDRESS);
(2) Please spell out
PciInfo != NULL
> + if (PciBase && PciSize) {
(3) Same here -- please use explicit comparisons.
&g
On 06/17/20 05:16, Igor Druzhinin wrote:
> On 16/06/2020 19:42, Laszlo Ersek wrote
>> If I understand correctly, TimerInterruptHandler()
>> [OvmfPkg/8254TimerDxe/Timer.c] currently does the following:
>>
>> - RaiseTPL (TPL_HIGH_LEVEL) --> mask interrupts from being
.PcdCName|Value
-
I'm not sure if the "build" utility accepts this intentionally, or by
mistake.
Can you simply keep the "|1" part too?
Otherwise, I'm OK with the argument laid out in the commit message.
(Thank you for the detailed commit message!)
W
On 01/29/20 13:12, Anthony PERARD wrote:
> Calculate the frequency of the APIC timer that Xen provides.
>
> Even though the frequency is currently hard-coded, it isn't part of
> the public ABI that Xen provides and thus may change at any time. OVMF
> needs to determine the frequency by an other me
};
> #ifndef __XEN__
> typedef struct shared_info shared_info_t;
> +typedef struct shared_info XEN_SHARED_INFO;
> #endif
>
> /* Turn a plain number into a C UINTN constant. */
>
Assuming the OVMF platforms continue to build at this stage into the
series, and provided that (1) and (2) are fixed:
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
to configure X86 Processor FSB clock.
> + # @Prompt FSB Clock.
> + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|2|UINT32|0x000c
> +
> [UserExtensions.TianoCore."ExtraFiles"]
>MdePkgExtra.uni
>
Looks good to me:
Reviewed-by: Laszlo Ersek
Mike or Liming will
On 01/29/20 13:12, Anthony PERARD wrote:
> To avoid nasm generating a warning, replace the macro by the value
> expected to be stored in eax.
> Ia32/XenPVHMain.asm:76: warning: dword data exceeds bounds
>
> Reported-by: Laszlo Ersek
> Signed-off-by: Anthony PERARD
On 09/16/19 20:36, Andrew Fish wrote:
>
>
>> On Sep 16, 2019, at 10:36 AM, Laszlo Ersek wrote:
>>
>> On 09/13/19 16:50, Anthony PERARD wrote:
>>> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid
>>> using the Memory Allocation Service
On 09/13/19 16:50, Anthony PERARD wrote:
> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid
> using the Memory Allocation Services.
>
> This comes with a new interface named RegisterExitCallback so that PV
> drivers can disconnect from the backend before XenBusDxe is teared
> down
his value" with
"XENSTORE_PAYLOAD_MAX").
Other than that, I'm going to have to ACK this after a brief skim only.
Acked-by: Laszlo Ersek
Thanks
Laszlo
> typedef enum {
>XENSTORE_STATUS_SUCCESS = 0,
>XENSTORE_STATUS_FAIL,
> @@ -64,19 +70,17 @@ typedef enum {
On 09/13/19 16:50, Anthony PERARD wrote:
> We will use a buffer on the stack instead of allocating memory for
> internal functions that are expecting a reply from xenstore.
>
> The external interface XENBUS_PROTOCOL isn't changed yet, so
> allocation are made for XsRead and XsBackendRead.
>
> Ref:
On 09/16/19 17:39, Laszlo Ersek wrote:
> On 09/13/19 16:50, Anthony PERARD wrote:
>> When doing an action with a path and subpath in the xenstore,
>> XenStoreJoin is called to generate "$path/$subpath". But this function
>> do an allocation of memory which i
190
> Signed-off-by: Anthony PERARD
> ---
> OvmfPkg/XenBusDxe/XenStore.c | 297 +++
> 1 file changed, 130 insertions(+), 167 deletions(-)
Sorry, too big for a detailed review, and I'd like to go through the
series today. So, based on the diffstat,
Ac
atus;
> }
> @@ -1226,7 +1240,7 @@ XenStoreTransactionStart (
>XENSTORE_STATUS Status;
>
>Status = XenStoreSingle (XST_NIL, XS_TRANSACTION_START, "", NULL,
> - (VOID **) &IdStr);
> +NULL, (VOID **) &IdStr);
(5) Indentation.
>if (Status == XENSTORE_STATUS_SUCCESS) {
> Transaction->Id = (UINT32)AsciiStrDecimalToUintn (IdStr);
> FreePool (IdStr);
> @@ -1246,7 +1260,7 @@ XenStoreTransactionEnd (
>AbortStr[0] = Abort ? 'F' : 'T';
>AbortStr[1] = '\0';
>
> - return XenStoreSingle (Transaction, XS_TRANSACTION_END, AbortStr, NULL,
> NULL);
> + return XenStoreSingle (Transaction, XS_TRANSACTION_END, AbortStr, NULL,
> NULL, NULL);
> }
>
> XENSTORE_STATUS
>
With the above addressed:
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
XENSTORE_STATUS_EINVAL;
> + }
>
> - return Status;
> + return XenStoreWrite (Transaction, DirectoryPath, Node, Buf);
> }
>
> XENSTORE_STATUS
>
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
file changed, 35 insertions(+), 90 deletions(-)
This looks a bit more complex than what I can allocate time for now, so
I'll trust you on it -- it only modifies XenStore.c. Feedback from other
reviewers is encouraged.
Acked-by: Laszlo Ersek
Thanks
Laszlo
_
ENSTORE_WATCH_SIGNATURE);
>
> - AsciiSPrint (Token, sizeof (Token), "%p", (VOID *) Watch);
> - if (XenStoreFindWatch (Token) == NULL) {
> + if (XenStoreFindWatch (Watch) == NULL) {
> return;
>}
>
> @@ -1393,6 +1394,7 @@ Xen
try;
> -DEBUG ((EFI_D_WARN, "XenStore: WatchEvents is not empty, cleaning
> up..."));
> +DEBUG ((DEBUG_WARN, "XenStore: WatchEvents is not empty, cleaning
> up...\n"));
> Entry = GetFirstNode (&xs.WatchEvents);
> while (!IsNull (&xs.WatchEvents, Entry)) {
>XENSTORE_MESSAGE *Message = XENSTORE_MESSAGE_FROM_LINK (Entry);
>
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
:
> Add a extra parameter to indicate where to start the search for the
> boot firmware volume.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v3:
> - rebased, S
On 08/15/19 13:03, Laszlo Ersek wrote:
> On 08/13/19 13:30, Anthony PERARD wrote:
>> Patch series available in this git branch:
>> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
>> br.platform-xen-pvh-v5
>>
>> Changes in v5:
>> - patch 23 g
On 08/13/19 13:30, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v5
>
> Changes in v5:
> - patch 23 got a rework of the lapic range skipping
> - small fixups in patch 20, 22, 23, 31, 32, 33.
> s
On 08/15/19 11:40, Laszlo Ersek wrote:
> On 08/13/19 13:31, Anthony PERARD wrote:
>> Introduce PcdXenGrantFrames to replace a define in XenBusDxe and allow
>> the same value to be used in a different module.
>>
>> The reason for the number of page to be 4 doesn't ex
en platform device which would start the XenIoPciDxe and allocate
> the space for the Grant Tables.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - add m
gt; Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - add missing PcdLib to [LibraryClasses]
Yes, that's for
365f2b95-b6c9-03cf-5346-5e1192bfa437@redhat.com">http://mid.mail-archive.com/365f2b95-b6c9-03cf-5346-5e1192bfa43
core.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - fix typos in commit message.
Thanks for those fixes, my R-b stands.
Laszlo
> v4:
> - instead of creating a new XEN_CONSOLE_DEVICE_PA
is supposed to have sane default. MTRR will need
> to be done properly but keeping what's already been done by programs
> that have run before OVMF will do for now.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked
rcall which would give the same result.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - fix commit message, the hypercall *can* be made several time, but we
&
On 08/13/19 13:31, Anthony PERARD wrote:
> XenPvhDetected() can be used to figure out if OVMF has started via the
> Xen PVH entry point.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
>
On 08/12/19 17:12, Anthony PERARD wrote:
> On Tue, Jul 30, 2019 at 03:10:13PM +0200, Laszlo Ersek wrote:
>> Hi Anthony,
>>
>> On 07/29/19 17:39, Anthony PERARD wrote:
>>> Patch series available in this git branch:
>>> https://xenbits.xen.org/git-http/peopl
On 08/08/19 15:44, Roger Pau Monné wrote:
> On Thu, Aug 08, 2019 at 02:28:32PM +0100, Anthony PERARD wrote:
>> On Wed, Aug 07, 2019 at 05:54:51PM +0200, Roger Pau Monné wrote:
>>> On Mon, Jul 29, 2019 at 04:39:38PM +0100, Anthony PERARD wrote:
PcdFSBClock is used by SecPeiDxeTimerLibCpu, the T
Hi Anthony,
On 07/29/19 17:39, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v4
>
> Changes in v4:
> - patch "OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it has
> run" was rem
.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - Update Maintainers.txt
>
> v3:
> - fix the commit message body
>
> ArmVirtPkg/ArmVirtXen.dsc | 2
!= NULL) {
> +FreePages (Allocation, FixedPcdGet32 (PcdXenGrantFrames));
> + }
> + return Status;
> +}
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 78e9f889ab..79defd13bf 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -382,6
om/4badd535-c23d-c64d-7bb3-fb42bbbf538a@redhat.com>
I didn't realize we'd be introducing the PcdLib dependency anew.
(1) However, in that case, we should list PcdLib in the [LibraryClasses]
section of the INF file as well.
With (1) fixed:
Reviewed-by: Laszlo Ersek
There is no nee
On 07/29/19 17:39, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v4
>
> Changes in v4:
> - patch "OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it has
> run" was removed, and ins
e.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - instead of creating a new XEN_CONSOLE_DEVICE_PATH, use the existing
> VENDOR_UART_DEVICE_PATH. And explain why VENDOR_UART_DEVICE_PATH
>
can work on
> both a Xen PVH guest and an HVM one.
>
> Based on the "OvmfPkg/8254TimerDxe" implementation.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
On 07/30/19 13:45, Laszlo Ersek wrote:
> On 07/29/19 17:39, Anthony PERARD wrote:
>> When running as a Xen PVH guest, there is no CMOS to read the memory
>> size from. Rework GetSystemMemorySize(Below|Above)4gb() so they can
>> work without CMOS by reading the e82
is supposed to have sane default. MTRR will need
> to be done properly but keeping what's already been done by programmes
> that has runned before OVMF will do for now.
(1) s/programmes that has runned/programs that have run/
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?
by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - fix top-level comment style
> - Update Maintainers.txt
>
> v3:
> - use SPDX
> - add XenPlatformLib.h to [LibraryClasses] in OvmfPkg.dec
> - fix typos
&g
; ResetSystemRuntimeDxe is calling the TimerLib API at runtime to do the
> operation "EfiResetCold", so this may never complete if the OS have
> disabled the Local APIC Timer.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
>
on't seems to be
> useful. This is the entry point used by HVM guest (hvmloader).
>
> [1] UefiCpuPkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> --
header, but this will be a manual step.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - fix top-level comment style
> - Update Maintainers.txt
>
&g
ntainers.txt
> index 34bdb275b4..42ec8d54af 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -379,6 +379,7 @@ F: OvmfPkg/PlatformPei/Xen.*
> F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
> F: OvmfPkg/XenBusDxe/
> F: OvmfPkg/XenIoPciDxe/
> +F: OvmfPkg/XenPlatformPei/
> F: OvmfPkg/XenPvBlkDxe/
> F: OvmfPkg/XenResetVector/
> R: Anthony Perard
>
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
EfiFirmwareVolumeTopFileGuid).
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - Update Maintainers.txt
>
> v3:
> - Added gEfiFirmwareVolumeTo
, "OvmfPkg: raise DXEFV size to 11 MB"
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - rebased
> - Update Maintainers.
On 07/26/19 18:06, Anthony PERARD wrote:
> On Wed, Jul 10, 2019 at 04:05:02PM +0200, Laszlo Ersek wrote:
>> On 07/04/19 16:42, Anthony PERARD wrote:
>>> + if (State == NULL) {
>>> +Status = EFI_OUT_OF_RESOURCES;
>>> +goto Error;
>>> + }
&g
On 07/22/19 19:06, Anthony PERARD wrote:
> On Wed, Jul 10, 2019 at 12:48:57PM +0200, Laszlo Ersek wrote:
>> On 07/04/19 16:42, Anthony PERARD wrote:
>>> On a Xen PVH guest, none of the existing serial or console interface
>>> works, so we add a new one, based on X
On 07/22/19 21:45, Laszlo Ersek wrote:
> we place the 32-bit PCI IOMMU aperture based on [...]
Do I get a medal for this hugely confusing typo? :)
In earnest, I'm sorry about it -- my comment had nothing to do with
"IOMMU"; I meant "MMIO". (At least I got it ri
's
>>> already done by hvmloader, on PVH it is supposed to have sane default.
>>>
>>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
>>> Signed-off-by: Anthony PERARD
>>> Acked-by: Laszlo Ersek
>>> ---
>>>
>>> Note
On 07/22/19 15:49, Anthony PERARD wrote:
> On Mon, Jul 15, 2019 at 04:22:19PM +0200, Roger Pau Monné wrote:
>> On Thu, Jul 04, 2019 at 03:42:07PM +0100, Anthony PERARD wrote:
>>> ACPI Timer does not work in a PVH guest, but local APIC works on both
>>
>> This is not accurate. It's not that the ACPI
On 07/19/19 18:42, Anthony PERARD wrote:
> On Fri, Jul 05, 2019 at 02:21:13PM +0200, Laszlo Ersek wrote:
>> The patches on the list are malformed. They have
>>
>> Content-Transfer-Encoding: quoted-printable
>>
>> which is fine, in itself; however, they have CR-
On 07/19/19 12:20, Anthony PERARD wrote:
> On Fri, Jul 05, 2019 at 02:57:06PM +0100, Andrew Cooper wrote:
>> On 04/07/2019 15:42, Anthony PERARD wrote:
>>> diff --git a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm
>>> b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm
>>> new file mode 100644
>>
On 07/04/19 16:41, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v3
>
> Hi,
>
> I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc
> with the goal to make it work on both Xen
On 07/04/19 16:42, Anthony PERARD wrote:
> XenIoPvhDxe use XenIoMmioLib to reserve some space to be use by the
> Grant Tables.
>
> The call is only done if it is necessary, we simply detect if the
> guest is PVH, as in this case there is currently no PCI bus, and no
> PCI Xen platform device which
seful. Because now that I'm looking at
VENDOR_UART_DEVICE_PATH, it seems that we don't need the new type
XEN_CONSOLE_DEVICE_PATH at all. Is that right? So:
(1) Please drop XEN_CONSOLE_DEVICE_PATH.
(2) Please replace the comment
Debug Agent UART Device Path structure
with
Vendor U
- rebased, SPDX, copyright
(1) Please replace both occurrences of "PcAtChipsetPkg" in the commit
message with "OvmfPkg". (You rebased the DSC/FDF files correctly, but
missed the commit message.)
With that:
Acked-by: Laszlo Ersek
___
Xe
LIB_ADDRESS (0, 0x1f, 0, 0x6b), 0x0b); // H
>break;
> default:
> + if (XenDetected ()) {
> +//
> +// There is no PCI bus in this case.
> +//
> +return;
> + }
>DEBUG ((EFI_D_ERROR, "%a: Unknown H
ob (&gEfiXenInfoGuid);
> - if (GuidHob == NULL) {
> -FoundHob = 0;
> -return FALSE;
> - }
> -
> - FoundHob = 1;
> - return TRUE;
> -}
> -
> EFI_STATUS
> EFIAPI
> ConnectRecursivelyIfPciMassStorage (
&
On 07/08/19 16:38, Laszlo Ersek wrote:
> On 07/04/19 16:42, Anthony PERARD wrote:
>> This patch replace the XenDetected() function by the one in
>> XenPlatformLib.
>>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
>> Signed-off-by: Anthony PERA
{
> +XenInfo = (EFI_XEN_INFO *) GET_GUID_HOB_DATA (GuidHob);
>}
> -
> - return (EFI_XEN_INFO *) GET_GUID_HOB_DATA (GuidHob);
> + Cached = TRUE;
> + return XenInfo;
> }
>
> /**
>
This will work fine in DXE modules (and by the end of the series, only
DXE mod
ost Bridge Device ID: 0x%04x\n",
> __FUNCTION__, mHostBridgeDevId));
>ASSERT (FALSE);
>
Acked-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
o.HyperPages = AllocatePages (TransferPages);
> @@ -152,6 +154,13 @@ XenConnect (
> sizeof(mXenInfo)
> );
>
> + //
> + // Initialize the XenHypercall library, now that the XenInfo HOB is
> + // available
> + //
> + Status = XenHypercallLibInit ();
>
t;
> +RETURN_STATUS
> +EFIAPI
> +XenHypercallLibConstruct (
> + VOID
> + )
> +{
> + XenHypercallLibInit ();
> + //
> + // We don't fail library construction, since that has catastrophic
> + // consequences for client modules (whereas those modul
look for PVH one
> + //
> + XenInfo = XenGetInfoHOB ();
> + ASSERT (XenInfo != NULL);
> + if (XenInfo->RsdpPvh != NULL) {
> +DEBUG ((DEBUG_INFO, "%a: Use ACPI RSDP table at 0x%p\n",
> +gEfiCallerBaseName, XenInfo->RsdpPvh));
(1) Please fix the ind
h, splited from the next patch
> (which was OvmfPkg/AcpiPlatformDxe: Use PVH RSDP if exist)
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
running under Xen and
> +* allow to get more information when it is the case.
> +*
> +* Copyright (c) 2019, Citrix Systems, Inc.
> +*
> +* SPDX-License-Identifier: BSD-2-Clause-Patent
> +*
> +**/
These comment blocks should not have a column of "*" to the left.
With tha
On 07/04/19 16:41, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v3
>
> Hi,
>
> I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc
> with the goal to make it work on both Xen
> Notes:
> v3:
> - cleanup .dsc, leave only one TimerLib resolution
> - Added a note in the commit message regarding the use of the local apic
> by runtime drivers
Good note -- yes, the warning in
"MdePkg/Library/SecPeiDxeTimerLibCpu/SecPeiDxeTimerLibCpu.inf&qu
extra parameter to indicate where to start the search for the
> boot firmware volume.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v3:
> - rebased, SPDX
>
allocate some space in the MEMFD for it. We use 'XPVH' as
> a signature (for "Xen PVH").
>
> [1] https://xenbits.xenproject.org/docs/unstable/misc/pvh.html
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Ack
; create mode 100644 OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm
Acked-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
(1) This patch is almost complete, just please update the comment style,
for this top-level comment, from
/*
* @file
* blah
*/
to:
/** @file
blah
**/
Please refer to e.g. "OvmfPkg/XenBusDxe/XenBusDxe.c".
With that comment style update:
Acked-by: Laszlo Ersek
Thanks
Laszlo
___
initialization fails if Xen has not been
> detected.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v3:
> - fix coding style in new code
> (use DEBUG_xxx,
++
> OvmfPkg/OvmfXen.fdf | 439 ++
> 2 files changed, 1168 insertions(+)
> create mode 100644 OvmfPkg/OvmfXen.dsc
> create mode 100644 OvmfPkg/OvmfXen.fdf
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hi Anthony,
On 07/04/19 16:41, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v3
>
> Hi,
>
> I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc
> with the goal to make it wor
On 04/30/19 18:35, Anthony PERARD wrote:
> On Fri, Apr 26, 2019 at 08:15:07PM +0200, Laszlo Ersek wrote:
>> On 04/25/19 22:23, Igor Druzhinin wrote:
>>> On Xen, hvmloader firmware leaves address decoding enabled for
>>> enumerated PCI device before jumping into OVMF. OVM
1 - 100 of 156 matches
Mail list logo
