Re: [PATCH 3/3] xen/acpi: upload power and performance related data from a PVH dom0

2023-03-16 Thread Josef Johansson
On 3/15/23 12:39, Roger Pau Monné wrote: On Mon, Jan 30, 2023 at 10:10:05AM +0100, Josef Johansson wrote: On 11/21/22 11:21, Roger Pau Monne wrote: When running as a PVH dom0 the ACPI MADT is crafted by Xen in order to report the correct numbers of vCPUs that dom0 has, so the host MADT is not

Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0

2023-02-03 Thread Josef Johansson
On 2/3/23 08:05, Jan Beulich wrote: On 30.01.2023 10:21, Josef Johansson wrote: On 11/21/22 11:21, Roger Pau Monne wrote: --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -346,3 +346,30 @@ void xen_arch_unregister_cpu(int num) } EXPORT_SYMBOL(xen_arch_unregister_cpu

Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0

2023-01-30 Thread Josef Johansson
On 11/21/22 11:21, Roger Pau Monne wrote: When running as a Xen dom0 the number of CPUs available to Linux can be different from the number of CPUs present on the system, but in order to properly fetch processor performance related data _PDC must be executed on all the physical CPUs online on the

Re: [PATCH 3/3] xen/acpi: upload power and performance related data from a PVH dom0

2023-01-30 Thread Josef Johansson
On 11/21/22 11:21, Roger Pau Monne wrote: When running as a PVH dom0 the ACPI MADT is crafted by Xen in order to report the correct numbers of vCPUs that dom0 has, so the host MADT is not provided to dom0. This creates issues when parsing the power and performance related data from ACPI dynami

Failed to terminate hdcp ta during suspend on Xen

2021-11-26 Thread Josef Johansson
Hi, I'm trying to solve problems during Suspend/Resume on Qubes OS (which is running Xen). What happens is that the resume works, but the screen blanks out each time I type a letter on the keyboard and then returns again, then after a while the screen just goes black. If I boot the same kernel w

Re: [PATCH] x86/smp: Factor out parts of native_smp_prepare_cpus()

2021-11-11 Thread Josef Johansson
On 11/11/21 11:15, Peter Zijlstra wrote: > On Wed, Nov 10, 2021 at 10:52:09PM +0100, Josef Johansson wrote: >> On 11/3/21 00:36, Boris Ostrovsky wrote: >>> Commit 66558b730f25 ("sched: Add cluster scheduler level for x86") >>> introduced cpu_l2c_shared_map mas

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-11-10 Thread Josef Johansson
On 11/10/21 21:30, Josef Johansson wrote: > On 11/4/21 00:45, Thomas Gleixner wrote: >> On Wed, Oct 27 2021 at 17:29, Josef Johansson wrote: >> >> CC+: EFIFB and scheduler folks >> >>> On 10/27/21 14:01, Josef Johansson wrote: >>> >>> printk:

Re: [PATCH] x86/smp: Factor out parts of native_smp_prepare_cpus()

2021-11-10 Thread Josef Johansson
On 11/3/21 00:36, Boris Ostrovsky wrote: > Commit 66558b730f25 ("sched: Add cluster scheduler level for x86") > introduced cpu_l2c_shared_map mask which is expected to be initialized > by smp_op.smp_prepare_cpus(). That commit only updated > native_smp_prepare_cpus() version but not xen_pv_smp_prep

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-11-10 Thread Josef Johansson
On 11/4/21 00:45, Thomas Gleixner wrote: > On Wed, Oct 27 2021 at 17:29, Josef Johansson wrote: > > CC+: EFIFB and scheduler folks > >> On 10/27/21 14:01, Josef Johansson wrote: >> >> printk: Suspending console(s) (use no_console_suspend to debug) >> [drm

Re: [PATCH v2] PCI/MSI: Move non-mask check back into low level accessors

2021-11-10 Thread Josef Johansson
On 11/10/21 14:31, Josef Johansson wrote: > On 11/9/21 15:53, Thomas Gleixner wrote: >> On Thu, Nov 04 2021 at 00:27, Thomas Gleixner wrote: >>> >>> - if (!entry->msi_attrib.is_virtual) { >>> + if (!entry->msi_attrib.can_mask) { >

Re: [PATCH v2] PCI/MSI: Move non-mask check back into low level accessors

2021-11-10 Thread Josef Johansson
On 11/9/21 15:53, Thomas Gleixner wrote: > On Thu, Nov 04 2021 at 00:27, Thomas Gleixner wrote: >> >> -if (!entry->msi_attrib.is_virtual) { >> +if (!entry->msi_attrib.can_mask) { > Groan. I'm a moron. This obviously needs to be > > if (entry->msi_attrib.can_m

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-11-04 Thread Josef Johansson
On 11/4/21 00:45, Thomas Gleixner wrote: > On Wed, Oct 27 2021 at 17:29, Josef Johansson wrote: > > CC+: EFIFB and scheduler folks > >> On 10/27/21 14:01, Josef Johansson wrote: >> When I suspend I get errors from Xen, including stacktraces below >> if anyone has any

BUG: arch/x86/mm/tlb.c:522 CR3 is not what we think

2021-10-27 Thread Josef Johansson
Hi, During suspend my kernel (v5.15-rc7) tries to disable non-boot CPUs, as it should. The first time the CPUs are offlined I get a BUG (it's WARN but it should be BUG if it could). The second time I suspend I get a WARN. I tried my very best to track what is happening during the first suspend an

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-10-27 Thread Josef Johansson
On 10/27/21 14:01, Josef Johansson wrote: > On 10/27/21 11:54, Josef Johansson wrote: >> On 10/27/21 11:50, Thomas Gleixner wrote: >>> The recent rework of PCI/MSI[X] masking moved the non-mask checks from the >>> low level accessors into the higher level mask/unmask fun

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-10-27 Thread Josef Johansson
On 10/27/21 11:54, Josef Johansson wrote: > On 10/27/21 11:50, Thomas Gleixner wrote: >> The recent rework of PCI/MSI[X] masking moved the non-mask checks from the >> low level accessors into the higher level mask/unmask functions. >> >> This missed the fact that the

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-10-27 Thread Josef Johansson
ons > combine them into one property of msi_desc::msi_attrib. > > Reported-by: Josef Johansson > Fixes: fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask > functions") > Signed-off-by: Thomas Gleixner > Cc: Jason Andryuk > Cc: Marc Zyngier > Cc: Bjor

Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV

2021-10-27 Thread Josef Johansson
On 10/27/21 08:24, David Woodhouse wrote: > On Mon, 2021-10-25 at 21:21 +0200, Josef Johansson wrote: >> + if (!(pci_msi_ignore_mask || entry->msi_attrib.is_virtual)) > Is it just me, or is that a lot easier to read if you write it as the > tautologically-identical (!p

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-26 Thread Josef Johansson
On 10/25/21 18:46, Josef Johansson wrote: > On 10/25/21 14:27, Jason Andryuk wrote: >> On Sun, Oct 24, 2021 at 9:26 PM Jason Andryuk wrote: >>> commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask >>> functions") introduc

Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV

2021-10-25 Thread Josef Johansson
On 10/25/21 03:25, Jason Andryuk wrote: > On Sun, Oct 24, 2021 at 2:55 PM Josef Johansson wrote: > >> I ended up with this patch, I also masked pci_set_mask and >> pci_set_unmask, even though patching __pci_restore_msi_state and >> __pci_restore_msi_state solved this prob

Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV

2021-10-25 Thread Josef Johansson
terrupts, which pci_msi_ignore_mask is used to indicate. >> >> This change avoids lockups in amdgpu drivers under Xen during boot. >> >> Fixes: commit 446a98b19fd6 ("PCI/MSI: Use new mask/unmask functions") >> Reported-by: Josef Johansson >> Signed-off-by:

Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV

2021-10-24 Thread Josef Johansson
On 10/21/21 10:25, Josef Johansson wrote: > On 10/20/21 16:03, Jason Andryuk wrote: >> Hi, Marc, >> >> Adding Juergen and Boris since this involves Xen. >> >> On Wed, Oct 20, 2021 at 8:51 AM Marc Zyngier wrote: >>> On Tue, 19 Oct 2021 22:48:19 +0100, &g

Deadlock when CONFIG_LOCKDEP=y

2021-10-24 Thread Josef Johansson
Hi! I'm running Qubes OS R4.1 which uses Xen as arch. Xen should be masking all MSI/MSI-X which is why I am running through rabbit holes trying to understand why my laptop gets odd errors while suspend/resume. Thus I'm building the kernel (v5.15-rc6) with a couple of debug-flags: CONFIG_PCI_DEBU

Re: [PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV

2021-10-21 Thread Josef Johansson
On 10/20/21 16:03, Jason Andryuk wrote: > Hi, Marc, > > Adding Juergen and Boris since this involves Xen. > > On Wed, Oct 20, 2021 at 8:51 AM Marc Zyngier wrote: >> On Tue, 19 Oct 2021 22:48:19 +0100, >> Josef Johansson wrote: >>> From: Josef Johansson &g

[PATCH v2] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV

2021-10-19 Thread Josef Johansson
From: Josef Johansson PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask functions") introduce functions pci_msi_update_mask() and pci_msix_write_vector_ctrl() that is missing checks for pci_msi_ignore

Re: [PATCH] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV

2021-10-19 Thread Josef Johansson
On 10/19/21 21:57, Bjorn Helgaas wrote: > [+cc Marc] > > On Mon, Oct 18, 2021 at 08:22:32AM +0200, Josef Johansson wrote: >> From: Josef Johansson >> >> >> PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV >> >> 'commit fcacdfbef5

[PATCH] PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV

2021-10-17 Thread Josef Johansson
From: Josef Johansson PCI/MSI: Re-add checks for skip masking MSI-X on Xen PV 'commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask functions")' introduced functions pci_msi_update_mask() and pci_msix_write_vector_ctrl() that were missing checks for pci_

Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79)

2021-10-12 Thread Josef Johansson
On 10/12/21 15:33, Josef Johansson wrote: > On 10/12/21 15:07, Jason Andryuk wrote: >> On Tue, Oct 12, 2021 at 2:09 AM Josef Johansson wrote: >>> On 10/11/21 21:34, Josef Johansson wrote: >>>> On 10/11/21 20:47, Josef Johansson wrote: >>>>> More

Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79)

2021-10-12 Thread Josef Johansson
On 10/12/21 15:07, Jason Andryuk wrote: > On Tue, Oct 12, 2021 at 2:09 AM Josef Johansson wrote: >> On 10/11/21 21:34, Josef Johansson wrote: >>> On 10/11/21 20:47, Josef Johansson wrote: >>>> More can be read over at freedesktop: >>>> https://gitlab.

Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79)

2021-10-11 Thread Josef Johansson
On 10/11/21 21:34, Josef Johansson wrote: > On 10/11/21 20:47, Josef Johansson wrote: >> Hi, >> >> I've got a late regression to this commit as well, but in the GPU area. >> The problem arises when booting it as XEN dom0. >> My hardware is Lenovo P14s Gen1