Re: [PATCH] block: remove unused parameter

2025-03-13 Thread Jinpu Wang
On Thu, Mar 13, 2025 at 6:14 AM Anuj Gupta wrote: > > request_queue param is not used by blk_rq_map_sg and __blk_rq_map_sg. > remove it. > > Signed-off-by: Anuj Gupta > --- > block/blk-merge.c | 4 ++-- > block/bsg-lib.c | 2 +- > drivers/block/mtip32xx/mtip

Re: [PATCH 10/11] rnbd-srv: use bdev_discard_alignment

2022-04-18 Thread Jinpu Wang
On Mon, Apr 18, 2022 at 6:53 AM Christoph Hellwig wrote: > > Use bdev_discard_alignment to calculate the correct discard alignment > offset even for partitions instead of just looking at the queue limit. > > Signed-off-by: Christoph Hellwig Thx! Acked-by: Jack Wang > --- > drivers/block/rnbd/rn

Re: [PATCH 11/19] rnbd-srv: remove struct rnbd_dev_blk_io

2022-01-24 Thread Jinpu Wang
On Mon, Jan 24, 2022 at 10:11 AM Christoph Hellwig wrote: > > Only the priv field of rnbd_dev_blk_io is used, so store the value of > that in bio->bi_private directly and remove the entire bio_set overhead. > > Signed-off-by: Christoph Hellwig Reviewed-by: Jack Wang Thanks! > --- > drivers/bloc

Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma

2022-01-20 Thread Jinpu Wang
On Thu, Jan 20, 2022 at 9:37 AM Christoph Hellwig wrote: > > On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote: > > this changes lead to IO error all the time, because bio_add_page return len. > > We need if (bio_add_page(bio, virt_to_p

Re: [PATCH 11/19] rnbd-src: remove struct rnbd_dev_blk_io

2022-01-19 Thread Jinpu Wang
On Tue, Jan 18, 2022 at 8:20 AM Christoph Hellwig wrote: > > Only the priv field of rnbd_dev_blk_io is used, so store the value of > that in bio->bi_private directly and remove the entire bio_set overhead. > > Signed-off-by: Christoph Hellwig there is one typo in the subject line, should be rnbd-

Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma

2022-01-18 Thread Jinpu Wang
On Wed, Jan 19, 2022 at 1:20 AM Jinpu Wang wrote: > > Hi Christoph, > > Thanks for the patch. > > On Tue, Jan 18, 2022 at 8:20 AM Christoph Hellwig wrote: > > > > The memory mapped in process_rdma is contiguous, so there is no need > > to loop over bio_add

Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma

2022-01-18 Thread Jinpu Wang
Hi Christoph, Thanks for the patch. On Tue, Jan 18, 2022 at 8:20 AM Christoph Hellwig wrote: > > The memory mapped in process_rdma is contiguous, so there is no need > to loop over bio_add_page. Remove rnbd_bio_map_kern and just open code > the bio allocation and mapping in the caller. > > Sign

Re: [PATCH 23/30] rnbd: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Jinpu Wang
On Wed, Jun 2, 2021 at 8:55 AM Christoph Hellwig wrote: > > Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and > request_queue allocation. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rnbd/rnbd-clt.c | 35 --- > 1 file changed, 8

Re: [PATCH 17/24] rbd: use set_capacity_and_notify

2020-11-11 Thread Jinpu Wang
On Wed, Nov 11, 2020 at 10:55 AM Ilya Dryomov wrote: > > On Wed, Nov 11, 2020 at 9:27 AM Christoph Hellwig wrote: > > > > Use set_capacity_and_notify to set the size of both the disk and block > > device. This also gets the uevent notifications for the resize for free. > > > > Signed-off-by: Chr

Re: [PATCH 18/24] rnbd: use set_capacity_and_notify

2020-11-08 Thread Jinpu Wang
On Fri, Nov 6, 2020 at 8:04 PM Christoph Hellwig wrote: > > Use set_capacity_and_notify to set the size of both the disk and block > device. This also gets the uevent notifications for the resize for free. > > Signed-off-by: Christoph Hellwig Thanks, Christoph! Acked-by: Jack Wang > --- > driv