Re: [Xen-devel] [PATCH v3 10/41] media/ivtv: convert put_page() to put_user_page*()

2019-08-07 Thread Hans Verkuil
sion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: John Hubbard Acked-by: Hans Verkuil Regards, Hans

Re: [Xen-devel] [PATCH v3 11/41] media/v4l2-core/mm: convert put_page() to put_user_page*()

2019-08-07 Thread Hans Verkuil
sion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Mauro Carvalho Chehab > Cc: Kees Cook > Cc: Hans Verkuil > Cc: Sakari Ailus > Cc: Jan Kara > Cc: Robin Murphy > Cc: Souptick Joarder > Cc: Da

Re: [Xen-devel] [PATCH v6 1/1] cameraif: add ABI for para-virtual camera

2019-03-22 Thread Hans Verkuil
s > - frame rates > 2. Support basic camera controls: > - contrast > - brightness > - hue > - saturation > 3. Support streaming control > > Signed-off-by: Oleksandr Andrushchenko Looks good! Reviewed-by: Hans Verkuil Thank you for all your work on this. R

Re: [Xen-devel] [PATCH v5 1/1] cameraif: add ABI for para-virtual camera

2019-03-12 Thread Hans Verkuil
On 3/12/19 10:35 AM, Oleksandr Andrushchenko wrote: > On 3/12/19 11:30 AM, Hans Verkuil wrote: >> On 3/12/19 10:08 AM, Oleksandr Andrushchenko wrote: >>> On 3/12/19 10:58 AM, Hans Verkuil wrote: >>>> Hi Oleksandr, >>>> >>>> Just one comment:

Re: [Xen-devel] [PATCH v5 1/1] cameraif: add ABI for para-virtual camera

2019-03-12 Thread Hans Verkuil
On 3/12/19 10:08 AM, Oleksandr Andrushchenko wrote: > On 3/12/19 10:58 AM, Hans Verkuil wrote: >> Hi Oleksandr, >> >> Just one comment: >> >> On 3/12/19 9:20 AM, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>&

Re: [Xen-devel] [PATCH v5 1/1] cameraif: add ABI for para-virtual camera

2019-03-12 Thread Hans Verkuil
Hi Oleksandr, Just one comment: On 3/12/19 9:20 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conferencing, In

Re: [Xen-devel] [PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-02-05 Thread Hans Verkuil
On 2/5/19 1:30 PM, Oleksandr Andrushchenko wrote: >> Sorry for paying so much attention to this, but I think it is important that >> this is documented precisely. > Thank you for helping with this - your comments are really > important and make the description precise. Ok, so finally: > >  * num_b

Re: [Xen-devel] [PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-02-05 Thread Hans Verkuil
On 2/5/19 12:44 PM, Oleksandr Andrushchenko wrote: > On 2/5/19 12:53 PM, Hans Verkuil wrote: >> On 2/5/19 11:44 AM, Oleksandr Andrushchenko wrote: >>> On 2/5/19 11:34 AM, Hans Verkuil wrote: >>>> On 2/5/19 9:48 AM, Oleksandr Andrushchenko wrote: >>>>>

Re: [Xen-devel] [PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-02-05 Thread Hans Verkuil
On 2/5/19 11:44 AM, Oleksandr Andrushchenko wrote: > On 2/5/19 11:34 AM, Hans Verkuil wrote: >> On 2/5/19 9:48 AM, Oleksandr Andrushchenko wrote: >>> On 1/23/19 10:14 AM, Oleksandr Andrushchenko wrote: >>>> Any comments from Xen community? >>>> Konrad? &

Re: [Xen-devel] [PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-02-05 Thread Hans Verkuil
On 2/5/19 9:48 AM, Oleksandr Andrushchenko wrote: > On 1/23/19 10:14 AM, Oleksandr Andrushchenko wrote: >> Any comments from Xen community? >> Konrad? > While I am still looking forward to any comments from Xen community... >> >> On 1/15/19 4:44 PM, Hans V

Re: [Xen-devel] [PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-01-15 Thread Hans Verkuil
Hi Oleksandr, Just two remaining comments: On 1/15/19 10:38 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conf

Re: [Xen-devel] [PATCH v3 1/1] cameraif: add ABI for para-virtual camera

2019-01-14 Thread Hans Verkuil
nrad, Xen-devel - do you have any objections/comments on this? > > Thank you, > Oleksandr > > On 12/17/18 9:37 AM, Oleksandr Andrushchenko wrote: >> Hello, Hans! >> >> Thank you for reviewing, please find my answers inline >> >> On 12/14/18 2:14 PM, Ha

Re: [Xen-devel] [PATCH v3 1/1] cameraif: add ABI for para-virtual camera

2018-12-14 Thread Hans Verkuil
Hi Oleksandr, This is looking a lot better than v2. I do have a few remaining comments about some things that are a bit unclear to me. On 12/12/18 10:49 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera drive

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/12/18 16:15, Oleksandr Andrushchenko wrote: > On 09/12/2018 04:38 PM, Hans Verkuil wrote: >> On 09/12/18 15:02, Oleksandr Andrushchenko wrote: >>> On 09/12/2018 03:25 PM, Hans Verkuil wrote: >>>>>>> + * formats >>>>>>> + *

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/12/18 15:02, Oleksandr Andrushchenko wrote: > On 09/12/2018 03:25 PM, Hans Verkuil wrote: >>>>> + * formats >>>>> + * Values: >>>>> + * >>>>> + * Formats are organized as a set of directories one per each >

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/12/18 12:09, Oleksandr Andrushchenko wrote: > Hi, Hans! > > Thank you for valuable comments and valid concerns! > > On 09/12/2018 10:52 AM, Hans Verkuil wrote: >> On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >&

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/11/18 10:29, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conferencing, In-Vehicle Infotainment, > high defin

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conferencing, In-Vehicle Infotainment, > high

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-11 Thread Hans Verkuil
On 09/11/18 09:14, Oleksandr Andrushchenko wrote: > On 09/11/2018 10:04 AM, Hans Verkuil wrote: >> On 09/11/2018 08:52 AM, Oleksandr Andrushchenko wrote: >>> Hi, Hans! >>> >>> On 09/10/2018 03:26 PM, Hans Verkuil wrote: >>>> On 09/10/2018 01:49 P

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-11 Thread Hans Verkuil
On 09/11/2018 08:52 AM, Oleksandr Andrushchenko wrote: > Hi, Hans! > > On 09/10/2018 03:26 PM, Hans Verkuil wrote: >> On 09/10/2018 01:49 PM, Oleksandr Andrushchenko wrote: >>> On 09/10/2018 02:09 PM, Hans Verkuil wrote: >>>> On 09/10/2018 11:52 AM, Oleksandr

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
On 09/10/2018 01:49 PM, Oleksandr Andrushchenko wrote: > On 09/10/2018 02:09 PM, Hans Verkuil wrote: >> On 09/10/2018 11:52 AM, Oleksandr Andrushchenko wrote: >>> On 09/10/2018 12:04 PM, Hans Verkuil wrote: >>>> On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wrote

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
On 09/10/2018 11:52 AM, Oleksandr Andrushchenko wrote: > On 09/10/2018 12:04 PM, Hans Verkuil wrote: >> On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wrote: >>> On 09/10/2018 10:53 AM, Hans Verkuil wrote: >>>> Hi Oleksandr, >>>> >>>>

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wrote: > On 09/10/2018 10:53 AM, Hans Verkuil wrote: >> Hi Oleksandr, >> >> On 09/10/2018 09:16 AM, Oleksandr Andrushchenko wrote: >>>> I suspect that you likely will want to support such sources eventually, so

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
On 09/10/2018 07:59 AM, Oleksandr Andrushchenko wrote: > Hi, Hans! > > On 09/09/2018 01:42 PM, Hans Verkuil wrote: >> On 09/04/2018 08:56 AM, Oleksandr Andrushchenko wrote: >>> On 09/03/2018 06:25 PM, Hans Verkuil wrote: >>>> Hi Oleksandr, >>>> >

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
Hi Oleksandr, On 09/10/2018 09:16 AM, Oleksandr Andrushchenko wrote: > Hi, Hans! > > On 09/09/2018 01:31 PM, Hans Verkuil wrote: >> Hi Oleksandr, >> >> Sorry for the delay in reviewing, I missed this patch until you pinged me, >> and >> I was very busy af

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-09 Thread Hans Verkuil
On 09/04/2018 08:56 AM, Oleksandr Andrushchenko wrote: > On 09/03/2018 06:25 PM, Hans Verkuil wrote: >> Hi Oleksandr, >> >> On 09/03/2018 12:16 PM, Oleksandr Andrushchenko wrote: >>> On 08/21/2018 08:54 AM, Oleksandr Andrushchenko wrote: >>>> On 08/14/20

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-09 Thread Hans Verkuil
Hi Oleksandr, Sorry for the delay in reviewing, I missed this patch until you pinged me, and I was very busy after that as well. On 07/31/2018 11:31 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver wh

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-03 Thread Hans Verkuil
Hi Oleksandr, On 09/03/2018 12:16 PM, Oleksandr Andrushchenko wrote: > On 08/21/2018 08:54 AM, Oleksandr Andrushchenko wrote: >> On 08/14/2018 11:30 AM, Juergen Gross wrote: >>> On 31/07/18 11:31, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the ABI for the