Re: [PATCH 0/9] hw/sysbus/platform-bus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE

2025-01-28 Thread Gerd Hoffmann
On Sat, Jan 25, 2025 at 07:13:34PM +0100, Philippe Mathieu-Daudé wrote: > Some SysBus devices can optionally be dynamically plugged onto > the sysbus-platform-bus (then virtual guests are aware of > mmio mapping and IRQs via device tree / ACPI rules). Do we have some sane way to have user-pluggabl

[PATCH v3 0/3] stdvga: fix screen blanking

2024-06-05 Thread Gerd Hoffmann
Gerd Hoffmann (3): stdvga: fix screen blanking ui+display: rename is_placeholder() -> surface_is_placeholder() ui+display: rename is_buffer_shared() -> surface_is_allocated() include/ui/surface.h| 6 +++--- hw/display/qxl-render.c | 2 +- hw/display/vga.c

[PATCH v3 2/3] ui+display: rename is_placeholder() -> surface_is_placeholder()

2024-06-05 Thread Gerd Hoffmann
No functional change. Signed-off-by: Gerd Hoffmann --- include/ui/surface.h | 2 +- ui/console.c | 2 +- ui/sdl2-2d.c | 2 +- ui/sdl2-gl.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/ui/surface.h b/include/ui/surface.h index

[PATCH v3 1/3] stdvga: fix screen blanking

2024-06-05 Thread Gerd Hoffmann
/qemu-project/qemu/-/issues/2067 Signed-off-by: Gerd Hoffmann --- hw/display/vga.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/display/vga.c b/hw/display/vga.c index 30facc6c8e33..474b6b14c327 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1762,6 +1762,12 @@ static void

[PATCH v3 3/3] ui+display: rename is_buffer_shared() -> surface_is_allocated()

2024-06-05 Thread Gerd Hoffmann
Boolean return value is reversed, to align with QEMU_ALLOCATED_FLAG, so all callers must be adapted. Also rename share_surface variable in vga_draw_graphic() to reduce confusion. No functional change. Suggested-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- include/ui/surface.h

Re: [PATCH v2 1/3] stdvga: fix screen blanking

2024-06-05 Thread Gerd Hoffmann
On Tue, Jun 04, 2024 at 10:27:18AM GMT, Marc-André Lureau wrote: > Hi > > > +if (is_buffer_shared(surface)) { > > Perhaps the suggestion to rename the function (in the following patch) > should instead be surface_is_allocated() ? that would match the actual > flag check. But callers would hav

[PATCH v2 3/3] ui+display: rename is_placeholder -> surface_is_placeholder

2024-06-03 Thread Gerd Hoffmann
No functional change. Signed-off-by: Gerd Hoffmann --- include/ui/surface.h | 2 +- ui/console.c | 2 +- ui/sdl2-2d.c | 2 +- ui/sdl2-gl.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/ui/surface.h b/include/ui/surface.h index

[PATCH v2 1/3] stdvga: fix screen blanking

2024-06-03 Thread Gerd Hoffmann
/qemu-project/qemu/-/issues/2067 Signed-off-by: Gerd Hoffmann --- hw/display/vga.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/display/vga.c b/hw/display/vga.c index 30facc6c8e33..474b6b14c327 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1762,6 +1762,12 @@ static void

[PATCH v2 0/3] stdvga: fix screen blanking

2024-06-03 Thread Gerd Hoffmann
Gerd Hoffmann (3): stdvga: fix screen blanking ui+display: rename is_buffer_shared() -> surface_is_borrowed() ui+display: rename is_placeholder -> surface_is_placeholder include/ui/surface.h| 4 ++-- hw/display/qxl-render.c | 2 +- hw/display/vga.c| 14 ++--

[PATCH v2 2/3] ui+display: rename is_buffer_shared() -> surface_is_borrowed()

2024-06-03 Thread Gerd Hoffmann
No functional change. Suggested-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- include/ui/surface.h| 2 +- hw/display/qxl-render.c | 2 +- hw/display/vga.c| 10 +- hw/display/xenfb.c | 4 ++-- ui/console.c| 2 +- 5 files changed, 10 insertions

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-21 Thread Gerd Hoffmann
Hi, > As virtio drivers are by design paravirt drivers ,I think it is reasonable > to accept some knowledge with and cooperation with the host to manage > suspend/resume. Fair point. In any case this needs a feature flag, so guest and host can negotiate whenever this is supported or not. virt

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-21 Thread Gerd Hoffmann
On Tue, Jun 20, 2023 at 01:26:15PM +0100, Robert Beckett wrote: > > On 20/06/2023 10:41, Gerd Hoffmann wrote: > >Hi, > > > > > > The guest driver should be able to restore resources after resume. > > > Thank you for your suggestion! > > > As f

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-20 Thread Gerd Hoffmann
Hi, > > The guest driver should be able to restore resources after resume. > > Thank you for your suggestion! > As far as I know, resources are created on host side and guest has no backup, > if resources are destroyed, guest can't restore them. > Or do you mean guest driver need to send comma

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-19 Thread Gerd Hoffmann
Hi, > Adding a new command requires new feature flag (and maybe it should be in > the <0x1000 range instead) > > But I am not sure we need a new message at the virtio-gpu level. Gerd, wdyt? > > Maybe it's not a good place to reset all GPU resources during QEMU reset() > after all, if it's call

seabios 1.16.2 release tagged (was: Re: [SeaBIOS] Re: [SeaBIOS PATCH] xen: require Xen info structure at). 0x1000 to detect Xen

2023-03-16 Thread Gerd Hoffmann
Hi, > Ok, we have as of today two changes: > > kraxel@sirius ~/projects/seabios (master)# git log --oneline rel-1.16.1.. > ea1b7a073390 xen: require Xen info structure at 0x1000 to detect Xen > 645a64b4911d usb: fix wrong init of keyboard/mouse's if first interface is > not boot protocol

Re: [SeaBIOS] Re: [SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen

2023-03-09 Thread Gerd Hoffmann
On Tue, Mar 07, 2023 at 08:42:18AM +, David Woodhouse wrote: > On Thu, 2023-02-02 at 10:10 +0100, Gerd Hoffmann wrote: > > > Thanks, Kevin. > > > > > > I'd like to get the rest of the Xen platform support in to qemu 8.0 > > > if > >

Re: [SeaBIOS] Re: [SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen

2023-02-02 Thread Gerd Hoffmann
> Thanks, Kevin. > > I'd like to get the rest of the Xen platform support in to qemu 8.0 if > possible. Which is currently scheduled for March. > > Is there likely to be a SeaBIOS release before then which Gerd would > pull into qemu anyway, or should I submit a submodule update to a > snapshot o

[PULL 12/15] virtio-gpu: update done only on the scanout associated with rect

2022-06-14 Thread Gerd Hoffmann
From: Dongwon Kim It only needs to update the scanouts containing the rect area coming with the resource-flush request from the guest. Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim Message-Id: <20220505214030.4261-1-dongwon@intel.com> Signed-off-by: Gerd Ho

[PULL 11/15] usbredir: avoid queuing hello packet on snapshot restore

2022-06-14 Thread Gerd Hoffmann
ot; Signed-off-by: Joelle van Dyne Message-Id: <20220507041850.98716-...@getutm.app> Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index fd7df599bc0b..1bd30efc3ef0 100644

Re: [PULL 00/16] Kraxel 20220613 patches

2022-06-14 Thread Gerd Hoffmann
On Mon, Jun 13, 2022 at 08:52:21AM -0700, Richard Henderson wrote: > On 6/13/22 04:36, Gerd Hoffmann wrote: > > The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac: > > > >Merge tag 'mips-20220611' of https://github.com/philmd/qemu into

[PULL 14/15] ui: Deliver refresh rate via QemuUIInfo

2022-06-14 Thread Gerd Hoffmann
ns, and prevents frequent changes of the display mode. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-3-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- include/ui/gtk.h | 2 +- hw/display/xenfb.c | 14 +++--- ui/consol

[PULL 15/15] virtio-gpu: Respect UI refresh rate for EDID

2022-06-14 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-4-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu.c| 1 + 3 files changed, 3 inse

[PULL 10/15] hw/usb/hcd-ehci: fix writeback order

2022-06-14 Thread Gerd Hoffmann
it no longer fails) This problem was previously reported as a seabios problem in https://mail.coreboot.org/hyperkitty/list/seab...@seabios.org/thread/OUTHT5ISSQJGXPNTUPY3O5E5EPZJCHM3/ and as a nixos CI build failure in https://github.com/NixOS/nixpkgs/issues/170803 Signed-off-by: Arnout Engelen

[PULL 13/15] ui/console: Do not return a value with ui_info

2022-06-14 Thread Gerd Hoffmann
From: Akihiko Odaki The returned value is not used and misleading. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-2-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- hw/display/virtio-gpu-base.c | 6 +++--- hw/display/virtio

[PULL 09/15] MAINTAINERS: add myself as CanoKey maintainer

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0df25ed4b0a3..4cf6174f9f37 100644 --- a/MAINTAINERS +++ b/M

[PULL 05/15] hw/usb/canokey: Add trace events

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.c| 13 + hw/usb/trace-events | 16 2 files changed, 29 insertions(+) diff --git a/hw/usb/canokey.c b/hw/usb/canok

[PULL 07/15] docs: Add CanoKey documentation

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/device-emulation.rst | 1 + docs/system/devices/canokey.rst | 168 +++ 2 files changed, 169 insertions(+) create mode 1

[PULL 06/15] meson: Add CanoKey

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- meson_options.txt | 2 ++ hw/usb/Kconfig| 5 + hw/usb/meson.build| 5 + meson.build | 6 +

[PULL 04/15] hw/usb: Add CanoKey Implementation

2022-06-14 Thread Gerd Hoffmann
B part was implemented in QEMU using QEMU's USB APIs, therefore the emulated CanoKey can communicate with the guest OS using USB. Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.h | 69 +++ hw/usb/

[PULL 08/15] docs/system/devices/usb: Add CanoKey to USB devices examples

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/devices/usb.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst index afb7d6c2268d..87

[PULL 01/15] ui/gtk-gl-area: implement GL context destruction

2022-06-14 Thread Gerd Hoffmann
From: Volker Rümelin The counterpart function for gd_gl_area_create_context() is currently empty. Implement the gd_gl_area_destroy_context() function to avoid GL context leaks. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-1-vr_q...@t-online.de> Signed-off-by: Gerd Ho

[PULL 02/15] ui/gtk-gl-area: create the requested GL context version

2022-06-14 Thread Gerd Hoffmann
;t have the latest OpenGL extensions fully implemented. An example for this is the Intel i965 driver on a Haswell processor. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-2-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann --- ui/gtk-gl-area.c | 31 +++

[PULL 03/15] ui/cocoa: Fix poweroff request code

2022-06-14 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220529082508.89097-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m

[PULL 00/15] Kraxel 20220614 patches

2022-06-14 Thread Gerd Hoffmann
The following changes since commit debd0753663bc89c86f5462a53268f2e3f680f60: Merge tag 'pull-testing-next-140622-1' of https://github.com/stsquad/qemu into staging (2022-06-13 21:10:57 -0700) are available in the Git repository at: git://git.kraxel.org/qemu tags/kraxel-20220614-pull-request

Re: [PULL 00/16] Kraxel 20220613 patches

2022-06-14 Thread Gerd Hoffmann
> > Hmm, build worked here and CI passed too. > > > > I think this is one of those cases where the build directory must be > > deleted because one subdirectory is replaced by a compatibility > > symlink. > > Except 'configure' deals with that, as it explicitly rm -rf's the > symlink target: > >

Re: [PULL 00/16] Kraxel 20220613 patches

2022-06-14 Thread Gerd Hoffmann
On Mon, Jun 13, 2022 at 08:52:21AM -0700, Richard Henderson wrote: > On 6/13/22 04:36, Gerd Hoffmann wrote: > > The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac: > > > >Merge tag 'mips-20220611' of https://github.com/philmd/qemu into

[PULL 16/16] ui: move 'pc-bios/keymaps' to 'ui/keymaps'

2022-06-13 Thread Gerd Hoffmann
e source tree to the build tree. Signed-off-by: Daniel P. Berrangé Message-Id: <20220613084456.470068-1-berra...@redhat.com> Signed-off-by: Gerd Hoffmann --- configure | 4 pc-bios/meson.build | 1 - {pc-bios => ui}/keymaps/ar | 0

[PULL 12/16] virtio-gpu: update done only on the scanout associated with rect

2022-06-13 Thread Gerd Hoffmann
From: Dongwon Kim It only needs to update the scanouts containing the rect area coming with the resource-flush request from the guest. Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim Message-Id: <20220505214030.4261-1-dongwon@intel.com> Signed-off-by: Gerd Ho

[PULL 11/16] usbredir: avoid queuing hello packet on snapshot restore

2022-06-13 Thread Gerd Hoffmann
ot; Signed-off-by: Joelle van Dyne Message-Id: <20220507041850.98716-...@getutm.app> Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index fd7df599bc0b..1bd30efc3ef0 100644

[PULL 14/16] ui: Deliver refresh rate via QemuUIInfo

2022-06-13 Thread Gerd Hoffmann
ns, and prevents frequent changes of the display mode. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-3-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- include/ui/gtk.h | 2 +- hw/display/xenfb.c | 14 +++--- ui/consol

[PULL 13/16] ui/console: Do not return a value with ui_info

2022-06-13 Thread Gerd Hoffmann
From: Akihiko Odaki The returned value is not used and misleading. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-2-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- hw/display/virtio-gpu-base.c | 6 +++--- hw/display/virtio

[PULL 15/16] virtio-gpu: Respect UI refresh rate for EDID

2022-06-13 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-4-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu.c| 1 + 3 files changed, 3 inse

[PULL 10/16] hw/usb/hcd-ehci: fix writeback order

2022-06-13 Thread Gerd Hoffmann
it no longer fails) This problem was previously reported as a seabios problem in https://mail.coreboot.org/hyperkitty/list/seab...@seabios.org/thread/OUTHT5ISSQJGXPNTUPY3O5E5EPZJCHM3/ and as a nixos CI build failure in https://github.com/NixOS/nixpkgs/issues/170803 Signed-off-by: Arnout Engelen

[PULL 07/16] docs: Add CanoKey documentation

2022-06-13 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/device-emulation.rst | 1 + docs/system/devices/canokey.rst | 168 +++ 2 files changed, 169 insertions(+) create mode 1

[PULL 09/16] MAINTAINERS: add myself as CanoKey maintainer

2022-06-13 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0df25ed4b0a3..4cf6174f9f37 100644 --- a/MAINTAINERS +++ b/M

[PULL 03/16] ui/cocoa: Fix poweroff request code

2022-06-13 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220529082508.89097-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m

[PULL 04/16] hw/usb: Add CanoKey Implementation

2022-06-13 Thread Gerd Hoffmann
B part was implemented in QEMU using QEMU's USB APIs, therefore the emulated CanoKey can communicate with the guest OS using USB. Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.h | 69 +++ hw/usb/

[PULL 06/16] meson: Add CanoKey

2022-06-13 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- meson_options.txt | 2 ++ hw/usb/Kconfig| 5 + hw/usb/meson.build| 5 + meson.build | 6 +

[PULL 01/16] ui/gtk-gl-area: implement GL context destruction

2022-06-13 Thread Gerd Hoffmann
From: Volker Rümelin The counterpart function for gd_gl_area_create_context() is currently empty. Implement the gd_gl_area_destroy_context() function to avoid GL context leaks. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-1-vr_q...@t-online.de> Signed-off-by: Gerd Ho

[PULL 00/16] Kraxel 20220613 patches

2022-06-13 Thread Gerd Hoffmann
The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac: Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging (2022-06-11 21:13:27 -0700) are available in the Git repository at: git://git.kraxel.org/qemu tags/kraxel-20220613-pull-request for you to f

[PULL 08/16] docs/system/devices/usb: Add CanoKey to USB devices examples

2022-06-13 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/devices/usb.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst index afb7d6c2268d..87

[PULL 05/16] hw/usb/canokey: Add trace events

2022-06-13 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.c| 13 + hw/usb/trace-events | 16 2 files changed, 29 insertions(+) diff --git a/hw/usb/canokey.c b/hw/usb/canok

[PULL 02/16] ui/gtk-gl-area: create the requested GL context version

2022-06-13 Thread Gerd Hoffmann
;t have the latest OpenGL extensions fully implemented. An example for this is the Intel i965 driver on a Haswell processor. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-2-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann --- ui/gtk-gl-area.c | 31 +++

[PULL 15/17] ui/console: Do not return a value with ui_info

2022-06-10 Thread Gerd Hoffmann
From: Akihiko Odaki The returned value is not used and misleading. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-2-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- hw/display/virtio-gpu-base.c | 6 +++--- hw/display/virtio

[PULL 13/17] virtio-gpu: update done only on the scanout associated with rect

2022-06-10 Thread Gerd Hoffmann
From: Dongwon Kim It only needs to update the scanouts containing the rect area coming with the resource-flush request from the guest. Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim Message-Id: <20220505214030.4261-1-dongwon@intel.com> Signed-off-by: Gerd Ho

[PULL 14/17] ui: move 'pc-bios/keymaps' to 'ui/keymaps'

2022-06-10 Thread Gerd Hoffmann
ime arrangement does not need to be reflected in the source tree arrangement. These keymaps logically belong with the UI code. Signed-off-by: Daniel P. Berrangé Message-Id: <20220426160150.812530-1-berra...@redhat.com> Signed-off-by: Gerd Hoffmann --- pc-bios/meson.build

[PULL 17/17] virtio-gpu: Respect UI refresh rate for EDID

2022-06-10 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-4-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu.c| 1 + 3 files changed, 3 inse

[PULL 16/17] ui: Deliver refresh rate via QemuUIInfo

2022-06-10 Thread Gerd Hoffmann
ns, and prevents frequent changes of the display mode. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-3-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- include/ui/gtk.h | 2 +- hw/display/xenfb.c | 14 +++--- ui/consol

[PULL 12/17] usbredir: avoid queuing hello packet on snapshot restore

2022-06-10 Thread Gerd Hoffmann
ot; Signed-off-by: Joelle van Dyne Message-Id: <20220507041850.98716-...@getutm.app> Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index fd7df599bc0b..1bd30efc3ef0 100644

[PULL 11/17] hw/usb/hcd-ehci: fix writeback order

2022-06-10 Thread Gerd Hoffmann
it no longer fails) This problem was previously reported as a seabios problem in https://mail.coreboot.org/hyperkitty/list/seab...@seabios.org/thread/OUTHT5ISSQJGXPNTUPY3O5E5EPZJCHM3/ and as a nixos CI build failure in https://github.com/NixOS/nixpkgs/issues/170803 Signed-off-by: Arnout Engelen

[PULL 09/17] docs/system/devices/usb: Add CanoKey to USB devices examples

2022-06-10 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/devices/usb.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst index afb7d6c2268d..87

[PULL 10/17] MAINTAINERS: add myself as CanoKey maintainer

2022-06-10 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5580a36b68e1..4ae9d707d5b0 100644 --- a/MAINTAINERS +++ b/M

[PULL 08/17] docs: Add CanoKey documentation

2022-06-10 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/device-emulation.rst | 1 + docs/system/devices/canokey.rst | 168 +++ 2 files changed, 169 insertions(+) create mode 1

[PULL 07/17] meson: Add CanoKey

2022-06-10 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- meson_options.txt | 2 ++ hw/usb/Kconfig| 5 + hw/usb/meson.build| 5 + meson.build | 6 +

[PULL 05/17] hw/usb: Add CanoKey Implementation

2022-06-10 Thread Gerd Hoffmann
B part was implemented in QEMU using QEMU's USB APIs, therefore the emulated CanoKey can communicate with the guest OS using USB. Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.h | 69 +++ hw/usb/

[PULL 02/17] ui/gtk-gl-area: create the requested GL context version

2022-06-10 Thread Gerd Hoffmann
;t have the latest OpenGL extensions fully implemented. An example for this is the Intel i965 driver on a Haswell processor. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-2-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann --- ui/gtk-gl-area.c | 31 +++

[PULL 06/17] hw/usb/canokey: Add trace events

2022-06-10 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.c| 13 + hw/usb/trace-events | 16 2 files changed, 29 insertions(+) diff --git a/hw/usb/canokey.c b/hw/usb/canok

[PULL 04/17] hw/audio/cs4231a: Const'ify global tables

2022-06-10 Thread Gerd Hoffmann
From: Bernhard Beschow The tables contain spcifically crafted constants for algorithms, so make them immutable. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220520180109.8224-3-shen...@gmail.com> Signed-off-by: Gerd Hoffmann --- hw/audio/cs4231a

[PULL 00/17] Kraxel 20220610 patches

2022-06-10 Thread Gerd Hoffmann
The following changes since commit 9cc1bf1ebca550f8d90f967ccd2b6d2e00e81387: Merge tag 'pull-xen-20220609' of https://xenbits.xen.org/git-http/people/aperard/qemu-dm into staging (2022-06-09 08:25:17 -0700) are available in the Git repository at: git://git.kraxel.org/qemu tags/kraxel-20220

[PULL 03/17] ui/cocoa: Fix poweroff request code

2022-06-10 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220529082508.89097-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m

[PULL 01/17] ui/gtk-gl-area: implement GL context destruction

2022-06-10 Thread Gerd Hoffmann
From: Volker Rümelin The counterpart function for gd_gl_area_create_context() is currently empty. Implement the gd_gl_area_destroy_context() function to avoid GL context leaks. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-1-vr_q...@t-online.de> Signed-off-by: Gerd Ho

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
Hi, > > > > (1) add refresh_rate > > > > (2) update users one by one > > > > (3) finally drop update_interval when no user is left. > > > > > > > > thanks, > > > > Gerd > > > > > > > > > > I think 1 and 3 should have to be done once since refresh_rate and > > > update_interval would inter

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
On Thu, Jun 09, 2022 at 08:45:41PM +0900, Akihiko Odaki wrote: > On 2022/06/09 19:28, Gerd Hoffmann wrote: > > > --- a/include/ui/console.h > > > +++ b/include/ui/console.h > > > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { > > > int

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
> --- a/include/ui/console.h > +++ b/include/ui/console.h > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { > int yoff; > uint32_t width; > uint32_t height; > +uint32_t refresh_rate; > } QemuUIInfo; > > /* cursor data format is 32bit RGBA */ > @@ -426,7 +427,6 @@ typ

Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID

2021-03-10 Thread Gerd Hoffmann
Hi, > -static void xenfb_update_interval(void *opaque, uint64_t interval) > +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) > -.update_interval = xenfb_update_interval, > +.ui_info = xenfb_ui_info, Hmm, I suspect xenfb really wants the actual refresh rate,

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021-03-03 Thread Gerd Hoffmann
On Fri, Feb 26, 2021 at 01:47:38PM +0900, Akihiko Odaki wrote: > 2021年2月25日(木) 20:46 Gerd Hoffmann : > > > > Hi, > > > > > > Because of the wasted frames I'd like this to be an option you can > > > > enable when needed. For the majorit

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021-02-25 Thread Gerd Hoffmann
Hi, > > Because of the wasted frames I'd like this to be an option you can > > enable when needed. For the majority of use cases this seems to be > > no problem ... > > I see blinks with GNOME on Wayland on Ubuntu 20.04 and virtio-gpu with > the EDID change included in this patch. /me looks c

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021-02-24 Thread Gerd Hoffmann
On Tue, Feb 23, 2021 at 01:50:51PM +0900, Akihiko Odaki wrote: > 2021年2月22日(月) 19:57 Gerd Hoffmann : > > > > On Sun, Feb 21, 2021 at 10:34:14PM +0900, Akihiko Odaki wrote: > > > This change introduces an additional member, refresh_rate to > > > qemu_edid_

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021-02-22 Thread Gerd Hoffmann
On Sun, Feb 21, 2021 at 10:34:14PM +0900, Akihiko Odaki wrote: > This change introduces an additional member, refresh_rate to > qemu_edid_info in include/hw/display/edid.h. > > This change also isolates the graphics update interval from the > display update interval. The guest will update the fram

Re: [PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-08 Thread Gerd Hoffmann
> > > The comments I've found suggest very much not ... Or is that all very > > > old stuff only that no one cares about anymore? > > > > I think these days it is possible to override dma_ops per device, which > > in turn allows virtio to deal with the quirks without the rest of the > > kernel kno

Re: [PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-07 Thread Gerd Hoffmann
On Mon, Sep 07, 2020 at 03:53:02PM +0200, Daniel Vetter wrote: > On Mon, Sep 7, 2020 at 1:24 PM Gerd Hoffmann wrote: > > > > Add drm_device argument to drm_prime_pages_to_sg(), so we can > > call dma_max_mapping_size() to figure the segment size limit > > and call into

[PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-07 Thread Gerd Hoffmann
gnore segment size limits so far ... v2: place max_segment in drm driver not gem object. v3: move max_segment next to the other gem fields. v4: just use dma_max_mapping_size(). Signed-off-by: Gerd Hoffmann --- include/drm/drm_prime.h | 3 ++- drivers/gpu/drm/amd/a

Re: [PATCH v2 1/2] drm: allow limiting the scatter list size.

2020-09-06 Thread Gerd Hoffmann
> > + /** > > +* @max_segment: > > +* > > +* Max size for scatter list segments. When unset the default > > +* (SCATTERLIST_MAX_SEGMENT) is used. > > +*/ > > + size_t max_segment; > > Is there no better place for this then "at the bottom"? drm_device is a > huge structure,

[PATCH v3 1/2] drm: allow limiting the scatter list size.

2020-09-06 Thread Gerd Hoffmann
drm driver not gem object. v3: move max_segment next to the other gem fields. Signed-off-by: Gerd Hoffmann --- include/drm/drm_device.h| 8 include/drm/drm_prime.h | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 3 ++- drivers/gpu/drm

[PATCH v2 1/2] drm: allow limiting the scatter list size.

2020-08-18 Thread Gerd Hoffmann
drm driver not gem object. Signed-off-by: Gerd Hoffmann --- include/drm/drm_device.h| 8 include/drm/drm_prime.h | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 3 ++- drivers/gpu/drm/drm_gem_shmem_helper.c | 3 ++- drivers/gpu/drm

Re: [PATCH 1/2] drm: allow limiting the scatter list size.

2020-08-18 Thread Gerd Hoffmann
Hi, > > > I'm missing an explanation why this should be useful (it certainly is). > > virtio-gpu needs this to work properly with SEV (see patch 2/2 of this > > series). > > Yeah, that's the problem patch 2/2 never showed up here :) The list should have everything. Your inbox probably has 1/2

Re: [PATCH 1/2] drm: allow limiting the scatter list size.

2020-08-18 Thread Gerd Hoffmann
On Tue, Aug 18, 2020 at 09:57:59AM +0200, Christian König wrote: > Am 18.08.20 um 09:48 schrieb Gerd Hoffmann: > > Add max_segment argument to drm_prime_pages_to_sg(). When set pass it > > through to the __sg_alloc_table_from_pages() call, otherwise use > > SCATTERLIST_MAX_S

[PATCH 1/2] drm: allow limiting the scatter list size.

2020-08-18 Thread Gerd Hoffmann
Add max_segment argument to drm_prime_pages_to_sg(). When set pass it through to the __sg_alloc_table_from_pages() call, otherwise use SCATTERLIST_MAX_SEGMENT. Also add max_segment field to gem objects and pass it to drm_prime_pages_to_sg() calls in drivers and helpers. Signed-off-by: Gerd

Re: [PATCH 00/26] hw/usb: Give it love, reduce 'hw/usb.h' inclusion out of hw/usb/

2020-07-13 Thread Gerd Hoffmann
On Sat, Jul 04, 2020 at 04:49:17PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > This is the second time I try to replace a magic typename string > by a constant, and Zoltan warns me this is counter productive as > "hw/usb.h" pulls in an insane amount of code. > > Time to give the usb subsystem

[PULL 2/4] microvm: drop max-ram-below-4g support

2020-06-17 Thread Gerd Hoffmann
Not useful for microvm and allows users to shoot themself into the foot (make ram + mmio overlap). Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Acked-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-id: 20200529073957.8018-3-kra

[PULL 4/4] microvm: move virtio base to 0xfeb00000

2020-06-17 Thread Gerd Hoffmann
Place virtio-mmio devices near the other mmio regions, next ioapic is at @ 0xfec0. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Paul Durrant Acked-by: Paolo Bonzini Message-id

[PULL 3/4] x86: move max-ram-below-4g to pc

2020-06-17 Thread Gerd Hoffmann
Move from X86MachineClass to PCMachineClass so it disappears from microvm machine type property list. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov Reviewed-by: Paul Durrant Message-id

[PULL 0/4] Microvm 20200617 patches

2020-06-17 Thread Gerd Hoffmann
fig tweaks ---- Gerd Hoffmann (4): microvm: use 3G split unconditionally microvm: drop max-ram-below-4g support x86: move max-ram-below-4g to pc microvm: move virtio base to 0xfeb0 include/hw/i386/microvm.h | 2 +- include/hw/i386/pc.h | 2 ++ include/hw/

[PULL 1/4] microvm: use 3G split unconditionally

2020-06-17 Thread Gerd Hoffmann
hough. So split @ 3G unconditionally. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Acked-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Message-id: 20200529073957.8018-2-kra...@redhat.com --- hw/i386/microvm.c | 16 +--- 1 file chang

Re: [PATCH v3 0/4] microvm: memory config tweaks

2020-06-17 Thread Gerd Hoffmann
On Mon, Jun 08, 2020 at 03:25:07PM +0200, Gerd Hoffmann wrote: > Ping. Anyone going to pick this up? MAINTAINERS lists Sergio+Paolo ... > Or should I send a pull req myself? Hmm, no reply. I guess that means "send a pull req" ... take care, Gerd

Re: [PATCH v3 0/4] microvm: memory config tweaks

2020-06-08 Thread Gerd Hoffmann
On Fri, May 29, 2020 at 09:39:53AM +0200, Gerd Hoffmann wrote: > With more microvm memory config tweaks split this into its owns series, > the microvm acpi patch series is already big enough ... > > v2: > - use 3G split. > - add patch to move virtio-mmio region. > - p

[PATCH v3 3/4] x86: move max-ram-below-4g to pc

2020-05-29 Thread Gerd Hoffmann
Move from X86MachineClass to PCMachineClass so it disappears from microvm machine type property list. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini --- include/hw/i386/pc.h | 2 ++ include/hw/i386/x86.h | 4 hw/i386/pc.c | 46

[PATCH v3 0/4] microvm: memory config tweaks

2020-05-29 Thread Gerd Hoffmann
With more microvm memory config tweaks split this into its owns series, the microvm acpi patch series is already big enough ... v2: - use 3G split. - add patch to move virtio-mmio region. - pick up acks & reviews. v3: - fix xen build. - pick up acks & reviews. take care, Ge

[PATCH v3 2/4] microvm: drop max-ram-below-4g support

2020-05-29 Thread Gerd Hoffmann
Not useful for microvm and allows users to shoot themself into the foot (make ram + mmio overlap). Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Acked-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/microvm.c | 19 --- 1 file changed, 19 deletions

[PATCH v3 1/4] microvm: use 3G split unconditionally

2020-05-29 Thread Gerd Hoffmann
hough. So split @ 3G unconditionally. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Acked-by: Paolo Bonzini --- hw/i386/microvm.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/hw/i386/microvm.c b/hw/i386/micr

  1   2   >