Hi,
On 9/28/20 12:36 PM, Marek Marczykowski-Górecki wrote:
> On Mon, Sep 28, 2020 at 07:02:19AM +0200, Jürgen Groß wrote:
>> On 27.09.20 13:14, Marek Marczykowski-Górecki wrote:
>>> Hi all,
>>>
>>> I get kernel panic on 'floppy' module load. If I blacklist the module,
>>> then everything works.
>>
Use kstrdup() instead of opencoded alloc and copy. kzalloc() is
excessive here.
Signed-off-by: Denis Efremov
---
drivers/net/xen-netback/xenbus.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index
On 31.08.2019 19:45, Markus Elfring wrote:
+# nested likely/unlikely calls
+ if ($line =~
/\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) {
+ WARN("LIKELY_MISUSE",
>>>
>>> How do you think about to use the specification
>>> “(?:IS_ERR(?
On 31.08.2019 12:15, Markus Elfring wrote:
>> +# nested likely/unlikely calls
>> + if ($line =~
>> /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) {
>> + WARN("LIKELY_MISUSE",
>
> How do you think about to use the specification
> “(?:IS_ERR(?:_(?:OR_NULL|
/1559767582-11081-1-git-send-email-i...@metux.net/
Signed-off-by: Denis Efremov
Cc: Joe Perches
Cc: Andrew Morton
Cc: Andy Whitcroft
---
scripts/checkpatch.pl | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 93a7edfe0f05..56969ce06df4
"unlikely(WARN(x))" is excessive. WARN() already uses unlikely()
internally.
Signed-off-by: Denis Efremov
Cc: Boris Ostrovsky
Cc: Juergen Gross
Cc: Joe Perches
Cc: Andrew Morton
Cc: xen-devel@lists.xenproject.org
---
drivers/xen/events/events_base.c | 2 +-
1 file changed, 1 inser
