Re: [PATCH 3/3] xen/EFI: Drop __ASSEMBLY__ ifdefary in efi.h

2025-07-29 Thread Daniel Smith
On Thu, 05 Jun 2025 07:16:38 -0400 Andrew Cooper wrote --- > There's already C outside of the ifdefary, proving that it's not included in > any assembly files. > > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné >

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-07-29 Thread Daniel Smith
On Thu, 05 Jun 2025 07:16:36 -0400 Andrew Cooper wrote --- > The format of the buildid is a property of the binary, not a property of how > it was loaded. This fixes buildid recognition when starting xen.efi from > it's > MB2 entrypoint. > > Suggested-by: Ross Lagerwall > Si

Re: [PATCH 3/3] tools/flask: Reformat allow declarations

2025-07-29 Thread Daniel Smith
On Mon, 28 Jul 2025 13:55:48 -0400 Andrew Cooper wrote --- > Having multiple values wrapped onto as few lines as practical is good for > space efficiency, but causes complex collisions for hypercall backports and > local policy changes. Reformat to use one value per line. > > No

Re: [PATCH 2/3] tools/flask: Use tabs uniformly

2025-07-29 Thread Daniel Smith
On Mon, 28 Jul 2025 13:55:47 -0400 Andrew Cooper wrote --- > Most indentation is with tabs, but a few spaces have slipped in. Switch > them > back to tabs. > > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Daniel P. Smith > --- > tools/flask/p

Re: [PATCH 1/3] tools/flask: Strip trailing whitespace

2025-07-29 Thread Daniel Smith
On Mon, 28 Jul 2025 13:55:46 -0400 Andrew Cooper wrote --- > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Daniel P. Smith > --- > tools/flask/policy/modules/modules.conf | 2 +- > tools/flask/policy/modules/vm_role.cons | 4 ++--

Re: [PATCH 0/2] Enable the ability to disable/remove gnttabv2

2025-01-10 Thread Daniel Smith
On Fri, 10 Jan 2025 08:37:09 -0500 Daniel P. Smith wrote --- > OpenXT has carried a patch for some time that allows the disabling and > removal > of the grant table v2 capability. This is a rework of that patch in an > attempt > to make an upstreamable series. > > The original

Re: [PATCH] SUPPORT.md: split XSM from Flask

2024-07-30 Thread Daniel Smith
On Tue, 30 Jul 2024 08:58:03 -0400 Jan Beulich wrote --- > On 30.07.2024 14:35, Andrew Cooper wrote: > > On 30/07/2024 11:57 am, Jan Beulich wrote: > >> XSM is a generic framework, which in particular is also used by SILO. > >> With this it can't really be experimental: Arm enables SI

Re: [PATCH] SUPPORT.md: split XSM from Flask

2024-07-30 Thread Daniel Smith
On Tue, 30 Jul 2024 08:04:09 -0400 Jan Beulich wrote --- > On 30.07.2024 13:37, Daniel Smith wrote: > > On Tue, 30 Jul 2024 06:57:08 -0400 Jan Beulich wrote --- > > > > > XSM is a generic framework, which in particular is also used by SILO. > >

Re: [PATCH] SUPPORT.md: split XSM from Flask

2024-07-30 Thread Daniel Smith
On Tue, 30 Jul 2024 06:57:08 -0400 Jan Beulich wrote --- > XSM is a generic framework, which in particular is also used by SILO. > With this it can't really be experimental: Arm enables SILO by default. > > Signed-off-by: Jan Beulich jbeul...@suse.com> > > --- a/SUPPORT.md > +

Re: [PATCH] XSM/domctl: Fix permission checks on XEN_DOMCTL_createdomain

2024-07-30 Thread Daniel Smith
On Mon, 29 Jul 2024 12:26:51 -0400 Andrew Cooper wrote --- > The XSM checks for XEN_DOMCTL_createdomain are problematic. There's a split > between xsm_domctl() called early, and flask_domain_create() called quite > late > during domain construction. > > All XSM implementations e

Re: [PATCH v3 02/10] xen/version: Introduce non-truncating deterministically-signed XENVER_* subops

2023-08-16 Thread Daniel Smith
On Wed, 16 Aug 2023 05:55:07 -0400 George Dunlap wrote --- > > > On Wed, Aug 16, 2023 at 3:58 AM Andrew Cooper andrew.coop...@citrix.com> > wrote: > On 16/08/2023 1:19 am, Stefano Stabellini wrote: > > On Tue, 15 Aug 2023, Andrew Cooper wrote: > > >> diff --git a/xen/include/pu

Re: [XEN PATCH v2] build: add --full to version.sh to guess $(XEN_FULLVERSION)

2021-09-27 Thread Daniel Smith
Apologies for any formatting issues, responding via web mail client. On Thu, 09 Sep 2021 10:33:06 -0400 Anthony PERARD wrote > Running $(MAKE) like that in a $(shell ) while parsing the Makefile > doesn't work reliably. In some case, make will complain with > "jobserver unavailab

Re: [RFC PATCH] xsm: Re-work domain_create and domain_alloc_security

2020-10-26 Thread Daniel Smith
On Mon, 26 Oct 2020 09:46:51 -0400 Jason Andryuk wrote > Untested! > > This only really matters for flask, but all of xsm is updated. > > flask_domain_create() and flask_domain_alloc_security() are a strange > pair. > > flask_domain_create() serves double duty. It bo

Re: XSM and the idle domain

2020-10-22 Thread Daniel Smith
On Thu, 22 Oct 2020 04:13:53 -0400 Jan Beulich wrote > On 22.10.2020 03:23, Daniel P. Smith wrote: > > On 10/21/20 10:34 AM, Hongyan Xia wrote: > >> Also, should idle domain be restricted? IMO the idle domain is Xen > >> itself which mostly bootstraps the system and performs lim

[BUG] PVH ACPI XSDT table construction

2020-05-26 Thread Daniel Smith
Greetings, I was reviewing the ACPI construction for PVH and discovered what I believe is a flaw in the logic for selecting the XSDT tables. The current logic is, static bool __init pvh_acpi_xsdt_table_allowed(const char *sig,    unsigned long add

[Xen-devel] Notes from December 2019 Xen F2F in Cambridge

2020-01-28 Thread Daniel Smith
Xen Community meeting at Citrix, December 2019 == *Combined Notes from Christopher Clark and Daniel P. Smith* # Day One @ Xen meeting ## Attendees - Daniel Smith (Apertus Solutions/TrenchBoot/OpenXT) - Christopher Clark (OpenXT) - Rich Persaud

Re: [Xen-devel] Running xenstored in Linux stubdom

2019-09-06 Thread Daniel Smith
On Wed, Sep 4, 2019 at 1:26 PM Daniel Smith wrote: > > On Wed, Sep 4, 2019 at 12:12 PM Juergen Gross wrote: > > > > The stubdom gets an event channel to use for dom0 xenbstore connection > > via commandline parameter ("--event "). This needs to be used >

Re: [Xen-devel] Running xenstored in Linux stubdom

2019-09-04 Thread Daniel Smith
On Wed, Sep 4, 2019 at 12:12 PM Juergen Gross wrote: > > The stubdom gets an event channel to use for dom0 xenbstore connection > via commandline parameter ("--event "). This needs to be used > in the stubdom for setting up the communication path. > > > Juergen Hi Juergen, Thanks for the quick r

[Xen-devel] Running xenstored in Linux stubdom

2019-09-04 Thread Daniel Smith
Greetings, I am attempting to see if I can get xenstored to run within a Linux stubdom for a variety of reasons. The way I have it constructed at this point is that embedded within the initramfs of dom0 is the linux stubdom image along with the init-xenstore-domain helper. The init script within t