Re: [RESEND PATCH v3 1/1] kern/xen: Add Xen command line parsing

2025-08-04 Thread Daniel Kiper
On Sun, Aug 03, 2025 at 10:57:03AM -0500, Aaron Rainbolt wrote: > On Fri, 1 Aug 2025 14:55:36 +0200 Daniel Kiper wrote: > > On Fri, Jul 25, 2025 at 03:31:12PM -0500, Aaron Rainbolt wrote: > > > Xen traditionally allows customizing guest behavior by passing > > > argumen

Re: [RESEND PATCH v3 1/1] kern/xen: Add Xen command line parsing

2025-08-01 Thread Daniel Kiper
On Fri, Jul 25, 2025 at 03:31:12PM -0500, Aaron Rainbolt wrote: > Xen traditionally allows customizing guest behavior by passing arguments > to the VM kernel via the kernel command line. This is no longer possible > when using GRUB with Xen, as the kernel command line is decided by the > GRUB confi

Re: [PATCH 4/5] multiboot2: parse console= option when setting GOP mode

2022-12-13 Thread Daniel Kiper
Sorry for late reply... On Mon, Dec 05, 2022 at 04:10:28PM +0100, Jan Beulich wrote: > On 23.11.2022 16:45, Roger Pau Monne wrote: > > Only set the GOP mode if vga is selected in the console option, > > otherwise just fetch the information from the current mode in order to > > make it available to

Re: [PATCH v5] templates: introduce GRUB_TOP_LEVEL_* vars

2022-11-03 Thread Daniel Kiper
h into a list so that we can > > optionally apply grub_move_to_front() to the list before the loop. > > > > [0]: https://aur.archlinux.org/packages/grub-linux-default-hook > > [1]: https://aur.archlinux.org/packages/grub-linux-rt-default-hook > > > > Signed-off-by: Denton Liu > > Reviewed-by: Oskari Pirhonen Reviewed-by: Daniel Kiper If I do not hear any objections in a week or so I will merge this patch. Daniel

Re: [PATCH v3 2/5] xen/x86: manually build xen.mb.efi binary

2021-06-09 Thread Daniel Kiper
On Wed, May 19, 2021 at 04:35:00PM +0200, Jan Beulich wrote: > On 19.05.2021 14:48, Daniel Kiper wrote: > > On Wed, May 19, 2021 at 11:29:43AM +0200, Jan Beulich wrote: > >> On 18.05.2021 19:46, Daniel Kiper wrote: > >>> On Mon, May 17, 2021 at 03:24:28PM +0200

Re: [PATCH v3 2/5] xen/x86: manually build xen.mb.efi binary

2021-05-19 Thread Daniel Kiper
On Wed, May 19, 2021 at 11:29:43AM +0200, Jan Beulich wrote: > On 18.05.2021 19:46, Daniel Kiper wrote: > > On Mon, May 17, 2021 at 03:24:28PM +0200, Jan Beulich wrote: > >> On 17.05.2021 15:20, Daniel Kiper wrote: > >>> On Mon, May 17, 2021 at 08:48:32AM +0200

Re: [PATCH v3 2/5] xen/x86: manually build xen.mb.efi binary

2021-05-18 Thread Daniel Kiper
On Mon, May 17, 2021 at 03:24:28PM +0200, Jan Beulich wrote: > On 17.05.2021 15:20, Daniel Kiper wrote: > > On Mon, May 17, 2021 at 08:48:32AM +0200, Jan Beulich wrote: > >> On 07.05.2021 22:26, Bob Eshleman wrote: > >>> What is your intuition WRT the idea that i

Re: [PATCH v3 2/5] xen/x86: manually build xen.mb.efi binary

2021-05-17 Thread Daniel Kiper
On Mon, May 17, 2021 at 08:48:32AM +0200, Jan Beulich wrote: > On 07.05.2021 22:26, Bob Eshleman wrote: > > What is your intuition WRT the idea that instead of trying add a PE/COFF hdr > > in front of Xen's mb2 bin, we instead go the route of introducing valid mb2 > > entry points into xen.efi? > >

Re: multiboot2 and module2 boot issues via GRUB2

2021-04-08 Thread Daniel Kiper
On Thu, Apr 01, 2021 at 08:43:46PM +0100, Andrew Cooper via Grub-devel wrote: > On 01/04/2021 09:44, Roger Pau Monné wrote: > > On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: > >> On 01.04.2021 03:06, Roman Shaposhnik wrote: > >>> And the obvious next question: is my EVE usecase esote

[SPECIFICATION RFC] The firmware and bootloader log specification

2020-11-13 Thread Daniel Kiper
Hey, This is next attempt to create firmware and bootloader log specification. Due to high interest among industry it is an extension to the initial bootloader log only specification. It takes into the account most of the comments which I got up until now. The goal is to pass all logs produced by

Re: [BOOTLOADER SPECIFICATION RFC] The bootloader log format for TrenchBoot and others

2020-06-01 Thread Daniel Kiper
On Fri, May 29, 2020 at 10:11:40AM -0700, Andy Lutomirski wrote: > > On May 29, 2020, at 4:30 AM, Daniel Kiper wrote: > > > > Hey, > > > > Below you can find my rough idea of the bootloader log format which is > > generic thing but initially will be used for T

[BOOTLOADER SPECIFICATION RFC] The bootloader log format for TrenchBoot and others

2020-05-29 Thread Daniel Kiper
Hey, Below you can find my rough idea of the bootloader log format which is generic thing but initially will be used for TrenchBoot work. I discussed this proposal with Ross and Daniel S. So, the idea went through initial sanitization. Now I would like to take feedback from other folks too. So, pl

Re: [GRUB PATCH 0/2] Better Xen support

2020-05-20 Thread Daniel Kiper
we are carrying some patches. Here they are > for your consideration. > > Regards, Ian. > > Ian Jackson (2): > 20_linux_xen: Ignore xenpolicy and config files too > 20_linux_xen: Support Xen Security Modules (XSM/FLASK) Reviewed-by: Daniel Kiper Daniel

Re: [RFC] UEFI Secure Boot on Xen Hosts

2020-05-01 Thread Daniel Kiper
On Fri, May 01, 2020 at 12:27:17AM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Apr 29, 2020 at 05:51:08PM -0500, Bobby Eshleman wrote: > > # Option #3: Lean on Grub2's LoadFile2() Verification > > > > Grub2 will provide a LoadFile2() method to subsequent programs that supports > > signature

Re: [RFC] UEFI Secure Boot on Xen Hosts

2020-04-30 Thread Daniel Kiper
Adding Ard... On Thu, Apr 30, 2020 at 09:01:45AM +0200, Jan Beulich wrote: > On 30.04.2020 00:51, Bobby Eshleman wrote: > > Hey all, > > > > We're looking to develop UEFI Secure Boot support for grub-loaded Xen and > > ultimately for XCP-ng (I'm on the XCP-ng team at Vates). > > > > In addition to

[Xen-devel] [tip: x86/boot] x86/boot: Introduce kernel_info.setup_type_max

2019-11-12 Thread tip-bot2 for Daniel Kiper
The following commit has been merged into the x86/boot branch of tip: Commit-ID: 00cd1c154d565c62ad5e065bf3530f68bdf59490 Gitweb: https://git.kernel.org/tip/00cd1c154d565c62ad5e065bf3530f68bdf59490 Author:Daniel Kiper AuthorDate:Tue, 12 Nov 2019 14:46:39 +01:00 Committer

[Xen-devel] [tip: x86/boot] x86/boot: Introduce kernel_info

2019-11-12 Thread tip-bot2 for Daniel Kiper
The following commit has been merged into the x86/boot branch of tip: Commit-ID: 2c33c27fd6033ced942c9a591b8ac15c07c57d70 Gitweb: https://git.kernel.org/tip/2c33c27fd6033ced942c9a591b8ac15c07c57d70 Author:Daniel Kiper AuthorDate:Tue, 12 Nov 2019 14:46:38 +01:00 Committer

[Xen-devel] [tip: x86/boot] x86/boot: Introduce setup_indirect

2019-11-12 Thread tip-bot2 for Daniel Kiper
The following commit has been merged into the x86/boot branch of tip: Commit-ID: b3c72fc9a78e74161f9d05ef7191706060628f8c Gitweb: https://git.kernel.org/tip/b3c72fc9a78e74161f9d05ef7191706060628f8c Author:Daniel Kiper AuthorDate:Tue, 12 Nov 2019 14:46:40 +01:00 Committer

[Xen-devel] [PATCH v6 1/3] x86/boot: Introduce the kernel_info

2019-11-12 Thread Daniel Kiper
abled bootloader would be expected to copy into a setup_data chunk. Do not bump setup_header version in arch/x86/boot/header.S because it will be followed by additional changes coming into the Linux/x86 boot protocol. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Reviewed-

[Xen-devel] [PATCH v6 2/3] x86/boot: Introduce the kernel_info.setup_type_max

2019-11-12 Thread Daniel Kiper
This field contains maximal allowed type for setup_data. Do not bump setup_header version in arch/x86/boot/header.S because it will be followed by additional changes coming into the Linux/x86 boot protocol. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Reviewed-by: Konrad

[Xen-devel] [PATCH v6 0/3] x86/boot: Introduce the kernel_info et consortes

2019-11-12 Thread Daniel Kiper
insertions(+), 16 deletions(-) Daniel Kiper (3): x86/boot: Introduce the kernel_info x86/boot: Introduce the kernel_info.setup_type_max x86/boot: Introduce the setup_indirect ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [PATCH v6 3/3] x86/boot: Introduce the setup_indirect

2019-11-12 Thread Daniel Kiper
memory are occupied by kernel data. Thus introduce an uniform way to specify such indirect data as setup_indirect struct and SETUP_INDIRECT type. And finally bump setup_header version in arch/x86/boot/header.S. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Acked-by: Konrad

Re: [Xen-devel] [PATCH v5 2/3] x86/boot: Introduce the kernel_info.setup_type_max

2019-11-08 Thread Daniel Kiper
On Fri, Nov 08, 2019 at 02:03:38PM +0100, Borislav Petkov wrote: > On Fri, Nov 08, 2019 at 01:52:48PM +0100, Daniel Kiper wrote: > > OK, got your comments. I will repost the patch series probably on Tuesday. > > I hope that it will land in 5.5 then. > > I don't see why n

Re: [Xen-devel] [PATCH v5 2/3] x86/boot: Introduce the kernel_info.setup_type_max

2019-11-08 Thread Daniel Kiper
On Fri, Nov 08, 2019 at 12:07:03PM +0100, Borislav Petkov wrote: > On Fri, Nov 08, 2019 at 11:47:02AM +0100, Daniel Kiper wrote: > > Yeah, you are right. Would you like me to repost whole patch series or > > could you fix it before committing? > > Lemme finish looking at patc

Re: [Xen-devel] [PATCH v5 2/3] x86/boot: Introduce the kernel_info.setup_type_max

2019-11-08 Thread Daniel Kiper
On Fri, Nov 08, 2019 at 11:09:30AM +0100, Borislav Petkov wrote: > On Mon, Nov 04, 2019 at 04:13:53PM +0100, Daniel Kiper wrote: > > This field contains maximal allowed type for setup_data. > > > > This patch does not bump setup_header version in arch/x86/boot/header.S &

Re: [Xen-devel] [PATCH v5 0/3] x86/boot: Introduce the kernel_info et consortes

2019-11-07 Thread Daniel Kiper
On Wed, Nov 06, 2019 at 09:56:48AM -0800, h...@zytor.com wrote: > On November 6, 2019 9:03:33 AM PST, Borislav Petkov wrote: > >On Mon, Nov 04, 2019 at 04:13:51PM +0100, Daniel Kiper wrote: > >> Hi, > >> > >> Due to very limited space in the setup_header th

Re: [Xen-devel] [PATCH v4 2/3] x86/boot: Introduce the kernel_info.setup_type_max

2019-11-04 Thread Daniel Kiper
On Fri, Nov 01, 2019 at 01:55:57PM -0700, H. Peter Anvin wrote: > On 2019-10-24 04:48, Daniel Kiper wrote: > > This field contains maximal allowed type for setup_data. > > > > Now bump the setup_header version in arch/x86/boot/header.S. > > Please don't bump the p

[Xen-devel] [PATCH v5 0/3] x86/boot: Introduce the kernel_info et consortes

2019-11-04 Thread Daniel Kiper
insertions(+), 16 deletions(-) Daniel Kiper (3): x86/boot: Introduce the kernel_info x86/boot: Introduce the kernel_info.setup_type_max x86/boot: Introduce the setup_indirect ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [PATCH v5 2/3] x86/boot: Introduce the kernel_info.setup_type_max

2019-11-04 Thread Daniel Kiper
This field contains maximal allowed type for setup_data. This patch does not bump setup_header version in arch/x86/boot/header.S because it will be followed by additional changes coming into the Linux/x86 boot protocol. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Reviewed

[Xen-devel] [PATCH v5 1/3] x86/boot: Introduce the kernel_info

2019-11-04 Thread Daniel Kiper
abled bootloader would be expected to copy into a setup_data chunk. This patch does not bump setup_header version in arch/x86/boot/header.S because it will be followed by additional changes coming into the Linux/x86 boot protocol. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Revi

[Xen-devel] [PATCH v5 3/3] x86/boot: Introduce the setup_indirect

2019-11-04 Thread Daniel Kiper
memory are occupied by kernel data. Thus we introduce an uniform way to specify such indirect data as setup_indirect struct and SETUP_INDIRECT type. And finally bump setup_header version in arch/x86/boot/header.S. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Acked-by: Konrad

[Xen-devel] [PATCH v4 3/3] x86/boot: Introduce the setup_indirect

2019-10-24 Thread Daniel Kiper
memory are occupied by kernel data. Thus we introduce an uniform way to specify such indirect data as setup_indirect struct and SETUP_INDIRECT type. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Acked-by: Konrad Rzeszutek Wilk Reviewed-by: Ross Philipson Reviewed-by: H. Peter

[Xen-devel] [PATCH v4 2/3] x86/boot: Introduce the kernel_info.setup_type_max

2019-10-24 Thread Daniel Kiper
This field contains maximal allowed type for setup_data. Now bump the setup_header version in arch/x86/boot/header.S. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk Reviewed-by: Ross Philipson Reviewed-by: H. Peter Anvin (Intel

[Xen-devel] [PATCH v4 1/3] x86/boot: Introduce the kernel_info

2019-10-24 Thread Daniel Kiper
abled bootloader would be expected to copy into a setup_data chunk. This patch does not bump setup_header version in arch/x86/boot/header.S because it will be followed by additional changes coming into the Linux/x86 boot protocol. Suggested-by: H. Peter Anvin (Intel) Signed-off-by: Daniel Kiper Revi

[Xen-devel] [PATCH v4 0/3] x86/boot: Introduce the kernel_info et consortes

2019-10-24 Thread Daniel Kiper
insertions(+), 16 deletions(-) Daniel Kiper (3): x86/boot: Introduce the kernel_info x86/boot: Introduce the kernel_info.setup_type_max x86/boot: Introduce the setup_indirect ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes

2019-10-16 Thread Daniel Kiper
On Wed, Oct 09, 2019 at 12:53:55PM +0200, Daniel Kiper wrote: > Hi, > > Due to very limited space in the setup_header this patch series introduces new > kernel_info struct which will be used to convey information from the kernel to > the bootloader. This way the boot protocol

Re: [Xen-devel] [PATCH v3 1/3] x86/boot: Introduce the kernel_info

2019-10-10 Thread Daniel Kiper
On Wed, Oct 09, 2019 at 05:43:31PM -0700, Randy Dunlap wrote: > Hi, > > Questions and comments below... > Thanks. > > On 10/9/19 3:53 AM, Daniel Kiper wrote: > > > Suggested-by: H. Peter Anvin > > Signed-off-by: Daniel Kiper > > Reviewed-by: Konrad Rzeszute

[Xen-devel] [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes

2019-10-09 Thread Daniel Kiper
, 292 insertions(+), 16 deletions(-) Daniel Kiper (3): x86/boot: Introduce the kernel_info x86/boot: Introduce the kernel_info.setup_type_max x86/boot: Introduce the setup_indirect ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [PATCH v3 2/3] x86/boot: Introduce the kernel_info.setup_type_max

2019-10-09 Thread Daniel Kiper
This field contains maximal allowed type for setup_data. Now bump the setup_header version in arch/x86/boot/header.S. Suggested-by: H. Peter Anvin Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk Reviewed-by: Ross Philipson --- Documentation/x86/boot.rst | 9

[Xen-devel] [PATCH v3 3/3] x86/boot: Introduce the setup_indirect

2019-10-09 Thread Daniel Kiper
memory are occupied by kernel data. Thus we introduce an uniform way to specify such indirect data as setup_indirect struct and SETUP_INDIRECT type. Suggested-by: H. Peter Anvin Signed-off-by: Daniel Kiper Acked-by: Konrad Rzeszutek Wilk Reviewed-by: Ross Philipson --- v3 - suggestions/fixes

[Xen-devel] [PATCH v3 1/3] x86/boot: Introduce the kernel_info

2019-10-09 Thread Daniel Kiper
abled bootloader would be expected to copy into a setup_data chunk. This patch does not bump setup_header version in arch/x86/boot/header.S because it will be followed by additional changes coming into the Linux/x86 boot protocol. Suggested-by: H. Peter Anvin Signed-off-by: Daniel Kiper Reviewed-

Re: [Xen-devel] [PATCH 3/4] x86/linker: add a reloc section to ELF binary

2019-06-24 Thread Daniel Kiper
On Fri, Jun 21, 2019 at 12:34:13AM -0600, Jan Beulich wrote: > >>> On 19.06.19 at 17:06, wrote: > > On Wed, Jun 19, 2019 at 06:57:05AM -0600, Jan Beulich wrote: > >> >>> On 19.06.19 at 13:02, wrote: > >> > If the hypervisor has been built with EFI support (ie: multiboot2). > >> > This allows to p

Re: [Xen-devel] Fedora - make BLS configs default - Xen Dom0 boot broken

2019-05-16 Thread Daniel Kiper
On Wed, May 15, 2019 at 02:02:57PM +0100, M A Young wrote: > On Wed, 15 May 2019, Daniel Kiper wrote: > > > FYI, another Xen Dom0 boot issue on Fedora... > > > > Please take a look at [1]. This will break Xen Dom0 boot due to lack of > > support for multiboot, m

[Xen-devel] Fedora - make BLS configs default - Xen Dom0 boot broken

2019-05-15 Thread Daniel Kiper
Hey, FYI, another Xen Dom0 boot issue on Fedora... Please take a look at [1]. This will break Xen Dom0 boot due to lack of support for multiboot, multiboot2, module, and module2 commands. If we care then this has to be fixed somehow... Again, I can coordinate work and review patches but I cannot

Re: [Xen-devel] Criteria / validation proposal: drop Xen

2019-04-29 Thread Daniel Kiper
I have not heard that Peter moved to the Oracle ;-))), so, changing his address back to RedHat one. And dropping Fedora testing mailing list address because I do not have permissions to send to it... On Mon, Apr 29, 2019 at 10:51:47AM +0200, Daniel Kiper wrote: > Sorry for top posting... >

Re: [Xen-devel] Criteria / validation proposal: drop Xen

2019-04-29 Thread Daniel Kiper
Sorry for top posting... FYI, I am on vacation right now. I will be back next week. So, if it is not urgent I will explain all the stuff and update relevant bug at the beginning of next week. Sorry for delay. Daniel On Sun, Apr 28, 2019 at 12:44:37PM +1000, Steven Haigh wrote: > (and sending to

Re: [Xen-devel] GRUB Xen PVH chainloading

2019-01-16 Thread Daniel Kiper
econd-stage PVH boot > > loader should be installed into the guest filesystem as > > /boot/xen/pvhboot-.elf, and otherwise things generally behave the > > same way. I'd be happy to draft a patch to the protocol specification > > once a proof-of-concept exists. >

Re: [Xen-devel] [RFC v1] kexec: Prototype for signature verification within Xen

2019-01-15 Thread Daniel Kiper
On Tue, Jan 15, 2019 at 03:15:28PM +0100, Simon Horman wrote: > On Mon, Jan 14, 2019 at 01:52:07PM -0600, Eric DeVolder wrote: > > These changes work in conjunction with the signature > > verification support for Xen I published recently. > > > > Prior to this change, kexec supported the following

Re: [Xen-devel] [PATCH v7 00/20] xen: add pvh guest support

2018-12-07 Thread Daniel Kiper
On Fri, Dec 07, 2018 at 01:11:28PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > platform grub is booted as a standalone image directly by Xen. > > For booting Linux kernel it is us

Re: [Xen-devel] [PATCH v6.1 09/20] xen: add basic hooks for PVH in current code

2018-12-07 Thread Daniel Kiper
eds > to get GRUB_KERNEL_USE_RSDP_ADDR from there. This in turn requires to > add an empty kernel.h header for some i386 platforms (efi, coreboot, > ieee1275, xen). > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > V3: xenpvh->xen_pvh (Daniel Kiper) > ad

Re: [Xen-devel] [GRUB PATCH 1/2] verifiers: Xen fallout cleanup

2018-12-06 Thread Daniel Kiper
On Thu, Dec 06, 2018 at 10:37:43AM -0500, Ross Philipson wrote: > On 12/06/2018 08:40 AM, Daniel Kiper wrote: > > Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for > > fine-grained signature-verification controlling). > > > > Signed-off-by: Daniel Ki

Re: [Xen-devel] [PATCH v6 09/20] xen: add basic hooks for PVH in current code

2018-12-06 Thread Daniel Kiper
eds > to get GRUB_KERNEL_USE_RSDP_ADDR from there. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > V3: xenpvh->xen_pvh (Daniel Kiper) > adjust copyright date (Roger Pau Monné) > V5: update commit message (Daniel Kiper) > move including xen/hvm/start_info.

[Xen-devel] [GRUB PATCH 2/2] verifiers: ARM Xen fallout cleanup

2018-12-06 Thread Daniel Kiper
ARM Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for fine-grained signature-verification controlling). Signed-off-by: Daniel Kiper --- grub-core/loader/arm64/xen_boot.c | 8 include/grub/file.h | 5 + 2 files changed, 9 insertions(+), 4 deletions

[Xen-devel] [GRUB PATCH 1/2] verifiers: Xen fallout cleanup

2018-12-06 Thread Daniel Kiper
Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for fine-grained signature-verification controlling). Signed-off-by: Daniel Kiper --- grub-core/loader/i386/xen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/grub-core/loader/i386/xen.c b

[Xen-devel] [GRUB PATCH 0/2] verifiers: Fallout cleanup

2018-12-06 Thread Daniel Kiper
/xen.c | 14 +++--- include/grub/file.h | 5 + 3 files changed, 16 insertions(+), 11 deletions(-) Daniel Kiper (2): verifiers: Xen fallout cleanup verifiers: ARM Xen fallout cleanup ___ Xen-devel mailing list Xen

Re: [Xen-devel] Make grub error "too few arguments" with xen

2018-12-04 Thread Daniel Kiper
> Signed-off-by: Vladimir Serbinenko > Signed-off-by: Daniel Kiper > Reviewed-by: Ross Philipson > > Make steps and Error log: > > cd grub > ./autogen.sh > ./configure --target=amd64 --with-platform=xen --prefix=${PWD}/../pvgrub2 > make > .. > load

Re: [Xen-devel] [PATCH v6 00/20] xen: add pvh guest support

2018-11-29 Thread Daniel Kiper
On Thu, Nov 29, 2018 at 01:40:35PM +0100, Hans van Kranenburg wrote: > Hi Daniel, > > On 11/29/18 1:22 PM, Daniel Kiper wrote: > > On Wed, Nov 28, 2018 at 02:55:10PM +0100, Juergen Gross wrote: > >> This patch series adds support for booting Linux as PVH guest. > >

Re: [Xen-devel] [PATCH v6 00/20] xen: add pvh guest support

2018-11-29 Thread Daniel Kiper
On Wed, Nov 28, 2018 at 02:55:10PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > platform grub is booted as a standalone image directly by Xen. > > For booting Linux kernel it is us

Re: [Xen-devel] [PATCH v6 16/20] grub-module-verifier: Ignore all_video for xenpvh

2018-11-29 Thread Daniel Kiper
oddeps section" > > > > Also see: > > - 6371e9c10433578bb236a8284ddb9ce9e201eb59 > > - https://savannah.gnu.org/bugs/?49012 > > > > Signed-off-by: Hans van Kranenburg > > Reviewed-by: Daniel Kiper > > Just a small detail... The xenpvh in the subject was not renamed to > xen

Re: [Xen-devel] [PATCH v6 11/20] xen: setup hypercall page for PVH

2018-11-29 Thread Daniel Kiper
Gross > Reviewed-by: Roger Pau Monné > --- > V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) > issue panic message (Roger Pau Monné) > rewrite grub_xen_hypercall to avoid register variables (Daniel Kiper) > V5: Use XEN_HVM_DEBUGCONS_IOPORT from Xen unst

Re: [Xen-devel] [PATCH v5 01/20] xen: add some xen headers

2018-11-28 Thread Daniel Kiper
Xen 4.10 being the first Xen version with > full (not only experimental) PVH guest support. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper When I apply this patch I get this: Applying: xen: add some xen headers .git/rebase-apply/patch:723: trailing whitespace.

Re: [Xen-devel] [PATCH v5 11/20] xen: setup hypercall page for PVH

2018-11-28 Thread Daniel Kiper
On Tue, Nov 27, 2018 at 09:31:10PM +0100, Daniel Kiper wrote: > On Wed, Nov 21, 2018 at 03:28:46PM +0100, Juergen Gross wrote: > > Add the needed code to setup the hypercall page for calling into the > > Xen hypervisor. > > > > Import the XEN_HVM_DEBUGCONS_IOPORT de

Re: [Xen-devel] [PATCH v5 15/20] xen_pvh: add build runes for grub-core

2018-11-27 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 03:28:50PM +0100, Juergen Gross wrote: > Add the modifications to the build system needed to build a xen_pvh > grub. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > V3: sorted some filenames (Daniel Kiper) > V4: add bus/pci.c

Re: [Xen-devel] [PATCH v5 13/20] xen: setup Xen specific data for PVH

2018-11-27 Thread Daniel Kiper
Write back the possibly modified memory map to the hypervisor in case > the guest is reading it from there again. > > Set the RSDP address for the guest from the start_info page passed > as boot parameter. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper One nitpick b

Re: [Xen-devel] [PATCH v5 11/20] xen: setup hypercall page for PVH

2018-11-27 Thread Daniel Kiper
gen Gross > --- > V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) > issue panic message (Roger Pau Monné) > rewrite grub_xen_hypercall to avoid register variables (Daniel Kiper) > V5: Use XEN_HVM_DEBUGCONS_IOPORT from Xen unstable (Roger Pau Monné) > Iss

Re: [Xen-devel] [PATCH v5 09/20] xen: add basic hooks for PVH in current code

2018-11-27 Thread Daniel Kiper
eds > to get GRUB_KERNEL_USE_RSDP_ADDR from there. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v5 07/20] xen: modify grub_xen_ptr2mfn() for xen-pvh

2018-11-27 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 03:28:42PM +0100, Juergen Gross wrote: > grub_xen_ptr2mfn() returns the machine frame number for a given pointer > value. For Xen-PVH guests this is just the PFN. Add the PVH specific > variant. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel

Re: [Xen-devel] [PATCH v5 05/20] xen: add some dummy headers for PVH mode

2018-11-27 Thread Daniel Kiper
> Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v5 02/20] loader/linux: support passing rsdp address via boot params

2018-11-27 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 03:28:37PM +0100, Juergen Gross wrote: > Xen PVH guests will have the RSDP at an arbitrary address. Support that > by passing the RSDP address via the boot parameters to Linux. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Ki

Re: [Xen-devel] [PATCH v4 12/19] xen: add PCI MMIO areas to memory map

2018-11-14 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 01:49:16PM +0100, Roger Pau Monné wrote: > On Fri, Nov 09, 2018 at 08:14:57PM +0100, Daniel Kiper wrote: > > On Fri, Nov 02, 2018 at 01:37:31PM +0100, Juergen Gross wrote: > > > Add possible PCI space MMIO areas as "Reserved" to the memory map i

Re: [Xen-devel] [PATCH v4 17/19] xen_pvh: support building a standalone image

2018-11-09 Thread Daniel Kiper
off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > V2: some style adjustments (Daniel Kiper) > use defines for elf-notes (Daniel Kiper) Thanks a lot! However, I would like to ask you to move the latter to separate patch. You can retain my RB though. Daniel __

Re: [Xen-devel] [PATCH v4 14/19] xen: init memory regions for PVH

2018-11-09 Thread Daniel Kiper
-bit mode don't add memory above 4GB. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 13/19] xen: setup Xen specific data for PVH

2018-11-09 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:32PM +0100, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Write back the possibly modifie

Re: [Xen-devel] [PATCH v4 12/19] xen: add PCI MMIO areas to memory map

2018-11-09 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:31PM +0100, Juergen Gross wrote: > Add possible PCI space MMIO areas as "Reserved" to the memory map in > order to avoid using those areas for special Xen pages later. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper but I would

Re: [Xen-devel] [PATCH v4 11/19] xen: get memory map from hypervisor for PVH

2018-11-09 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:30PM +0100, Juergen Gross wrote: > Retrieve the memory map from the hypervisor and normalize it to contain > no overlapping entries and to be sorted by address. > > Signed-off-by: Juergen Gross One nit pick below. Otherwise Reviewed-by: Daniel Kiper

Re: [Xen-devel] [PATCH v4 10/19] xen: setup hypercall page for PVH

2018-11-09 Thread Daniel Kiper
message (Roger Pau Monné) > rewrite grub_xen_hypercall to avoid register variables (Daniel Kiper) > --- > grub-core/kern/i386/xen/pvh.c | 69 > +++ > 1 file changed, 69 insertions(+) > > diff --git a/grub-core/kern/i386/xen/pvh.c b/gr

Re: [Xen-devel] [PATCH v4 08/19] xen: add basic hooks for PVH in current code

2018-11-09 Thread Daniel Kiper
On Thu, Nov 08, 2018 at 08:23:20PM +0100, Juergen Gross wrote: > On 08/11/2018 16:45, Daniel Kiper wrote: > > On Fri, Nov 02, 2018 at 01:37:27PM +0100, Juergen Gross wrote: > >> Add the hooks to current code needed for Xen PVH. They will be filled > >> with

Re: [Xen-devel] [PATCH v4 09/19] xen: add PVH boot entry code

2018-11-08 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:28PM +0100, Juergen Gross wrote: > Add the code for the Xen PVH mode boot entry. > > Signed-off-by: Juergen Gross One nitpick below. Otherwise Reviewed-by: Daniel Kiper > --- > V3: clear %fs and %gs, too (Daniel K

Re: [Xen-devel] [PATCH v4 08/19] xen: add basic hooks for PVH in current code

2018-11-08 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:27PM +0100, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. They will be filled > with code later when the related functionality is being added. > > Signed-off-by: Juergen Gross > --- > V3: xenpvh->xen_pvh (Danie

Re: [Xen-devel] [PATCH v4 05/19] xen: add some dummy headers for PVH mode

2018-11-08 Thread Daniel Kiper
On Wed, Nov 07, 2018 at 03:49:51PM +0100, Juergen Gross wrote: > On 07/11/2018 13:21, Daniel Kiper wrote: > > On Fri, Nov 02, 2018 at 01:37:24PM +0100, Juergen Gross wrote: > >> With Xen PVH mode adding a new machine type the machine related headers > >> need to be prese

Re: [Xen-devel] x86 Community Call: Nov 14 - 15:00 - 16:00 UTC - Call for Agenda Items

2018-11-08 Thread Daniel Kiper
On Wed, Nov 07, 2018 at 04:15:17PM +0100, Juergen Gross wrote: > On 07/11/2018 16:06, Daniel Kiper wrote: > > On Wed, Nov 07, 2018 at 11:49:38AM +0100, Daniel Kiper wrote: > >> On Tue, Nov 06, 2018 at 09:54:54AM -0700, Jan Beulich wrote: > >>>>>> On 02.1

Re: [Xen-devel] x86 Community Call: Nov 14 - 15:00 - 16:00 UTC - Call for Agenda Items

2018-11-07 Thread Daniel Kiper
On Wed, Nov 07, 2018 at 11:49:38AM +0100, Daniel Kiper wrote: > On Tue, Nov 06, 2018 at 09:54:54AM -0700, Jan Beulich wrote: > > >>> On 02.11.18 at 18:59, wrote: > > > It’s time again for the x86 community call: for the agenda see > > > htt

Re: [Xen-devel] [PATCH v4 07/19] xen: add PVH specific defines to offset.h

2018-11-07 Thread Daniel Kiper
On Fri, Nov 02, 2018 at 01:37:26PM +0100, Juergen Gross wrote: > include/grub/offsets.h needs some defines for Xen PVH mode. > > Add them. While at it line up the values in the surrounding lines to > start at the same column. > > Signed-off-by: Juergen Gross Reviewed-by: Dan

Re: [Xen-devel] [PATCH v4 05/19] xen: add some dummy headers for PVH mode

2018-11-07 Thread Daniel Kiper
> Signed-off-by: Juergen Gross > --- > V3: updated commit message (Daniel Kiper) > xenpvh->xen_pvh (Daniel Kiper) > --- > include/grub/i386/xen_pvh/boot.h| 1 + > include/grub/i386/xen_pvh/console.h | 1 + > include/grub/i386/xen_pvh/int.h | 1 + >

Re: [Xen-devel] [PATCH v4 04/19] xen: prepare common code for Xen PVH support

2018-11-07 Thread Daniel Kiper
u fix two nitpicks below you can add Reviewed-by: Daniel Kiper > --- > V3: GRUB_MACHINE_XENPVH -> GRUB_MACHINE_XEN_PVH (Daniel Kiper) > split include/grub/i386/pc/int.h (Daniel Kiper) > move struct grub_e820_mmap_entry definition to header file > --- > grub-core/

Re: [Xen-devel] [PATCH v4 02/19] loader/linux: support passing rsdp address via boot params

2018-11-07 Thread Daniel Kiper
he actually use protocol version (the minimum of the kernel > supplied protocol version and the grub2 supported protocol version) > if 2.14 or higher are in effect. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Xen-d

Re: [Xen-devel] x86 Community Call: Nov 14 - 15:00 - 16:00 UTC - Call for Agenda Items

2018-11-07 Thread Daniel Kiper
On Tue, Nov 06, 2018 at 09:54:54AM -0700, Jan Beulich wrote: > >>> On 02.11.18 at 18:59, wrote: > > It’s time again for the x86 community call: for the agenda see > > https://docs.google.com/document/d/1RxW-iwcFFuKzNjjEqLEtiwFVHgAUlk35c0EtTkRE1 > > k4/edit# > > > > Please propose new agenda items

Re: [Xen-devel] [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-22 Thread Daniel Kiper
On Mon, Oct 22, 2018 at 01:43:53PM +0200, Juergen Gross wrote: > On 22/10/2018 13:31, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: > >> Add all usable memory regions to grub memory management and add the > >> needed mmap iterate

Re: [Xen-devel] [PATCH v2 18/18] xenpvh: add support to configure

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:17PM +0200, Juergen Gross wrote: > Support platform i386/xenpvh in configure. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper +/- XENPVH/xenpvh play still Reviewed-by: Daniel Kiper Daniel _

Re: [Xen-devel] [PATCH v2 17/18] xenpvh: support grub-install for xenpvh

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:16PM +0200, Juergen Gross wrote: > Add xenpvh support to grub-install. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper +/- XENPVH play still Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mail

Re: [Xen-devel] [PATCH v2 16/18] xenpvh: support building a standalone image

2018-10-22 Thread Daniel Kiper
off-by: Juergen Gross +/- XENPVH/xenpvh play Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 15/18] grub-module-verifier: Ignore all_video for xenpvh

2018-10-22 Thread Daniel Kiper
gnu.org/bugs/?49012 > > Signed-off-by: Hans van Kranenburg Except s/xenpvh/xen_pvh/ Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 14/18] xenpvh: add build runes for grub-core

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:13PM +0200, Juergen Gross wrote: > Add the modifications to the build system needed to build a xenpvh > grub. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > gentpl.py | 4 ++-- > grub-cor

Re: [Xen-devel] [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: > Add all usable memory regions to grub memory management and add the > needed mmap iterate code. I am missing a few words why this patch is needed. Especially why grub_machine_mmap_iterate() has to belong to this patch. However, I thi

Re: [Xen-devel] [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-22 Thread Daniel Kiper
On Fri, Oct 19, 2018 at 04:50:25PM +0200, Juergen Gross wrote: > On 19/10/2018 14:17, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:08PM +0200, Juergen Gross wrote: > >> Add the code for the Xen PVH mode boot entry. > >> > >> Signed-off-by: Juergen Gross

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-22 Thread Daniel Kiper
On Fri, Oct 19, 2018 at 05:52:44PM +0200, Juergen Gross wrote: > On 19/10/2018 17:33, Roger Pau Monné wrote: > > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > >> Add the hooks to current code needed for Xen PVH. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> grub-core/ker

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Set the RSDP address for the gu

Re: [Xen-devel] [PATCH v2 11/18] xen: get memory map from hypervisor for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:10PM +0200, Juergen Gross wrote: > Retrieve the memory map from the hypervisor and normalize it to contain > no overlapping entries and to be sorted by address. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 98 > +++

Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: > Add the needed code to setup the hypercall page for calling into the > Xen hypervisor. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 70 > +++ > 1 file changed, 70

Re: [Xen-devel] [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:08PM +0200, Juergen Gross wrote: > Add the code for the Xen PVH mode boot entry. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/startup_pvh.S | 50 > +++ > 1 file changed, 50 insertions(+) > > diff --git a/grub-core/

  1   2   3   >