Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Corey Minyard
= { > #ifdef CONFIG_PROC_FS > #include > > -static struct ctl_table ipmi_table[] = { > +static const struct ctl_table ipmi_table[] = { > { .procname = "poweroff_powercycle", > .data = &poweroff_powercycle, > .maxlen = sizeof(poweroff_powercycle), For the IPMI portion: Acked-by: Corey Minyard

Re: [PATCH 2/7] ipmi: simplify sysctl registration

2023-03-02 Thread Corey Minyard
On Thu, Mar 02, 2023 at 12:46:07PM -0800, Luis Chamberlain wrote: > register_sysctl_table() is a deprecated compatibility wrapper. > register_sysctl() can do the directory creation for you so just use > that. Thanks, I have included this in my tree for the next merge window. -corey > > Signed-o

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

2022-04-28 Thread Corey Minyard
nd the IPMI panic_event()] > due to the risks they offer (may not return, for example). > Proper documentation is going to be provided in a subsequent patch, > that effectively refactors the panic path. For the IPMI portion: Acked-by: Corey Minyard Note that the IPMI panic_event()

Re: Xen on Pi4: Xen doesn't work with overlays from Raspberry Pi 5.4 kernel

2020-06-15 Thread Corey Minyard
On Mon, Jun 15, 2020 at 06:05:57PM -0700, Roman Shaposhnik wrote: > On Mon, Jun 15, 2020 at 6:02 PM Corey Minyard wrote: > > > > On Mon, Jun 15, 2020 at 05:14:21PM -0700, Stefano Stabellini wrote: > > > On Mon, 15 Jun 2020, Christopher Clark wrote: > > > > O

Re: Xen on Pi4: Xen doesn't work with overlays from Raspberry Pi 5.4 kernel

2020-06-15 Thread Corey Minyard
On Mon, Jun 15, 2020 at 05:14:21PM -0700, Stefano Stabellini wrote: > On Mon, 15 Jun 2020, Christopher Clark wrote: > > On Wed, Jun 10, 2020 at 7:21 PM Roman Shaposhnik wrote: > > > > > > On Wed, Jun 10, 2020 at 11:54 AM Corey Minyard > > > wrote: > >

Xen on Pi4: Xen doesn't work with overlays from Raspberry Pi 5.4 kernel

2020-06-10 Thread Corey Minyard
I had been working on Xen on the Pi4 by throwing kernels I compiled onto existing sd cards, and this was working fine. I finally got to a full yocto build of the system, and it didn't boot. In fact, Xen didn't print anything at all, and nothing happens that might suggest it's booting without any

Re: [PATCH] xen/rpi4: implement watchdog-based reset

2020-06-04 Thread Corey Minyard
On Thu, Jun 04, 2020 at 09:15:33AM +0100, Julien Grall wrote: > Hi, > > On 04/06/2020 01:15, Corey Minyard wrote: > > On Wed, Jun 03, 2020 at 03:31:56PM -0700, Stefano Stabellini wrote: > > > Touching the watchdog is required to be able to reboot the board. > >

Re: [PATCH] xen/rpi4: implement watchdog-based reset

2020-06-03 Thread Corey Minyard
annoying me greatly. This works for me, so: Tested-by: Corey Minyard However, I was wondering if it might be better to handle this by failing the operation in xen and passing it back to dom0 to do. On the Pi you send a firmware message to reboot, and that seems like too much to do in Xen,

Re: Troubles running Xen on Raspberry Pi 4 with 5.6.1 DomU

2020-06-03 Thread Corey Minyard
On Wed, Jun 03, 2020 at 08:37:09AM -0700, Stefano Stabellini wrote: > On Wed, 3 Jun 2020, Corey Minyard wrote: > > On Tue, Jun 02, 2020 at 12:24:05PM -0700, Stefano Stabellini wrote: > > > On Tue, 2 Jun 2020, Corey Minyard wrote: > > > > Snip >

Re: Troubles running Xen on Raspberry Pi 4 with 5.6.1 DomU

2020-06-03 Thread Corey Minyard
On Tue, Jun 02, 2020 at 12:24:05PM -0700, Stefano Stabellini wrote: > On Tue, 2 Jun 2020, Corey Minyard wrote: > > Snip > > > > > > > > > whether > > > > > > > this was already done: > > > > > > > 1) D

Re: Troubles running Xen on Raspberry Pi 4 with 5.6.1 DomU

2020-06-02 Thread Corey Minyard
Snip > > > > > whether > > > > > this was already done: > > > > > 1) Does the kernel boot on baremetal (i.e without Xen)? This > > > > > should > > > > > help > > > > > to confirm whether the bug is Xen is related. > > > > > > > > Yes it boots > > > > > > > > > 2) Swiotlb should not b

Re: [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

2020-05-18 Thread Corey Minyard
efore we want allocate as much as possible memory below 1GB > > for dom0. > > > > Use the recently introduced dma_bitsize field to specify the DMA width > > supported. > > > > Signed-off-by: Julien Grall > > Reported-by: Corey Minyard > > --- >

Re: Troubles running Xen on Raspberry Pi 4 with 5.6.1 DomU

2020-05-06 Thread Corey Minyard
On Sat, May 02, 2020 at 12:46:14PM +0100, Julien Grall wrote: > Hi, > > On 02/05/2020 03:16, Corey Minyard wrote: > > On Fri, May 01, 2020 at 06:06:11PM -0700, Roman Shaposhnik wrote: > > > On Fri, May 1, 2020 at 4:42 AM Corey Minyard wrote: > > > > > &

Re: Troubles running Xen on Raspberry Pi 4 with 5.6.1 DomU

2020-05-04 Thread Corey Minyard
On Sat, May 02, 2020 at 06:48:27PM +0100, Julien Grall wrote: > > > On 02/05/2020 18:35, Corey Minyard wrote: > > On Sat, May 02, 2020 at 12:46:14PM +0100, Julien Grall wrote: > > No. If I am understanding this correctly, all the memory in dom0 below > > 1GB would

Re: Troubles running Xen on Raspberry Pi 4 with 5.6.1 DomU

2020-05-02 Thread Corey Minyard
On Sat, May 02, 2020 at 12:46:14PM +0100, Julien Grall wrote: > Hi, > > On 02/05/2020 03:16, Corey Minyard wrote: > > On Fri, May 01, 2020 at 06:06:11PM -0700, Roman Shaposhnik wrote: > > > On Fri, May 1, 2020 at 4:42 AM Corey Minyard wrote: > > > > > &

Re: Troubles running Xen on Raspberry Pi 4 with 5.6.1 DomU

2020-05-01 Thread Corey Minyard
On Fri, May 01, 2020 at 06:06:11PM -0700, Roman Shaposhnik wrote: > On Fri, May 1, 2020 at 4:42 AM Corey Minyard wrote: > > > > On Thu, Apr 30, 2020 at 07:20:05PM -0700, Roman Shaposhnik wrote: > > > Hi! > > > > > > I'm trying to run Xen on Raspber

Re: Troubles running Xen on Raspberry Pi 4 with 5.6.1 DomU

2020-05-01 Thread Corey Minyard
arch/arm64/mm/dma-mapping.c?h=v5.6.1#n55 > > I've tried to emulate the effect of the patch by simply introducing > a static variable that would signal that we already initialized > dev->dma_ops -- but that didn't help at all. > > I'm CCing Jeff Kubascik to

Re: [PATCH-for-5.1 2/3] various: Remove unnecessary OBJECT() cast

2020-04-14 Thread Corey Minyard
On Sun, Apr 12, 2020 at 11:09:53PM +0200, Philippe Mathieu-Daudé wrote: > The OBJECT() macro is defined as: > > #define OBJECT(obj) ((Object *)(obj)) > > Remove unnecessary OBJECT() casts. For ipmi change: Acked-by: Corey Minyard > > Patch created mechanically u

Re: [Xen-devel] [PATCH v3 23/25] hw/ipmi: Assert outlen > outpos

2019-02-20 Thread Corey Minyard
unsigned values tend to be more buggy in usage due to underflows, but for a length value that will eventually be converted to an unsigned value, what is here is better, I think. Both outpos and outlen are unsigned, so the size_t() cast is not really necessary, but I guess it makes it clear. Revie