Re: [REGRESSION] Linux 6.15.1 xen/dom0 domain_crash_sync called from entry.S

2025-07-03 Thread Chuck Zmudzinski
On 6/11/25 5:34 PM, Chuck Zmudzinski wrote: > On 6/10/25 12:22 AM, Jürgen Groß wrote: >> On 10.06.25 00:43, Chuck Zmudzinski wrote: >>> Hi, >>> >>> I am seeing the following regression between Linux 6.14.8 and 6.15.1. >>> >>> Kernel ve

Re: [REGRESSION] Linux 6.15.1 xen/dom0 domain_crash_sync called from entry.S

2025-06-11 Thread Chuck Zmudzinski
On 6/10/25 12:22 AM, Jürgen Groß wrote: > On 10.06.25 00:43, Chuck Zmudzinski wrote: >> Hi, >> >> I am seeing the following regression between Linux 6.14.8 and 6.15.1. >> >> Kernel version 6.14.8 boots fine but version 6.15.1 crashes and >> reboots on Xe

[REGRESSION] Linux 6.15.1 xen/dom0 domain_crash_sync called from entry.S

2025-06-09 Thread Chuck Zmudzinski
chine in 5 seconds. (XEN) Resetting with ACPI MEMORY or I/O RESET_REG. I searched mailing lists but could not find a report similar to what I am seeing here. I don't know what to try except to git bisect, but I have not done that yet. Chuck Zmudzinski

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-12-11 Thread Chuck Zmudzinski
On 11/27/2023 9:28 PM, Stefano Stabellini wrote: > On Mon, 27 Nov 2023, Chuck Zmudzinski wrote: >> On 11/27/2023 10:22 AM, Chuck Zmudzinski wrote: >> > On 11/27/2023 7:45 AM, Mario Marietto wrote: >> >> @Chuck Zmudzinski <mailto:brchu...@netscape.net> : Stay tun

Re: xc_dom_guest_type: image not capable of booting inside a HV M container: Invalid kernel

2023-12-11 Thread Chuck Zmudzinski
the earlier > > > On Mon, Dec 11, 2023 at 6:23 PM Chuck Zmudzinski <mailto:brchu...@netscape.net>> wrote: > > On 12/11/2023 9:02 AM, Mario Marietto wrote: > > Hello. > > > > Finally I tried to recompile the FreeBSD kernel using the @El

Re: xc_dom_guest_type: image not capable of booting inside a HV M container: Invalid kernel

2023-12-11 Thread Chuck Zmudzinski
On 12/11/2023 9:02 AM, Mario Marietto wrote: > Hello. > > Finally I tried to recompile the FreeBSD kernel using the @Elliott Mitchell > code because I want to boot FreeBSD as domU > with Xen installed on my Arm 32 bit Chromebook. Unfortunately it didn't work > at a

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-27 Thread Chuck Zmudzinski
On 11/27/2023 10:22 AM, Chuck Zmudzinski wrote: > On 11/27/2023 7:45 AM, Mario Marietto wrote: >> @Chuck Zmudzinski <mailto:brchu...@netscape.net> : Stay tuned. They want to >> help us. The xen developers are great. Very good support for us. I'm sure >> that you

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-27 Thread Chuck Zmudzinski
On 11/27/2023 7:45 AM, Mario Marietto wrote: > @Chuck Zmudzinski <mailto:brchu...@netscape.net> : Stay tuned. They want to > help us. The xen developers are great. Very good support for us. I'm sure > that you can give a good contribution to understand what's our proble

Re: [PATCH] arm/mm: add option to prefer IOMMU ops for DMA on Xen

2023-11-17 Thread Fr. Chuck Zmudzinski, C.P.M.
On 11/14/2023 5:20 PM, Stefano Stabellini wrote: > On Tue, 14 Nov 2023, Robin Murphy wrote: >> On 11/11/2023 6:45 pm, Chuck Zmudzinski wrote: >> > Enabling the new option, ARM_DMA_USE_IOMMU_XEN, fixes this error when >> > attaching the Exynos mixer in Linux dom0 on

Re: [PATCH] arm/mm: add option to prefer IOMMU ops for DMA on Xen

2023-11-16 Thread Chuck Zmudzinski
On 11/15/2023 12:56 PM, Chuck Zmudzinski wrote: > On 11/14/2023 5:20 PM, Stefano Stabellini wrote: >> On Tue, 14 Nov 2023, Robin Murphy wrote: >>> On 11/11/2023 6:45 pm, Chuck Zmudzinski wrote: >>> > Enabling the new option, ARM_DMA_USE_IOMMU_XEN, fixes this error w

Re: Values generated by the ViryaOS uboot-script-gen do not work correctly on the Chromebook Snow

2023-11-16 Thread Chuck Zmudzinski
t it rebooted to the verification screen. > > NB : I have applied both your suggestions (offset + your new start and end > memory address. Maybe they auto exclude each other ?) > > On Thu, Nov 16, 2023 at 12:49 AM Stefano Stabellini <mailto:sstabell...@kernel.org>> wrot

Re: [PATCH] arm/mm: add option to prefer IOMMU ops for DMA on Xen

2023-11-15 Thread Chuck Zmudzinski
On 11/14/2023 5:20 PM, Stefano Stabellini wrote: > On Tue, 14 Nov 2023, Robin Murphy wrote: >> On 11/11/2023 6:45 pm, Chuck Zmudzinski wrote: >> > Enabling the new option, ARM_DMA_USE_IOMMU_XEN, fixes this error when >> > attaching the Exynos mixer in Linux dom0 on

Re: Values generated by the ViryaOS uboot-script-gen do not work correctly on the Chromebook Snow

2023-11-15 Thread Chuck Zmudzinski
On 11/14/2023 6:43 PM, Mario Marietto wrote: > I hope that the informations below are correct : I don't know that they are correct. I have not spent the necessary time to determine what the correct values for MEMORY_START and MEMORY_END are for the Chromebook we are using. I just presumed, probabl

[PATCH] arm/mm: add option to prefer IOMMU ops for DMA on Xen

2023-11-11 Thread Chuck Zmudzinski
/xen-devel/acfab1c5-eed1-4930-8c70-8681e256c...@netscape.net/ Signed-off-by: Chuck Zmudzinski --- The reported error with the Exynos mixer is not fixed by default by adding a second patch to select the new option in the Kconfig definition for the Exynos mixer if EXYNOS_IOMMU and SWIOTLB_XEN are

Re: exynos-mixer 14450000.mixer: [drm:exynos_drm_register_dma] *ERROR* Device 14450000.mixer lacks support for IOMMU

2023-11-10 Thread Chuck Zmudzinski
Hi everyone, This reply is intended to clarify the latest test results and bring the clarifications and other relevant discussion to the xen-devel mailing list. On 11/1/2023 5:14 AM, Julien Grall wrote: > > > On 01/11/2023 08:45, Chuck Zmudzinski wrote: >> On 11/1/2023 4:27 A

Re: exynos-mixer 14450000.mixer: [drm:exynos_drm_register_dma] *ERROR* Device 14450000.mixer lacks support for IOMMU

2023-11-01 Thread Chuck Zmudzinski
h from Linux 6.2 and above that fixes the exynos IOMMU initialization did not help at all, and the same error is reported that the mixer lacks support for IOMMU. > > On 01/11/2023 02:50, Chuck Zmudzinski wrote: >> On 10/31/2023 7:45 PM, Stefano Stabellini wrote: >>> Unfortun

Re: exynos-mixer 14450000.mixer: [drm:exynos_drm_register_dma] *ERROR* Device 14450000.mixer lacks support for IOMMU

2023-11-01 Thread Chuck Zmudzinski
On 10/31/2023 8:08 AM, Marek Szyprowski wrote: > Hi, > > On 31.10.2023 00:03, Mario Marietto wrote: >> We are a team of linux enthusiasts who are trying to boot Xen on a >> Samsung XE303C12 Chromebook aka "snow" following the suggestions in >> the slide show presentation here: >> https://www.sl

Re: exynos-mixer 14450000.mixer: [drm:exynos_drm_register_dma] *ERROR* Device 14450000.mixer lacks support for IOMMU

2023-10-31 Thread Chuck Zmudzinski
On 10/31/2023 7:45 PM, Stefano Stabellini wrote: > Unfortunately there is no easy solution. > > Do you know the version of the SMMU available on the platform? I am trying to discern, but I doubt we have v3 because we are working on a very old chromebook from 2012, and I am finding patches for sm

Re: [PATCH v3 2/6] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize()

2023-09-20 Thread Chuck Zmudzinski
On 9/19/2023 4:02 PM, Bernhard Beschow wrote: > > > Am 3. April 2023 12:27:14 UTC schrieb Jason Andryuk : >>On Mon, Apr 3, 2023 at 5:33 AM Anthony PERARD >>wrote: >>> >>> On Sat, Apr 01, 2023 at 10:36:45PM +, Bernhard Beschow wrote: >>> > >>> > >>> > Am 30. März 2023 13:00:25 UTC schrieb An

Re: xl dmesg buffer too small for Xen 4.18?

2023-09-19 Thread Chuck Zmudzinski
On 9/19/2023 12:00 PM, Jan Beulich wrote: > On 19.09.2023 17:56, Julien Grall wrote: >> On 19/09/2023 16:09, Chuck Zmudzinski wrote: >>> On 9/19/2023 8:10 AM, Julien Grall wrote: >>>> On 19/09/2023 08:02, Roger Pau Monné wrote: >>>>> On Mon, Sep 18,

Re: xl dmesg buffer too small for Xen 4.18?

2023-09-19 Thread Chuck Zmudzinski
On 9/19/2023 8:10 AM, Julien Grall wrote: > Hi Roger, > > On 19/09/2023 08:02, Roger Pau Monné wrote: >> On Mon, Sep 18, 2023 at 07:49:26PM +0100, Julien Grall wrote: >>> (+Roger and moving to xen-devel) >>> >>> Hi, >>> >>> On 18/09/2

Re: xl dmesg buffer too small for Xen 4.18?

2023-09-18 Thread Chuck Zmudzinski
On 9/18/2023 2:49 PM, Julien Grall wrote: > (+Roger and moving to xen-devel) > > Hi, > > On 18/09/2023 19:17, Chuck Zmudzinski wrote: >> On 9/18/2023 9:00 AM, Chuck Zmudzinski wrote: >>> Hello, >>> >>> I tested Xen 4.18~rc0 on Alma Linux 9 an

Re: Community Manager update - August 2023

2023-08-18 Thread Chuck Zmudzinski
On 8/18/2023 6:55 AM, Kelly Choi wrote: > Hi everyone! :)  > > I hope you're all well.  > > If we haven't met before, I'd like to introduce myself. I'm Kelly, the > Community Manager for The Xen Project. My role is to support everyone and > make sure the project is healthy and thriving.  > > *

Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator

2023-05-17 Thread Chuck Zmudzinski
On 5/17/2023 2:39 AM, Michael Tokarev wrote: > 08.02.2023 05:03, Chuck Zmudzinski wrote: > > Commit 998250e97661 ("xen, gfx passthrough: register host bridge specific > > to passthrough") uses the igd-passthrough-i440FX pci host device with > > the xenfv machine type

[PATCH v4 2/2] pci: introduce slot_reserved_auto_mask and slot_reserved_manual_mask

2023-03-15 Thread Chuck Zmudzinski
these accessor functions are not needed for slot_reserved_manual_mask because the sun4u machine has no need to get the value of the mask or clear bits in the mask. Link: https://lore.kernel.org/qemu-devel/20230106064838-mutt-send-email-...@kernel.org/ Signed-off-by: Chuck Zmudzinski --- Changel

[PATCH v4 0/2] pci: slot_reserved_mask improvements

2023-03-15 Thread Chuck Zmudzinski
machine not tested -- Mark, can you do this? Link: https://lore.kernel.org/qemu-devel/20230106064838-mutt-send-email-...@kernel.org/ Chuck Zmudzinski (2): pci: avoid accessing slot_reserved_mask directly outside of pci.c pci: introduce slot_reserved_auto_mask and slot_reserved_manual_mask

[PATCH v4 1/2] pci: avoid accessing slot_reserved_mask directly outside of pci.c

2023-03-15 Thread Chuck Zmudzinski
. Signed-off-by: Chuck Zmudzinski --- Changelog v4: This patch is unchanged since v2. v3: This patch is unchanged since v2. v2: This is the first version of this patch, it did not exist in v1. hw/pci/pci.c | 15 +++ hw/sparc64/sun4u.c | 7 +++ hw/xen/xen_pt.c | 7

[PATCH v3 1/2] pci: avoid accessing slot_reserved_mask directly outside of pci.c

2023-03-14 Thread Chuck Zmudzinski
. Signed-off-by: Chuck Zmudzinski --- Changelog v3: This patch is unchanged since v2. v2: This is the first version of this patch, it did not exist in v1. hw/pci/pci.c | 15 +++ hw/sparc64/sun4u.c | 7 +++ hw/xen/xen_pt.c | 7 +++ include/hw/pci/pci.h | 3

[PATCH v3 0/2] pci: slot_reserved_mask improvements

2023-03-14 Thread Chuck Zmudzinski
machine not tested -- Mark, can you do this? Link: https://lore.kernel.org/qemu-devel/20230106064838-mutt-send-email-...@kernel.org/ Chuck Zmudzinski (2): pci: avoid accessing slot_reserved_mask directly outside of pci.c pci: introduce slot_reserved_auto_mask and slot_reserved_manual_mask

[PATCH v3 2/2] pci: introduce slot_reserved_auto_mask and slot_reserved_manual_mask

2023-03-14 Thread Chuck Zmudzinski
these accessor functions are not needed for slot_reserved_manual_mask because the sun4u machine has no need to get the value of the mask or clear bits in the mask. Link: https://lore.kernel.org/qemu-devel/20230106064838-mutt-send-email-...@kernel.org/ Signed-off-by: Chuck Zmudzinski --- Cha

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 10:39 AM, Mark Cave-Ayland wrote: > On 14/03/2023 14:21, Chuck Zmudzinski wrote: > > > On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: > >> On 14/03/2023 13:26, Chuck Zmudzinski wrote: > >> > >>> On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote:

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: > On 14/03/2023 13:26, Chuck Zmudzinski wrote: > > > On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > >> On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > >>> On 14/03/2023 06:33, Michael S. Tsirkin w

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: > On 14/03/2023 13:26, Chuck Zmudzinski wrote: > > > On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > >> On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > >>> On 14/03/2023 06:33, Michael S. Tsirkin w

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > > On 14/03/2023 06:33, Michael S. Tsirkin wrote: > > > > > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > > > Commit 4f6

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Chuck Zmudzinski
On 3/14/2023 2:33 AM, Michael S. Tsirkin wrote: > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > > uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the > &g

[PATCH v2 0/2] pci: slot_reserved_mask improvements

2023-03-13 Thread Chuck Zmudzinski
/qemu-devel/20230106064838-mutt-send-email-...@kernel.org/ Chuck Zmudzinski (2): pci: avoid accessing slot_reserved_mask directly outside of pci.c pci: allow slot_reserved_mask to be ignored with manual slot assignment Changelog v2: Add first patch and cover letter to make this a 2-patch

[PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-13 Thread Chuck Zmudzinski
only apply when the pci device to be added to a pc/i440fx/xenfv machine is configured for automatic slot assignment. Link: https://lore.kernel.org/qemu-devel/20230106064838-mutt-send-email-...@kernel.org/ Signed-off-by: Chuck Zmudzinski --- Changelog v2: Change Subject of patch from

[PATCH v2 1/2] pci: avoid accessing slot_reserved_mask directly outside of pci.c

2023-03-13 Thread Chuck Zmudzinski
. Signed-off-by: Chuck Zmudzinski --- v2: This is the first version of this patch, it did not exist in v1. hw/pci/pci.c | 15 +++ hw/sparc64/sun4u.c | 7 +++ hw/xen/xen_pt.c | 7 +++ include/hw/pci/pci.h | 3 +++ 4 files changed, 24 insertions(+), 8 deletions

Re: [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

2023-03-12 Thread Chuck Zmudzinski
On 3/12/23 5:22 AM, Bernhard Beschow wrote: > > > Am 11. März 2023 22:20:29 UTC schrieb Chuck Zmudzinski : >>On 2/9/2023 4:53 PM, Bernhard Beschow wrote: >>> Am 1. Februar 2023 08:11:10 UTC schrieb Bernhard Beschow >>> : >>> > >>> > >

Re: [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

2023-03-11 Thread Chuck Zmudzinski
On 2/9/2023 4:53 PM, Bernhard Beschow wrote: > Am 1. Februar 2023 08:11:10 UTC schrieb Bernhard Beschow : > > > > > >Am 24. Januar 2023 17:07:30 UTC schrieb Bernhard Beschow : > >> > >> > >>Am 24. Januar 2023 16:11:47 UTC schrieb Anthony PERARD > >>: > >>>On Wed, Jan 18, 2023 at 05:13:03AM -0500,

[RFC PATCH] libxl/dm: Stop using "xenfv" machine in the Qemu upstream device model

2023-02-20 Thread Chuck Zmudzinski
uot; machine to the "pc" machine but there is no degredation in performance, just a possible need to reset the display resolution to the desired value. Signed-off-by: Chuck Zmudzinski --- Sorry about how long this discussion is, but it is helpful to again bring together all the con

[PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator

2023-02-07 Thread Chuck Zmudzinski
the sysemu/xen.h header file as the test to determine whether or not to use the igd-passthrough-i440FX pci host device instead of the normal i440FX pci host device. Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge specific to passthrough") Signed-off-by: Chuck Zmudzinsk

Re: [XEN PATCH v2 0/3] Configure qemu upstream correctly by default for igd-passthru

2023-01-31 Thread Chuck Zmudzinski
On 1/29/23 7:38 PM, Chuck Zmudzinski wrote: > On 1/25/23 6:19 PM, Chuck Zmudzinski wrote: >> On 1/25/2023 6:37 AM, Anthony PERARD wrote: >>> On Tue, Jan 10, 2023 at 02:32:01AM -0500, Chuck Zmudzinski wrote: >>> > I call attention to the commit message of the first pat

Re: [XEN PATCH v2 0/3] Configure qemu upstream correctly by default for igd-passthru

2023-01-29 Thread Chuck Zmudzinski
On 1/25/23 6:19 PM, Chuck Zmudzinski wrote: > On 1/25/2023 6:37 AM, Anthony PERARD wrote: >> On Tue, Jan 10, 2023 at 02:32:01AM -0500, Chuck Zmudzinski wrote: >> > I call attention to the commit message of the first patch which points >> > out that using the &quo

Re: [XEN PATCH v2 0/3] Configure qemu upstream correctly by default for igd-passthru

2023-01-25 Thread Chuck Zmudzinski
On 1/25/2023 6:37 AM, Anthony PERARD wrote: > On Tue, Jan 10, 2023 at 02:32:01AM -0500, Chuck Zmudzinski wrote: > > I call attention to the commit message of the first patch which points > > out that using the "pc" machine and adding the xen platform device on > > th

Re: [XEN PATCH v2 0/3] Configure qemu upstream correctly by default for igd-passthru

2023-01-25 Thread Chuck Zmudzinski
On 1/25/2023 6:37 AM, Anthony PERARD wrote: > On Tue, Jan 10, 2023 at 02:32:01AM -0500, Chuck Zmudzinski wrote: > > I call attention to the commit message of the first patch which points > > out that using the "pc" machine and adding the xen platform device on > > th

Re: [PATCH v11] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-22 Thread Chuck Zmudzinski
On 1/22/23 3:40 AM, Michael S. Tsirkin wrote: > On Sat, Jan 21, 2023 at 07:57:02PM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
On 1/21/23 1:06 PM, Chuck Zmudzinski wrote: > On 1/6/2023 9:03 AM, Anthony PERARD wrote: >> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: >> > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> > as noted in docs/igd-assign.

[PATCH v11] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
t, and function values as well as by checking that gfx_passthru is enabled, the device class is VGA, and the device vendor in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on reco

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
On 1/6/2023 9:03 AM, Anthony PERARD wrote: > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when

Re: [PATCH v9] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
On 1/20/2023 4:34 PM, Stefano Stabellini wrote: > On Sat, 14 Jan 2023, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when the xl toolstack

[PATCH v10] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
t, and function values as well as by checking that gfx_passthru is enabled, the device class is VGA, and the device vendor in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on reco

Re: [PATCH v9] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-20 Thread Chuck Zmudzinski
On 1/20/23 4:34 PM, Stefano Stabellini wrote: > On Sat, 14 Jan 2023, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when the xl toolstack

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-20 Thread Chuck Zmudzinski
On 1/20/2023 11:01 AM, Igor Mammedov wrote: > On Tue, 17 Jan 2023 09:50:23 -0500 > Chuck Zmudzinski wrote: > > > On 1/17/2023 5:35 AM, Igor Mammedov wrote: > > > On Mon, 16 Jan 2023 13:00:53 -0500 > > > Chuck Zmudzinski wrote: > > > > > > >

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-20 Thread Chuck Zmudzinski
On 1/20/2023 11:57 AM, Stefano Stabellini wrote: > On Tue, 17 Jan 2023, Chuck Zmudzinski wrote: > > On 1/17/2023 6:04 AM, Igor Mammedov wrote: > > > On Mon, 16 Jan 2023 13:00:53 -0500 > > > Chuck Zmudzinski wrote: > > > > > > > On 1/16/23 10:33, Ig

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-18 Thread Chuck Zmudzinski
On 1/17/2023 11:27 PM, Alex Williamson wrote: > On Tue, 17 Jan 2023 19:15:57 -0500 > Chuck Zmudzinski wrote: > > > On 1/17/2023 6:04 AM, Igor Mammedov wrote: > > > On Mon, 16 Jan 2023 13:00:53 -0500 > > > Chuck Zmudzinski wrote: > > > >

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-17 Thread Chuck Zmudzinski
On 1/17/2023 6:04 AM, Igor Mammedov wrote: > On Mon, 16 Jan 2023 13:00:53 -0500 > Chuck Zmudzinski wrote: > > > On 1/16/23 10:33, Igor Mammedov wrote: > > > On Fri, 13 Jan 2023 16:31:26 -0500 > > > Chuck Zmudzinski wrote: > > > > > >> On 1

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-17 Thread Chuck Zmudzinski
On 1/17/2023 5:35 AM, Igor Mammedov wrote: > On Mon, 16 Jan 2023 13:00:53 -0500 > Chuck Zmudzinski wrote: > > > On 1/16/23 10:33, Igor Mammedov wrote: > > > On Fri, 13 Jan 2023 16:31:26 -0500 > > > Chuck Zmudzinski wrote: > > > > > >> On 1

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-17 Thread Chuck Zmudzinski
On 1/17/2023 5:35 AM, Igor Mammedov wrote: > On Mon, 16 Jan 2023 13:00:53 -0500 > Chuck Zmudzinski wrote: > > > On 1/16/23 10:33, Igor Mammedov wrote: > > > On Fri, 13 Jan 2023 16:31:26 -0500 > > > Chuck Zmudzinski wrote: > > > > > >> On 1

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-16 Thread Chuck Zmudzinski
On 1/16/23 10:33, Igor Mammedov wrote: > On Fri, 13 Jan 2023 16:31:26 -0500 > Chuck Zmudzinski wrote: > >> On 1/13/23 4:33 AM, Igor Mammedov wrote: >> > On Thu, 12 Jan 2023 23:14:26 -0500 >> > Chuck Zmudzinski wrote: >> > >> >> On 1/12/

[PATCH v9] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-13 Thread Chuck Zmudzinski
is done by checking the domain, bus, slot, and function values as well as by checking that gfx_passthru is enabled, the device class is VGA, and the device vendor in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-13 Thread Chuck Zmudzinski
On 1/10/23 3:16 AM, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-13 Thread Chuck Zmudzinski
On 1/13/23 4:33 AM, Igor Mammedov wrote: > On Thu, 12 Jan 2023 23:14:26 -0500 > Chuck Zmudzinski wrote: > >> On 1/12/23 6:03 PM, Michael S. Tsirkin wrote: >> > On Thu, Jan 12, 2023 at 10:55:25PM +, Bernhard Beschow wrote: >> >> I think the change Michael

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-12 Thread Chuck Zmudzinski
On 1/12/23 6:03 PM, Michael S. Tsirkin wrote: > On Thu, Jan 12, 2023 at 10:55:25PM +, Bernhard Beschow wrote: >> I think the change Michael suggests is very minimalistic: Move the if >> condition around xen_igd_reserve_slot() into the function itself and >> always call it there unconditionally

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-12 Thread Chuck Zmudzinski
On 1/12/23 2:18 PM, Bernhard Beschow wrote: > > > Am 11. Januar 2023 15:40:24 UTC schrieb Chuck Zmudzinski : >>On 1/10/23 3:16 AM, Michael S. Tsirkin wrote: >>> On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: >>>> Intel specifies that the Int

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-11 Thread Chuck Zmudzinski
On 1/10/23 3:16 AM, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-10 Thread Chuck Zmudzinski
On 1/10/2023 3:16 AM, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currentl

[PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-09 Thread Chuck Zmudzinski
in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Qemu docs: https://qemu.readthedocs.io/en/latest/devel/qom.html Notes that might be helpful to reviewers of patched code

Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-09 Thread Chuck Zmudzinski
On 1/10/2023 12:27 AM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2023 at 07:05:35PM -0500, Chuck Zmudzinski wrote: > > On 1/9/23 6:33 PM, Michael S. Tsirkin wrote: > > > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > > >> Intel specifies that th

Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-09 Thread Chuck Zmudzinski
On 1/9/2023 7:05 PM, Chuck Zmudzinski wrote: > On 1/9/23 6:33 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > >> as noted in docs/igd-assign.

Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-09 Thread Chuck Zmudzinski
On 1/9/23 6:35 PM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2023 at 06:28:44PM -0500, Chuck Zmudzinski wrote: >> On 1/9/23 5:33 PM, Michael S. Tsirkin wrote: >> > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: >> >> Intel specifies that the Intel

Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-09 Thread Chuck Zmudzinski
On 1/9/23 6:33 PM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when

Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-09 Thread Chuck Zmudzinski
On 1/9/23 5:33 PM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when

[XEN PATCH 3/3] libxl/dm: Assign slot 2 by default for Intel IGD passthrough

2023-01-09 Thread Chuck Zmudzinski
slot addresses of passed through pci devices when gfx_passthru is disabled and the administrator does not set @VSLOT for passed through pci devices is also preserved. Signed-off-by: Chuck Zmudzinski --- tools/libs/light/libxl_dm.c | 22 ++ 1 file changed, 22 insertions(+)

[XEN PATCH 2/3] libxl/dm: Manage pci slot assignment for Intel IGD passthrough

2023-01-09 Thread Chuck Zmudzinski
tream qemu assign the slot if the guest is configured for Intel IGD passthrough, and preserve the current behavior of letting qemu assign the slot address otherwise. Signed-off-by: Chuck Zmudzinski --- The diff of this patch is easier to review if it is generated using the -b (aka --ignore-space-c

[XEN PATCH 1/3] libxl/dm: Use "pc" machine type for Intel IGD passthrough

2023-01-09 Thread Chuck Zmudzinski
type with the default settings of xen_platform_pci enabled and igd gfx_passthru disabled. The patch only affects machines configured with gfx_passthru enabled. Signed-off-by: Chuck Zmudzinski --- Reviewers might find this patch easier to review by looking at the resulting code in the patched file ins

[XEN PATCH 0/3] Configure qemu upstream correctly by default for igd-passthru

2023-01-09 Thread Chuck Zmudzinski
ru. These devices are also subject to mistakes in the patch not discovered by the compiler, as mentioned in the comments for reviewers section of the second patch. [1] https://lore.kernel.org/qemu-devel/8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchu...@aol.com/ Chuck Zmudzinski (3): libxl/dm: Use &q

[PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-09 Thread Chuck Zmudzinski
in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Qemu docs: https://qemu.readthedocs.io/en/latest/devel/qom.html Notes that might be helpful to reviewers of patched code

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-08 Thread Chuck Zmudzinski
On 1/6/2023 10:02 AM, Chuck Zmudzinski wrote: > On 1/6/23 9:31 AM, Chuck Zmudzinski wrote: > > On 1/6/23 9:10 AM, Chuck Zmudzinski wrote: > >> On 1/6/23 9:03 AM, Anthony PERARD wrote: > >>> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > >

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-07 Thread Chuck Zmudzinski
On 1/7/23 6:05 AM, Bernhard Beschow wrote: > Am 7. Januar 2023 01:08:46 UTC schrieb Chuck Zmudzinski : > >On 1/6/23 6:04 PM, Chuck Zmudzinski wrote: > >> On 1/6/23 2:08 PM, Chuck Zmudzinski wrote: > >>> On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: > >>>

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 6:04 PM, Chuck Zmudzinski wrote: > On 1/6/23 2:08 PM, Chuck Zmudzinski wrote: >> On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: >>> On 6/1/23 12:57, Bernhard Beschow wrote: >>>> >>>> >>>> Am 4. Januar 2023 15:35:33 UTC schrieb

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 2:08 PM, Chuck Zmudzinski wrote: > On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: >> On 6/1/23 12:57, Bernhard Beschow wrote: >>> >>> >>> Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" >>> : >>>&g

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: > On 6/1/23 12:57, Bernhard Beschow wrote: >> >> >> Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" >> : >>> +Markus/Thomas >>> >>> On 4/1/23 15:44, Bernhard Beschow wrote: During the last patches, TYPE_PIIX3_XEN_DEVICE turned

Re: [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 12:46 PM, Chuck Zmudzinski wrote: > On 1/6/23 12:35 PM, David Woodhouse wrote: >> On Wed, 2023-01-04 at 15:44 +0100, Bernhard Beschow wrote: >>> +    if (xen_enabled()) { >> >> Could this perhaps be if (xen_mode != XEN_DISABLED) once we merge the >&

Re: [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 12:35 PM, David Woodhouse wrote: > On Wed, 2023-01-04 at 15:44 +0100, Bernhard Beschow wrote: >> +    if (xen_enabled()) { > > Could this perhaps be if (xen_mode != XEN_DISABLED) once we merge the > Xen-on-KVM series? I am not an expert and just on here as a user/tester, but I think

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 9:31 AM, Chuck Zmudzinski wrote: > On 1/6/23 9:10 AM, Chuck Zmudzinski wrote: >> On 1/6/23 9:03 AM, Anthony PERARD wrote: >>> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: >>>> Intel specifies that the Intel IGD must occupy slot 2 on the

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 9:10 AM, Chuck Zmudzinski wrote: > On 1/6/23 9:03 AM, Anthony PERARD wrote: >> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: >>> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >>> as noted in docs/igd-assign.

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 9:03 AM, Anthony PERARD wrote: > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-06 Thread Chuck Zmudzinski
On 1/6/23 5:52 AM, Anthony PERARD wrote: > On Tue, Jan 03, 2023 at 05:58:01PM -0500, Chuck Zmudzinski wrote: >> Hello Anthony and Paul, > > Hi Chuck, > >> I am requesting your feedback to Alex Williamson's suggestion that this >> problem with assigning the cor

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-05 Thread Chuck Zmudzinski
On 1/4/23 3:47 PM, Chuck Zmudzinski wrote: > On 1/3/23 10:14 AM, Alex Williamson wrote: > >> >> It's necessary to configure the assigned IGD at slot 2 to make it >> functional, yes, but I don't really understand this notion of >> "reserving" slo

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
On 1/4/2023 5:18 PM, Philippe Mathieu-Daudé wrote: > On 4/1/23 20:29, Chuck Zmudzinski wrote: > > On 1/4/23 1:48 PM, Philippe Mathieu-Daudé wrote: > > >> Here TYPE_PIIX3_DEVICE means for "PCI function part of the PIIX > >> south bridge chipset, which expose a PCI

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
On 1/4/2023 5:35 PM, Philippe Mathieu-Daudé wrote: > On 4/1/23 17:42, Chuck Zmudzinski wrote: > > On 1/4/23 9:44 AM, Bernhard Beschow wrote: > >> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of > >> TYPE_PIIX3_DEVICE. Remove this redundancy. > &

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
On 1/4/23 5:35 PM, Philippe Mathieu-Daudé wrote: > On 4/1/23 17:42, Chuck Zmudzinski wrote: >> On 1/4/23 9:44 AM, Bernhard Beschow wrote: >>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>>

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
On 1/4/23 3:31 PM, Bernhard Beschow wrote: > > > Am 4. Januar 2023 19:29:35 UTC schrieb Chuck Zmudzinski : >>On 1/4/23 1:48 PM, Philippe Mathieu-Daudé wrote: >>> On 4/1/23 18:54, Chuck Zmudzinski wrote: >>>> On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: &

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
On 1/4/23 3:44 PM, Bernhard Beschow wrote: > > > Am 4. Januar 2023 17:54:16 UTC schrieb Chuck Zmudzinski : >>On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: >>> +Markus/Thomas >>> >>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>> During

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-04 Thread Chuck Zmudzinski
On 1/3/23 10:14 AM, Alex Williamson wrote: > > It's necessary to configure the assigned IGD at slot 2 to make it > functional, yes, but I don't really understand this notion of > "reserving" slot 2. If something occupies address 00:02.0 in the > config, it's the user's or management tool's respo

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
On 1/4/23 1:48 PM, Philippe Mathieu-Daudé wrote: > On 4/1/23 18:54, Chuck Zmudzinski wrote: >> On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: >>> +Markus/Thomas >>> >>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>> During the last patch

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: > +Markus/Thomas > > On 4/1/23 15:44, Bernhard Beschow wrote: >> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >> TYPE_PIIX3_DEVICE. Remove this redundancy. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/i386/pc_piix

Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
On 1/4/23 11:12 AM, Bernhard Beschow wrote: > > > Am 4. Januar 2023 13:11:16 UTC schrieb Chuck Zmudzinski : >>On 1/4/2023 7:13 AM, Bernhard Beschow wrote: >>> Am 4. Januar 2023 08:18:59 UTC schrieb Chuck Zmudzinski : >>> >On 1/3/2023 8:38 AM, Bernhard Bescho

Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

2023-01-04 Thread Chuck Zmudzinski
gt; --- a/include/hw/southbridge/piix.h > +++ b/include/hw/southbridge/piix.h > @@ -77,7 +77,6 @@ struct PIIXState { > OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) > > #define TYPE_PIIX3_DEVICE "PIIX3" > -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" > #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" > > #endif This fixes the regression with the emulated usb tablet device that I reported in v1 here: https://lore.kernel.org/qemu-devel/aed4f2c1-83f7-163a-fb44-f28437666...@aol.com/ I tested this patch again with all the prerequisites and now with v2 there are no regressions. Tested-by: Chuck Zmudzinski

  1   2   3   >