Re: [XEN PATCH] xen/arm: ffa: fix bind/unbind notification

2025-02-03 Thread Bertrand Marquis
ly been swapped for > FFA_NOTIFICATION_BIND and FFA_NOTIFICATION_UNBIND in the FF-A mediator. > So fix that by using the correct registers. > > Fixes: b490f470f58d ("xen/arm: ffa: support notification") > Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis @Olek

Re: [PATCH v1 2/2] docs: fusa: Add the requirements for some of the commands of XEN_VERSION

2025-01-29 Thread Bertrand Marquis
Hi Julien, > On 29 Jan 2025, at 21:20, Julien Grall wrote: > > > On Wed, 29 Jan 2025 at 12:49, Bertrand Marquis > wrote: > Hi Julien, > > Welcome back :-) > > I am not fully back yet but I have a bit of spare time to go through > xen-devel :). Then

Re: [PATCH v1 2/2] docs: fusa: Add the requirements for some of the commands of XEN_VERSION

2025-01-29 Thread Bertrand Marquis
Hi Julien, Welcome back :-) > On 29 Jan 2025, at 16:33, Julien Grall wrote: > > Hi, > > On Tue, 14 Jan 2025 at 16:50, Ayan Kumar Halder > wrote: > We have written the requirements for some of the commands of the XEN_VERSION > hypercall. > > Signed-off-by: Ayan Kumar Halder > --- > .../des

Re: [PATCH v1 2/2] docs: fusa: Add the requirements for some of the commands of XEN_VERSION

2025-01-29 Thread Bertrand Marquis
Hi Ayan, > On 14 Jan 2025, at 20:50, Ayan Kumar Halder wrote: > > We have written the requirements for some of the commands of the XEN_VERSION > hypercall. > > Signed-off-by: Ayan Kumar Halder > --- > .../design-reqs/arm64/version_hypercall.rst | 33 > .../reqs/design-reqs/version_hy

Re: [PATCH v1 1/2] docs: fusa: Define the requirements for XEN_VERSION hypercall.

2025-01-29 Thread Bertrand Marquis
Hi Ayan, > On 14 Jan 2025, at 20:50, Ayan Kumar Halder wrote: > > In the current patch, we have defined the requirements which are common for > all the commands. > > Signed-off-by: Ayan Kumar Halder > --- > .../fusa/reqs/design-reqs/arm64/hypercall.rst | 52 > docs/fusa/reqs/in

Re: [PATCH v4] docs: fusa: Add dom0less domain configuration requirements

2025-01-09 Thread Bertrand Marquis
Hi Ayan, > On 9 Jan 2025, at 11:00, Ayan Kumar Halder wrote: > > > On 09/01/2025 07:53, Bertrand Marquis wrote: >> Hi Ayan, > Hi Bertrand, >> >> This is a lot better. >> I just have some minor phrasing comments after. >> >>>

Re: [PATCH v4] docs: fusa: Add dom0less domain configuration requirements

2025-01-08 Thread Bertrand Marquis
Hi Ayan, This is a lot better. I just have some minor phrasing comments after. > On 8 Jan 2025, at 18:03, Ayan Kumar Halder wrote: > > From: Michal Orzel > > Add requirements for dom0less domain creation. > > Signed-off-by: Michal Orzel > Signed-off-by: Ayan Kumar Halder > --- > Changes fr

Re: [PATCH v2] xen/arm: ffa: fix build with clang

2025-01-08 Thread Bertrand Marquis
granular call support") > Signed-off-by: Stewart Hildebrand Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > v1->v2: > * remove declaration and make definition static > --- > xen/arch/arm/tee/ffa.c | 2 +- > xen/arch/arm/tee/ffa_private.h | 1 - > 2 files cha

Re: [PATCH] xen/arm: ffa: fix build with clang

2025-01-08 Thread Bertrand Marquis
Hi, > On 8 Jan 2025, at 16:45, Alejandro Vallejo > wrote: > > Hi, > > On Wed Jan 8, 2025 at 3:23 PM GMT, Stewart Hildebrand wrote: >> Clang 16 reports: >> >> In file included from arch/arm/tee/ffa.c:72: >> arch/arm/tee/ffa_private.h:329:17: error: 'used' attribute ignored on a >> non-definit

Re: [PATCH] xen/arm: ffa: fix build with clang

2025-01-08 Thread Bertrand Marquis
t;xen/arm: ffa: Fine granular call support") > Signed-off-by: Stewart Hildebrand Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > It appears the variable ffa_fw_version is only used in ffa.c. Was there > any rationale for exporting the symbol in 2f9f240a5e87 ("xen/ar

Re: [PATCH v3] docs: fusa: Add dom0less domain configuration requirements

2025-01-08 Thread Bertrand Marquis
Hi Ayan, > On 8 Jan 2025, at 13:54, Ayan Kumar Halder wrote: > > > On 08/01/2025 07:51, Bertrand Marquis wrote: >> Hi Ayan, > > Hi Bertrand, > > I just need clarifications on the two points and then I can send v4. > > < sn

Re: [for-4.20][PATCH] xen/arm64: Drop relocate_and_switch_ttbr() stub

2025-01-08 Thread Bertrand Marquis
his assumption is > incorrect as we already rely on DCE for cases like this one. Therefore > drop the stub, that otherwise would be a place potentially prone to > errors in the future. > > Suggested-by: Julien Grall > Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis

Re: [PATCH v3] docs: fusa: Add dom0less domain configuration requirements

2025-01-07 Thread Bertrand Marquis
Hi Ayan, > On 19 Dec 2024, at 11:56, Ayan Kumar Halder wrote: > > From: Michal Orzel > > Add requirements for dom0less domain creation. > > Signed-off-by: Michal Orzel > Signed-off-by: Ayan Kumar Halder > --- > Changes from - > > v1 - 1. As the dom0less domain creation requirements specifi

[PATCH] xen/arm: ffa: add changelog entries for FF-A improvements

2025-01-07 Thread Bertrand Marquis
Add a CHANGELOG entry for release 4.20 to mention the various improvements and fixes that have been done in the FF-A support since 4.19 release. Signed-off-by: Bertrand Marquis --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8507e6556a56

Re: [PATCH v3 3/6] xen/arm: platforms: Add NXP S32G3 Processors config

2024-12-18 Thread Bertrand Marquis
Hi Andrei, > On 18 Dec 2024, at 16:56, Andrei Cherechesu > wrote: > > Hi Bertrand, Andrew, > > On 18/12/2024 17:33, Bertrand Marquis wrote: >> Hi Andrew, >> >>> On 18 Dec 2024, at 16:19, Andrew Cooper wrote: >>> >>> On 18/12/2024 1

Re: [PATCH v3 3/6] xen/arm: platforms: Add NXP S32G3 Processors config

2024-12-18 Thread Bertrand Marquis
Hi Andrew, > On 18 Dec 2024, at 16:19, Andrew Cooper wrote: > > On 18/12/2024 10:11 am, Andrei Cherechesu (OSS) wrote: >> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig >> index 02322c259c..6dbf6ec87b 100644 >> --- a/xen/arch/arm/platforms/Kconfig >> +++ b/xen/arch/

Re: [PATCH v2] docs: fusa: Add dom0less domain configuration requirements

2024-12-18 Thread Bertrand Marquis
Hi, > On 18 Dec 2024, at 15:09, Ayan Kumar Halder wrote: > > Hi Bertrand/Michal, > > On 18/12/2024 14:00, Bertrand Marquis wrote: >> Hi Michal, >> >>> On 18 Dec 2024, at 14:56, Michal Orzel wrote: >>> >>> >>> >

Re: [PATCH v2] docs: fusa: Add dom0less domain configuration requirements

2024-12-18 Thread Bertrand Marquis
Hi Michal, > On 18 Dec 2024, at 14:56, Michal Orzel wrote: > > > > On 18/12/2024 14:08, Bertrand Marquis wrote: >> >> >> Hi Ayan, >> >>> On 18 Dec 2024, at 12:34, Ayan Kumar Halder wrote: >>> >>> >>>

Re: [PATCH v2] docs: fusa: Add dom0less domain configuration requirements

2024-12-18 Thread Bertrand Marquis
Hi Ayan, > On 18 Dec 2024, at 12:34, Ayan Kumar Halder wrote: > > > On 18/12/2024 08:27, Bertrand Marquis wrote: >> Hi Ayan, > Hi Bertrand, >> >>> On 12 Dec 2024, at 20:03, Ayan Kumar Halder >>> wrote: >>> >>> From: Micha

Re: [PATCH v3 6/6] MAINTAINERS: Add myself as maintainer for NXP S32G3

2024-12-18 Thread Bertrand Marquis
Hi Andrei, > On 18 Dec 2024, at 11:11, Andrei Cherechesu (OSS) > wrote: > > From: Andrei Cherechesu > > Add myself as maintainer for NXP S32G3 SoCs Family, > and the S32 Linux Team as relevant reviewers list. > > Signed-off-by: Andrei Cherechesu Acked-by

Re: [PATCH v3 4/6] CHANGELOG.md: Add NXP S32G3 and SCMI-SMC layer support mentions

2024-12-18 Thread Bertrand Marquis
Hi Andrei, > On 18 Dec 2024, at 11:11, Andrei Cherechesu (OSS) > wrote: > > From: Andrei Cherechesu > > Signed-off-by: Andrei Cherechesu Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > CHANGELOG.md | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [PATCH v3 5/6] SUPPORT.md: Describe SCMI-SMC layer feature

2024-12-18 Thread Bertrand Marquis
DT during initialization, it fails > silently as it's not mandatory. > > The SCMI SMCs trapping at EL2 now lets hwdom perform SCMI ops for > interacting with system-level resources almost as if it would be > running natively. > > Signed-off-by: Andrei Cherechesu

Re: [PATCH v3 3/6] xen/arm: platforms: Add NXP S32G3 Processors config

2024-12-18 Thread Bertrand Marquis
tem-level resources from > firmware at EL3. > > Signed-off-by: Andrei Cherechesu Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/platforms/Kconfig | 8 > 1 file changed, 8 insertions(+) > > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/

Re: [PATCH v2] docs: fusa: Add dom0less domain configuration requirements

2024-12-18 Thread Bertrand Marquis
Hi Ayan, > On 12 Dec 2024, at 20:03, Ayan Kumar Halder wrote: > > From: Michal Orzel > > Add requirements for dom0less domain creation. > > Signed-off-by: Michal Orzel > Signed-off-by: Ayan Kumar Halder > --- > Changes from v1 :- > > 1. As the dom0less domain creation requirements specifie

Re: [PATCH v3 04/10] xen/arm: ffa: Fine granular call support

2024-12-17 Thread Bertrand Marquis
Hi, > On 16 Dec 2024, at 21:05, Julien Grall wrote: > > > > On 16/12/2024 08:06, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 13 Dec 2024, at 23:57, Julien Grall wrote: >>> >>> Hi Bertrand, >>> >&g

Re: [PATCH v3 04/10] xen/arm: ffa: Fine granular call support

2024-12-16 Thread Bertrand Marquis
Hi Julien, > On 13 Dec 2024, at 23:57, Julien Grall wrote: > > Hi Bertrand, > > On 27/11/2024 16:07, Bertrand Marquis wrote: >> Create a bitmap to store which feature is supported or not by the >> firmware and use it to filter which calls are done to the firmware

Re: [PATCH] MAINTAINERS: add Anthony, Michal, Roger to THE REST

2024-12-10 Thread Bertrand Marquis
Stabellini Acked-by: Bertrand Marquis

Re: [PATCH v3 07/10] xen/arm: ffa: Transmit RXTX buffers to the SPMC

2024-12-06 Thread Bertrand Marquis
Hi Jens, > On 6 Dec 2024, at 08:58, Jens Wiklander wrote: > > Hi Bertrand, > > On Wed, Nov 27, 2024 at 5:08 PM Bertrand Marquis > wrote: >> >> When an RXTX buffer is mapped by a VM transmit it to the SPMC when it >> supports RX_ACQUIRE. >> As a c

Re: [PATCH] bootfdt: Add missing trailing commas in BOOTINFO_{ACPI,SHMEM}_INIT

2024-12-03 Thread Bertrand Marquis
initdata bootinfo = BOOTINFO_INIT; > > Fixes: a14593e3995a ("xen/device-tree: Allow region overlapping with > /memreserve/ ranges") > Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/include/xen/bootfdt.h | 4 ++-- > 1 fil

[PATCH v3 08/10] xen/arm: ffa: move message function into ffa_msg.c

2024-11-27 Thread Bertrand Marquis
Move the direct message handling function in its own source file and rename it to have a ffa_ prefix. This is a preparation to add support for indirect messages which will go into this newly created source file. Signed-off-by: Bertrand Marquis Reviewed-by: Jens Wiklander --- Changes in v3

[PATCH v3 09/10] xen/arm: ffa: Remove per VM notif_enabled

2024-11-27 Thread Bertrand Marquis
notifications, there won't be any generated and setting one will give back a NOT_SUPPORTED. Signed-off-by: Bertrand Marquis --- Changes in v3: - Add a comment explaining why it is ok to call bitmap destroy even if bitmap create failed. Changes in v2: - rebase --- xen/arch/arm/tee/ffa.c

[PATCH v3 10/10] xen/arm: ffa: Add indirect message support

2024-11-27 Thread Bertrand Marquis
Add support for FFA_MSG_SEND2 to send indirect messages from a VM to a secure partition. Signed-off-by: Bertrand Marquis --- Changes in v3: - in ffa_handle_msg_send2 use ffa_get_vm_id instead of a local variable to make sure that we use the right VM ID as source without having a potential

[PATCH v3 05/10] xen/arm: ffa: Rework partition info get

2024-11-27 Thread Bertrand Marquis
this and the subscriber discovery on probe. No functional changes expected. Signed-off-by: Bertrand Marquis Reviewed-by: Jens Wiklander --- Changes in v3: - add Jens R-b Changes in v2: - rebase --- xen/arch/arm/tee/ffa.c | 13 +-- xen/arch/arm/tee/ffa_partinfo.c | 185

[PATCH v3 03/10] xen/arm: ffa: Fix version negotiation

2024-11-27 Thread Bertrand Marquis
major but greater minor is requested - use requested version if same major but lower minor is requested - do not use if incompatible major is requested - always return our version without error to the requester [1] https://developer.arm.com/documentation/den0077/e/ Signed-off-by: Bertrand Marquis

[PATCH v3 04/10] xen/arm: ffa: Fine granular call support

2024-11-27 Thread Bertrand Marquis
Create a bitmap to store which feature is supported or not by the firmware and use it to filter which calls are done to the firmware. While there reoder ABI definition by numbers to easily find the min and max ones. Signed-off-by: Bertrand Marquis Reviewed-by: Jens Wiklander --- Changes in v3

[PATCH v3 07/10] xen/arm: ffa: Transmit RXTX buffers to the SPMC

2024-11-27 Thread Bertrand Marquis
: ffa: separate rxtx buffer routines") Signed-off-by: Bertrand Marquis --- Changes in v3: - add a comment to explain why we only release the RX buffer if an error occurs during partition_info_get - fix the BUILD_BUG_ON check for TX buffer size in rxtx_map (coding style and use PAGE_SIZE

[PATCH v3 01/10] xen/arm: ffa: Rework firmware discovery

2024-11-27 Thread Bertrand Marquis
Rework firmware discovery during probe: - move prints into the probe - rename ffa_version to ffa_fw_version as the variable identifies the version of the firmware and not the one we support - add error prints when allocation fail during probe No functional changes. Signed-off-by: Bertrand

[PATCH v3 06/10] xen/arm: ffa: Use bit 15 convention for SPs

2024-11-27 Thread Bertrand Marquis
between secure and non-secure endpoints, preventing the need to store a list of secure endpoint IDs in Xen. Signed-off-by: Bertrand Marquis --- Changes in v3: - rename real_num to n_limit - remove log of skipped SP due to invalid ID as it is already printed Changes in v2: - rebase --- xen/arch

[PATCH v3 00/10] xen/arm: ffa: Improvements and fixes

2024-11-27 Thread Bertrand Marquis
omments in code - add some R-b from Jens - handle comments from Jens (details in each patch) - rebase on top of latest staging Changes in v2: - do not activate FF-A if firmware does not support it - various clean up and small fixes explained in each patch - rebase on top of latest staging Bertra

[PATCH v3 02/10] xen/arm: ffa: Rework feature discovery

2024-11-27 Thread Bertrand Marquis
Store the list of ABI we need in a list and go through the list instead of having a list of conditions inside the code. No functional change. Signed-off-by: Bertrand Marquis --- Changes in v3: - remove const attribute for id in ffa_fw_abi struct Changes in v2: - Store a string version of ABI

Re: [PATCH] docs: fusa: Add requirements for mapping domain address to machine address

2024-11-19 Thread Bertrand Marquis
Hi Ayan, First a general comment: you use some terms such as machine address or domain address which are a bit undefined to me. This needs some definition first for those to be clear. Maybe use Virtual, IPA and PA instead all the time. > On 4 Nov 2024, at 20:06, Ayan Kumar Halder wrote: > > Th

Re: [PATCH] docs: fusa: Add dom0less domain configuration requirements

2024-11-19 Thread Bertrand Marquis
Hi Ayan and Julien, > On 16 Nov 2024, at 10:57, Julien Grall wrote: > > Hi Ayan, > > On 15/11/2024 18:53, Ayan Kumar Halder wrote: +Assign vCPUs from CPU pool +-- + +`XenSwdgn~arm64_assign_vcpus_cpu_pool~1` + +Description: +Xen shall as

Re: Xen 4.20 Development Update [August-October]

2024-11-13 Thread Bertrand Marquis
Hi, > On 13 Nov 2024, at 14:51, oleksii.kuroc...@gmail.com wrote: > > Hi Bertrand, > > On Wed, 2024-11-13 at 13:02 +, Bertrand Marquis wrote: >> Hi Oleksii, >> >>> On 12 Nov 2024, at 16:16, Oleksii Kurochko >>> wrote: >>> >>>

Re: Xen 4.20 Development Update [August-October]

2024-11-13 Thread Bertrand Marquis
ch64 MPU systems (v5) > - Ayan Kumar Halder > - > https://lore.kernel.org/xen-devel/20241107150330.181143-1-ayan.kumar.hal...@amd.com/T/#m9cfd8bed109cc703b6ae8b8b6faaa116c08598ee > > * Add support for S32CC platforms and LINFlexD UART (v2) > - Andrei Cherechesu > -

Re: [RFC PATCH 1/4] xen/arm: ffa: Introduce VM to VM support

2024-11-04 Thread Bertrand Marquis
Hi Jan, > On 4 Nov 2024, at 08:46, Jan Beulich wrote: > > On 04.11.2024 08:19, Bertrand Marquis wrote: >> Hi Andrew, >> >>> On 1 Nov 2024, at 12:05, Andrew Cooper wrote: >>> >>> On 16/10/2024 10:21 am, Bertrand Marquis wrote: >>>> d

Re: [RFC PATCH 1/4] xen/arm: ffa: Introduce VM to VM support

2024-11-03 Thread Bertrand Marquis
Hi Andrew, > On 1 Nov 2024, at 12:05, Andrew Cooper wrote: > > On 16/10/2024 10:21 am, Bertrand Marquis wrote: >> diff --git a/xen/arch/arm/tee/ffa_partinfo.c >> b/xen/arch/arm/tee/ffa_partinfo.c >> index fde187dba4e5..d699a267cc76 100644 >> --- a/xen/arch/ar

Re: [RFC PATCH 4/4] xen/arm: ffa: Enable VM to VM without firmware

2024-11-03 Thread Bertrand Marquis
Hi Jens, > On 1 Nov 2024, at 11:44, Jens Wiklander wrote: > > Hi Bertrand, > > On Wed, Oct 16, 2024 at 11:22 AM Bertrand Marquis > wrote: >> >> When VM to VM support is activated and there is no suitable FF-A support >> in the firmware, enable FF-A support

Re: [PATCH v2 10/10] xen/arm: ffa: Add indirect message support

2024-10-24 Thread Bertrand Marquis
Hi Jens, > On 24 Oct 2024, at 15:43, Jens Wiklander wrote: > > Hi Bertrand, > > On Thu, Oct 24, 2024 at 12:05 PM Bertrand Marquis > wrote: >> >> Hi Jens, >> >>> On 24 Oct 2024, at 10:50, Jens Wiklander wrote: >>> >>> Hi Bertr

Re: [PATCH v2 10/10] xen/arm: ffa: Add indirect message support

2024-10-24 Thread Bertrand Marquis
Hi Jens, > On 24 Oct 2024, at 10:50, Jens Wiklander wrote: > > Hi Bertrand, > > On Wed, Oct 16, 2024 at 10:32 AM Bertrand Marquis > wrote: >> >> Add support for FFA_MSG_SEND2 to send indirect messages from a VM to a >> secure partition. &g

Re: [PATCH v2 04/10] xen/arm: ffa: Fine granular call support

2024-10-24 Thread Bertrand Marquis
Hi Jens, > On 24 Oct 2024, at 10:15, Jens Wiklander wrote: > > On Wed, Oct 23, 2024 at 11:58 AM Jens Wiklander > wrote: >> >> Hi Bertrand, >> >> On Wed, Oct 16, 2024 at 10:32 AM Bertrand Marquis >> wrote: >>> >>> Creat

Re: [PATCH v2 09/10] xen/arm: ffa: Remove per VM notif_enabled

2024-10-24 Thread Bertrand Marquis
Hi Jens, > On 24 Oct 2024, at 09:41, Jens Wiklander wrote: > > Hi Bertrand, > > On Wed, Oct 16, 2024 at 10:32 AM Bertrand Marquis > wrote: >> >> Remove the per VM flag to store if notifications are enabled or not as >> the only case where they are not, i

Re: [PATCH v2 07/10] xen/arm: ffa: Transmit RXTX buffers to the SPMC

2024-10-24 Thread Bertrand Marquis
Hi Jens, > On 23 Oct 2024, at 16:51, Jens Wiklander wrote: > > Hi Bertrand, > > On Wed, Oct 16, 2024 at 10:32 AM Bertrand Marquis > wrote: >> >> When an RXTX buffer is mapped by a VM transmit it to the SPMC when it >> supports RX_ACQUIRE. >> As a c

Re: [PATCH v2 06/10] xen/arm: ffa: Use bit 15 convention for SPs

2024-10-24 Thread Bertrand Marquis
Hi Jens, > On 23 Oct 2024, at 15:15, Jens Wiklander wrote: > > Hi Bertrand, > > On Wed, Oct 16, 2024 at 10:32 AM Bertrand Marquis > wrote: >> >> Make use and required to have bit 15 convention respected by secure >> world (having bit 15 of IDs set for sec

Re: [PATCH v2 02/10] xen/arm: ffa: Rework feature discovery

2024-10-23 Thread Bertrand Marquis
Hi Jens, > On 22 Oct 2024, at 08:30, Jens Wiklander wrote: > > Hi Bertrand, > > On Wed, Oct 16, 2024 at 10:32 AM Bertrand Marquis > wrote: >> >> Store the list of ABI we need in a list and go through the list instead >> of having a list of conditions i

Re: [PATCH v2 01/10] xen/arm: ffa: Rework firmware discovery

2024-10-23 Thread Bertrand Marquis
Hi Jens, > On 21 Oct 2024, at 19:03, Jens Wiklander wrote: > > Hi Bertrand, > > On Wed, Oct 16, 2024 at 10:32 AM Bertrand Marquis > wrote: >> >> Rework firmware discovery during probe: >> - move prints into the probe >> - rename ffa_version to ffa

Re: [PATCH v2] MAINTAINERS: minor file line update

2024-10-17 Thread Bertrand Marquis
EDIATORS >>> M: Volodymyr Babchuk >>> S: Supported >>> -F: xen/arch/arm/include/asm/tee >>> +F: xen/arch/arm/include/asm/tee/ >>> F: xen/arch/arm/tee/ >> > > Acked-by: Volodymyr Babchuk Acked-by: Bertrand Marquis Cheers Bertrand >

[RFC PATCH 3/4] xen/arm: ffa: Add indirect message between VM

2024-10-16 Thread Bertrand Marquis
Add support for indirect messages between VMs. This is only enabled if CONFIG_FFA_VM_TO_VM is selected. Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/ffa_msg.c | 96 ++ 1 file changed, 88 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/tee

[RFC PATCH 4/4] xen/arm: ffa: Enable VM to VM without firmware

2024-10-16 Thread Bertrand Marquis
the global flag to only be used as check for firmware notification support instead. Modify part_info_get to return the list of VMs when there is no firmware support. Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 11 +++ xen/arch/arm/tee/ffa_notif.c| 118

[RFC PATCH 2/4] xen/arm: ffa: Add buffer full notification support

2024-10-16 Thread Bertrand Marquis
simplified to only handle the buffer full notification using a boolean. If other framework notifications have to be supported one day, the design will have to be modified to handle it properly. Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/ffa_notif.c | 26 +- xen

[RFC PATCH 1/4] xen/arm: ffa: Introduce VM to VM support

2024-10-16 Thread Bertrand Marquis
Create a CONFIG_FFA_VM_TO_VM parameter to activate FFA communication between VMs. When activated list VMs in the system with FF-A support in part_info_get. WARNING: There is no filtering for now and all VMs are listed !! Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/Kconfig| 11

[RFC PATCH 0/4] FF-A VM to VM support

2024-10-16 Thread Bertrand Marquis
sharing living on the side of Xen grantables. This serie must be applied on top of [1] which introduces some rework of FF-A support required by this patch serie. !! This patch serie must no be merged !! [1] https://lore.kernel.org/xen-devel/cover.1729066788.git.bertrand.marq...@arm.com/ Bertrand

[PATCH v2 09/10] xen/arm: ffa: Remove per VM notif_enabled

2024-10-16 Thread Bertrand Marquis
notifications, there won't be any generated and setting one will give back a NOT_SUPPORTED. Signed-off-by: Bertrand Marquis --- Changes in v2: - rebase --- xen/arch/arm/tee/ffa.c | 17 +++-- xen/arch/arm/tee/ffa_notif.c | 10 +- xen/arch/arm/tee/ffa_private.h | 2 -- 3

[PATCH v2 07/10] xen/arm: ffa: Transmit RXTX buffers to the SPMC

2024-10-16 Thread Bertrand Marquis
change move some structure definition to ffa_private from ffa_shm as those are need for the MAP call with the SPMC. Signed-off-by: Bertrand Marquis --- Changes in v2: - unmap VM rxtx buffer in SPMC on unmap call or on VM destroy - rework the unmap call to the SPMC to properly pass the VM ID --- xen

[PATCH v2 04/10] xen/arm: ffa: Fine granular call support

2024-10-16 Thread Bertrand Marquis
Create a bitmap to store which feature is supported or not by the firmware and use it to filter which calls are done to the firmware. While there reoder ABI definition by numbers to easily find the min and max ones. Signed-off-by: Bertrand Marquis --- Changes in v2: - rename fw_feat to abi and

[PATCH v2 02/10] xen/arm: ffa: Rework feature discovery

2024-10-16 Thread Bertrand Marquis
Store the list of ABI we need in a list and go through the list instead of having a list of conditions inside the code. No functional change. Signed-off-by: Bertrand Marquis --- Changes in v2: - Store a string version of ABI needed from firmware and print the name of the ABI not supported

[PATCH v2 10/10] xen/arm: ffa: Add indirect message support

2024-10-16 Thread Bertrand Marquis
Add support for FFA_MSG_SEND2 to send indirect messages from a VM to a secure partition. Signed-off-by: Bertrand Marquis --- Changes in v2: - rebase --- xen/arch/arm/tee/ffa.c | 5 xen/arch/arm/tee/ffa_msg.c | 49 ++ xen/arch/arm/tee

[PATCH v2 06/10] xen/arm: ffa: Use bit 15 convention for SPs

2024-10-16 Thread Bertrand Marquis
between secure and non-secure endpoints, preventing the need to store a list of secure endpoint IDs in Xen. Signed-off-by: Bertrand Marquis --- Changes in v2: - rebase --- xen/arch/arm/tee/ffa.c | 22 +++--- xen/arch/arm/tee/ffa_partinfo.c | 54

[PATCH v2 08/10] xen/arm: ffa: move message function into ffa_msg.c

2024-10-16 Thread Bertrand Marquis
Move the direct message handling function in its own source file and rename it to have a ffa_ prefix. This is a preparation to add support for indirect messages which will go into this newly created source file. Signed-off-by: Bertrand Marquis --- Changes in v2: - rebase --- xen/arch/arm/tee

[PATCH v2 05/10] xen/arm: ffa: Rework partition info get

2024-10-16 Thread Bertrand Marquis
this and the subscriber discovery on probe. No functional changes expected. Signed-off-by: Bertrand Marquis --- Changes in v2: - rebase --- xen/arch/arm/tee/ffa.c | 13 +-- xen/arch/arm/tee/ffa_partinfo.c | 185 xen/arch/arm/tee/ffa_private.h | 4

[PATCH v2 00/10] xen/arm: ffa: Improvements and fixes

2024-10-16 Thread Bertrand Marquis
ivate FF-A if firmware does not support i - various clean up and small fixes explained in each patch - rebase on top of latest staging Bertrand Marquis (10): xen/arm: ffa: Rework firmware discovery xen/arm: ffa: Rework feature discovery xen/arm: ffa: Fix version negotiation xen/arm: ffa: Fin

[PATCH v2 01/10] xen/arm: ffa: Rework firmware discovery

2024-10-16 Thread Bertrand Marquis
Rework firmware discovery during probe: - move prints into the probe - rename ffa_version to ffa_fw_version as the variable identifies the version of the firmware and not the one we support - add error prints when allocation fail during probe No functional changes. Signed-off-by: Bertrand

[PATCH v2 03/10] xen/arm: ffa: Fix version negotiation

2024-10-16 Thread Bertrand Marquis
major but greater minor is requested - use requested version if same major but lower minor is requested - do not use if incompatible major is requested - always return our version without error to the requester [1] https://developer.arm.com/documentation/den0077/e/ Signed-off-by: Bertrand Marquis

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-10 Thread Bertrand Marquis
HI Ayan, > On 10 Oct 2024, at 11:18, Ayan Kumar Halder wrote: > > Hi Bertrand, > > < snip> > >>> 4) AoU on domain - 1) Domains should not use HVC DCC registers as Xen does >>> not emulate them. >> Xen does not depend on that, the domain does so this is only a Xen expected >> behaviour and we

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-09 Thread Bertrand Marquis
Hi Oleksandr, > On 9 Oct 2024, at 19:20, Oleksandr Tyshchenko wrote: > > > > On 09.10.24 09:36, Bertrand Marquis wrote: >> Hi Oleksandr, > > Hello Bertrand > > >>> On 8 Oct 2024, at 20:53, Oleksandr Tyshchenko wrote: >>> >>>

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-09 Thread Bertrand Marquis
Hi Ayan, > On 9 Oct 2024, at 13:24, Ayan Kumar Halder wrote: > > Hi Bertrand/Stefano/all, > > Let me know if the explanation makes sense. > > On 09/10/2024 07:30, Bertrand Marquis wrote: >> Hi Stefano, >> >>> On 9 Oct 2024, at 00:46, Stefano Stab

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-08 Thread Bertrand Marquis
Hi Oleksandr, > On 8 Oct 2024, at 20:53, Oleksandr Tyshchenko wrote: > > > > On 08.10.24 09:17, Bertrand Marquis wrote: >> Hi, > > Hello Bertrand > > >>> On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: >>> >>> From:

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-08 Thread Bertrand Marquis
Hi Stefano, > On 9 Oct 2024, at 00:46, Stefano Stabellini wrote: > > On Tue, 8 Oct 2024, Oleksandr Tyshchenko wrote: On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Add common requirements for a physical device assignment to Arm64

[PATCH] MAINTAINERS: add myself as maintainer for arm tee

2024-10-08 Thread Bertrand Marquis
With Tee mediators now containing Optee and FF-A implementations, add myself as maintainers to have someone handling the FF-A side. Signed-off-by: Bertrand Marquis --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb0ebf093965..2450b0f9ff9e

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-07 Thread Bertrand Marquis
Hi, > On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: > > From: Oleksandr Tyshchenko > > Add common requirements for a physical device assignment to Arm64 > and AMD64 PVH domains. > > Signed-off-by: Oleksandr Tyshchenko > --- > Based on: > [PATCH] docs: fusa: Replace VM with domain > ht

Re: [PATCH] docs: fusa: Replace VM with domain

2024-10-07 Thread Bertrand Marquis
Hi Ayan, > On 7 Oct 2024, at 20:26, Ayan Kumar Halder wrote: > > We should use the word domain everywhere (instead of VM or guest). > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > docs/fusa/reqs/market-reqs

Re: [PATCH 07/10] xen/arm: ffa: Transmit RXTX buffers to the SPMC

2024-09-25 Thread Bertrand Marquis
Hi Jens, > On 23 Sep 2024, at 19:36, Jens Wiklander wrote: > > Hi, > > On Thu, Sep 19, 2024 at 2:20 PM Bertrand Marquis > wrote: >> >> When an RXTX buffer is mapped by a VM transmit it to the SPMC when it >> supports RX_ACQUIRE. >> As a consequence o

Re: [PATCH 02/10] xen/arm: ffa: Rework feature discovery

2024-09-25 Thread Bertrand Marquis
Hi Julien, > On 24 Sep 2024, at 19:31, Julien Grall wrote: > > Hi Bertrand, > > On 24/09/2024 09:16, Bertrand Marquis wrote: >>> On 22 Sep 2024, at 11:07, Julien Grall wrote: >>> >>> Hi, >>> >>> On 19/09/2024 14:19, Bertrand Marqui

Re: [PATCH 03/10] xen/arm: ffa: fix version negotiation

2024-09-25 Thread Bertrand Marquis
Hi Julien, > On 25 Sep 2024, at 18:45, Julien Grall wrote: > > > > On 24/09/2024 09:23, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > > >>> On 22 Sep 2024, at 14:25, Julien Grall wrote: >>> >>> Hi Bertrand, &

Re: [PATCH 04/10] xen/arm: ffa: Fine granular call support

2024-09-25 Thread Bertrand Marquis
Hi Julien, > On 22 Sep 2024, at 15:03, Julien Grall wrote: > > Hi Bertrand, > > On 19/09/2024 14:19, Bertrand Marquis wrote: >> Create a bitmap to store which feature is supported or not by the >> firmware and use it to filter which calls done to the firmware. >&

Re: [PATCH 04/10] xen/arm: ffa: Fine granular call support

2024-09-25 Thread Bertrand Marquis
 PM Julien Grall wrote: >>> >>> Hi Bertrand, >>> >>> On 19/09/2024 14:19, Bertrand Marquis wrote: >>>> Create a bitmap to store which feature is supported or not by the >>>> firmware and use it to filter which calls done to the firmware.

Re: [PATCH v4] docs: fusa: Add Assumption of Use (AOU)

2024-09-24 Thread Bertrand Marquis
consequently there is an assumption on the platform to program the > register correctly. > > Signed-off-by: Michal Orzel > Signed-off-by: Ayan Kumar Halder > Reviewed-by: Julien Grall With "functional" change to "operational" as suggested by Andrew: Revie

Re: [PATCH v3] docs: fusa: Add Assumption of Use (AoU)

2024-09-24 Thread Bertrand Marquis
Hi Andrew, > On 24 Sep 2024, at 10:15, Andrew Cooper wrote: > > On 24/09/2024 8:14 am, Bertrand Marquis wrote: >>>>> diff --git a/docs/fusa/reqs/intro.rst b/docs/fusa/reqs/intro.rst >>>>> index 245a219ff2..aa85ff821c 100644 >>>>> ---

Re: [PATCH 01/10] xen/arm: ffa: Rework firmware discovery

2024-09-24 Thread Bertrand Marquis
Hi Julien, > On 22 Sep 2024, at 11:00, Julien Grall wrote: > > Hi Bertrand, > > On 19/09/2024 14:19, Bertrand Marquis wrote: >> Rework firmware discovery during probe: >> - move prints into the probe >> - rename ffa_version to ffa_fw_version as the variable i

Re: [PATCH 03/10] xen/arm: ffa: fix version negotiation

2024-09-24 Thread Bertrand Marquis
Hi Julien, > On 22 Sep 2024, at 14:25, Julien Grall wrote: > > Hi Bertrand, > > NIT Typo: s/fix/Fix/ to match the other title Ack > > On 19/09/2024 14:19, Bertrand Marquis wrote: >> Fix FFA version negotiation with the firmware to follow the >> specificati

Re: [PATCH 02/10] xen/arm: ffa: Rework feature discovery

2024-09-24 Thread Bertrand Marquis
Hi Julien, Thanks a lot for the review. > On 22 Sep 2024, at 11:07, Julien Grall wrote: > > Hi, > > On 19/09/2024 14:19, Bertrand Marquis wrote: >> Store the list of ABI we need in a list and go through the list instead >> of having a list of conditions inside

Re: [PATCH v3] docs: fusa: Add Assumption of Use (AoU)

2024-09-24 Thread Bertrand Marquis
Hi Ayan, > On 23 Sep 2024, at 18:57, Ayan Kumar Halder wrote: > > > On 19/09/2024 13:01, Bertrand Marquis wrote: >> Hi Ayan, > Hi Bertrand, >> >>> On 16 Sep 2024, at 14:18, Ayan Kumar Halder >>> wrote: >>> >>> From: Michal O

Re: [PATCH v2 1/4] xen/arm: mpu: Introduce choice between MMU and MPU

2024-09-19 Thread Bertrand Marquis
Hi, > On 19 Sep 2024, at 14:33, Julien Grall wrote: > > Hi Ayan, > > On 18/09/2024 19:50, Ayan Kumar Halder wrote: >> There are features in the forthcoming patches which are dependent on >> MPU. For eg fixed start address. >> Also, some of the Xen features (eg STATIC_MEMORY) will be selected >>

Re: [PATCH v2] docs/misra: add R17.2 and R18.2

2024-09-19 Thread Bertrand Marquis
h rules to rules.rst > enables us to immediately make both rules gating in the ECLAIR job part > of gitlab-ci. > > Signed-off-by: Stefano Stabellini Acked-by: Bertrand Marquis Cheers Bertrand > --- > Changes in v2: > - improve the note of 17.2 > > diff --git a/docs

[PATCH 07/10] xen/arm: ffa: Transmit RXTX buffers to the SPMC

2024-09-19 Thread Bertrand Marquis
change move some structure definition to ffa_private from ffa_shm as those are need for the MAP call with the SPMC. Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 2 +- xen/arch/arm/tee/ffa_partinfo.c | 28 +++ xen/arch/arm/tee/ffa_private.h | 22 +- xen/arch/arm

[PATCH 09/10] xen/arm: ffa: Remove per VM notif_enabled

2024-09-19 Thread Bertrand Marquis
notifications, there won't be any generated and setting one will give back a NOT_SUPPORTED. Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 17 +++-- xen/arch/arm/tee/ffa_notif.c | 10 +- xen/arch/arm/tee/ffa_private.h | 2 -- 3 files changed, 4 inser

[PATCH 06/10] xen/arm: ffa: Use bit 15 convention for SPs

2024-09-19 Thread Bertrand Marquis
between secure and non-secure endpoints, preventing the need to store a list of secure endpoint IDs in Xen. Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 22 +++--- xen/arch/arm/tee/ffa_partinfo.c | 54 + xen/arch/arm/tee

[PATCH 10/10] xen/arm: ffa: Add indirect message support

2024-09-19 Thread Bertrand Marquis
Add support for FFA_MSG_SEND2 to send indirect messages from a VM to a secure partition. Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 5 xen/arch/arm/tee/ffa_msg.c | 49 ++ xen/arch/arm/tee/ffa_private.h | 1 + 3 files changed

[PATCH 03/10] xen/arm: ffa: fix version negotiation

2024-09-19 Thread Bertrand Marquis
urn 1.0 if 1.0 was requested Signed-off-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 7ff2529b2055..1f602f25d097 100644 --- a/xen/arch/

[PATCH 00/10] xen/arm: ffa: Improvements and fixes

2024-09-19 Thread Bertrand Marquis
ication to distinguish between secure and non-secure identifiers as Xen VM IDs cannot have bit 15 set. Finally we introduce support for indirect messages and for that we transmit the RXTX buffers to the SPMC and we put the message related functions into their own source file. Bertrand Marquis (10): xe

[PATCH 01/10] xen/arm: ffa: Rework firmware discovery

2024-09-19 Thread Bertrand Marquis
Rework firmware discovery during probe: - move prints into the probe - rename ffa_version to ffa_fw_version as the variable identifies the version of the firmware and not the one we support - add error prints when allocation fail during probe No functional changes. Signed-off-by: Bertrand

  1   2   3   4   5   6   7   8   9   10   >