Re: [PATCH 1/1] xen/common: Remove dead code

2025-01-10 Thread Ariel Otilibili-Anieli
Hi Stefano, On Thursday, January 02, 2025 18:08 CET, Stefano Stabellini wrote: > On Thu, 19 Dec 2024, Ariel Otilibili wrote: > > Reviewed-by: Stefano Stabellini > > Thanks for having looked into the patch; sorry for the late response, I have had limited access to my m

Re: [PATCH v3 1/1] libacpi/Makefile: clear ASL warning about PCI0

2024-12-27 Thread Ariel Otilibili-Anieli
On Friday, December 27, 2024 15:27 CET, Jan Beulich wrote: > On 22.12.2024 17:10, Ariel Otilibili wrote: > > iasl has one ID per warning [6]; subsequent commits will address other ASL > > warnings. > > > > ``` > > $ awk 'NR>533 && NR<556 {p

[PATCH v2 0/2] tools/libs,xen/tools: remove dead code

2024-12-24 Thread Ariel Otilibili
Hello, This series addresses the Coverity IDs 1056148, 1056149, & 1458052. Thank you, --- v2: * addresse feedback of Jan Beulich on expr.c Ariel Otilibili (2): tools/libs: remove dead code xen/tools: remove dead code tools/libs/light/libxl_create.c | 1 - tools/libs/light/libxl_devi

[PATCH v2 1/2] tools/libs: remove dead code

2024-12-24 Thread Ariel Otilibili
Default switch cases skip these steps; these instructions are never reached. Coverity-IDs: 1056148, 1056149 Fixes: 0a69ea908d ("libxl: ao: convert libxl__spawn_*") Fixes: 643b106b40 ("libxl: do not use tap disk backend other than for raw and vhd") Signed-off-by: Ariel Otili

[PATCH v2 2/2] xen/tools: remove dead code

2024-12-24 Thread Ariel Otilibili
"%s")' 6419020270 ("CHANGELOG: Mention LLC coloring feature on Arm") $ git remote -v up git://xenbits.xen.org/xen.git (fetch) up git://xenbits.xen.org/xen.git (push) ``` Coverity-ID: 1458052 Fixes: 8c271b7584 ("build: import Kbuild/Kconfig from Linux 4.

Re: [PATCH 2/2] xen/tools: remove dead code

2024-12-24 Thread Ariel Otilibili-Anieli
On Tuesday, December 24, 2024 09:43 CET, Jan Beulich wrote: > On 20.12.2024 17:55, Ariel Otilibili wrote: > > Default switch case exits directly; these instructions are never reached. > > > > The file was taken from Linux; the copies have diverged a lot since: > > &g

[PATCH v3 1/1] libacpi/Makefile: clear ASL warning about PCI0

2024-12-22 Thread Ariel Otilibili
ation.html?highlight=_hid#device-identification-objects [6] https://github.com/acpica/acpica Fixes: 5a8b28bfd4 ("tools/libacpi: cleanup Makefile, don't check for iasl binary") Signed-off-by: Ariel Otilibili --- Cc: Jan Beulich Cc: Anthony PERARD --- tools/libacpi/Makefile | 6 -

[PATCH v3 0/1] libacpi/Makefile: clear ASL warning about PCI0

2024-12-22 Thread Ariel Otilibili
-b432-82f9c1276...@suse.com/ Ariel Otilibili (1): libacpi/Makefile: clear ASL warning about PCI0 tools/libacpi/Makefile | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.47.1

[PATCH 2/2] xen/tools: remove dead code

2024-12-20 Thread Ariel Otilibili
: 1458052 Fixes: 8c271b7584 ("build: import Kbuild/Kconfig from Linux 4.3") Signed-off-by: Ariel Otilibili -- Cc: Doug Goldstein --- xen/tools/kconfig/expr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/tools/kconfig/expr.c b/xen/tools/kconfig/expr.c index 773a05..be1400c

[PATCH 0/2] tools/libs,xen/tools: remove dead code

2024-12-20 Thread Ariel Otilibili
Hello, This series addresses the Coverity IDs 1056148, 1056149, & 1458052. Thank you, Ariel Otilibili (2): tools/libs: remove dead code xen/tools: remove dead code tools/libs/light/libxl_create.c | 1 - tools/libs/light/libxl_device.c | 1 - xen/tools/kconfig/expr.c| 2 -- 3 f

[PATCH 1/2] tools/libs: remove dead code

2024-12-20 Thread Ariel Otilibili
Default switch cases skip these steps; these instructions are never reached. Coverity-IDs: 1056148, 1056149 Fixes: 0a69ea908d ("libxl: ao: convert libxl__spawn_*") Fixes: 643b106b40 ("libxl: do not use tap disk backend other than for raw and vhd") Signed-off-by: Ariel Otili

Re: [PATCH v2 1/1] lib: Remove dead code

2024-12-20 Thread Ariel Otilibili-Anieli
On Friday, December 20, 2024 10:01 CET, "Ariel Otilibili-Anieli" wrote: > On Friday, December 20, 2024 09:53 CET, Greg KH > wrote: > > > On Fri, Dec 20, 2024 at 09:44:31AM +0100, Ariel Otilibili-Anieli wrote: > > > On Friday, December 20, 202

Re: [PATCH 1/1] xen/scripts: Fix regex syntax warnings with Python 3.12

2024-12-20 Thread Ariel Otilibili-Anieli
On Friday, December 20, 2024 09:49 CET, Luca Fancellu wrote: > Hi Ariel, > > > On 19 Dec 2024, at 18:10, Ariel Otilibili > > wrote: > > > > Same fix than commit 826a9eb072 (tools: Fix regex syntax warnings with > > Python 3.12). > > > > I

Re: [PATCH v2 1/1] lib: Remove dead code

2024-12-20 Thread Ariel Otilibili-Anieli
On Friday, December 20, 2024 09:53 CET, Greg KH wrote: > On Fri, Dec 20, 2024 at 09:44:31AM +0100, Ariel Otilibili-Anieli wrote: > > On Friday, December 20, 2024 08:09 CET, Greg KH > > wrote: > > > > > On Thu, Dec 19, 2024 at 11:45:01PM +0100, Ariel Otilibili w

Re: [PATCH v2 1/1] lib: Remove dead code

2024-12-20 Thread Ariel Otilibili-Anieli
On Friday, December 20, 2024 08:09 CET, Greg KH wrote: > On Thu, Dec 19, 2024 at 11:45:01PM +0100, Ariel Otilibili wrote: > > This is a follow up from a discussion in Xen: > > > > The if-statement tests `res` is non-zero; meaning the case zero is never > > reached

Re: + lib-remove-dead-code.patch added to mm-nonmm-unstable branch

2024-12-19 Thread Ariel Otilibili-Anieli
> > The -mm tree is included into linux-next via the mm-everything > branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > and is updated there every 2-3 working days > > -- > From: Ariel Otilibili > Subje

[PATCH v2 0/1] lib: Remove dead code

2024-12-19 Thread Ariel Otilibili
/ -- v2: * Cc stable Ariel Otilibili (1): lib: Remove dead code lib/inflate.c | 2 -- 1 file changed, 2 deletions(-) -- 2.47.1

[PATCH v2 1/1] lib: Remove dead code

2024-12-19 Thread Ariel Otilibili
ned-off-by: Ariel Otilibili -- Cc: sta...@vger.kernel.org Cc: Andrew Morton Cc: linux-ker...@vger.kernel.org Cc: Andrew Cooper Cc: Anthony PERARD Cc: Michal Orzel Cc: Julien Grall Cc: =?utf-8?q?Roger_Pau_Monn=C3=A9?= Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org --- lib/inflate.c

Re: [PATCH 1/1] xen/scripts: Fix regex syntax warnings with Python 3.12

2024-12-19 Thread Ariel Otilibili-Anieli
CCing Luca Fancellu. On Thursday, December 19, 2024 19:10 CET, Ariel Otilibili wrote: > Same fix than commit 826a9eb072 (tools: Fix regex syntax warnings with Python > 3.12). > > It clears out the warning: > > ``` > $ xen/scripts/xen-analysis.py >

[PATCH 0/1] xen/scripts: Fix regex syntax warnings with Python 3.12

2024-12-19 Thread Ariel Otilibili
72 (tools: Fix regex syntax warnings with Python 3.12). Thank you, Ariel Otilibili (1): xen/scripts: Fix regex syntax warnings with Python 3.12 xen/scripts/xen_analysis/cppcheck_analysis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.47.1

[PATCH 1/1] xen/scripts: Fix regex syntax warnings with Python 3.12

2024-12-19 Thread Ariel Otilibili
]*/\*.*$', line) ``` The warning appears only the first time the command is run, then it disappears. Fixes: 02b26c02c7 (xen/scripts: add cppcheck tool to the xen-analysis.py script) Signed-off-by: Ariel Otilibili -- Cc: Andrew Cooper Cc: Anthony PERARD Cc: Michal Orzel Cc: Jan Beulich

Re: [PATCH 1/1] xen/common: Remove dead code

2024-12-19 Thread Ariel Otilibili-Anieli
On Thursday, December 19, 2024 10:10 CET, "Ariel Otilibili-Anieli" wrote: > On Thursday, December 19, 2024 09:32 CET, Jan Beulich > wrote: > > > On 19.12.2024 00:34, Ariel Otilibili wrote: > > > The if-statement tests `res` is non-zero; meaning the

[PATCH 1/1] lib: Remove dead code

2024-12-19 Thread Ariel Otilibili
ned-off-by: Ariel Otilibili -- Cc: Andrew Morton Cc: linux-ker...@vger.kernel.org Cc: Andrew Cooper Cc: Anthony PERARD Cc: Michal Orzel Cc: Julien Grall Cc: =?utf-8?q?Roger_Pau_Monn=C3=A9?= Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org --- lib/inflate.c | 2 -- 1 file changed, 2

[PATCH 0/1] lib: Remove dead code

2024-12-19 Thread Ariel Otilibili
/ Ariel Otilibili (1): lib: Remove dead code lib/inflate.c | 2 -- 1 file changed, 2 deletions(-) -- 2.47.1

Re: [PATCH 1/1] xen/common: Remove dead code

2024-12-19 Thread Ariel Otilibili-Anieli
On Thursday, December 19, 2024 09:32 CET, Jan Beulich wrote: > On 19.12.2024 00:34, Ariel Otilibili wrote: > > The if-statement tests `res` is non-zero; meaning the case zero is never > > reached. > > > > Coverity-ID: 1055253 > > Fixes: e2b1ebf4de ("x86: S

[PATCH 0/1] xen/common: Remove dead code

2024-12-18 Thread Ariel Otilibili
Hello, This patch fixes Coverity-ID 1055253. Its history says a fix was required. Thank you, Link: https://scan5.scan.coverity.com/#/project-view/63598/10426?selectedIssue=1055253 Ariel Otilibili (1): xen/common: Remove dead code xen/common/gzip/inflate.c | 2 -- 1 file changed, 2

[PATCH 1/1] xen/common: Remove dead code

2024-12-18 Thread Ariel Otilibili
The if-statement tests `res` is non-zero; meaning the case zero is never reached. Coverity-ID: 1055253 Fixes: e2b1ebf4de ("x86: Support booting a bzImage format domain 0 kernel.") Signed-off-by: Ariel Otilibili -- Cc: Andrew Cooper Cc: Anthony PERARD Cc: Michal Orzel Cc: Jan B

Re: [PATCH v2 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-18 Thread Ariel Otilibili-Anieli
On Wednesday, December 18, 2024 15:21 CET, Andrew Cooper wrote: > On 17/12/2024 5:13 pm, Ariel Otilibili-Anieli wrote: > > On Tuesday, December 17, 2024 17:26 CET, Andrew Cooper > > wrote: > > > >> On 16/12/2024 11:07 pm, Ariel Otilibili wrote: > >>

Re: [PATCH v2 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-17 Thread Ariel Otilibili-Anieli
On Tuesday, December 17, 2024 17:26 CET, Andrew Cooper wrote: > On 16/12/2024 11:07 pm, Ariel Otilibili wrote: > > * since 3.12 invalid escape sequences generate SyntaxWarning > > * in the future, these invalid sequences will generate SyntaxError > > * therefore changed

Re: [PATCH v2 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-17 Thread Ariel Otilibili-Anieli
On Tuesday, December 17, 2024 09:31 CET, Luca Fancellu wrote: > Hi Ariel, > > > On 16 Dec 2024, at 23:07, Ariel Otilibili > > wrote: > > > > * since 3.12 invalid escape sequences generate SyntaxWarning > > * in the future, these invalid sequences will

Re: [PATCH v2 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-17 Thread Ariel Otilibili-Anieli
On Tuesday, December 17, 2024 10:29 CET, Jan Beulich wrote: > On 17.12.2024 00:50, Ariel Otilibili wrote: > > iasl complains _HID and _ADR cannot be used at the same time: > > > > ``` > > /usr/bin/iasl -vs -p tools/firmware/hvmloader/dsdt_anycpu.tmp -tc &

[PATCH v2 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili
org/~mchehab/kernel_docs/firmware-guide/acpi/namespace.html Link: https://www.intel.com/content/www/us/en/developer/topic-technology/open/acpica/documentation.html Fixes: a5da231f56268702ba9d9e0c4f1ad7156446e77b Cc: Jan Beulich Cc: Anthony PERARD Signed-off-by: Ariel Otilibili --- tools/libacpi/dsdt.asl |

[PATCH v2 0/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili
14:31:57 + x86_64 GNU/Linux ``` -- v2: * stated reasons why the changes should be backward compatible * see, https://lore.kernel.org/all/7f30f105-e13e-4e41-b432-82f9c1276...@suse.com/ Ariel Otilibili (1): tools/libacpi: clear ASL warning about PCI0 tools/libacpi/dsdt.asl | 1 - 1 file

[PATCH v2 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-16 Thread Ariel Otilibili
;) Fixes: 02b26c02c7c ("xen/scripts: add cppcheck tool to the xen-analysis.py script") Fixes: 56c0063f4e7 ("xen/misra: xen-analysis.py: Improve the cppcheck version check") Cc: Anthony PERARD Cc: Luca Fancellu Cc: Andrew Cooper Signed-off-by: Ariel Otilibili --- tools/pygrub

[PATCH v2 0/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-16 Thread Ariel Otilibili
ools/misc: Drop xensymoops") * refined regexes (https://lore.kernel.org/all/49497f8c-a2e4-49a1-aac0-96d704834...@citrix.com/) Ariel Otilibili (1): tools, xen/scripts: clear out Python syntax warnings tools/pygrub/src/GrubConf.py | 4 ++-- tools/pygrub/src/pygrub

Re: [PATCH 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 12:34 CET, Andrew Cooper wrote: > On 14/12/2024 4:09 pm, Ariel Otilibili wrote: > > * since 3.12 invalid escape sequences generate SyntaxWarning > > * in the future, these invalid sequences will generate SyntaxError > > * therefore changed

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 13:39 CET, Jan Beulich wrote: > On 16.12.2024 13:19, Ariel Otilibili-Anieli wrote: > > On Monday, December 16, 2024 12:38 CET, Jan Beulich > > wrote: > > > >> On 16.12.2024 12:31, Ariel Otilibili-Anieli wrote: > >>> O

Re: [PATCH] tools/misc: Drop xensymoops

2024-12-16 Thread Ariel Otilibili-Anieli
; Also, the regex it uses ties it to a 32bit build of Xen, which was dropped > > in > > Xen 4.3, 11 years ago. > > > > Signed-off-by: Andrew Cooper > > Acked-by: Jan Beulich > > Acked-by: Ariel Otilibili-Anieli

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 12:38 CET, Jan Beulich wrote: > On 16.12.2024 12:31, Ariel Otilibili-Anieli wrote: > > On Monday, December 16, 2024 12:01 CET, Jan Beulich > > wrote: > > > >> On 16.12.2024 11:36, Ariel Otilibili-Anieli wrote: > >>> O

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 12:01 CET, Jan Beulich wrote: > On 16.12.2024 11:36, Ariel Otilibili-Anieli wrote: > > On Monday, December 16, 2024 10:53 CET, Jan Beulich > > wrote: > > > >> On 15.12.2024 16:40, Ariel Otilibili wrote: > >>> * iasl com

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 10:53 CET, Jan Beulich wrote: > On 15.12.2024 16:40, Ariel Otilibili wrote: > > * iasl complains _HID and _ADR cannot be used at the same time > > > > ``` > > /usr/bin/iasl -vs -p tools/firmware/hvmloader/dsdt_anycpu.tmp -tc &

[PATCH 0/1] tools/libacpi: clear ASL warning about PCI0

2024-12-15 Thread Ariel Otilibili
14:31:57 + x86_64 GNU/Linux ``` Ariel Otilibili (1): tools/libacpi: clear ASL warning about PCI0 tools/libacpi/dsdt.asl | 1 - 1 file changed, 1 deletion(-) -- 2.47.1

[PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-15 Thread Ariel Otilibili
leared out. Link: https://www.intel.com/content/www/us/en/developer/topic-technology/open/acpica/documentation.html Fixes: a5da231f56268702ba9d9e0c4f1ad7156446e77b Cc: Jan Beulich Cc: Anthony PERARD Signed-off-by: Ariel Otilibili --- tools/libacpi/dsdt.asl | 1 - 1 file changed, 1 deletion(-) d

[PATCH 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-14 Thread Ariel Otilibili
ult entry in string format") Fixes: 622e368758b ("Add ZFS libfsimage support patch") Fixes: 02b26c02c7c ("xen/scripts: add cppcheck tool to the xen-analysis.py script") Fixes: 56c0063f4e7 ("xen/misra: xen-analysis.py: Improve the cppcheck version check") Cc: Anthony PERA

[PATCH 0/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-14 Thread Ariel Otilibili
Hello, The series clears out Python syntax warnings. In all occurrences of the re methods, ``` $ git grep -Pn '[^\w_]re\.[a-z]+' | wc -l 69 ``` Where it was needed, the strings have been quoted as raw. Thank you, Ariel Otilibili (1): tools, xen/scripts: clear out Python synta

Re: [PATCH 1/1] tools/libacpi: clear out compilation warnings

2024-12-06 Thread Ariel Otilibili-Anieli
On Friday, December 06, 2024 01:42 CET, Andrew Cooper wrote: > On 06/12/2024 12:00 am, Ariel Otilibili wrote: > > From: Ariel Otilibili > > > > * While compiling ASLs, iasl puts out deprecation warnings > > > > ``` > > tools/libs/light/mk_dsdt -

[PATCH 0/1] tools/libacpi: clear out compilation warnings

2024-12-05 Thread Ariel Otilibili
you, Ariel Otilibili (1): tools/libacpi: clear out compilation warnings tools/libacpi/mk_dsdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.47.1

[PATCH 1/1] tools/libacpi: clear out compilation warnings

2024-12-05 Thread Ariel Otilibili
From: Ariel Otilibili * While compiling ASLs, iasl puts out deprecation warnings ``` tools/libs/light/mk_dsdt --debug=y --maxcpu any --dm-version none >> tools/libs/light/dsdt_pvh.asl /usr/bin/iasl -vs -p tools/libs/light/dsdt_pvh.tmp -tc tools/libs/light/dsdt_pvh.asl tools/libs