[PATCH v3] arm/ioreq: guard interaction data on read/write operations

2023-10-05 Thread Andrii Chepurnyi
ing a write access, the Device Model only need to know the content of the bits associated with the access size (e.g. for 8-bit, the lower 8-bits). During a read access, the Device Model don't need to know any value. So restrict the value it can access. Signed-off-by: Andrii Chepurnyi Release-acked

[PATCH v2] arm/ioreq: guard interaction data on read/write operations

2023-10-05 Thread Andrii Chepurnyi
also a good point to guard interaction data with actual size of the interaction. Signed-off-by: Andrii Chepurnyi --- xen/arch/arm/ioreq.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c index 3bed0a14c0..26dae8ca28 100644

Re: [PATCH] arm/ioreq: clean data field in ioreq struct on read operations

2023-10-05 Thread Andrii Chepurnyi
Hello, On 10/4/23 18:41, Julien Grall wrote: > I was asking a pointer to the code in the Device Emulator (QEMU in your > case). I am confident the code is correct in U-boot, because when using > 'w0', the unused bits are meant to be set to zero (per the Arm Arm). But > I am curious to know why

Re: [PATCH] arm/ioreq: clean data field in ioreq struct on read operations

2023-10-04 Thread Andrii Chepurnyi
Hello, On 10/3/23 16:49, Julien Grall wrote: > Hi, > > On 03/10/2023 14:19, Andrii Chepurnyi wrote: >> For read operations, there's a potential issue when the data field >> of the ioreq struct is partially updated in the response. To address >> this, zero data fi

[PATCH] arm/ioreq: clean data field in ioreq struct on read operations

2023-10-04 Thread Andrii Chepurnyi
tions. Signed-off-by: Andrii Chepurnyi --- xen/arch/arm/ioreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c index 3bed0a14c0..aaa2842acc 100644 --- a/xen/arch/arm/ioreq.c +++ b/xen/arch/arm/ioreq.c @@ -80,7 +80,7 @@ enum io_

Re: [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent'

2022-07-18 Thread Andrii Chepurnyi
tent feature support changes. This patchset fixes the issues. > > Changes from v3 > (https://lore.kernel.org/xen-devel/20220715175521.126649-1...@kernel.org/) > - Split 'blkback' patch for each of the two issues > - Add 'Reported-by: Andrii Chepurnyi ' > > Changes from

Re: [PATCH v2] xen-blkback: fix persistent grants negotiation

2022-07-15 Thread Andrii Chepurnyi
[2] https://lore.kernel.org/xen-devel/20220714224410.51147-1...@kernel.org/ Best regards, Andrii On Fri, Jul 15, 2022 at 1:15 PM Oleksandr wrote: > > On 15.07.22 01:44, SeongJae Park wrote: > > > Hello all. > > Adding Andrii Chepurnyi to CC who have played with the use-