to the top of the file on script
usage? Or "--help" option? If you would like to be the script maintainer,
please change the MAINTAINERS too.
Reviewed-by: Aleksandar Markovic
>
> CC: Gerd Hoffmann
> CC: "Gonglei (Arei)"
> CC: Eduardo Habkost
> CC: Igor Mammedo
>
> In case you, for any reason, can't complete this by softfreeze, I advice
>> you not to rush, and postpone the integration to 5.0.
>>
>
> This series doesn't provide any useful feature, it is a simple cleanup,
> posted and reviewed before soft freeze, so we still have 1 week (until
> hard freeze
On Saturday, October 26, 2019, Philippe Mathieu-Daudé
wrote:
> Changes since v2 [0]:
> - Use a #define
> - Reword one description
> - Added review tags (thanks all for reviewing!)
>
> Changes since v1 [1]:
> - Removed patch reintroducing DO_UPCAST() use (thuth)
> - Took various patches out to red
On Saturday, October 26, 2019, Philippe Mathieu-Daudé
wrote:
> Hi Aleksandar,
>
> On 10/25/19 12:51 PM, Aleksandar Markovic wrote:
>
>> On Thursday, October 24, 2019, Aleksandar Markovic <
>> aleksandar.m.m...@gmail.com <mailto:aleksandar.m.m...@gmail.com>&
On Thursday, October 24, 2019, Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> On Friday, October 18, 2019, Philippe Mathieu-Daudé
> wrote:
>
>> Changes since v1 [0]:
>> - Removed patch reintroducing DO_UPCAST() use (thuth)
>> - Took vari
On Friday, October 18, 2019, Philippe Mathieu-Daudé
wrote:
> Changes since v1 [0]:
> - Removed patch reintroducing DO_UPCAST() use (thuth)
> - Took various patches out to reduce series (thuth)
> - Added review tags (thanks all for reviewing!)
>
>
Philippe,
Do you intend to submit v3? The softfre
x4_init() function.
>
> Acked-by: Michael S. Tsirkin
> Acked-by: Paolo Bonzini
> Signed-off-by: Hervé Poussineau
> Message-Id: <20171216090228.28505-8-hpous...@reactos.org>
> Reviewed-by: Aleksandar Markovic
> [PMD: rebased, updated includes, use ISA_NUM_IRQS in for
On Friday, October 18, 2019, Philippe Mathieu-Daudé
wrote:
> Changes since v1 [0]:
> - Removed patch reintroducing DO_UPCAST() use (thuth)
> - Took various patches out to reduce series (thuth)
> - Added review tags (thanks all for reviewing!)
>
>
As far as I can tell, a handful of checkpatch warn
d-off-by: Philippe Mathieu-Daudé
> ---
> hw/i386/pc_piix.c| 8 +++-
> hw/pci-host/i440fx.c | 8
> include/hw/pci-host/i440fx.h | 3 +--
> 3 files changed, 8 insertions(+), 11 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
Philippe, I don
u-Daudé
> ---
> include/hw/timer/mc146818rtc.h | 2 ++
> include/hw/timer/mc146818rtc_regs.h | 2 --
> tests/rtc-test.c| 1 +
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/include/hw/tim
On Friday, October 18, 2019, Philippe Mathieu-Daudé
wrote:
> On 10/18/19 11:19 AM, Aleksandar Markovic wrote:
>
>> On Tuesday, October 15, 2019, Philippe Mathieu-Daudé > <mailto:phi...@redhat.com>> wrote:
>>
>> From: Philippe Mathieu-Daudé mailto
4 deletions(-)
> rename hw/pci-host/{piix.c => i440fx.c} (100%)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4845f47d93..1bc9959b8a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1225,7 +1225,7 @@ M: Marcel Apfelbaum
++
> 8 files changed, 442 insertions(+), 403 deletions(-)
> create mode 100644 hw/isa/piix3.c
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/MAINTAINERS b/MAINTAINERS
> index adf059a164..4845f47d93 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1231,6 +12
On Tuesday, October 15, 2019, Philippe Mathieu-Daudé
wrote:
> We will move this code, fix its style first.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/pci-host/piix.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>
Reviewed-by: Aleksandar Ma
+
> stubs/pci-host-piix.c| 3 ++-
> 7 files changed, 43 insertions(+), 24 deletions(-)
> create mode 100644 include/hw/pci-host/i440fx.h
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 556f58
2 doesn't have prefix and the registers
ftom this patch do - inconsistency?
In any case:
Reviewed-by: Aleksandar Markovic
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index 6b5e5bb7f5..4ce2fb9c89 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hv
| 1 +
> include/hw/i386/pc.h | 6 --
> include/hw/southbridge/piix.h | 6 ++
> 3 files changed, 7 insertions(+), 6 deletions(-)
>
>
Does it make sense to add prefix PIIX_ or a similar one to the register
name?
In any case:
Reviewed-by: Aleksandar Markovic
insertions(+), 20 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 2f4cbcbfe9..3292703de7 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -331,6 +331,36 @@ static void i440fx
On Thursday, October 17, 2019, Philippe Mathieu-Daudé
wrote:
> On 10/17/19 5:16 PM, Aleksandar Markovic wrote:
>
>> On Tuesday, October 15, 2019, Philippe Mathieu-Daudé > <mailto:phi...@redhat.com>> wrote:
>>
>> pc_gsi_create() is the single function tha
On Tuesday, October 15, 2019, Philippe Mathieu-Daudé
wrote:
> The block code related to IRQ start few lines later. Move
block code -> code block
start -> starts
the comment and the pc_gsi_create() call
where we start
call -> invocation
> to use the IRQs.
>
> Signed-off-by: Philippe Mathie
On Tuesday, October 15, 2019, Philippe Mathieu-Daudé
wrote:
> pc_gsi_create() is the single function that uses gsi_handler.
> Make it a static variable.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/i386/pc.c | 2 +-
> include/hw/i386/pc.h | 2 --
> 2 files changed, 1 insertion(+
-
> hw/i386/pc_q35.c | 9 +
> include/hw/i386/pc.h | 2 ++
> 4 files changed, 19 insertions(+), 16 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index bcda50efcc..a7597c6c44 100644
> --- a/hw/i386/pc.c
>
Mathieu-Daudé
> ---
> hw/isa/piix4.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
> index c3a2bd0d70..8998b0ca47 100644
> --- a/hw/isa/piix4.c
> +++ b/hw/isa/p
d: <20171216090228.28505-7-hpous...@reactos.org>
> [PMD: rebased, updated includes]
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/isa/piix4.c | 40
> 1 file changed, 40 insertions(+)
>
>
Reviewed-by: Aleksandar Markovic
nzini
> Signed-off-by: Hervé Poussineau
> Message-Id: <20171216090228.28505-6-hpous...@reactos.org>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/isa/piix4.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
nzini
> Signed-off-by: Hervé Poussineau
> Message-Id: <20171216090228.28505-6-hpous...@reactos.org>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/isa/piix4.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
On Tuesday, October 15, 2019, Philippe Mathieu-Daudé
wrote:
> From: Philippe Mathieu-Daudé
>
> The ISA default number for the RTC devices is not related to its
> registers neither. Move this definition to "hw/timer/mc146818rtc.h".
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/ti
8505-4-hpous...@reactos.org>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/timer/mc146818rtc.c | 30 --
> include/hw/timer/mc146818rtc.h | 33 +
> 2 files changed, 33 insertions(+), 30 deletions(-)
>
>
On Tuesday, October 15, 2019, Philippe Mathieu-Daudé
wrote:
> Move the KVM-related call to "sysemu/kvm.h".
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/i386/pc.h | 1 -
> include/sysemu/kvm.h | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
>
Is there any other similar
off-by: Hervé Poussineau
> Message-Id: <20171216090228.28505-15-hpous...@reactos.org>
> [PMD: rebased]
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/isa/piix4.c | 1 -
> hw/mips/mips_malta.c | 2 +-
> include/hw/isa/isa.h | 2 ++
> 3 files changed, 3 insertions(+
6 ++
> 5 files changed, 37 insertions(+), 30 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
> index 9f554747af..d90899e122 100644
> --- a/hw/isa/piix4.c
> +++ b/hw/isa/piix4.c
> @@ -27,12 +27,14 @@
> #include "
ips/mips_malta.c | 47 +++-
> 1 file changed, 29 insertions(+), 18 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 774bb810f6..0d4312840b 100644
> --- a/hw/mips/mips_malta.c
&g
athieu-Daudé
> ---
> hw/mips/mips_malta.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 528c34a1c3..774bb810f6 100644
> --- a/hw/mips/mips_malta.c
>
++
> 9 files changed, 48 insertions(+), 19 deletions(-)
> delete mode 100644 include/hw/acpi/piix4.h
> create mode 100644 include/hw/southbridge/piix.h
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c9f625fc2e..556f58bd8c 100644
>
171216090228.28505-10-hpous...@reactos.org>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/isa/piix4.c | 4
> hw/mips/mips_malta.c | 4
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
> diff --git a/hw/isa/p
0171216090228.28505-9-hpous...@reactos.org>
> [PMD: rebased]
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/isa/piix4.c | 4
> hw/mips/mips_malta.c | 2 --
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Aleksandar Markovic
---
> hw/acpi/piix4.c | 40 -
> hw/intc/apic_common.c | 49 -
> hw/pci-host/piix.c | 25 -
> hw/timer/i8254_common.c | 40 -
> 4 files changed, 154 deletions(-)
>
&g
ieu-Daudé
> ---
> hw/isa/piix4.c | 41 ++---
> hw/mips/mips_malta.c | 32 +---
> include/hw/i386/pc.h | 1 -
> 3 files changed, 43 insertions(+), 31 deletions(-)
>
>
Reviewed-by: Aleksandar Markovic
off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Aleksandar Markovic
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe4dc51b08..c9f625fc2e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
>
39 matches
Mail list logo
