[PATCH v5] xen/efi: Update error flow for read_file function

2025-06-27 Thread Frediano Ziglio
Use more explicit goto statements to handle common error code path instead of a lot of if/else. Signed-off-by: Frediano Ziglio --- Change since v4: - fixed label indentation. --- xen/common/efi/boot.c | 80 +++ 1 file changed, 43 insertions(+), 37 deletion

Re: [PATCH v2 0/8] pdx: introduce a new compression algorithm

2025-06-27 Thread Stefano Stabellini
Hi Roger, We have an ARM board with the following memory layout: 0x0-0x8000, 0, 2G 0x8,0x88000, 32GB, 2G 0x500-0x5008000 5T, 2GB 0x600-0x6008000 6T, 2GB 0x700-0x7008000 7T, 2GB It looks like your PDX series is exactly what we need. However,

Re: [PATCH v3 2/2] xen/console: unify printout behavior for UART emulators

2025-06-27 Thread Stefano Stabellini
On Fri, 27 Jun 2025, Julien Grall wrote: > Hi Stefano, > > On 19/06/2025 01:45, Stefano Stabellini wrote: > > On Wed, 18 Jun 2025, Jan Beulich wrote: > > > On 18.06.2025 02:39, Stefano Stabellini wrote: > > > > On Thu, 12 Jun 2025, Jan Beulich wrote: > > > > > On 11.06.2025 21:07, Stefano Stabelli

Re: [PATCH] xen/arm: Drop frametable_virt_end

2025-06-27 Thread Stefano Stabellini
On Fri, 26 Jun 2025, Michal Orzel wrote: > It has never been used since the introduction and is technically a dead > code violating MISRA C. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini

Re: [PATCH v3 2/2] xen/console: unify printout behavior for UART emulators

2025-06-27 Thread Julien Grall
Hi Stefano, On 19/06/2025 01:45, Stefano Stabellini wrote: On Wed, 18 Jun 2025, Jan Beulich wrote: On 18.06.2025 02:39, Stefano Stabellini wrote: On Thu, 12 Jun 2025, Jan Beulich wrote: On 11.06.2025 21:07, Stefano Stabellini wrote: On Wed, 11 Jun 2025, Jan Beulich wrote: On 11.06.2025 02:0

Re: [PATCH 0/2] xen/efi: Make boot more flexible, especially with GRUB2

2025-06-27 Thread Marek Marczykowski-Górecki
On Fri, Jun 27, 2025 at 04:58:43PM +0100, Frediano Ziglio wrote: > On Fri, Jun 27, 2025 at 3:20 PM Marek Marczykowski-Górecki > wrote: > > So, it looks like major distributions use a patched grub version that > > changes behavior of "linux" command. IIUC many of those patches are > > about hardeni

Re: [PATCH 0/2] xen/efi: Make boot more flexible, especially with GRUB2

2025-06-27 Thread Frediano Ziglio
On Fri, Jun 27, 2025 at 3:20 PM Marek Marczykowski-Górecki wrote: > > On Fri, Jun 27, 2025 at 01:29:48PM +0100, Frediano Ziglio wrote: > > On Thu, Jun 26, 2025 at 4:03 PM Marek Marczykowski-Górecki > > wrote: > > > > > > On Thu, Jun 26, 2025 at 09:12:53AM +0100, Frediano Ziglio wrote: > > > > On

Re: [XEN PATCH] automation/eclair: Make report browsing URL configurable.

2025-06-27 Thread Anthony PERARD
On Fri, Jun 27, 2025 at 10:39:21AM +0200, Nicola Vetrini wrote: > On 2025-06-26 12:08, Anthony PERARD wrote: > > On Thu, Jun 26, 2025 at 08:38:18AM +0200, Nicola Vetrini wrote: > > > +eclairReportHost="${MACHINE_HOST:-saas.eclairit.com}" > > > +eclairReportPort="${MACHINE_PORT:-3787}" > > > +eclair

Re: [PATCH v2 8/8] pdx: introduce a new compression algorithm based on region offsets

2025-06-27 Thread Roger Pau Monné
On Thu, Jun 26, 2025 at 09:35:04AM +0200, Jan Beulich wrote: > On 25.06.2025 18:24, Roger Pau Monné wrote: > > On Tue, Jun 24, 2025 at 06:16:15PM +0200, Jan Beulich wrote: > >> On 20.06.2025 13:11, Roger Pau Monne wrote: > >>> +bool pdx_is_region_compressible(paddr_t base, unsigned long npages) > >

Re: [PATCH 0/2] xen/efi: Make boot more flexible, especially with GRUB2

2025-06-27 Thread Marek Marczykowski-Górecki
On Fri, Jun 27, 2025 at 01:29:48PM +0100, Frediano Ziglio wrote: > On Thu, Jun 26, 2025 at 4:03 PM Marek Marczykowski-Górecki > wrote: > > > > On Thu, Jun 26, 2025 at 09:12:53AM +0100, Frediano Ziglio wrote: > > > On Wed, Jun 25, 2025 at 9:26 PM Marek Marczykowski-Górecki > > > wrote: > > > > > >

[PATCH] x86/cpu-policy: Simplify logic in guest_common_default_feature_adjustments()

2025-06-27 Thread Andrew Cooper
For features which are unconditionally set in the max policies, making the default policy to match the host can be done with a conditional clear. This is simpler than the unconditional clear, conditional set currently performed. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Mon

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-27 Thread Frediano Ziglio
On Thu, Jun 5, 2025 at 12:17 PM Andrew Cooper wrote: > > The format of the buildid is a property of the binary, not a property of how > it was loaded. This fixes buildid recognition when starting xen.efi from it's > MB2 entrypoint. > > Suggested-by: Ross Lagerwall > Signed-off-by: Andrew Cooper

Re: [PATCH] systemd: Add hooks to stop/start xen-watchdog on suspend/resume

2025-06-27 Thread Anthony PERARD
Hi Mykola, First, since you used a different email account to send you patch, the email should start with "From: Mykola ... <...@epam.com>" so that `git am` can set the correct author for the commit. Often `git send-email` managed to do that automatically, if it knows that the author of the email

Re: [PATCH 0/2] xen/efi: Make boot more flexible, especially with GRUB2

2025-06-27 Thread Frediano Ziglio
On Thu, Jun 26, 2025 at 4:03 PM Marek Marczykowski-Górecki wrote: > > On Thu, Jun 26, 2025 at 09:12:53AM +0100, Frediano Ziglio wrote: > > On Wed, Jun 25, 2025 at 9:26 PM Marek Marczykowski-Górecki > > wrote: > > > > > > On Tue, Jun 24, 2025 at 09:38:42AM +0100, Frediano Ziglio wrote: > > > > On

Re: [PATCH 2/6] xen/arm: Introduce flags_has_rwx helper

2025-06-27 Thread Orzel, Michal
On 20/06/2025 11:49, Hari Limaye wrote: > From: Luca Fancellu > > Introduce flags_has_rwx() function that will check if a > mapping is both writable and executable when modifying > or update the mapping. NIT: s/update/updating/ > > This check was already present in pt.c but since it will > b

Re: [PATCH 1/6] arm/mpu: Find MPU region by range

2025-06-27 Thread Orzel, Michal
On 20/06/2025 11:49, Hari Limaye wrote: > From: Luca Fancellu > > Implement a function to find the index of a MPU region > in the xen_mpumap MPU region array. The commit msg should also mention why a change is needed. > > Signed-off-by: Luca Fancellu > Signed-off-by: Hari Limaye > --- > x

[PATCH v5 4/4] CHANGELOG: Document guest suspend/resume to RAM support on Arm

2025-06-27 Thread Mykola Kvach
From: Mykola Kvach Mention the newly added support for guest suspend and resume to/from RAM via vPSCI on Arm platforms (ARM32 and ARM64). This support is limited to non-hardware domain guests. Signed-off-by: Mykola Kvach --- Changes in v5: - adjustments to the commit title and message - expande

[PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-06-27 Thread Mykola Kvach
From: Mykola Kvach This patch adds support for the PSCI SYSTEM_SUSPEND function in the vPSCI (virtual PSCI) interface, allowing guests to request suspend via the PSCI v1.0 SYSTEM_SUSPEND call (both 32-bit and 64-bit variants). The implementation: - Adds SYSTEM_SUSPEND function IDs to PSCI defini

[PATCH v5 3/4] SUPPORT.md: Add entry for guest PSCI SYSTEM_SUSPEND support

2025-06-27 Thread Mykola Kvach
From: Mykola Kvach Document support for the optional PSCI SYSTEM_SUSPEND function, exposed via the virtual PSCI (vPSCI) interface to guests. This allows non-hardware domain guests (domUs) to initiate system suspend operations via PSCI calls. The feature is currently marked as Experimental. Sign

[PATCH v5 0/4] Enable guest suspend/resume support on ARM via vPSCI

2025-06-27 Thread Mykola Kvach
From: Mykola Kvach This patch series introduces the initial support for guest suspend and resume on ARM platforms using the PSCI SYSTEM_SUSPEND interface. The main goal is to allow ARM guests to request suspension using PSCI and be resumed by the control domain (e.g., via "xl resume"). ### Backg

[PATCH v5 2/4] tools/xl: allow resume command compilation for arm

2025-06-27 Thread Mykola Kvach
From: Mykola Kvach The "xl resume" command was previously excluded from ARM builds because system suspend/resume (e.g., `SYSTEM_SUSPEND`) via vPSCI was not implemented. On x86, the command is used for ACPI S3 suspend/resume. This change enables compilation of `xl resume` on ARM regardless of the

Re: [PATCH v6 2/8] vpci: Refactor REGISTER_VPCI_INIT

2025-06-27 Thread Jan Beulich
On 27.06.2025 11:00, Chen, Jiqian wrote: > On 2025/6/27 14:05, Jan Beulich wrote: >> On 27.06.2025 04:59, Chen, Jiqian wrote: >>> On 2025/6/26 20:06, Jan Beulich wrote: On 26.06.2025 10:03, Chen, Jiqian wrote: > On 2025/6/25 22:07, Jan Beulich wrote: >> On 25.06.2025 12:16, Chen, Jiqia

Re: [PATCH] xen/arm: Drop frametable_virt_end

2025-06-27 Thread Ayan Kumar Halder
Hi Michal, On 27/06/2025 09:43, Michal Orzel wrote: It has never been used since the introduction and is technically a dead code violating MISRA C. Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder - Ayan

Re: [PATCH v6 2/8] vpci: Refactor REGISTER_VPCI_INIT

2025-06-27 Thread Chen, Jiqian
On 2025/6/27 17:00, Chen, Jiqian wrote: > On 2025/6/27 14:05, Jan Beulich wrote: >> On 27.06.2025 04:59, Chen, Jiqian wrote: >>> On 2025/6/26 20:06, Jan Beulich wrote: On 26.06.2025 10:03, Chen, Jiqian wrote: > On 2025/6/25 22:07, Jan Beulich wrote: >> On 25.06.2025 12:16, Chen, Jiqian

Re: [PATCH v6 2/8] vpci: Refactor REGISTER_VPCI_INIT

2025-06-27 Thread Chen, Jiqian
On 2025/6/27 14:05, Jan Beulich wrote: > On 27.06.2025 04:59, Chen, Jiqian wrote: >> On 2025/6/26 20:06, Jan Beulich wrote: >>> On 26.06.2025 10:03, Chen, Jiqian wrote: On 2025/6/25 22:07, Jan Beulich wrote: > On 25.06.2025 12:16, Chen, Jiqian wrote: >> On 2025/6/25 18:03, Jan Beulich

[PATCH] xen/arm: Drop frametable_virt_end

2025-06-27 Thread Michal Orzel
It has never been used since the introduction and is technically a dead code violating MISRA C. Signed-off-by: Michal Orzel --- xen/arch/arm/include/asm/config.h | 4 xen/arch/arm/mmu/mm.c | 5 - 2 files changed, 9 deletions(-) diff --git a/xen/arch/arm/include/asm/config.h

Re: [XEN PATCH] automation/eclair: Make report browsing URL configurable.

2025-06-27 Thread Nicola Vetrini
On 2025-06-26 12:08, Anthony PERARD wrote: On Thu, Jun 26, 2025 at 08:38:18AM +0200, Nicola Vetrini wrote: diff --git a/automation/eclair_analysis/ECLAIR/action.settings b/automation/eclair_analysis/ECLAIR/action.settings index 1577368b613b..f822f0ea66d7 100644 --- a/automation/eclair_analysis/

Re: [PATCH] tools/libxenguest: fix build in stubdom environment

2025-06-27 Thread Anthony PERARD
On Wed, Jun 25, 2025 at 09:20:05AM -0400, Jason Andryuk wrote: > On 2025-06-25 06:33, Juergen Gross wrote: > > With introduction of the new byteswap infrastructure the build of > > libxenguest for stubdoms was broken. Fix that again. > > > > Fixes: 60dcff871e34 ("xen/decompressors: Remove use of *

Re: [PATCH v6 2/8] vpci: Refactor REGISTER_VPCI_INIT

2025-06-27 Thread Chen, Jiqian
On 2025/6/27 16:16, Chen, Jiqian wrote: > On 2025/6/27 14:05, Jan Beulich wrote: >> On 27.06.2025 04:59, Chen, Jiqian wrote: >>> On 2025/6/26 20:06, Jan Beulich wrote: On 26.06.2025 10:03, Chen, Jiqian wrote: > On 2025/6/25 22:07, Jan Beulich wrote: >> On 25.06.2025 12:16, Chen, Jiqian

Re: [PATCH v6 2/8] vpci: Refactor REGISTER_VPCI_INIT

2025-06-27 Thread Chen, Jiqian
On 2025/6/27 14:05, Jan Beulich wrote: > On 27.06.2025 04:59, Chen, Jiqian wrote: >> On 2025/6/26 20:06, Jan Beulich wrote: >>> On 26.06.2025 10:03, Chen, Jiqian wrote: On 2025/6/25 22:07, Jan Beulich wrote: > On 25.06.2025 12:16, Chen, Jiqian wrote: >> On 2025/6/25 18:03, Jan Beulich

Re: [PATCH] docs: cmdline: Update serial_tx_buffer default value

2025-06-27 Thread Jan Beulich
On 27.06.2025 09:06, Michal Orzel wrote: > After commit 4df2e99d7314 ("console/serial: set the default transmit > buffer size in Kconfig"), the default value is set by Kconfig option > CONFIG_SERIAL_TX_BUFSIZE. Moreover it was bumped to 32KB by commit > d09e44e5d8fd ("console/serial: bump buffer fr

[PATCH] docs: cmdline: Update serial_tx_buffer default value

2025-06-27 Thread Michal Orzel
After commit 4df2e99d7314 ("console/serial: set the default transmit buffer size in Kconfig"), the default value is set by Kconfig option CONFIG_SERIAL_TX_BUFSIZE. Moreover it was bumped to 32KB by commit d09e44e5d8fd ("console/serial: bump buffer from 16K to 32K"). Signed-off-by: Michal Orzel --