Re: [PATCH 1/2] code style: Format ns16550 driver

2025-02-22 Thread Oleksandr Andrushchenko
Hello, Jan! On 19.02.25 18:01, Jan Beulich wrote: On 19.02.2025 16:40, Oleksandr Andrushchenko wrote: On 19.02.25 16:05, Jan Beulich wrote: On 19.02.2025 14:52, Oleksandr Andrushchenko wrote: On 19.02.25 15:18, Jan Beulich wrote: On 19.02.2025 13:39, Oleksandr Andrushchenko wrote: On 17.02.

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-22 Thread Oleksandr Andrushchenko
Hello, Stefano! On 20.02.25 03:34, Stefano Stabellini wrote: On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote: Yes, I do agree. But only if we talk about having an automated code style check now (which is definitely the goal at some time). Before that we could still use the tool to take all t

Re: [PATCH] xen/consoled: clean up console handling for pv_shim

2025-02-22 Thread Denis Mukhin
On Friday, February 21st, 2025 at 4:26 PM, dm...@proton.me wrote: > > > There are few places which check pv_shim console under CONFIG_PV_SHIM or > CONFIG_X86 in xen console driver. > > Instead of #ifdef-ing, use new consoled_is_enabled() in switch_serial_input() > and _serial_rx() (where pv_s

[PATCH v2] xen/consoled: clean up console handling for PV shim

2025-02-22 Thread dmkhn
From: Denis Mukhin There are few places which check pv_shim console under CONFIG_PV_SHIM or CONFIG_X86 in xen console driver. Instead of inconsistent #ifdef-ing, introduce and use consoled_is_enabled() in switch_serial_input() and __serial_rx(). PV shim case is fixed in __serial_rx() - should b