Re: [PATCH 2/3] vmd: disable MSI remapping bypass under Xen

Hi Bjorn, On 1/10/25 3:25 PM, Bjorn Helgaas wrote: Match historical subject line style for prefix and capitalization: PCI: vmd: Set devices to D0 before enabling PM L1 Substates PCI: vmd: Add DID 8086:B06F and 8086:B60B for Intel client SKUs PCI: vmd: Fix indentation issue in vmd_shutd

Re: [PATCH v2 08/15] x86/hyperlaunch: locate dom0 kernel with hyperlaunch

On 2024-12-26 11:57, Daniel P. Smith wrote: Look for a subnode of type `multiboot,kernel` within a domain node. If found, process the reg property for the MB1 module index. If the bootargs property is present and there was not an MB1 string, then use the command line from the device tree definiti

Re: [PATCH 3/3] pci/msi: remove pci_msi_ignore_mask

Match subject line style again. On Fri, Jan 10, 2025 at 03:01:50PM +0100, Roger Pau Monne wrote: > Setting pci_msi_ignore_mask inhibits the toggling of the mask bit for both MSI > and MSI-X entries globally, regardless of the IRQ chip they are using. Only > Xen sets the pci_msi_ignore_mask when r

Re: [PATCH 1/3] xen/pci: do not register devices outside of PCI segment scope

On Fri, Jan 10, 2025 at 03:01:48PM +0100, Roger Pau Monne wrote: > The PCI segment value is limited to 16 bits, however there are buses like VMD > that fake being part of the PCI topology by adding segment with a number > outside the scope of the PCI firmware specification range (>= 0x1). The >

Re: [PATCH 2/3] vmd: disable MSI remapping bypass under Xen

Match historical subject line style for prefix and capitalization: PCI: vmd: Set devices to D0 before enabling PM L1 Substates PCI: vmd: Add DID 8086:B06F and 8086:B60B for Intel client SKUs PCI: vmd: Fix indentation issue in vmd_shutdown() On Fri, Jan 10, 2025 at 03:01:49PM +0100, Roger Pa

Re: [PATCH v2 07/15] x86/hyperlaunch: initial support for hyperlaunch device tree

On 2024-12-26 11:57, Daniel P. Smith wrote: Add the ability to detect both a formal hyperlaunch device tree or a dom0less device tree. If the hyperlaunch device tree is found, then count the number of domain entries, reporting an error if more than one is found. Signed-off-by: Daniel P. Smith

Re: [XEN PATCH 0/1] Bug: Hyperlinks in generated documentation may point to the wrong architecture

On 10/01/2025 9:19 pm, Maximilian Engelhardt wrote: > As suggested by Andrew Cooper in [1], I formally submit this patch for > fixing that documentation hyperlinks may point to the wrong > architecture. This fix also makes building the documentation > reproducible in Debian. > > With this patch app

[XEN PATCH 0/1] Bug: Hyperlinks in generated documentation may point to the wrong architecture

As suggested by Andrew Cooper in [1], I formally submit this patch for fixing that documentation hyperlinks may point to the wrong architecture. This fix also makes building the documentation reproducible in Debian. With this patch applied, I still get the following: /usr/bin/perl -w /build/repro

[XEN PATCH 1/1] docs/Makefile: Add ppc and riscv to DOC_ARCHES

Not having ppc and riscv included in DOC_ARCHES causes "multiple definitions of ..." message on documentation build, similar to the example shown below: include/public/arch-ppc.h:91: multiple definitions of Typedef vcpu_guest_core_regs_t: include/public/arch-arm.h:300 include/public/arch-ppc.h:91:

Re: [PATCH] CI: Add an x86_64 Clang Randconfig job

On Fri, 10 Jan 2025, Alejandro Vallejo wrote: > On Fri Jan 10, 2025 at 4:02 PM GMT, Andrew Cooper wrote: > > This was recently identified as a hole in testing. > > > > Signed-off-by: Andrew Cooper > > --- > > CC: Roger Pau Monné > > CC: Stefano Stabellini > > CC: Anthony PERARD > > CC: Oleksii

Re: [PATCH v2 05/15] kconfig: introduce domain builder config option

On 2024-12-26 11:57, Daniel P. Smith wrote: Hyperlaunch domain builder will be the consolidated boot time domain building logic framework. Introduces the config option to enable this domain builder to and turn on the ability to load the domain configuration via a flattened device tree. Signed-of

Re: [PATCH v2 03/15] x86/boot: add cmdline to struct boot_domain

On 2024-12-26 11:57, Daniel P. Smith wrote: Add a container for the "cooked" command line for a domain. This provides for the backing memory to be directly associated with the domain being constructed. This is done in anticipation that the domain construction path may need to be invoked multiple

[PATCH v3] xen: update pvcalls_front_accept prototype

While currently there are no in-tree callers of these functions, it is best to keep them up-to-date with the latest network API. Signed-off-by: Stefano Stabellini --- Changes in v3: expand commit message --- drivers/xen/pvcalls-front.c | 5 +++-- drivers/xen/pvcalls-front.h | 2 +- 2 files chang

Re: [PATCH v2 15/18] x86/mm: introduce a per-vCPU mapcache when using ASI

On Fri, Jan 10, 2025 at 04:19:03PM +, Alejandro Vallejo wrote: > On Fri Jan 10, 2025 at 3:02 PM GMT, Roger Pau Monné wrote: > > On Thu, Jan 09, 2025 at 03:08:15PM +, Alejandro Vallejo wrote: > > > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > > > When using a unique per-vCPU

Re: [PATCH v2 22/25] drm/vmwgfx: Compute dumb-buffer sizes with drm_mode_size_dumb()

On Thu, Jan 9, 2025 at 10:03 AM Thomas Zimmermann wrote: > > Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch > and buffer size. No alignment required. > > Signed-off-by: Thomas Zimmermann > Cc: Zack Rusin > Cc: Broadcom internal kernel review list > > --- > drivers/gpu/drm/vmw

Re: [PATCH] treewide: const qualify ctl_tables where applicable

On Thu, 09 Jan 2025 05:16:39 -0800, Joel Granados wrote: > > diff --git a/drivers/gpu/drm/i915/i915_perf.c > b/drivers/gpu/drm/i915/i915_perf.c > index 2406cda75b7b..5384d1bb4923 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4802,7 +4802,7 @@ int i9

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

On 1/10/25 9:16 AM, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except for > watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls, > loadpin_sysctl_table and the ones calling register_net_sysctl (./net, > drivers/inifiniband dirs). These are specia

Re: [ANNOUNCEMENT] Xen 4.20.0-rc1 is tagged

Sorry for inconvenience but I did something wrong with link location in my e-mail application. Please find the corrected links below: On 1/10/25 6:46 PM, Oleksii Kurochko wrote: Hi all, Xen 4.20 rc1 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.20.0-rc1 For

[ANNOUNCEMENT] Xen 4.20.0-rc1 is tagged

Hi all, Xen 4.20 rc1 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.20.0-rc1 For your convenience there is also a tarball and the signature at: https://downloads.xenproject.org/release/xen/4.20.0-rc1/xen-4.20.0-rc1.tar.gz

Re: [PATCH 2/2] Update Xen version to 4.20-rc

On 09/01/2025 3:53 pm, Jan Beulich wrote: > On 09.01.2025 16:46, Andrew Cooper wrote: >> On 09/01/2025 3:44 pm, Jan Beulich wrote: >>> On 09.01.2025 16:39, Andrew Cooper wrote: --- a/README +++ b/README @@ -1,11 +1,11 @@ -#

Re: [PATCH] CI: Add an x86_64 Clang Randconfig job

On Fri Jan 10, 2025 at 4:02 PM GMT, Andrew Cooper wrote: > This was recently identified as a hole in testing. > > Signed-off-by: Andrew Cooper > --- > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Anthony PERARD > CC: Oleksii Kurochko > > https://gitlab.com/xen-project/people/andyhhp/xen/

Re: [PATCH v2 15/18] x86/mm: introduce a per-vCPU mapcache when using ASI

On Fri Jan 10, 2025 at 3:02 PM GMT, Roger Pau Monné wrote: > On Thu, Jan 09, 2025 at 03:08:15PM +, Alejandro Vallejo wrote: > > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > > When using a unique per-vCPU root page table the per-domain region becomes > > > per-vCPU, and hence th

Re: [PATCH v2 15/18] x86/mm: introduce a per-vCPU mapcache when using ASI

On Fri Jan 10, 2025 at 3:02 PM GMT, Roger Pau Monné wrote: > On Thu, Jan 09, 2025 at 03:08:15PM +, Alejandro Vallejo wrote: > > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > > When using a unique per-vCPU root page table the per-domain region becomes > > > per-vCPU, and hence th

[PATCH] CI: Add an x86_64 Clang Randconfig job

This was recently identified as a hole in testing. Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Stefano Stabellini CC: Anthony PERARD CC: Oleksii Kurochko https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/8820980201 --- automation/gitlab-ci/build.yaml | 6 ++ 1 file c

Re: [PATCH v2 04/18] x86/pv: introduce function to populate perdomain area and use it to map Xen GDT

On Fri Jan 10, 2025 at 2:29 PM GMT, Roger Pau Monné wrote: > On Thu, Jan 09, 2025 at 09:55:44AM +, Alejandro Vallejo wrote: > > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > > The current code to update the Xen part of the GDT when running a PV guest > > > relies on caching the

Re: [PATCH v2 13/18] x86/spec-ctrl: introduce Address Space Isolation command line option

On Fri Jan 10, 2025 at 2:55 PM GMT, Roger Pau Monné wrote: > On Thu, Jan 09, 2025 at 02:58:29PM +, Alejandro Vallejo wrote: > > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > > No functional change, as the option is not used. > > > > > > Introduced new so newly added functionalit

Re: [PATCH v2 07/18] x86/pv: update guest LDT mappings using the linear entries

On Fri Jan 10, 2025 at 2:44 PM GMT, Roger Pau Monné wrote: > On Thu, Jan 09, 2025 at 02:34:05PM +, Alejandro Vallejo wrote: > > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > > The pv_map_ldt_shadow_page() and pv_destroy_ldt() functions rely on the L1 > > > table(s) that contain

Re: [PATCH v2 15/18] x86/mm: introduce a per-vCPU mapcache when using ASI

On Thu, Jan 09, 2025 at 03:08:15PM +, Alejandro Vallejo wrote: > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > When using a unique per-vCPU root page table the per-domain region becomes > > per-vCPU, and hence the mapcache is no longer shared between all vCPUs of a > > domain.

Re: [PATCH v2 13/18] x86/spec-ctrl: introduce Address Space Isolation command line option

On Thu, Jan 09, 2025 at 02:58:29PM +, Alejandro Vallejo wrote: > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > No functional change, as the option is not used. > > > > Introduced new so newly added functionality is keyed on the option being > > enabled, even if the feature is no

Re: [PATCH v2 07/18] x86/pv: update guest LDT mappings using the linear entries

On Thu, Jan 09, 2025 at 02:34:05PM +, Alejandro Vallejo wrote: > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > The pv_map_ldt_shadow_page() and pv_destroy_ldt() functions rely on the L1 > > table(s) that contain such mappings being stashed in the domain structure, > > and > > t

Re: [PATCH v2 09/18] x86/mm: simplify create_perdomain_mapping() interface

On Thu, Jan 09, 2025 at 11:01:00AM +, Alejandro Vallejo wrote: > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h > > index 65cd751087dc..0c57442c9593 100644 > > --- a/xen/arch/x86/include/asm/mm.h > > +++ b

Re: [PATCH v2.1 06/18] x86/pv: set/clear guest GDT mappings using {populate,destroy}_perdomain_mapping()

On Thu, Jan 09, 2025 at 10:25:50AM +, Alejandro Vallejo wrote: > On Wed Jan 8, 2025 at 3:11 PM GMT, Roger Pau Monne wrote: > > The pv_{set,destroy}_gdt() functions rely on the L1 table(s) that contain > > such > > mappings being stashed in the domain structure, and thus such mappings being > >

Re: [PATCH v2 05/18] x86/mm: switch destroy_perdomain_mapping() parameter from domain to vCPU

On Thu, Jan 09, 2025 at 10:02:19AM +, Alejandro Vallejo wrote: > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > In preparation for the per-domain area being populated with per-vCPU > > mappings > > change the parameter of destroy_perdomain_mapping() to be a vCPU instead of > >

Re: [PATCH v2 04/18] x86/pv: introduce function to populate perdomain area and use it to map Xen GDT

On Thu, Jan 09, 2025 at 09:55:44AM +, Alejandro Vallejo wrote: > On Wed Jan 8, 2025 at 2:26 PM GMT, Roger Pau Monne wrote: > > The current code to update the Xen part of the GDT when running a PV guest > > relies on caching the direct map address of all the L1 tables used to map > > the > > GD

Re: [PATCH v3 05/11] misc: Use never-managed version of pci_intx()

On Mon, Dec 09, 2024 at 02:06:27PM +0100, Philipp Stanner wrote: > pci_intx() is a hybrid function which can sometimes be managed through > devres. To remove this hybrid nature from pci_intx(), it is necessary to > port users to either an always-managed or a never-managed version. > > cardreader/r

[PATCH v2] treewide: const qualify ctl_tables where applicable

Add the const qualifier to all the ctl_tables in the tree except for watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls, loadpin_sysctl_table and the ones calling register_net_sysctl (./net, drivers/inifiniband dirs). These are special cases as they use a registration function with a n

Re: [PATCH v2 04/18] x86/pv: introduce function to populate perdomain area and use it to map Xen GDT

On Thu, Jan 09, 2025 at 10:10:20AM +0100, Jan Beulich wrote: > On 08.01.2025 15:26, Roger Pau Monne wrote: > > The current code to update the Xen part of the GDT when running a PV guest > > relies on caching the direct map address of all the L1 tables used to map > > the > > GDT and LDT, so that e

Re: [PATCH 0/2] Enable the ability to disable/remove gnttabv2

On Fri, 10 Jan 2025 08:37:09 -0500 Daniel P. Smith wrote --- > OpenXT has carried a patch for some time that allows the disabling and > removal > of the grant table v2 capability. This is a rework of that patch in an > attempt > to make an upstreamable series. > > The original

[PATCH 3/3] pci/msi: remove pci_msi_ignore_mask

Setting pci_msi_ignore_mask inhibits the toggling of the mask bit for both MSI and MSI-X entries globally, regardless of the IRQ chip they are using. Only Xen sets the pci_msi_ignore_mask when routing physical interrupts over event channels, to prevent PCI code from attempting to toggle the maskbi

[PATCH 1/3] xen/pci: do not register devices outside of PCI segment scope

The PCI segment value is limited to 16 bits, however there are buses like VMD that fake being part of the PCI topology by adding segment with a number outside the scope of the PCI firmware specification range (>= 0x1). The MCFG ACPI Table "PCI Segment Group Number" field is defined as having a

[PATCH 0/3] xen: fix usage of devices behind a VMD bridge

Hello, The following series should fix the usage of devices behind a VMD bridge when running Linux as a Xen PV hardware domain (dom0). I've only been able to test PV. I think PVH should also work but I don't have hardware capable of testing it right now. I don't expect the first two patches to b

[PATCH 2/3] vmd: disable MSI remapping bypass under Xen

MSI remapping bypass (directly configuring MSI entries for devices on the VMD bus) won't work under Xen, as Xen is not aware of devices in such bus, and hence cannot configure the entries using the pIRQ interface in the PV case, and in the PVH case traps won't be setup for MSI entries for such devi

[PATCH 2/2] gnttab: make grant table v2 support configurable

If the v2 interface support is not required, disabling this option will remove substantial amounts of unused code in a critical subsystem. Disables the v2-only GNTTABOP_get_status_frames grant table op. Authored-by: Christopher Clark Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smi

[PATCH 1/2] gnttab: introduce version agnostic macros

Introduce a set of macros that abstract version specifics of the grant table structures. This lays the ground work for being able to turn off v2 logic and code. Authored-by: Christopher Clark Signed-off-by: Christopher Clark Signed-off-by: Daniel P. Smith --- xen/common/grant_table.c | 114 +++

[PATCH 0/2] Enable the ability to disable/remove gnttabv2

OpenXT has carried a patch for some time that allows the disabling and removal of the grant table v2 capability. This is a rework of that patch in an attempt to make an upstreamable series. The original patch was developed under funding provided by BAE, therefore a separate Authored-by tag to refl

Re: [PATCH v2 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Am 10.01.25 um 02:49 schrieb Andy Yan: Hi Thomas, At 2025-01-09 22:56:56, "Thomas Zimmermann" wrote: Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer scanline pitch and allocation size. Implementations of struct drm_driver.dumb_create can call the new helper for their size

[PATCH v3 12/12] x86/xstate: Make xstate_all() and vcpu_xsave_mask() take explicit xstate

No functional change. Signed-off-by: Alejandro Vallejo Acked-by: Jan Beulich --- v2->v3: * Added A-by --- xen/arch/x86/i387.c | 9 + xen/arch/x86/include/asm/xstate.h | 5 +++-- xen/arch/x86/xstate.c | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) d

[PATCH v3 09/12] x86/mpx: Map/unmap xsave area in in read_bndcfgu()

No functional change. Signed-off-by: Alejandro Vallejo --- v2->v3: * No change v1->v2: * s/ret/bndcfgu --- xen/arch/x86/xstate.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 3d249518a1b7..2003ba664594 10

[PATCH v3 03/12] x86/fpu: Map/umap xsave area in vcpu_{reset,setup}_fpu()

No functional change. Signed-off-by: Alejandro Vallejo Acked-by: Jan Beulich --- v2->v3: * Added A-by v1->v2: * No change --- xen/arch/x86/i387.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/i387.c b/xen/arch/x86/i387.c index 8fba0aef

[PATCH v3 05/12] x86/hvm: Map/unmap xsave area in hvmemul_{get,put}_fpu()

No functional change. Signed-off-by: Alejandro Vallejo Acked-by: Jan Beulich --- v2->v3: * style: Capitalized first letter of the fastpath comment * Added A-by v1->v2: * Added comments highlighting fastpath for current --- xen/arch/x86/hvm/emulate.c | 12 ++-- 1 file changed, 10

[PATCH v3 08/12] x86/emulator: Refactor FXSAVE_AREA to use wrappers

Adds an UNMAP primitive to make use of vcpu_unmap_xsave_area() when linked into xen. unmap is a no-op during tests. Signed-off-by: Alejandro Vallejo --- v2->v3: * Fixed typo in first parameter of UNMAP_FXSAVE_AREA. * Added Parenthesis around "x" in #else's UNMAP_FXSAVE_AREA(x) v1->v2: * Ad

[PATCH v3 11/12] x86/fpu: Pass explicit xsave areas to fpu_(f)xrstor()

No functional change. Signed-off-by: Alejandro Vallejo --- v2->v3: * const-ified v in fpu_xrstor() * Removed v in fpu_fxrstor() v1->v2: * const-ified v in xrstor() ( it was incorrectly reported in v2 as it being fpu_xrstor() ) --- xen/arch/x86/i387.c | 26 +++

[PATCH v3 01/12] x86/xstate: Create map/unmap primitives for xsave areas

Add infrastructure to simplify ASI handling. With ASI in the picture we'll have several different means of accessing the XSAVE area of a given vCPU, depending on whether a domain is covered by ASI or not and whether the vCPU is question is scheduled on the current pCPU or not. Having these complex

[PATCH v3 10/12] x86/fpu: Pass explicit xsave areas to fpu_(f)xsave()

No functional change. Signed-off-by: Alejandro Vallejo --- v2->v3: * const-ified v in fpu_fxsave() (missing in v2) v1->v2: * const-ified v --- xen/arch/x86/i387.c | 16 ++-- xen/arch/x86/include/asm/xstate.h | 2 +- xen/arch/x86/xstate.c | 3 +-- 3 fi

[PATCH v3 07/12] x86/xstate: Map/unmap xsave area in {compress,expand}_xsave_states()

No functional change. Signed-off-by: Alejandro Vallejo --- v2->v3: * Unmap xsave area also before the early return. v1->v2: * No change --- xen/arch/x86/xstate.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c

[PATCH v3 06/12] x86/domctl: Map/unmap xsave area in arch_get_info_guest()

No functional change. Signed-off-by: Alejandro Vallejo Acked-by: Jan Beulich --- v1->v2: * Added A-by v1->v2: * No change --- xen/arch/x86/domctl.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 5f0619da.

[PATCH v3 04/12] x86/xstate: Map/unmap xsave area in xstate_set_init() and handle_setbv()

No functional change. Signed-off-by: Alejandro Vallejo Acked-by: Jan Beulich --- v2->v3: * style: Capitalized first letter of the comment. * Added A-by v1->v2: * Added comment highlighting fastpath for current --- xen/arch/x86/xstate.c | 12 ++-- 1 file changed, 10 insertions(+),

[PATCH v3 02/12] x86/hvm: Map/unmap xsave area in hvm_save_cpu_ctxt()

No functional change. Signed-off-by: Alejandro Vallejo Acked-by: Jan Beulich --- v2->v3: * Added A-by v1->v2: * No change --- xen/arch/x86/hvm/hvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 922c9b3af64

[PATCH v3 00/12] x86: Address Space Isolation FPU preparations

See original cover letter in v1 v2: https://lore.kernel.org/xen-devel/20241105143310.28301-1-alejandro.vall...@cloud.com/ v2->v3: * Evaluated `v` argument in UNMAP operation (see patch 1) * Fixed bug on (de)compressing xstates by not unmapping them on early return. * Constified more when co

Re: [PATCH 1/1] xen/common: Remove dead code

Hi Stefano, On Thursday, January 02, 2025 18:08 CET, Stefano Stabellini wrote: > On Thu, 19 Dec 2024, Ariel Otilibili wrote: > > Reviewed-by: Stefano Stabellini > > Thanks for having looked into the patch; sorry for the late response, I have had limited access to my mailbox. I will follow

Re: [PATCH v2 10/13] x86/mpx: Map/unmap xsave area in in read_bndcfgu()

On Mon Dec 16, 2024 at 2:02 PM GMT, Alejandro Vallejo wrote: > On Mon Dec 16, 2024 at 12:03 PM GMT, Jan Beulich wrote: > > On 16.12.2024 13:00, Alejandro Vallejo wrote: > > > On Mon Dec 9, 2024 at 4:30 PM GMT, Jan Beulich wrote: > > >> On 05.11.2024 15:33, Alejandro Vallejo wrote: > > >>> --- a/xen

[PATCH 3/4] hw/xen: Use xs_node_read() from xen_netdev_get_name()

From: David Woodhouse Now that xs_node_read() can construct a node path, no need to open-code it. Signed-off-by: David Woodhouse --- hw/net/xen_nic.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.c index 97ebd9fa30..54100394

[PATCH 1/4] hw/xen: Use xs_node_read() from xs_node_vscanf()

From: David Woodhouse Reduce some duplication. Signed-off-by: David Woodhouse --- hw/xen/trace-events | 1 - hw/xen/xen-bus-helper.c | 15 ++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/xen/trace-events b/hw/xen/trace-events index 461dee7b23..b67942d07b

[PATCH 2/4] hw/xen: Use xs_node_read() from xen_console_get_name()

From: David Woodhouse Now that xs_node_read() can construct a node path, no need to open-code it. Signed-off-by: David Woodhouse --- hw/char/xen_console.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c index

[PATCH 4/4] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it

From: David Woodhouse Signed-off-by: David Woodhouse --- hw/xen/xen_pvdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c index c5ad71e8dc..c9143ba259 100644 --- a/hw/xen/xen_pvdev.c +++ b/hw/xen/xen_pvdev.c @@ -22,6 +22,7 @@

Re: [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes

On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote: > Hello, > > First patch from David introduces a new helper to fetch xenstore nodes, > while second patch removes the usage of scanf related functions with the > "%ms" format specifier, as it's not supported by the FreeBSD scanf libc > impl

Re: [PATCH v2 1/2] hw/xen: Add xs_node_read() helper function

On 10/1/25 10:35, Roger Pau Monne wrote: From: David Woodhouse This returns the full contents of the node, having created the node path from the printf-style format string provided in its arguments. This will save various callers from having to do so for themselves (and from using xs_node_scan

Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier

On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote: > The 'm' parameter used to request auto-allocation of the destination variable > is not supported on FreeBSD, and as such leads to failures to parse. > > What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as > it ju

[PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes

Hello, First patch from David introduces a new helper to fetch xenstore nodes, while second patch removes the usage of scanf related functions with the "%ms" format specifier, as it's not supported by the FreeBSD scanf libc implementation. Thanks, Roger. David Woodhouse (1): hw/xen: Add xs_nod

[PATCH v2 2/2] xen: do not use '%ms' scanf specifier

The 'm' parameter used to request auto-allocation of the destination variable is not supported on FreeBSD, and as such leads to failures to parse. What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as it just leads to a double allocation of the same string. Instead use xs_

[PATCH v2 1/2] hw/xen: Add xs_node_read() helper function

From: David Woodhouse This returns the full contents of the node, having created the node path from the printf-style format string provided in its arguments. This will save various callers from having to do so for themselves (and from using xs_node_scanf() with the non-portable %ms format string

Re: [PATCH v2 1/2] x86/uaccess: rework user access speculative harden guards

On 2025-01-10 09:29, Roger Pau Monné wrote: On Thu, Jan 09, 2025 at 03:57:24PM -0800, Stefano Stabellini wrote: On Thu, 9 Jan 2025, Nicola Vetrini wrote: > On 2025-01-04 01:20, Stefano Stabellini wrote: > > Hi Nicola, one question below > > > > On Wed, 27 Nov 2024, Nicola Vetrini wrote: > > > >

Re: [PATCH v2 1/2] x86/uaccess: rework user access speculative harden guards

On Thu, Jan 09, 2025 at 03:57:24PM -0800, Stefano Stabellini wrote: > On Thu, 9 Jan 2025, Nicola Vetrini wrote: > > On 2025-01-04 01:20, Stefano Stabellini wrote: > > > Hi Nicola, one question below > > > > > > On Wed, 27 Nov 2024, Nicola Vetrini wrote: > > > > > #define AMD_OSVW_ERRATUM(osvw_id,

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

On Fri, 2025-01-10 at 09:16 +0100, Philippe Mathieu-Daudé wrote: > On 10/1/25 09:08, David Woodhouse wrote: > > On Thu, 2025-01-09 at 17:55 +0100, Roger Pau Monné wrote: > > > On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: > > > > On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

On 10/1/25 09:08, David Woodhouse wrote: On Thu, 2025-01-09 at 17:55 +0100, Roger Pau Monné wrote: On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote:   char label[32];   XenDevice *xendev = NULL;   XenConso

Re: [PATCH v2 10/25] drm/imx/ipuv3: Compute dumb-buffer sizes with drm_mode_size_dumb()

On Do, 2025-01-09 at 15:57 +0100, Thomas Zimmermann wrote: > Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and > buffer size. The hardware requires the framebuffer width to be a > multiple of 8. The scanline pitch has be large enough to support > this. Therefore compute the byte s

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

On Thu, 2025-01-09 at 17:55 +0100, Roger Pau Monné wrote: > On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: > > On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote: > > > > > > >   char label[32]; > > > >   XenDevice *xendev = NULL; > > > >   XenConsole *con; > > >

Re:[PATCH v2 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Thomas, At 2025-01-09 22:56:56, "Thomas Zimmermann" wrote: >Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer >scanline pitch and allocation size. Implementations of struct >drm_driver.dumb_create can call the new helper for their size >computations. There's currently quite a b