Re: [PATCH 20/71] hw/char: Constify all Property

On Fri 13 Dec 2024 01:06:54 PM -06, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: Alberto Garcia Berto

Re: [PATCH 1/2] ARM: ITS: implement quirks and add support for Renesas Gen4 ITS

Hi, On 13/12/2024 22:06, Stefano Stabellini wrote: On Fri, 13 Dec 2024, Mykyta Poturai wrote: From: Oleksandr Andrushchenko There are number of ITS implementations exist which are different from the base one which have number of functionalities defined as is "IMPLEMENTATION DEFINED", e.g. the

Re: [PATCH v3 04/10] xen/arm: ffa: Fine granular call support

Hi Bertrand, On 27/11/2024 16:07, Bertrand Marquis wrote: Create a bitmap to store which feature is supported or not by the firmware and use it to filter which calls are done to the firmware. While there reoder ABI definition by numbers to easily find the min and Typo (I can fix it while comm

Re: [PATCH 2/2] xen/arm: platform: Add support for R-Car Gen4

On Fri, 13 Dec 2024, Mykyta Poturai wrote: > From: Oleksandr Andrushchenko > > Add Rcar Gen4 platform choice to Kconfig to select all required > drivers automatically. > > Signed-off-by: Oleksandr Andrushchenko > Signed-off-by: Volodymyr Babchuk > Signed-off-by: Mykyta Poturai Reviewed-by: S

Re: [PATCH 1/2] ARM: ITS: implement quirks and add support for Renesas Gen4 ITS

On Fri, 13 Dec 2024, Mykyta Poturai wrote: > From: Oleksandr Andrushchenko > > There are number of ITS implementations exist which are different from > the base one which have number of functionalities defined as is > "IMPLEMENTATION DEFINED", e.g. there may exist differences in cacheability, > s

Re: [PATCH] xen: address violation of MISRA C Rule 11.1

On Fri, 13 Dec 2024, Alessandro Zucchelli wrote: > On 2024-12-13 11:08, Jan Beulich wrote: > > On 13.12.2024 01:53, Stefano Stabellini wrote: > > > On Thu, 12 Dec 2024, Jan Beulich wrote: > > > > On 12.12.2024 03:27, Stefano Stabellini wrote: > > > > > On Wed, 11 Dec 2024, Jan Beulich wrote: > > >

Re: [PATCH v2 33/35] x86/domain: implement domain_has_vuart()

On Fri, 13 Dec 2024, Roger Pau Monné wrote: > On Thu, Dec 05, 2024 at 08:42:03PM -0800, Denis Mukhin via B4 Relay wrote: > > From: Denis Mukhin > > > > Add new emulation flag for virtual UART on x86 and plumb it through the > > stack. > > > > This change enables NS8250 emulator initialization.

[PATCH 68/71] hw/xen: Constify all Property

Signed-off-by: Richard Henderson --- hw/xen/xen-bus.c| 2 +- hw/xen/xen-legacy-backend.c | 4 ++-- hw/xen/xen_pt.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index 95b207ac8b..0d7defb8cd 100644 --- a/hw/xen/xe

[PATCH 69/71] hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties

Signed-off-by: Richard Henderson --- hw/xen/xen-legacy-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c index b15393e934..f6ad58fe13 100644 --- a/hw/xen/xen-legacy-backend.c +++ b/hw/xen/xen-legacy-backend.c @@

[PATCH 41/71] hw/net: Constify all Property

Signed-off-by: Richard Henderson --- hw/net/allwinner-sun8i-emac.c | 2 +- hw/net/allwinner_emac.c| 2 +- hw/net/cadence_gem.c | 2 +- hw/net/can/xlnx-versal-canfd.c | 2 +- hw/net/can/xlnx-zynqmp-can.c | 2 +- hw/net/dp8393x.c | 2 +- hw/net/e1000.c

[PATCH 29/71] hw/i386: Constify all Property

Signed-off-by: Richard Henderson --- hw/i386/amd_iommu.c| 2 +- hw/i386/intel_iommu.c | 2 +- hw/i386/kvm/clock.c| 2 +- hw/i386/kvm/i8254.c| 2 +- hw/i386/kvm/ioapic.c | 2 +- hw/i386/sgx-epc.c | 2 +- hw/i386/vmmouse.c | 2 +- hw/i386/vmport.

[PATCH 19/71] hw/block: Constify all Property

Signed-off-by: Richard Henderson --- hw/block/fdc-isa.c| 2 +- hw/block/fdc-sysbus.c | 4 ++-- hw/block/fdc.c| 2 +- hw/block/m25p80.c | 2 +- hw/block/nand.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/pflash_cfi02.c | 2 +- hw/block/swim.c

[PATCH 18/71] hw/block/xen-block: Unexport PropertyInfo

xen_block_prop_vdev is not used outside the file. Signed-off-by: Richard Henderson --- hw/block/xen-block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index aed1d5c330..72cfd6893a 100644 --- a/hw/block/xen-block.c +++ b/hw/bloc

[PATCH 20/71] hw/char: Constify all Property

Signed-off-by: Richard Henderson --- hw/char/avr_usart.c | 2 +- hw/char/bcm2835_aux.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char/cmsdk-apb-uart.c| 2 +- hw/char/debugcon.c | 2 +- hw/char/digic-uart.c| 2 +- hw/char/escc.c | 2 +- hw/char/

Re: [PATCH v3 09/11] wifi: qtnfmac: use always-managed version of pcim_intx()

[+cc personal address for Igor] On Fri, Dec 13, 2024 at 12:30:42PM +0200, Kalle Valo wrote: > Bjorn Helgaas writes: > > > [cc->to: Igor] > > > > On Mon, Dec 09, 2024 at 02:06:31PM +0100, Philipp Stanner wrote: > >> pci_intx() is a hybrid function which can sometimes be managed through > >> devre

[PATCH v12 10/12] xen/arm: add Xen cache colors command line parameter

From: Luca Miccio Add a new command line parameter to configure Xen cache colors. These colors are dumped together with other coloring info. Benchmarking the VM interrupt response time provides an estimation of LLC usage by Xen's most latency-critical runtime task. Results on Arm Cortex-A53 on X

[PATCH v12 08/12] xen/page_alloc: introduce preserved page flags macro

PGC_static and PGC_extra need to be preserved when assigning a page. Define a new macro that groups those flags and use it instead of or'ing every time. Signed-off-by: Carlo Nonato --- v12: - fixed wrong patch sent in v11 - added comment on PGC_preserved v11: - removed PGC_broken from PGC_preserv

[PATCH v12 12/12] xen/arm: add cache coloring support for Xen image

Xen image is relocated to a new colored physical space. Some relocation functionalities must be brought back: - the virtual address of the new space is taken from 0c18fb76323b ("xen/arm: Remove unused BOOT_RELOC_VIRT_START"). - relocate_xen() and get_xen_paddr() are taken from f60658c6ae47 ("xe

[PATCH v3 7/7] tools/xenstored: use new stable interface instead of libxenctrl

Replace the current use of the unstable xc_domain_getinfo_single() interface with the stable domctl XEN_DOMCTL_get_domain_state call via the new libxenmanage library. This will remove the last usage of libxenctrl by Xenstore, so update the library dependencies accordingly. For now only do a direc

[PATCH v12 11/12] xen/arm: make consider_modules() available for xen relocation

Cache coloring must physically relocate Xen in order to color the hypervisor and consider_modules() is a key function that is needed to find a new available physical address. 672d67f339c0 ("xen/arm: Split MMU-specific setup_mm() and related code out") moved consider_modules() under arm32. Move it

[PATCH v12 07/12] xen/arm: add support for cache coloring configuration via device-tree

Add the "llc-colors" Device Tree property to express DomUs and Dom0less color configurations. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri Reviewed-by: Jan Beulich # non-Arm Reviewed-by: Michal Orzel --- v12: - no changes v11: - made clear

[PATCH v12 05/12] xen: extend domctl interface for cache coloring

Add a new domctl hypercall to allow the user to set LLC coloring configurations. Colors can be set only once, just after domain creation, since recoloring isn't supported. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri Reviewed-by: Jan Beulich

[PATCH v12 03/12] xen/arm: permit non direct-mapped Dom0 construction

Cache coloring requires Dom0 not to be direct-mapped because of its non contiguous mapping nature, so allocate_memory() is needed in this case. 8d2c3ab18cc1 ("arm/dom0less: put dom0less feature code in a separate module") moved allocate_memory() in dom0less_build.c. In order to use it in Dom0 const

[PATCH v12 09/12] xen: add cache coloring allocator for domains

Add a new memory page allocator that implements the cache coloring mechanism. The allocation algorithm enforces equal frequency distribution of cache partitions, following the coloring configuration of a domain. This allows for an even utilization of cache sets for every domain. Pages are stored i

[PATCH v12 01/12] xen/common: add cache coloring common code

Last Level Cache (LLC) coloring allows to partition the cache in smaller chunks called cache colors. Since not all architectures can actually implement it, add a HAS_LLC_COLORING Kconfig option. LLC_COLORS_ORDER Kconfig option has a range maximum of 10 (2^10 = 1024) because that's the number of co

[PATCH v12 06/12] tools: add support for cache coloring configuration

Add a new "llc_colors" parameter that defines the LLC color assignment for a domain. The user can specify one or more color ranges using the same syntax used everywhere else for color config described in the documentation. The parameter is defined as a list of strings that represent the color range

[PATCH v12 04/12] xen/arm: add Dom0 cache coloring support

Add a command line parameter to allow the user to set the coloring configuration for Dom0. A common configuration syntax for cache colors is introduced and documented. Take the opportunity to also add: - default configuration notion. - function to check well-formed configurations. Direct mapping

[PATCH v12 00/12] Arm cache coloring

Shared caches in multi-core CPU architectures represent a problem for predictability of memory access latency. This jeopardizes applicability of many Arm platform in real-time critical and mixed-criticality scenarios. We introduce support for cache partitioning with page coloring, a transparent sof

[PATCH v12 02/12] xen/arm: add initial support for LLC coloring on arm64

LLC coloring needs to know the last level cache layout in order to make the best use of it. This can be probed by inspecting the CLIDR_EL1 register, so the Last Level is defined as the last level visible by this register. Note that this excludes system caches in some platforms. Static memory alloc

[PATCH v3 6/7] tools/libs: add a new libxenmanage library

In order to have a stable interface in user land for using stable domctl and possibly later sysctl interfaces, add a new library libxenmanage. Signed-off-by: Juergen Gross --- V1: - new patch V2: - define __XEN_TOOLS__ via Makefile (Anthony PERARD) - use SPDX in header file (Anthony PERARD) - cha

[PATCH v3 4/7] xen: add bitmap to indicate per-domain state changes

Add a bitmap with one bit per possible domid indicating the respective domain has changed its state (created, deleted, dying, crashed, shutdown). Registering the VIRQ_DOM_EXC event will result in setting the bits for all existing domains and resetting all other bits. As the usage of this bitmap i

[PATCH v3 5/7] xen: add new domctl get_changed_domain

Add a new domctl sub-function to get data of a domain having changed state (this is needed by Xenstore). The returned state just contains the domid, the domain unique id, and some flags (existing, shutdown, dying). In order to enable Xenstore stubdom being built for multiple Xen versions, make th

[PATCH v3 3/7] xen: add a domain unique id to each domain

Xenstore is referencing domains by their domid, but reuse of a domid can lead to the situation that Xenstore can't tell whether a domain with that domid has been deleted and created again without Xenstore noticing the domain is a new one now. Add a global domain creation unique id which is updated

[PATCH v3 1/7] xen/xsm: make getdomaininfo xsm dummy checks more stringent

Today the dummy XSM privilege checks for getdomaininfo are less stringent than possible: they basically rely on the general sysctl/domctl entry check to do all tests and then do the test with the XSM_HOOK privilege, which is an "allow all" default. Instead of XSM_HOOK use XSM_XS_PRIV, which is the

[PATCH v3 0/7] remove libxenctrl usage from xenstored

Xenstored is using libxenctrl for only one purpose: to get information about state of domains. This patch series is removing that dependency by introducing a new stable interface which can be used by xenstored instead. There was a RFC series sent out 3 years ago, which I have taken as a base and

[PATCH v3 2/7] tools: add a dedicated header file for barrier definitions

Instead of having to include xenctrl.h for getting definitions of cpu barriers, add a dedicated header for that purpose. Switch the xen-9pfsd daemon to use the new header instead of xenctrl.h. This is in preparation of making Xenstore independent from libxenctrl. Signed-off-by: Juergen Gross --

Re: [PATCH V4 10/15] xen/page_alloc: vmap heap nodes when they are outside the direct map

On Mon Nov 11, 2024 at 1:11 PM GMT, Elias El Yandouzi wrote: > From: Hongyan Xia > > When we do not have a direct map, archs_mfn_in_direct_map() will always > return false, thus init_node_heap() will allocate xenheap pages from an > existing node for the metadata of a new node. This means that the

Re: [PATCH] xen: address violation of MISRA C Rule 11.1

On 2024-12-13 11:08, Jan Beulich wrote: On 13.12.2024 01:53, Stefano Stabellini wrote: On Thu, 12 Dec 2024, Jan Beulich wrote: On 12.12.2024 03:27, Stefano Stabellini wrote: On Wed, 11 Dec 2024, Jan Beulich wrote: On 11.12.2024 12:02, Alessandro Zucchelli wrote: Rule 11.1 states as following

Re: [PATCH V4 10/15] xen/page_alloc: vmap heap nodes when they are outside the direct map

Hi, I'm seeing crashes on NUMA machines, which can be attributed to a bug below: On Mon Nov 11, 2024 at 1:11 PM GMT, Elias El Yandouzi wrote: > From: Hongyan Xia > > When we do not have a direct map, archs_mfn_in_direct_map() will always > return false, thus init_node_heap() will allocate xenhea

[PATCH 1/2] ARM: ITS: implement quirks and add support for Renesas Gen4 ITS

From: Oleksandr Andrushchenko There are number of ITS implementations exist which are different from the base one which have number of functionalities defined as is "IMPLEMENTATION DEFINED", e.g. there may exist differences in cacheability, shareability and memory requirements and others. This re

[PATCH 2/2] xen/arm: platform: Add support for R-Car Gen4

From: Oleksandr Andrushchenko Add Rcar Gen4 platform choice to Kconfig to select all required drivers automatically. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Volodymyr Babchuk Signed-off-by: Mykyta Poturai --- xen/arch/arm/platforms/Kconfig | 10 +- 1 file changed, 9 ins

[PATCH 0/2] Add support for Renesas R-Car Gen4

Add support for Renesas Gen4 boards such as S4[1] and V4H[2] by adding the appropriate confing option, and support for the Gen4 ITS. Tested on Renesas R-Car V4H board. [1]: https://www.renesas.com/en/products/automotive-products/automotive-system-chips-socs/r-car-s4-automotive-system-chip-soc-car

Re: [PATCH v2 2/7] xen/riscv: add destroy_xen_mappings() to remove mappings in Xen page tables

On 12/12/24 12:43 PM, Jan Beulich wrote: On 11.12.2024 18:27, Oleksii Kurochko wrote: Introduce the destroy_xen_mappings() function, which removes page mappings in Xen's page tables between a start address s and an end address e. The function ensures that both s and e are page-aligned and verif

Re: [PATCH v11 03/12] xen/arm: permit non direct-mapped Dom0 construction

On Fri, Dec 13, 2024 at 12:47 PM Michal Orzel wrote: > > > > On 13/12/2024 12:33, Carlo Nonato wrote: > > > > > > Using paste.debian: > > > > https://paste.debian.net/1339647/ > > 1. Issue I mentioned with prefixing with double underscore > 2. Generic helper should not be named ext_regions > 3. s/

Re: [PATCH v2 33/35] x86/domain: implement domain_has_vuart()

On Thu, Dec 05, 2024 at 08:42:03PM -0800, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin > > Add new emulation flag for virtual UART on x86 and plumb it through the stack. > > This change enables NS8250 emulator initialization. > > Signed-off-by: Denis Mukhin > --- > tools/libs/light/l

Re: [PATCH v2 32/35] x86/hvm: add debugging facility to NS8250 UART emulator

On Thu, Dec 05, 2024 at 08:42:02PM -0800, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin > > Enable keyhandler mechanism for dumping state of emulated NS8250 on the > console. > > Signed-off-by: Denis Mukhin > --- > xen/arch/x86/hvm/vuart_ns8250.c | 122 > ++

Re: [PATCH v11 03/12] xen/arm: permit non direct-mapped Dom0 construction

On 13/12/2024 12:33, Carlo Nonato wrote: > > > Using paste.debian: > > https://paste.debian.net/1339647/ 1. Issue I mentioned with prefixing with double underscore 2. Generic helper should not be named ext_regions 3. s/skip_size/min_bank_size/ And still you need to convince others about 128

Re: [PATCH v2 31/35] x86/hvm: introduce NS8250 UART emulator

On Thu, Dec 05, 2024 at 08:42:01PM -0800, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin > > Add initial in-hypervisor emulator for NS8250/NS16x50-compatible UARTs under > CONFIG_HAS_VUART_NS8250. > > In parallel domain creation scenario (hyperlaunch), NS8520 emulator helps > early guest

Re: [PATCH v11 03/12] xen/arm: permit non direct-mapped Dom0 construction

Using paste.debian: https://paste.debian.net/1339647/ Thanks. - Carlo

Re: [PATCH v11 03/12] xen/arm: permit non direct-mapped Dom0 construction

On Fri, Dec 13, 2024 at 11:56 AM Michal Orzel wrote: > > > > On 13/12/2024 11:26, Carlo Nonato wrote: > > > > > > Hi Michal, > > > > On Fri, Dec 13, 2024 at 10:46 AM Michal Orzel wrote: > >> > >> Hi Carlo, Andrea, > >> > >> On 12/12/2024 19:22, Andrea Bastoni wrote: > >>> > >>> > >>> On 12/12/202

Re: [PATCH v11 03/12] xen/arm: permit non direct-mapped Dom0 construction

On 13/12/2024 11:26, Carlo Nonato wrote: > > > Hi Michal, > > On Fri, Dec 13, 2024 at 10:46 AM Michal Orzel wrote: >> >> Hi Carlo, Andrea, >> >> On 12/12/2024 19:22, Andrea Bastoni wrote: >>> >>> >>> On 12/12/2024 18:48, Carlo Nonato wrote: Hi, On Mon, Dec 9, 2024 at 8:17 PM J

[PATCH v7] xen/arm: Check for Static Heap feature when freeing resources

From: Penny Zheng If the Xen heap is statically configured in Device Tree, its size is definite, so only the defined memory shall be given to the boot allocator. Have a check where init_domheap_pages() is called which takes into account if static heap feature is used. Extract static_heap flag fr

Re: [PATCH v3 09/11] wifi: qtnfmac: use always-managed version of pcim_intx()

Bjorn Helgaas writes: > [cc->to: Igor] > > On Mon, Dec 09, 2024 at 02:06:31PM +0100, Philipp Stanner wrote: >> pci_intx() is a hybrid function which can sometimes be managed through >> devres. To remove this hybrid nature from pci_intx(), it is necessary to >> port users to either an always-manag

Re: [PATCH v11 03/12] xen/arm: permit non direct-mapped Dom0 construction

Hi Michal, On Fri, Dec 13, 2024 at 10:46 AM Michal Orzel wrote: > > Hi Carlo, Andrea, > > On 12/12/2024 19:22, Andrea Bastoni wrote: > > > > > > On 12/12/2024 18:48, Carlo Nonato wrote: > >> Hi, > >> > >> On Mon, Dec 9, 2024 at 8:17 PM Julien Grall wrote: > >>> > >>> Hi Michal, > >>> > >>> On 07

Re: [PATCH] xen: address violation of MISRA C Rule 11.1

On 13.12.2024 01:53, Stefano Stabellini wrote: > On Thu, 12 Dec 2024, Jan Beulich wrote: >> On 12.12.2024 03:27, Stefano Stabellini wrote: >>> On Wed, 11 Dec 2024, Jan Beulich wrote: On 11.12.2024 12:02, Alessandro Zucchelli wrote: > Rule 11.1 states as following: "Conversions shall not be

Re: [PATCH 0/3] virtgpu: check if P2P is possiable or not

On 2024/12/12 15:43, Juergen Gross wrote: > On 07.12.24 11:50, Julia Zhang wrote: >> To implement dGPU prime feature, virtgpu needs to import/export buffer >> between virtio iGPU and passthrough dGPU. Before that, virtgpu should >> check if P2P is possible or not. But calling function >> pci_p2pd

Re: [PATCH v11 03/12] xen/arm: permit non direct-mapped Dom0 construction

Hi Carlo, Andrea, On 12/12/2024 19:22, Andrea Bastoni wrote: > > > On 12/12/2024 18:48, Carlo Nonato wrote: >> Hi, >> >> On Mon, Dec 9, 2024 at 8:17 PM Julien Grall wrote: >>> >>> Hi Michal, >>> >>> On 07/12/2024 15:04, Michal Orzel wrote: On 06/12/2024 19:37, Julien Grall wrote: