Re: [XEN PATCH v6] CODING_STYLE: Add a section on header guards naming conventions

2024-09-09 Thread Jan Beulich
On 10.09.2024 06:57, Stefano Stabellini wrote: > On Mon, 9 Sep 2024, Jan Beulich wrote: >> On 05.09.2024 17:48, Alessandro Zucchelli wrote: >>> This section explains which format should be followed by header >>> inclusion guards via a drop-down list of rules. >>> >>> No functional change. >>> >>> S

Re: [XEN PATCH v2] automation/eclair_analysis: deviate linker symbols for Rule 18.2

2024-09-09 Thread Jan Beulich
On 10.09.2024 06:46, Stefano Stabellini wrote: > On Mon, 9 Sep 2024, Jan Beulich wrote: >> On 07.09.2024 15:03, Nicola Vetrini wrote: >>> + * - R18.2 >>> + - Subtraction between pointers encapsulated by macro page_to_mfn >>> + are safe. >>> + - Tagged as `safe` for ECLAIR. >> >> Thi

Re: [XEN PATCH v6] CODING_STYLE: Add a section on header guards naming conventions

2024-09-09 Thread Stefano Stabellini
On Mon, 9 Sep 2024, Jan Beulich wrote: > On 05.09.2024 17:48, Alessandro Zucchelli wrote: > > This section explains which format should be followed by header > > inclusion guards via a drop-down list of rules. > > > > No functional change. > > > > Signed-off-by: Alessandro Zucchelli > > > > ---

Re: [XEN PATCH v2] automation: fix xilinx test console settings

2024-09-09 Thread Stefano Stabellini
On Mon, 9 Sep 2024, victorm.l...@amd.com wrote: > From: Victor Lira > > The test showed unreliable behavior due to unsupported console settings. > Update the baud rate used to connect to the UART. > > Signed-off-by: Victor Lira Reviewed-by: Stefano Stabellini > --- > Changes v2: > - restore

Re: [XEN PATCH v2] automation/eclair_analysis: deviate linker symbols for Rule 18.2

2024-09-09 Thread Stefano Stabellini
On Mon, 9 Sep 2024, Jan Beulich wrote: > On 07.09.2024 15:03, Nicola Vetrini wrote: > > --- a/docs/misra/deviations.rst > > +++ b/docs/misra/deviations.rst > > @@ -501,6 +501,16 @@ Deviations related to MISRA C:2012 Rules: > > - __builtin_memset() > > - cpumask_check() > > > >

Re: [XEN PATCH] automation/eclair_analysis: fix MISRA Rule 20.7 regression in self-tests.h

2024-09-09 Thread Stefano Stabellini
Acked-by: Stefano Stabellini On Mon, 9 Sep 2024, Jan Beulich wrote: > On 08.09.2024 15:27, Nicola Vetrini wrote: > > --- a/docs/misra/deviations.rst > > +++ b/docs/misra/deviations.rst > > @@ -533,6 +533,14 @@ Deviations related to MISRA C:2012 Rules: > > to incur in the risk of being m

[ovmf test] 187628: all pass - PUSHED

2024-09-09 Thread osstest service owner
flight 187628 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187628/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 61f9695f20a575085d0579a0d3efc41b322ce1ac baseline version: ovmf 3885a3edad618861168fe

[PATCH] fbdev/xen-fbfront: Assign fb_info->device

2024-09-09 Thread Jason Andryuk
From: Jason Andryuk Probing xen-fbfront faults in video_is_primary_device(). The passed-in struct device is NULL since xen-fbfront doesn't assign it and the memory is kzalloc()-ed. Assign fb_info->device to avoid this. This was exposed by the conversion of fb_is_primary_device() to video_is_pr

[qemu-mainline test] 187598: regressions - FAIL

2024-09-09 Thread osstest service owner
flight 187598 qemu-mainline real [real] flight 187627 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/187598/ http://logs.test-lab.xenproject.org/osstest/logs/187627/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[XEN PATCH v2] automation: fix xilinx test console settings

2024-09-09 Thread victorm.lira
From: Victor Lira The test showed unreliable behavior due to unsupported console settings. Update the baud rate used to connect to the UART. Signed-off-by: Victor Lira --- Changes v2: - restore I/O port address --- Cc: Andrew Cooper Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc

[libvirt bisection] complete test-amd64-amd64-libvirt

2024-09-09 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-libvirt testid guest-start Tree: libvirt https://gitlab.com/libvirt/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenb

Re: [XEN PATCH v1] automation: fix xilinx test console settings

2024-09-09 Thread Stefano Stabellini
On Mon, 9 Sep 2024, victorm.l...@amd.com wrote: > From: Victor Lira > > The test showed unreliable behavior due to unsupported console settings. > Update the baud rate and I/O port used to connect to the UART. > > Signed-off-by: Victor Lira The change of ioport number should not be needed. I d

Re: [PATCH 4/4] ARM/vgic: Use for_each_set_bit() in vgic-mmio*

2024-09-09 Thread Julien Grall
Hi, On 03/09/2024 14:19, Andrew Cooper wrote: On 03/09/2024 11:30 am, Michal Orzel wrote: On 02/09/2024 12:03, Andrew Cooper wrote: These are all loops over a scalar value, and don't need to call general bitop helpers behind the scenes. No functional change. Signed-off-by: Andrew Cooper -

Re: [PATCH 5/5] ARM/cache: Drop legacy __read_mostly/__ro_after_init definitions

2024-09-09 Thread Julien Grall
Hi Andrew, On 05/09/2024 23:08, Andrew Cooper wrote: These are no longer needed. Signed-off-by: Andrew Cooper Acked-by: Julien Grall Cheers, --- CC: Jan Beulich CC: Roger Pau Monné CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Michal Orzel

Re: [PATCH] docs: fusa: Add Assumption of Use (AOU)

2024-09-09 Thread Julien Grall
Hi Stefano, On 09/09/2024 20:53, Stefano Stabellini wrote: On Mon, 9 Sep 2024, Julien Grall wrote: On 09/09/2024 10:50, Ayan Kumar Halder wrote: On 09/09/2024 10:11, Julien Grall wrote: On 09/09/2024 09:56, Michal Orzel wrote: Hi Julien, On 08/09/2024 23:05, Julien Grall wrote: Hi Ayan

[linux-linus test] 187595: tolerable FAIL - PUSHED

2024-09-09 Thread osstest service owner
flight 187595 linux-linus real [real] flight 187620 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/187595/ http://logs.test-lab.xenproject.org/osstest/logs/187620/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

[ovmf test] 187617: all pass - PUSHED

2024-09-09 Thread osstest service owner
flight 187617 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187617/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3885a3edad618861168fe7081027867f1753ed42 baseline version: ovmf e5715711a41b3a323b160

Re: [PATCH] Revert "ALSA: memalloc: Workaround for Xen PV"

2024-09-09 Thread Elliott Mitchell
On Sat, Sep 07, 2024 at 11:38:50AM +0100, Andrew Cooper wrote: > On 07/09/2024 8:46 am, Takashi Iwai wrote: > > On Fri, 06 Sep 2024 20:42:09 +0200, > > Ariadne Conill wrote: > >> This patch attempted to work around a DMA issue involving Xen, but > >> causes subtle kernel memory corruption. > >> > >

Re: [PATCH] docs: fusa: Add Assumption of Use (AOU)

2024-09-09 Thread Stefano Stabellini
On Mon, 9 Sep 2024, Julien Grall wrote: > On 09/09/2024 10:50, Ayan Kumar Halder wrote: > > On 09/09/2024 10:11, Julien Grall wrote: > > > > > > > > > On 09/09/2024 09:56, Michal Orzel wrote: > > > > Hi Julien, > > > > > > > > On 08/09/2024 23:05, Julien Grall wrote: > > > > > > > > > > > > >

[xen-unstable-smoke test] 187613: tolerable all pass - PUSHED

2024-09-09 Thread osstest service owner
flight 187613 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187613/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[XEN PATCH v1] automation: fix xilinx test console settings

2024-09-09 Thread victorm.lira
From: Victor Lira The test showed unreliable behavior due to unsupported console settings. Update the baud rate and I/O port used to connect to the UART. Signed-off-by: Victor Lira --- Cc: Andrew Cooper Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.o

[libvirt test] 187594: regressions - FAIL

2024-09-09 Thread osstest service owner
flight 187594 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/187594/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 187513 test-amd64-amd64-libvir

[xen-unstable-smoke test] 187607: tolerable all pass - PUSHED

2024-09-09 Thread osstest service owner
flight 187607 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187607/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] docs: fusa: Add Assumption of Use (AOU)

2024-09-09 Thread Julien Grall
On 09/09/2024 10:50, Ayan Kumar Halder wrote: On 09/09/2024 10:11, Julien Grall wrote: On 09/09/2024 09:56, Michal Orzel wrote: Hi Julien, On 08/09/2024 23:05, Julien Grall wrote: Hi Ayan, On 06/09/2024 11:13, Ayan Kumar Halder wrote: From: Michal Orzel AOU are the assumptions Xen rel

Re: [PATCH v5 1/4] x86/time: pull cmos_rtc_probe outside of function and rename

2024-09-09 Thread Jan Beulich
On 09.09.2024 16:54, Roger Pau Monne wrote: > Rename cmos_rtc_probe to opt_cmos_rtc_probe in order to better describe it > being a command line option, and rename cmos_probe() function to > cmos_rtc_probe(). > > Also move opt_cmos_rtc_probe to being a static global variable in preparation > for fu

[PATCH v5 3/4] x86/time: introduce command line option to select wallclock

2024-09-09 Thread Roger Pau Monne
Allow setting the used wallclock from the command line. When the option is set to a value different than `auto` the probing is bypassed and the selected implementation is used (as long as it's available). The `xen` and `efi` options require being booted as a Xen guest (with Xen guest supported bu

[PATCH v5 1/4] x86/time: pull cmos_rtc_probe outside of function and rename

2024-09-09 Thread Roger Pau Monne
Rename cmos_rtc_probe to opt_cmos_rtc_probe in order to better describe it being a command line option, and rename cmos_probe() function to cmos_rtc_probe(). Also move opt_cmos_rtc_probe to being a static global variable in preparation for further changes that will require the variable being globa

[PATCH v5 4/4] x86/time: prefer CMOS over EFI_GET_TIME

2024-09-09 Thread Roger Pau Monne
The EFI_GET_TIME implementation is well known to be broken for many firmware implementations, for Xen the result on such implementations are: [ Xen-4.19-unstable x86_64 debug=y Tainted: C] CPU:0 RIP:e008:[<62ccfa70>] 62ccfa70 [...] Xen call trace: [<

[PATCH v5 2/4] x86/time: introduce probing logic for the wallclock

2024-09-09 Thread Roger Pau Monne
Adding such probing allows to clearly separate init vs runtime code, and to place the probing logic into the init section for the CMOS case. Note both the Xen shared_info page wallclock, and the EFI wallclock don't really have any probing-specific logic. The shared_info wallclock will always be t

[PATCH v5 0/4] x86/time: improvements to wallclock logic

2024-09-09 Thread Roger Pau Monne
Hello, This series started as an attempt to change the default wallclock preference from EFI_GET_TIME to CMOS RTC, but has grown quite a lot. Thanks, Roger. Roger Pau Monne (4): x86/time: pull cmos_rtc_probe outside of function and rename x86/time: introduce probing logic for the wallclock

Re: [PATCH v1 2/4] xen/arm: mpu: Define Xen start address for MPU systems

2024-09-09 Thread Julien Grall
Hi Ayan, On 09/09/2024 11:29, Ayan Kumar Halder wrote: On 08/09/2024 22:13, Julien Grall wrote: Hi, Hi Julien, On 02/09/2024 15:48, Ayan Kumar Halder wrote: I will rephrase this as ... "Used to set customized address at which which Xen will be linked on MPU systems. This address must b

Re: [PATCH] cirrus-ci: update to FreeBSD 14.1 image

2024-09-09 Thread Andrew Cooper
On 09/09/2024 3:39 pm, Roger Pau Monne wrote: > 14.0 is going EOL by the end of the month. > > Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper

[PATCH] cirrus-ci: update to FreeBSD 14.1 image

2024-09-09 Thread Roger Pau Monne
14.0 is going EOL by the end of the month. Signed-off-by: Roger Pau Monné --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 72227916c736..1c2a6cb8120e 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -23,7 +23,7 @@ task: task: na

Re: [XEN PATCH v1] x86/mwait-idle: add dependency on general Intel CPU support

2024-09-09 Thread Jan Beulich
On 05.09.2024 18:00, Sergiy Kibrik wrote: > --- a/xen/arch/x86/cpu/Makefile > +++ b/xen/arch/x86/cpu/Makefile > @@ -8,7 +8,7 @@ obj-y += common.o > obj-y += hygon.o > obj-y += intel.o > obj-y += intel_cacheinfo.o > -obj-y += mwait-idle.o > +obj-$(CONFIG_INTEL) += mwait-idle.o I'm okay this way,

Re: [XEN PATCH v4] x86/intel: optional build of PSR support

2024-09-09 Thread Jan Beulich
On 03.09.2024 09:26, Sergiy Kibrik wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -284,6 +284,9 @@ endchoice > config GUEST > bool > > +config PSR > + bool > + > config XEN_GUEST > bool "Xen Guest" > select GUEST Inserting in the middle of guest rel

Re: [XEN PATCH v6] CODING_STYLE: Add a section on header guards naming conventions

2024-09-09 Thread Jan Beulich
On 05.09.2024 17:48, Alessandro Zucchelli wrote: > This section explains which format should be followed by header > inclusion guards via a drop-down list of rules. > > No functional change. > > Signed-off-by: Alessandro Zucchelli > > --- > Changes in v6: > - edit inclusion guards naming conven

Re: [PATCH v2] mm: Unify PRI_gfn and PRI_mfn macros

2024-09-09 Thread Jan Beulich
On 09.09.2024 15:29, Frediano Ziglio wrote: > On Mon, Sep 9, 2024 at 2:21 PM Jan Beulich wrote: > >> On 09.09.2024 15:14, Frediano Ziglio wrote: >>> @@ -4334,7 +4334,7 @@ static void gnttab_usage_print(struct domain *rd) >>> first = 0; >>> >>> /* [0xXXX] d 0xX 0xXX

Re: [PATCH] Define and use UINT64_C and INT64_C

2024-09-09 Thread Jan Beulich
On 09.09.2024 15:41, Frediano Ziglio wrote: > On Mon, Sep 9, 2024 at 11:38 AM Jan Beulich wrote: >> On 09.09.2024 12:08, Frediano Ziglio wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -1384,9 +1384,9 @@ void asmlinkage __init noreturn >> __start_xen(unsigned long mbi_p

Re: [XEN PATCH v2] x86/mm address violations of MISRA C:2012 Rule 5.3

2024-09-09 Thread Jan Beulich
On 09.09.2024 15:36, Alessandro Zucchelli wrote: > This addresses violations of MISRA C:2012 Rule 5.3 which states as > following: An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope. > > In /x86/mm.c the object struct e820entry *e820 hides an identif

Re: [XEN PATCH v2] x86/mm address violations of MISRA C:2012 Rule 5.3

2024-09-09 Thread Jan Beulich
On 09.09.2024 15:46, Frediano Ziglio wrote: >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -4708,7 +4708,7 @@ long arch_memory_op(unsigned long cmd, >> XEN_GUEST_HANDLE_PARAM(void) arg) >> { >> struct xen_foreign_memory_map fmap; >> struct domain *d; >> -

Re: [PATCH v4 2/2] x86/boot: Add missing __XEN__ definition

2024-09-09 Thread Andrew Cooper
On 09/09/2024 2:22 pm, Frediano Ziglio wrote: > We are compiling Xen source code so we should define __XEN__ macro. > We don't want to import all definitions from XEN_CFLAGS (as done for > other options) because most of them are processor dependent and > do not apply to 32 bit. > > Signed-off-by: F

Re: [PATCH v3 0/3] tools/ocaml: Stabilize domain_getinfo for Oxenstored

2024-09-09 Thread Andrew Cooper
On 09/09/2024 1:02 pm, Andrii Sultanov wrote: > Changes from V2: > > * Drop the upstreamed "Build infrastructure" commit > * Split the last commit into two: Loading the plugin in oxenstored and > switching to it > * Remove configure and paths.m4 defines as suggested. > * Reformat files appropriatel

Re: [XEN PATCH v2] x86/mm address violations of MISRA C:2012 Rule 5.3

2024-09-09 Thread Frediano Ziglio
On Mon, Sep 9, 2024 at 2:36 PM Alessandro Zucchelli < alessandro.zucche...@bugseng.com> wrote: > This addresses violations of MISRA C:2012 Rule 5.3 which states as > following: An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope. > > In /x86/mm.c the

Re: [PATCH] Define and use UINT64_C and INT64_C

2024-09-09 Thread Frediano Ziglio
On Mon, Sep 9, 2024 at 11:38 AM Jan Beulich wrote: > On 09.09.2024 12:08, Frediano Ziglio wrote: > > --- a/xen/arch/x86/include/asm/config.h > > +++ b/xen/arch/x86/include/asm/config.h > > @@ -86,10 +86,10 @@ > > #include > > > > #define PML4_ENTRY_BITS 39 > > -#define PML4_ENTRY_BYTES (_AC(1

[XEN PATCH v2] x86/mm address violations of MISRA C:2012 Rule 5.3

2024-09-09 Thread Alessandro Zucchelli
This addresses violations of MISRA C:2012 Rule 5.3 which states as following: An identifier declared in an inner scope shall not hide an identifier declared in an outer scope. In /x86/mm.c the object struct e820entry *e820 hides an identifier with the same name declared in x86/include/asm/e820.h.

Re: [PATCH v2] mm: Unify PRI_gfn and PRI_mfn macros

2024-09-09 Thread Frediano Ziglio
On Mon, Sep 9, 2024 at 2:21 PM Jan Beulich wrote: > On 09.09.2024 15:14, Frediano Ziglio wrote: > > @@ -4334,7 +4334,7 @@ static void gnttab_usage_print(struct domain *rd) > > first = 0; > > > > /* [0xXXX] d 0xX 0x d 0xXX > 0xXX */ > > -

[PATCH v4 2/2] x86/boot: Add missing __XEN__ definition

2024-09-09 Thread Frediano Ziglio
We are compiling Xen source code so we should define __XEN__ macro. We don't want to import all definitions from XEN_CFLAGS (as done for other options) because most of them are processor dependent and do not apply to 32 bit. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/Makefile | 2 +- 1

Re: [PATCH v2] mm: Unify PRI_gfn and PRI_mfn macros

2024-09-09 Thread Jan Beulich
On 09.09.2024 15:14, Frediano Ziglio wrote: > @@ -4334,7 +4334,7 @@ static void gnttab_usage_print(struct domain *rd) > first = 0; > > /* [0xXXX] d 0xX 0x d 0xXX 0xXX */ > -printk("[0x%03x] %5d 0x%"PRI_mfn" 0x%08x %5d 0x%06"PRIx64

[PATCH v4 1/2] x86/boot: Optimise 32 bit C source code

2024-09-09 Thread Frediano Ziglio
The various filters are removing all optimisations. No need to have all optimisations turned off. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- Changes since v2: - combine filter calls together; - added additional patch.

Re: [PATCH] mm: Reuse PRI_gfn macro instead of manual specify the format

2024-09-09 Thread Frediano Ziglio
On Mon, Sep 9, 2024 at 1:58 PM Jan Beulich wrote: > On 09.09.2024 14:53, Frediano Ziglio wrote: > > On Mon, Sep 9, 2024 at 11:45 AM Jan Beulich wrote: > >> On 09.09.2024 12:08, Frediano Ziglio wrote: > >>> Macros are defined to avoid type mismatch in format strings > >>> but also to unify format

[PATCH v2] mm: Unify PRI_gfn and PRI_mfn macros

2024-09-09 Thread Frediano Ziglio
Always format with no padding and hex prefix, if needed. Signed-off-by: Frediano Ziglio --- xen/arch/arm/mmu/p2m.c | 4 ++-- xen/arch/arm/mmu/pt.c| 2 +- xen/arch/arm/p2m.c | 6 +++--- xen/arch/arm/static-shmem.c | 2 +- xen/arch/x86/h

Re: [PATCH] tools/ocaml: Rationalise .gitignore

2024-09-09 Thread Andrew Cooper
On 09/09/2024 1:31 pm, Edwin Torok wrote: > On Fri, Sep 6, 2024 at 3:55 PM Andrew Cooper > wrote: >> The root .gitignore is quite stale from recent (and less recent) removals, >> but >> also fails to work for the forthcoming dynamic plugin work. >> >> Strip all Ocaml content out of the root .git

Re: [PATCH] mm: Reuse PRI_gfn macro instead of manual specify the format

2024-09-09 Thread Jan Beulich
On 09.09.2024 14:53, Frediano Ziglio wrote: > On Mon, Sep 9, 2024 at 11:45 AM Jan Beulich wrote: >> On 09.09.2024 12:08, Frediano Ziglio wrote: >>> Macros are defined to avoid type mismatch in format strings >>> but also to unify format amongst code. >> >> I'm certainly fine with this part. >> >>>

Re: [PATCH] mm: Reuse PRI_gfn macro instead of manual specify the format

2024-09-09 Thread Frediano Ziglio
On Mon, Sep 9, 2024 at 11:45 AM Jan Beulich wrote: > On 09.09.2024 12:08, Frediano Ziglio wrote: > > Macros are defined to avoid type mismatch in format strings > > but also to unify format amongst code. > > I'm certainly fine with this part. > > > In the meantime expands to 9 hexadecimal digits.

Re: [PATCH v3 2/2] x86/boot: Add missing __XEN__ definition

2024-09-09 Thread Jan Beulich
On 09.09.2024 14:04, Frediano Ziglio wrote: > On Mon, Sep 9, 2024 at 12:21 PM Jan Beulich wrote: > >> On 09.09.2024 13:03, Frediano Ziglio wrote: >>> --- a/xen/arch/x86/boot/Makefile >>> +++ b/xen/arch/x86/boot/Makefile >>> @@ -15,7 +15,7 @@ CFLAGS_x86_32 := $(subst -m64,-m32 >> -march=i686,$(XEN

[xen-unstable test] 187589: tolerable FAIL

2024-09-09 Thread osstest service owner
flight 187589 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/187589/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit2 8 xen-boot fail pass in 187562 Tests which did not succeed, but

Re: Call for next release manager

2024-09-09 Thread Kelly Choi
Hi all, As confirmed on last week's community call, Oleksii is happy to continue as the RM. If you have any questions or concerns, please reply to the thread. I look forward to working with you on the next release, Oleksii! Many thanks, Kelly Choi Community Manager Xen Project On Tue, Sep 3,

Re: [PATCH] tools/ocaml: Rationalise .gitignore

2024-09-09 Thread Edwin Torok
On Fri, Sep 6, 2024 at 3:55 PM Andrew Cooper wrote: > > The root .gitignore is quite stale from recent (and less recent) removals, but > also fails to work for the forthcoming dynamic plugin work. > > Strip all Ocaml content out of the root .gitignore, and provide a more local > .gitignore's with

Re: [PATCH v3 2/2] x86/boot: Add missing __XEN__ definition

2024-09-09 Thread Frediano Ziglio
On Mon, Sep 9, 2024 at 12:21 PM Jan Beulich wrote: > On 09.09.2024 13:03, Frediano Ziglio wrote: > > --- a/xen/arch/x86/boot/Makefile > > +++ b/xen/arch/x86/boot/Makefile > > @@ -15,7 +15,7 @@ CFLAGS_x86_32 := $(subst -m64,-m32 > -march=i686,$(XEN_TREEWIDE_CFLAGS)) > > $(call cc-options-add,CFLA

[PATCH v3 0/3] tools/ocaml: Stabilize domain_getinfo for Oxenstored

2024-09-09 Thread Andrii Sultanov
Changes from V2: * Drop the upstreamed "Build infrastructure" commit * Split the last commit into two: Loading the plugin in oxenstored and switching to it * Remove configure and paths.m4 defines as suggested. * Reformat files appropriately * Rename all instances of 'xenstoredglue', 'xenstored_glu

[PATCH v3 2/3] tools/oxenstored: Load the plugin for Xenctrl.domain_getinfo

2024-09-09 Thread Andrii Sultanov
Oxenstored dynamically loads the plugin provided in ocaml/libs/xsd_glue. The plugin is verified to be providing the specified plugin_interface during its loading. If a V2 of the plugin is produced, V1 will still be present, and a new version should only be loaded if it's verified to exist (New oxe

[PATCH v3 3/3] tools/oxenstored: Switch to using the plugin for Xenctrl.domain_getinfo

2024-09-09 Thread Andrii Sultanov
Also run 'make format' on the file to reformat an adjacent block of code correctly. Signed-off-by: Andrii Sultanov Acked-by: Christian Lindig --- * This commit is a result of the split of one oxenstored commit into two. tools/ocaml/xenstored/domains.ml | 51 1

[PATCH v3 1/3] ocaml/libs: Implement a dynamically-loaded plugin for Xenctrl.domain_getinfo

2024-09-09 Thread Andrii Sultanov
This plugin intends to hide the unstable Xenctrl interface under a stable one. In case of the change in the interface, a V2 of this plugin would need to be produced, but V1 with the old interface would need to be kept (with potential change in the implementation) in the meantime. To reduce the nee

Re: [PATCH 4/5] x86/cache: Drop legacy __read_mostly/__ro_after_init definitions

2024-09-09 Thread Jan Beulich
On 06.09.2024 00:08, Andrew Cooper wrote: > Lots of files were picking these up transitively, including lib.h > > However, lib.h needs __read_mostly for printk_once() and this has the side > effect of kicking the transitive can down the road. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beuli

Re: [PATCH 3/5] x86/build: Swap cache.h includes for xen/sections.h

2024-09-09 Thread Jan Beulich
On 06.09.2024 00:08, Andrew Cooper wrote: > These include {xen/asm}/cache.h but only want xen/sections.h. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

Re: [PATCH 2/5] xen/build: Drop unused includes of xen/cache.h

2024-09-09 Thread Jan Beulich
On 06.09.2024 00:08, Andrew Cooper wrote: > None of these are used, not even transitively. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

Re: [PATCH 1/5] x86/build: Rework includes in genapic/probe.c

2024-09-09 Thread Jan Beulich
On 06.09.2024 00:08, Andrew Cooper wrote: > probe.c includes a large number of headers which are unused, and not from > churn so far as I can see in history. Strip back to a reasonable set. > > One complication is that genapic.h has to include xen/cpumask.h because > there's no way to forward dec

Re: [PATCH 5/5] x86/HVM: drop redundant access splitting

2024-09-09 Thread Jan Beulich
On 06.09.2024 20:06, Andrew Cooper wrote: > On 04/09/2024 2:30 pm, Jan Beulich wrote: >> @@ -1094,13 +1094,13 @@ static int hvmemul_linear_mmio_access( >> if ( cache == NULL ) >> return X86EMUL_UNHANDLEABLE; >> >> -chunk = min_t(unsigned int, size, PAGE_SIZE - offset); >> +A

Re: [PATCH] Define and use UINT64_C and INT64_C

2024-09-09 Thread Jan Beulich
On 09.09.2024 13:09, Andrew Cooper wrote: > On 09/09/2024 11:38 am, Jan Beulich wrote: >> On 09.09.2024 12:08, Frediano Ziglio wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -1384,9 +1384,9 @@ void asmlinkage __init noreturn __start_xen(unsigned >>> long mbi_p) >>>

Re: [PATCH] xen/riscv: fix type mismatch in read_atomic_size()

2024-09-09 Thread Jan Beulich
On 09.09.2024 13:28, Oleksii Kurochko wrote: > Correct a typo in read_atomic_size() where a 64-bit result > was incorrectly cast to a `uint32_t` instead of `uint64_t` > in the case of 8-byte reads. > > Fixes: 3cd46d4ec8b9 ("xen/riscv: introduce atomic.h") > Reported-by: Andrew Cooper > Signed-off

[PATCH] xen/riscv: fix type mismatch in read_atomic_size()

2024-09-09 Thread Oleksii Kurochko
Correct a typo in read_atomic_size() where a 64-bit result was incorrectly cast to a `uint32_t` instead of `uint64_t` in the case of 8-byte reads. Fixes: 3cd46d4ec8b9 ("xen/riscv: introduce atomic.h") Reported-by: Andrew Cooper Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/include/asm/atom

Re: [PATCH v3 2/2] x86/boot: Add missing __XEN__ definition

2024-09-09 Thread Jan Beulich
On 09.09.2024 13:03, Frediano Ziglio wrote: > --- a/xen/arch/x86/boot/Makefile > +++ b/xen/arch/x86/boot/Makefile > @@ -15,7 +15,7 @@ CFLAGS_x86_32 := $(subst -m64,-m32 > -march=i686,$(XEN_TREEWIDE_CFLAGS)) > $(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS)) > CFLAGS_x86_32 += -We

Re: [PATCH 2/5] x86/HVM: allocate emulation cache entries dynamically

2024-09-09 Thread Jan Beulich
On 06.09.2024 21:20, Andrew Cooper wrote: > On 04/09/2024 2:29 pm, Jan Beulich wrote: >> Both caches may need higher capacity, and the upper bound will need to >> be determined dynamically based on CPUID policy (for AMX at least). > > Is this to cope with TILE{LOAD,STORE}, or something else? Thes

Re: [PATCH] Define and use UINT64_C and INT64_C

2024-09-09 Thread Andrew Cooper
On 09/09/2024 11:38 am, Jan Beulich wrote: > On 09.09.2024 12:08, Frediano Ziglio wrote: >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -1384,9 +1384,9 @@ void asmlinkage __init noreturn __start_xen(unsigned >> long mbi_p) >> } >> >> if ( e > min(HYPERVISOR_V

[PATCH v3 1/2] x86/boot: Optimise 32 bit C source code

2024-09-09 Thread Frediano Ziglio
The various filters are removing all optimisations. No need to have all optimisations turned off. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- Changes since v2: - combine filter calls together; - added additional patch.

[PATCH v3 2/2] x86/boot: Add missing __XEN__ definition

2024-09-09 Thread Frediano Ziglio
We are compiling Xen source code so we should define __XEN__ macro. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile index dfe3cb7034..ff0f965876 100644 --- a/

Re: [PATCH v4 4/6] x86/time: introduce probing logic for the wallclock

2024-09-09 Thread Roger Pau Monné
On Thu, Sep 05, 2024 at 05:58:47PM +0200, Jan Beulich wrote: > On 04.09.2024 17:31, Roger Pau Monne wrote: > > --- a/xen/arch/x86/time.c > > +++ b/xen/arch/x86/time.c > > @@ -1291,14 +1291,23 @@ static bool __get_cmos_time(struct rtc_time *rtc) > > return t1 <= SECONDS(1) && t2 < MILLISECS(3);

Re: [PATCH v2] x86/boot: Optimise 32 bit C source code

2024-09-09 Thread Andrew Cooper
On 09/09/2024 11:51 am, Frediano Ziglio wrote: > On Mon, Sep 9, 2024 at 11:47 AM Andrew Cooper > wrote: > > On 09/09/2024 11:44 am, Frediano Ziglio wrote: > > The various filters are removing all optimisations. > > No need to have all optimisations turned off. > > > > Signed-of

Re: [PATCH v2] x86/boot: Optimise 32 bit C source code

2024-09-09 Thread Frediano Ziglio
On Mon, Sep 9, 2024 at 11:47 AM Andrew Cooper wrote: > On 09/09/2024 11:44 am, Frediano Ziglio wrote: > > The various filters are removing all optimisations. > > No need to have all optimisations turned off. > > > > Signed-off-by: Frediano Ziglio > > --- > > xen/arch/x86/boot/Makefile | 1 + > >

Re: [PATCH v2] x86/boot: Optimise 32 bit C source code

2024-09-09 Thread Andrew Cooper
On 09/09/2024 11:44 am, Frediano Ziglio wrote: > The various filters are removing all optimisations. > No need to have all optimisations turned off. > > Signed-off-by: Frediano Ziglio > --- > xen/arch/x86/boot/Makefile | 1 + > 1 file changed, 1 insertion(+) > --- > Changes since v1 > - reuse opt

Re: [PATCH] mm: Reuse PRI_gfn macro instead of manual specify the format

2024-09-09 Thread Jan Beulich
On 09.09.2024 12:08, Frediano Ziglio wrote: > Macros are defined to avoid type mismatch in format strings > but also to unify format amongst code. I'm certainly fine with this part. > In the meantime expands to 9 hexadecimal digits. What makes 9 special? What will the extra padding zeroes buy us

Re: [PATCH v3] x86/boot: Avoid usage of global in reloc.c

2024-09-09 Thread Andrew Cooper
On 09/09/2024 11:30 am, Frediano Ziglio wrote: > All code and dat from this file will go into a text section > which we want to not be writeable. > > Signed-off-by: Frediano Ziglio Reviewed-by: Andrew Cooper

[PATCH v2] x86/boot: Optimise 32 bit C source code

2024-09-09 Thread Frediano Ziglio
The various filters are removing all optimisations. No need to have all optimisations turned off. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/Makefile | 1 + 1 file changed, 1 insertion(+) --- Changes since v1 - reuse optimization level from XEN_CFLAGS. diff --git a/xen/arch/x86/boot/M

Re: [PATCH] Define and use UINT64_C and INT64_C

2024-09-09 Thread Jan Beulich
On 09.09.2024 12:08, Frediano Ziglio wrote: > --- a/xen/arch/x86/include/asm/config.h > +++ b/xen/arch/x86/include/asm/config.h > @@ -86,10 +86,10 @@ > #include > > #define PML4_ENTRY_BITS 39 > -#define PML4_ENTRY_BYTES (_AC(1,UL) << PML4_ENTRY_BITS) > +#define PML4_ENTRY_BYTES (UINT64_C(1) <

Re: [XEN PATCH v14 2/5] x86/pvh: Allow (un)map_pirq when dom0 is PVH

2024-09-09 Thread Chen, Jiqian
On 2024/9/9 18:04, Roger Pau Monné wrote: > On Mon, Sep 09, 2024 at 10:56:07AM +0200, Jan Beulich wrote: >> On 07.09.2024 01:34, Stefano Stabellini wrote: >>> On Fri, 6 Sep 2024, Jan Beulich wrote: On 06.09.2024 00:51, Stefano Stabellini wrote: > On Thu, 5 Sep 2024, Jan Beulich wrote:

[PATCH v3] x86/boot: Avoid usage of global in reloc.c

2024-09-09 Thread Frediano Ziglio
All code and dat from this file will go into a text section which we want to not be writeable. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/reloc.c | 67 +-- 1 file changed, 37 insertions(+), 30 deletions(-) --- Changes since v1: - add comment; - chang

Re: [XEN PATCH v14 3/5] x86/domctl: Add hypercall to set the access of x86 gsi

2024-09-09 Thread Chen, Jiqian
On 2024/9/9 17:15, Roger Pau Monné wrote: > On Tue, Sep 03, 2024 at 03:04:22PM +0800, Jiqian Chen wrote: >> Some type of domains don't have PIRQs, like PVH, it doesn't do >> PHYSDEVOP_map_pirq for each gsi. When passthrough a device >> to guest base on PVH dom0, callstack >> pci_add_dm_done->XEN_DO

Re: [PATCH v1 2/4] xen/arm: mpu: Define Xen start address for MPU systems

2024-09-09 Thread Ayan Kumar Halder
On 08/09/2024 22:13, Julien Grall wrote: Hi, Hi Julien, On 02/09/2024 15:48, Ayan Kumar Halder wrote: I will rephrase this as ... "Used to set customized address at which which Xen will be linked on MPU systems. This address must be aligned to a page size. 0x is used as the defa

Re: [PATCH v4 1/6] x86/time: introduce helper to fetch Xen wallclock when running as a guest

2024-09-09 Thread Roger Pau Monné
On Thu, Sep 05, 2024 at 05:45:20PM +0200, Jan Beulich wrote: > On 04.09.2024 17:31, Roger Pau Monne wrote: > > Move the current code in get_wallclock_time() to fetch the Xen wallclock > > information from the shared page when running as a guest into a separate > > helper. > > > > No functional cha

Re: [XEN PATCH v14 2/5] x86/pvh: Allow (un)map_pirq when dom0 is PVH

2024-09-09 Thread Jan Beulich
On 09.09.2024 12:04, Roger Pau Monné wrote: > On Mon, Sep 09, 2024 at 10:56:07AM +0200, Jan Beulich wrote: >> On 07.09.2024 01:34, Stefano Stabellini wrote: >>> On Fri, 6 Sep 2024, Jan Beulich wrote: On 06.09.2024 00:51, Stefano Stabellini wrote: > On Thu, 5 Sep 2024, Jan Beulich wrote: >>

Re: [PATCH] x86/boot: Optimise 32 bit C source code

2024-09-09 Thread Jan Beulich
On 09.09.2024 12:04, Frediano Ziglio wrote: > The various filters are removing all optimisations. > No need to have all optimisations turned off. Yet also no reason to optimize more than the rest of the build, using -O1 for debug builds (and iirc we meant to switch to using -Og when available). J

Re: [PATCH] x86/boot: Avoid usage of global in reloc.c

2024-09-09 Thread Jan Beulich
On 09.09.2024 12:04, Frediano Ziglio wrote: > --- a/xen/arch/x86/boot/reloc.c > +++ b/xen/arch/x86/boot/reloc.c > @@ -72,11 +72,16 @@ struct vesa_mode_info { > #define get_mb2_data(tag, type, member) (((const multiboot2_tag_##type##_t > *)(tag))->member) > #define get_mb2_string(tag, type, mem

Re: [RFC 2/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-09-09 Thread Frediano Ziglio
On Mon, Sep 9, 2024 at 11:10 AM Jan Beulich wrote: > On 04.09.2024 16:56, Frediano Ziglio wrote: > > --- a/.gitignore > > +++ b/.gitignore > > @@ -251,8 +251,7 @@ xen/System.map > > xen/arch/x86/boot/mkelf32 > > xen/arch/x86/boot/cmdline.S > > xen/arch/x86/boot/reloc.S > > -xen/arch/x86/boot/*

Re: [RFC 0/5] Reuse 32 bit C code more safely

2024-09-09 Thread Jan Beulich
On 06.09.2024 17:59, Andrew Cooper wrote: > On 04/09/2024 3:56 pm, Frediano Ziglio wrote: >> This RFC series attempt to: >> - use more C code, that is replace some assembly code with C; >> - avoid some code duplication between C and assembly; >> - prevent some issues having relocations in C code. >

Re: [XEN PATCH] automation/eclair_analysis: fix MISRA Rule 20.7 regression in self-tests.h

2024-09-09 Thread Andrew Cooper
On 08/09/2024 2:27 pm, Nicola Vetrini wrote: > Prior to bd1664db7b7d ("xen/bitops: Introduce a multiple_bits_set() helper") > the definition of {COMPILE,RUNTIME}_CHECK was fully compliant with respect > to MISRA C Rule 20.7: > > "Expressions resulting from the expansion of macro parameters shall be

Re: [RFC 2/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-09-09 Thread Jan Beulich
On 04.09.2024 16:56, Frediano Ziglio wrote: > --- a/.gitignore > +++ b/.gitignore > @@ -251,8 +251,7 @@ xen/System.map > xen/arch/x86/boot/mkelf32 > xen/arch/x86/boot/cmdline.S > xen/arch/x86/boot/reloc.S > -xen/arch/x86/boot/*.bin > -xen/arch/x86/boot/*.lnk > +xen/arch/x86/boot/build32.*.lds P

[PATCH] mm: Reuse PRI_gfn macro instead of manual specify the format

2024-09-09 Thread Frediano Ziglio
Macros are defined to avoid type mismatch in format strings but also to unify format amongst code. In the meantime expands to 9 hexadecimal digits. Signed-off-by: Frediano Ziglio --- xen/common/grant_table.c | 6 +++--- xen/include/xen/mm-frame.h | 4 ++-- 2 files changed, 5 insertions(+), 5 d

[PATCH] Define and use UINT64_C and INT64_C

2024-09-09 Thread Frediano Ziglio
Makes code and constants work on both 32 and 64 bit. Signed-off-by: Frediano Ziglio --- xen/arch/x86/include/asm/config.h | 6 +++--- xen/arch/x86/include/asm/mm.h | 12 ++-- xen/arch/x86/include/asm/x86_64/page.h | 4 ++-- xen/arch/x86/setup.c | 4 ++--

Re: Setting up the Xen Communications Team

2024-09-09 Thread Roger Pau Monné
On Fri, Sep 06, 2024 at 01:54:13PM +0100, Kelly Choi wrote: > Hi all, > > Thank you for your interest, we'll look into setting up a new Xen > PR/communications group. > If anyone else in the community would like to join, please reply directly > to this email. I would be interested in joining. Th

[PATCH] x86/boot: Optimise 32 bit C source code

2024-09-09 Thread Frediano Ziglio
The various filters are removing all optimisations. No need to have all optimisations turned off. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile index 8f5bbf

  1   2   >