[linux-linus test] 187536: regressions - FAIL

2024-09-06 Thread osstest service owner
flight 187536 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/187536/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 187504 build-i386-pvops

Re: [XEN PATCH v14 2/5] x86/pvh: Allow (un)map_pirq when dom0 is PVH

2024-09-06 Thread Stefano Stabellini
On Fri, 6 Sep 2024, Jan Beulich wrote: > On 06.09.2024 00:51, Stefano Stabellini wrote: > > On Thu, 5 Sep 2024, Jan Beulich wrote: > >> On 05.09.2024 08:45, Chen, Jiqian wrote: > >>> HI, > >>> > >>> On 2024/9/4 14:04, Jan Beulich wrote: > On 04.09.2024 03:43, Stefano Stabellini wrote: > >

Re: [PATCH v3 1/5] xen/bitops: Reinstate the please tidy message

2024-09-06 Thread Stefano Stabellini
On Wed, 4 Sep 2024, Andrew Cooper wrote: > Recent additions have undone prior tidying at the top of the file. > > Signed-off-by: Andrew Cooper Hi Andrew, I admit I don't understand the value and the meaning of the "Please tidy above here" comments. However, you got one just like this one commi

Re: Follow up discussion for: [RFC v2] Introduce SCI-mediator feature

2024-09-06 Thread Stefano Stabellini
On Mon, 2 Sep 2024, Oleksii Moisieiev wrote: > Greetings, > > After some time we are back to the development of the SCI-Mediator > feature presented as RFC few years earlier. > Link to the RFC v2: > https://lore.kernel.org/all/cover.1644341635.git.oleksii_moisie...@epam.com/ > > Last time featu

[xen-unstable test] 187515: regressions - FAIL

2024-09-06 Thread osstest service owner
flight 187515 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/187515/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 187498 build-i386

[xen-unstable-smoke test] 187544: tolerable all pass - PUSHED

2024-09-06 Thread osstest service owner
flight 187544 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187544/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 3/3] x86/trampoline: Collect other scattered trampoline symbols

2024-09-06 Thread Andrew Cooper
On 06/09/2024 6:58 am, Jan Beulich wrote: > On 05.09.2024 18:10, Andrew Cooper wrote: >> On 05/09/2024 4:42 pm, Jan Beulich wrote: >>> On 05.09.2024 15:06, Andrew Cooper wrote: --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -102,9 +102,6 @@ static void __init

Re: [PATCH 2/5] x86/HVM: allocate emulation cache entries dynamically

2024-09-06 Thread Andrew Cooper
On 04/09/2024 2:29 pm, Jan Beulich wrote: > Both caches may need higher capacity, and the upper bound will need to > be determined dynamically based on CPUID policy (for AMX at least). Is this to cope with TILE{LOAD,STORE}, or something else? It's not exactly clear, even when looking at prior AMX

Re: [PATCH v3 3/5] xen/bitops: Implement hweight32() in terms of hweightl()

2024-09-06 Thread Andrew Cooper
On 06/09/2024 1:27 am, Andrew Cooper wrote: > On 06/09/2024 12:08 am, Stefano Stabellini wrote: >> On Wed, 4 Sep 2024, Andrew Cooper wrote: >>> ... and drop generic_hweight32(). >>> >>> As noted previously, the only two users of hweight32() are in __init paths. >>> >>> The int-optimised form of gen

[PATCH] Revert "ALSA: memalloc: Workaround for Xen PV"

2024-09-06 Thread Ariadne Conill
This patch attempted to work around a DMA issue involving Xen, but causes subtle kernel memory corruption. When I brought up this patch in the XenDevel matrix channel, I was told that it had been requested by the Qubes OS developers because they were trying to fix an issue where the sound stack wo

Re: [PATCH 5/5] x86/HVM: drop redundant access splitting

2024-09-06 Thread Andrew Cooper
On 04/09/2024 2:30 pm, Jan Beulich wrote: > @@ -1094,13 +1094,13 @@ static int hvmemul_linear_mmio_access( > if ( cache == NULL ) > return X86EMUL_UNHANDLEABLE; > > -chunk = min_t(unsigned int, size, PAGE_SIZE - offset); > +ASSERT(size <= PAGE_SIZE - offset); Do we really w

Re: [PATCH 4/5] x86/HVM: slightly improve CMPXCHG16B emulation

2024-09-06 Thread Andrew Cooper
On 04/09/2024 2:29 pm, Jan Beulich wrote: > Using hvmemul_linear_mmio_write() directly (as fallback when mapping the > memory operand isn't possible) won't work properly when the access > crosses a RAM/MMIO boundary. Use linear_write() instead, which splits at > such boundaries as necessary. > > Si

[libvirt test] 187513: tolerable all pass - PUSHED

2024-09-06 Thread osstest service owner
flight 187513 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/187513/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 187501 test-amd64-amd64-libvirt-xsm 15 migrate-s

Re: [PATCH 1/5] x86/HVM: reduce recursion in linear_{read,write}()

2024-09-06 Thread Andrew Cooper
On 04/09/2024 2:27 pm, Jan Beulich wrote: > Let's make explicit what the compiler may or may not do on our behalf: > The 2nd of the recursive invocations each can fall through rather than > re-invoking the function. This will save us from adding yet another > parameter (or more) to the function, ju

Re: Setting up the Xen Communications Team

2024-09-06 Thread Andrew Cooper
On 19/08/2024 10:46 am, Charles-H. Schulz wrote: > Hello everyone, > > Just like any major FOSS project, Xen needs to take care of its > messaging and communication. We are usually focused on software > development, however we'd like to take the opportunity to call on > whoever is interested here t

Re: [RFC 1/5] Avoid usage of global in reloc.c

2024-09-06 Thread Andrew Cooper
On 04/09/2024 3:56 pm, Frediano Ziglio wrote: > All code and dat from this file will go into a text section > which we want to not be writeable. Getting data out of the instruction cache is a good thing, but writeability isn't relevant here.  This logic only executes in 32bit unpaged mode. > > Si

[qemu-mainline test] 187511: tolerable FAIL - PUSHED

2024-09-06 Thread osstest service owner
flight 187511 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/187511/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-vhd 22 leak-check/check fail like 187481 test-armhf-armhf-libvirt 16 sav

Re: [RFC 0/5] Reuse 32 bit C code more safely

2024-09-06 Thread Andrew Cooper
On 04/09/2024 3:56 pm, Frediano Ziglio wrote: > This RFC series attempt to: > - use more C code, that is replace some assembly code with C; > - avoid some code duplication between C and assembly; > - prevent some issues having relocations in C code. > > The idea is extending the current C to binary

Re: [PATCH] tools/ocaml: Rationalise .gitignore

2024-09-06 Thread Andrew Cooper
On 06/09/2024 3:55 pm, Andrew Cooper wrote: > diff --git a/tools/ocaml/.gitignore b/tools/ocaml/.gitignore > new file mode 100644 > index ..3687c2af4f26 > --- /dev/null > +++ b/tools/ocaml/.gitignore > @@ -0,0 +1,5 @@ > +/**/META > +/**/.ocamldep.make > +/**/*.annot > +/**/*.cm[ixao] >

[PATCH] tools/ocaml: Rationalise .gitignore

2024-09-06 Thread Andrew Cooper
The root .gitignore is quite stale from recent (and less recent) removals, but also fails to work for the forthcoming dynamic plugin work. Strip all Ocaml content out of the root .gitignore, and provide a more local .gitignore's with up-to-date patterns. Signed-off-by: Andrew Cooper --- CC: Chri

Re: [PATCH v2 2/3] ocaml/libs: Implement a dynamically-loaded plugin for Xenctrl.domain_getinfo

2024-09-06 Thread Andrew Cooper
On 06/09/2024 3:20 pm, Andrii Sultanov wrote: >> > diff --git > a/tools/ocaml/libs/xenstoredglue/domain_getinfo_plugin_v1/Makefile > b/tools/ocaml/libs/xenstoredglue/domain_getinfo_plugin_v1/Makefile >> > new file mode 100644 >> > index 00..9c40026cab >> > --- /dev/null >> > +++ b/tools/oca

Re: [PATCH v2 3/3] tools/oxenstored: Use the plugin for Xenctrl.domain_getinfo

2024-09-06 Thread Andrew Cooper
On 03/09/2024 12:44 pm, Andrii Sultanov wrote: > diff --git a/m4/paths.m4 b/m4/paths.m4 > index 3f94c62efb..533bac919b 100644 > --- a/m4/paths.m4 > +++ b/m4/paths.m4 > @@ -144,6 +144,10 @@ XEN_LIB_DIR=$localstatedir/lib/xen > AC_SUBST(XEN_LIB_DIR) > AC_DEFINE_UNQUOTED([XEN_LIB_DIR], ["$XEN_LIB_DI

Re: [PATCH v1 4/4] xen/arm: mpu: Disable secondary cpu bringup

2024-09-06 Thread Ayan Kumar Halder
On 28/08/2024 20:24, Julien Grall wrote: Hi Ayan, Hi Julien, The title is a bit confusing. It implies seconary CPU bringup used to work on the MPU. However, you are adding a stub for enable_secondary_cpu_mm. Also, I am not entirely this is really sufficient to disable CPU bringup. There

Re: [PATCH v2 2/3] ocaml/libs: Implement a dynamically-loaded plugin for Xenctrl.domain_getinfo

2024-09-06 Thread Andrew Cooper
On 03/09/2024 12:44 pm, Andrii Sultanov wrote: > tools/ocaml/Makefile | 1 + > tools/ocaml/libs/Makefile | 2 +- > tools/ocaml/libs/xenstoredglue/META.in| 4 + > tools/ocaml/libs/xenstoredglue/Makefile | 46 + > .../domain_getin

Re: [PATCH v2 2/3] ocaml/libs: Implement a dynamically-loaded plugin for Xenctrl.domain_getinfo

2024-09-06 Thread Andrii Sultanov
> > diff --git a/tools/ocaml/libs/xenstoredglue/domain_getinfo_plugin_v1/Makefile b/tools/ocaml/libs/xenstoredglue/domain_getinfo_plugin_v1/Makefile > > new file mode 100644 > > index 00..9c40026cab > > --- /dev/null > > +++ b/tools/ocaml/libs/xenstoredglue/domain_getinfo_plugin_v1/Makefile

[xen-unstable-smoke test] 187533: tolerable all pass - PUSHED

2024-09-06 Thread osstest service owner
flight 187533 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187533/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-unstable bisection] complete build-i386

2024-09-06 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386 testid xen-build Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://

Re: [PATCH v2 2/3] ocaml/libs: Implement a dynamically-loaded plugin for Xenctrl.domain_getinfo

2024-09-06 Thread Andrew Cooper
On 03/09/2024 12:44 pm, Andrii Sultanov wrote: > This plugin intends to hide the unstable Xenctrl interface under a > stable one. In case of the change in the interface, a V2 of this plugin > would need to be produced, but V1 with the old interface would > need to be kept (with potential change in

Re: [PATCH v1 3/4] xen/arm: mpu: Create boot-time MPU protection regions

2024-09-06 Thread Ayan Kumar Halder
Hi Julien/Luca/all, On 04/09/2024 19:38, Ayan Kumar Halder wrote: On 04/09/2024 19:14, Luca Fancellu wrote: Hi Ayan, Hi Luca, Apologies but I can’t do a full review yet, No worries. :) + +/* MPU normal memory attributes. */ +#define PRBAR_NORMAL_MEM    0x30    /* SH=11 AP=00 XN=00

Re: Setting up the Xen Communications Team

2024-09-06 Thread Kelly Choi
Hi all, Thank you for your interest, we'll look into setting up a new Xen PR/communications group. If anyone else in the community would like to join, please reply directly to this email. Many thanks, Kelly Choi Community Manager Xen Project On Wed, Aug 21, 2024 at 5:16 PM Stefano Stabellini <

Re: [xen-unstable test] 187507: regressions - FAIL

2024-09-06 Thread Anthony PERARD
On Fri, Sep 06, 2024 at 11:07:06AM +0100, Andrew Cooper wrote: > Interestingly, Gitlab's x86_32 build test missed this. > > https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/7762103169 passed. > > I wonder if there's anything we should have done to get better coverage. osstest does `make

Re: [PATCH v2 0/3] tools/ocaml: Stabilize domain_getinfo for Oxenstored

2024-09-06 Thread Christian Lindig
There was some confusion about my ack for this series - my apologies. I intended to ack’ it entirely. Acked-by: Christian Lindig > On 3 Sep 2024, at 12:44, Andrii Sultanov wrote: > > This is a V2 of the "Stabilize Oxenstored's interface with" patch > series, see V1's cover letter for the mot

[linux-linus test] 187510: regressions - FAIL

2024-09-06 Thread osstest service owner
flight 187510 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/187510/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 6 xen-buildfail REGR. vs. 187504 Tests which did not

[ovmf test] 187527: all pass - PUSHED

2024-09-06 Thread osstest service owner
flight 187527 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187527/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b437b5ca4c1a6725897dfd0740de6ef20cacd226 baseline version: ovmf 253b3d678aa541b24a2e0

Re: [xen-unstable test] 187507: regressions - FAIL

2024-09-06 Thread Jan Beulich
On 06.09.2024 12:07, Andrew Cooper wrote: > On 06/09/2024 11:01 am, Andrew Cooper wrote: >> On 06/09/2024 7:08 am, Jan Beulich wrote: >>> On 06.09.2024 06:41, osstest service owner wrote: flight 187507 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/187507/

Re: [PATCH] x86emul/test: use MSR constants

2024-09-06 Thread Andrew Cooper
On 06/09/2024 11:39 am, Jan Beulich wrote: > msr-index.h has been in use for a while, so use the identifiers it > provides in place of raw numbers plus comments. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

[PATCH] x86emul/test: use MSR constants

2024-09-06 Thread Jan Beulich
msr-index.h has been in use for a while, so use the identifiers it provides in place of raw numbers plus comments. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -689,11 +689,11 @@ static int read_msr( { s

Re: [PATCH] x86emul: mark new "cp" local var maybe-unused

2024-09-06 Thread Andrew Cooper
On 06/09/2024 11:38 am, Jan Beulich wrote: > Just for the sake of the 32-bit build of the test harness. This wants > reverting once unconditional uses of the variable appear (AMX, AVX10). > > Fixes: b20e3fbc3ec9 ("x86emul: introduce a struct cpu_policy * local in > x86_emulate()") > Signed-off-by:

[PATCH] x86emul: mark new "cp" local var maybe-unused

2024-09-06 Thread Jan Beulich
Just for the sake of the 32-bit build of the test harness. This wants reverting once unconditional uses of the variable appear (AMX, AVX10). Fixes: b20e3fbc3ec9 ("x86emul: introduce a struct cpu_policy * local in x86_emulate()") Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emul

Re: [REGRESSION] kernel NULL pointer dereference in xen-balloon with mem hotplug

2024-09-06 Thread Marek Marczykowski-Górecki
On Fri, Sep 06, 2024 at 12:30:03PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 08.08.24 12:31, Marek Marczykowski-Górecki wrote: > > > > When testing Linux 6.11-rc2, I've got the crash like below. It's a PVH > > guest started with 400MB memory, and then extended via mem hotpl

[xen-unstable bisection] complete build-i386-xsm

2024-09-06 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen gi

Re: [REGRESSION] kernel NULL pointer dereference in xen-balloon with mem hotplug

2024-09-06 Thread Linux regression tracking (Thorsten Leemhuis)
On 08.08.24 12:31, Marek Marczykowski-Górecki wrote: > > When testing Linux 6.11-rc2, I've got the crash like below. It's a PVH > guest started with 400MB memory, and then extended via mem hotplug (I > don't know to what exact size it was at this time, but up to 4GB), it > was quite early in the d

[PATCH] docs: fusa: Add Assumption of Use (AOU)

2024-09-06 Thread Ayan Kumar Halder
From: Michal Orzel AOU are the assumptions Xen relies on other components (eg platform, domains) to fulfill its requirements. In our case, platform means a combination of hardware, firmware and bootloader. We have defined AOU in the intro.rst and added AOU for the generic timer. Signed-off-by:

Re: [xen-unstable test] 187507: regressions - FAIL

2024-09-06 Thread Andrew Cooper
On 06/09/2024 11:01 am, Andrew Cooper wrote: > On 06/09/2024 7:08 am, Jan Beulich wrote: >> On 06.09.2024 06:41, osstest service owner wrote: >>> flight 187507 xen-unstable real [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/187507/ >>> >>> Regressions :-( >>> >>> Tests which did not s

Re: [xen-unstable test] 187507: regressions - FAIL

2024-09-06 Thread Andrew Cooper
On 06/09/2024 7:08 am, Jan Beulich wrote: > On 06.09.2024 06:41, osstest service owner wrote: >> flight 187507 xen-unstable real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/187507/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which coul

Re: [PATCH] docs: fusa: Add requirements for emulated uart

2024-09-06 Thread Michal Orzel
Hi Bertrand, On 06/09/2024 09:56, Bertrand Marquis wrote: > > > Hi, > >> On 29 Aug 2024, at 15:33, Ayan Kumar Halder >> wrote: >> >> From: Michal Orzel >> >> Add the requirements for emulated SBSA UART. >> >> Signed-off-by: Michal Orzel >> Signed-off-by: Ayan Kumar Halder >> --- >> .../fus

[xen-unstable-smoke test] 187520: tolerable all pass - PUSHED

2024-09-06 Thread osstest service owner
flight 187520 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187520/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2] x86/cpufeatures: Add new cpuid features in SPR to featureset

2024-09-06 Thread Andrew Cooper
On 21/08/2024 4:34 pm, Matthew Barnes wrote: > Upon running `xen-cpuid -v` on a host machine with Sapphire Rapids > within Dom0, there exist unrecognised features. > > This patch adds these features as macros to the CPU featureset, > disabled by default. > > Signed-off-by: Matthew Barnes Acked-by

[ovmf test] 187521: all pass - PUSHED

2024-09-06 Thread osstest service owner
flight 187521 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187521/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 253b3d678aa541b24a2e05f2279975de06abfeec baseline version: ovmf 9dabe005f0cd422068fbb

Re: [PATCH] docs: fusa: Add requirements for emulated uart

2024-09-06 Thread Bertrand Marquis
Hi, > On 29 Aug 2024, at 15:33, Ayan Kumar Halder wrote: > > From: Michal Orzel > > Add the requirements for emulated SBSA UART. > > Signed-off-by: Michal Orzel > Signed-off-by: Ayan Kumar Halder > --- > .../fusa/reqs/design-reqs/arm64/sbsa-uart.rst | 224 ++ > docs/fusa/reqs

[ovmf test] 187517: all pass - PUSHED

2024-09-06 Thread osstest service owner
flight 187517 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187517/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9dabe005f0cd422068fbb6cb915cf8180c55918d baseline version: ovmf bfb33c0e09b0cf0546016

Re: [XEN PATCH] automation/eclair_analysis: address violations of Rule 18.2

2024-09-06 Thread Nicola Vetrini
On 2024-09-06 08:03, Jan Beulich wrote: On 05.09.2024 18:37, Nicola Vetrini wrote: MISRA C Rule 18.2 states: "Subtraction between pointers shall only be applied to pointers that address elements of the same array". Subtractions between pointer where at least one symbol is a symbol defined by th