[ovmf test] 186358: all pass - PUSHED

2024-06-14 Thread osstest service owner
flight 186358 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186358/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cf323e2839ce260fde43487baae205527dee1b2f baseline version: ovmf 5e776299a2604b336a947

[linux-linus test] 186354: tolerable FAIL - PUSHED

2024-06-14 Thread osstest service owner
flight 186354 linux-linus real [real] flight 186357 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186354/ http://logs.test-lab.xenproject.org/osstest/logs/186357/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

[xen-unstable test] 186353: tolerable FAIL - PUSHED

2024-06-14 Thread osstest service owner
flight 186353 xen-unstable real [real] flight 186355 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186353/ http://logs.test-lab.xenproject.org/osstest/logs/186355/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

Re: Design session notes: GPU acceleration in Xen

2024-06-14 Thread Demi Marie Obenour
On Fri, Jun 14, 2024 at 08:38:51AM +0200, Jan Beulich wrote: > On 13.06.2024 20:43, Demi Marie Obenour wrote: > > GPU acceleration requires that pageable host memory be able to be mapped > > into a guest. > > I'm sure it was explained in the session, which sadly I couldn't attend. > I've been aski

[linux-linus test] 186345: regressions - FAIL

2024-06-14 Thread osstest service owner
flight 186345 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/186345/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 6 xen-build fail in 186342 REGR. vs. 186314 Tests which are fai

Re: [PATCH 3/7] x86/boot: Collect the Raw CPU Policy earlier on boot

2024-06-14 Thread Andrew Cooper
On 23/05/2024 4:44 pm, Jan Beulich wrote: > On 23.05.2024 13:16, Andrew Cooper wrote: >> This is a tangle, but it's a small step in the right direction. >> >> xstate_init() is shortly going to want data from the Raw policy. >> calculate_raw_cpu_policy() is sufficiently separate from the other polic

Re: [PATCH] MAINTAINERS: add me as scheduer maintainer

2024-06-14 Thread Dario Faggioli
On Mon, 2024-06-10 at 13:35 +0200, Jan Beulich wrote: > George, Dario, > > On 06.06.2024 07:47, Juergen Gross wrote: > > I've been active in the scheduling code since many years now. Add > > me as a maintainer. > > > > Signed-off-by: Juergen Gross > > --- > >  MAINTAINERS | 1 + > >  1 file chang

Re: Design session notes: GPU acceleration in Xen

2024-06-14 Thread Demi Marie Obenour
On Fri, Jun 14, 2024 at 09:21:56AM +0200, Roger Pau Monné wrote: > On Fri, Jun 14, 2024 at 08:38:51AM +0200, Jan Beulich wrote: > > On 13.06.2024 20:43, Demi Marie Obenour wrote: > > > GPU acceleration requires that pageable host memory be able to be mapped > > > into a guest. > > > > I'm sure it

for_each_set_bit() clean-up (API RFC)

2024-06-14 Thread Andrew Cooper
More fallout from looking at the code generation... for_each_set_bit() forces it's bitmap parameter out into memory.  For an arbitrary sized bitmap, this is fine - and likely preferable as it's an in-memory to begin with. However, more than half the current users of for_each_set_bit() are operati

Re: Design session notes: GPU acceleration in Xen

2024-06-14 Thread Demi Marie Obenour
On Fri, Jun 14, 2024 at 10:12:40AM +0200, Jan Beulich wrote: > On 14.06.2024 09:21, Roger Pau Monné wrote: > > On Fri, Jun 14, 2024 at 08:38:51AM +0200, Jan Beulich wrote: > >> On 13.06.2024 20:43, Demi Marie Obenour wrote: > >>> GPU acceleration requires that pageable host memory be able to be map

Re: convert the SCSI ULDs to the atomic queue limits API v2

2024-06-14 Thread Jens Axboe
On Fri, 31 May 2024 09:47:55 +0200, Christoph Hellwig wrote: > this series converts the SCSI upper level drivers to the atomic queue > limits API. > > The first patch is a bug fix for ubd that later patches depend on and > might be worth picking up for 6.10. > > The second patch changes the max

[PATCH 1/2] x86/mm address violations of MISRA C:2012 Rule 5.3

2024-06-14 Thread Alessandro Zucchelli
This addresses violations of MISRA C:2012 Rule 5.3 which states as following: An identifier declared in an inner scope shall not hide an identifier declared in an outer scope. No functional change. Signed-off-by: Alessandro Zucchelli --- xen/arch/x86/mm.c | 12 ++-- 1 file changed, 6 in

[PATCH 2/2] x86/e820 address violations of MISRA C:2012 Rule 5.3

2024-06-14 Thread Alessandro Zucchelli
This addresses violations of MISRA C:2012 Rule 5.3 which states as following: An identifier declared in an inner scope shall not hide an identifier declared in an outer scope. No functional change. Signed-off-by: Alessandro Zucchelli --- xen/arch/x86/e820.c | 74 ++--

[PATCH 0/2] Address violations of MISRA C:2012 Rule 5.3

2024-06-14 Thread Alessandro Zucchelli
This addresses violations of MISRA C:2012 Rule 5.3 which states as following: An identifier declared in an inner scope shall not hide an identifier declared in an outer scope. In this series are modified files x86/mm.c and x86/e820.c in which occurred instances of variable names shadowing a global

[ovmf test] 186352: all pass - PUSHED

2024-06-14 Thread osstest service owner
flight 186352 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186352/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5e776299a2604b336a947e68593012ab2cc16eb4 baseline version: ovmf ce91687a1b2d4e03b01ab

Re: [PATCH for-4.19] xen/arch: Centralise __read_mostly and __ro_after_init

2024-06-14 Thread Oleksii K.
On Fri, 2024-06-14 at 13:49 +0100, Andrew Cooper wrote: > These being in cache.h is inherited from Linux, but is an > inappropriate > location to live. > > __read_mostly is an optimisation related to data placement in order > to avoid > having shared data in cachelines that are likely to be writte

Re: [PATCH] x86: pci: xen: Remove unnecessary ‘0’ values from ret

2024-06-14 Thread Ilpo Järvinen
On Wed, 12 Jun 2024, Li zeming wrote: > ret is assigned first, so it does not need to initialize the assignment. While the patch seems fine, this description and the shortlog are confusing. -- i. > Signed-off-by: Li zeming > --- > arch/x86/pci/xen.c | 4 ++-- > 1 file changed, 2 insertions(

[xen-unstable-smoke test] 186349: tolerable all pass - PUSHED

2024-06-14 Thread osstest service owner
flight 186349 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186349/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 6/7] x86/cpuid: Fix handling of XSAVE dynamic leaves

2024-06-14 Thread Andrew Cooper
On 23/05/2024 5:16 pm, Jan Beulich wrote: > On 23.05.2024 13:16, Andrew Cooper wrote: >> First, if XSAVE is available in hardware but not visible to the guest, the >> dynamic leaves shouldn't be filled in. >> >> Second, the comment concerning XSS state is wrong. VT-x doesn't manage >> host/guest s

[xen-unstable test] 186344: tolerable FAIL

2024-06-14 Thread osstest service owner
flight 186344 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186344/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186341 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH for-4.19] xen/arch: Centralise __read_mostly and __ro_after_init

2024-06-14 Thread Roger Pau Monné
On Fri, Jun 14, 2024 at 01:49:50PM +0100, Andrew Cooper wrote: > These being in cache.h is inherited from Linux, but is an inappropriate > location to live. > > __read_mostly is an optimisation related to data placement in order to avoid > having shared data in cachelines that are likely to be wri

Re: [PATCH 4/7] x86/xstate: Rework xstate_ctxt_size() as xstate_uncompressed_size()

2024-06-14 Thread Andrew Cooper
On 23/05/2024 5:09 pm, Jan Beulich wrote: > On 23.05.2024 13:16, Andrew Cooper wrote: >> @@ -611,6 +587,40 @@ static bool valid_xcr0(uint64_t xcr0) >> return true; >> } >> >> +unsigned int xstate_uncompressed_size(uint64_t xcr0) >> +{ >> +unsigned int size = XSTATE_AREA_MIN_SIZE, i; >>

Re: [PATCH 2/7] x86/xstate: Cross-check dynamic XSTATE sizes at boot

2024-06-14 Thread Andrew Cooper
On 23/05/2024 4:34 pm, Jan Beulich wrote: > On 23.05.2024 13:16, Andrew Cooper wrote: >> Right now, xstate_ctxt_size() performs a cross-check of size with CPUID in >> for >> every call. This is expensive, being used for domain create/migrate, as well >> as to service certain guest CPUID instructi

Re: [PATCH for-4.19] xen/arch: Centralise __read_mostly and __ro_after_init

2024-06-14 Thread Jan Beulich
On 14.06.2024 14:49, Andrew Cooper wrote: > These being in cache.h is inherited from Linux, but is an inappropriate > location to live. > > __read_mostly is an optimisation related to data placement in order to avoid > having shared data in cachelines that are likely to be written to, but it > rea

[PATCH for-4.19] xen/arch: Centralise __read_mostly and __ro_after_init

2024-06-14 Thread Andrew Cooper
These being in cache.h is inherited from Linux, but is an inappropriate location to live. __read_mostly is an optimisation related to data placement in order to avoid having shared data in cachelines that are likely to be written to, but it really is just a section of the linked image separating d

Re: [PATCH v3 0/3] x86/irq: fixes for CPU hot{,un}plug

2024-06-14 Thread Roger Pau Monné
On Fri, Jun 14, 2024 at 01:52:59PM +0200, Oleksii K. wrote: > On Fri, 2024-06-14 at 09:28 +0200, Roger Pau Monné wrote: > > Sorry, forgot to add the for-4.19 tag and Cc Oleksii. > > > > Since we have taken the start of the series, we might as well take > > the > > remaining patches (if other x86 m

Xen Summit talks live on YouTube

2024-06-14 Thread Kelly Choi
Hi everyone, We had a great few days filled with discussions and talks during the Xen Summit in Lisbon. These are now available for you to watch on YouTube! https://www.youtube.com/playlist?list=PLQMQQsKgvLntZiKoELFs22Mtk-tBNNOMJ Many thanks, Kelly Choi Community Manager Xen Project

Re: [PATCH v3 0/3] x86/irq: fixes for CPU hot{,un}plug

2024-06-14 Thread Oleksii K.
On Fri, 2024-06-14 at 09:28 +0200, Roger Pau Monné wrote: > Sorry, forgot to add the for-4.19 tag and Cc Oleksii. > > Since we have taken the start of the series, we might as well take > the > remaining patches (if other x86 maintainers agree) and attempt to > hopefully fix all the interrupt issue

Re: [PATCH for 4.19?] x86/Intel: unlock CPUID earlier for the BSP

2024-06-14 Thread Jan Beulich
On 14.06.2024 12:14, Andrew Cooper wrote: > On 14/06/2024 7:27 am, Jan Beulich wrote: >> On 13.06.2024 18:17, Andrew Cooper wrote: >>> On 13/06/2024 9:19 am, Jan Beulich wrote: Intel CPUs have a MSR bit to limit CPUID enumeration to leaf two. If this bit is set by the BIOS then CPUID eval

Re: [PATCH for 4.19?] x86/Intel: unlock CPUID earlier for the BSP

2024-06-14 Thread Andrew Cooper
On 14/06/2024 7:27 am, Jan Beulich wrote: > On 13.06.2024 18:17, Andrew Cooper wrote: >> On 13/06/2024 9:19 am, Jan Beulich wrote: >>> Intel CPUs have a MSR bit to limit CPUID enumeration to leaf two. If >>> this bit is set by the BIOS then CPUID evaluation does not work when >>> data from any leaf

Re: [PATCH v12 5/8] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-06-14 Thread Andrew Cooper
On 11/06/2024 7:23 pm, Oleksii K. wrote: > On Tue, 2024-06-11 at 16:53 +0100, Andrew Cooper wrote: >> On 30/05/2024 7:22 pm, Oleksii K. wrote: >>> On Thu, 2024-05-30 at 18:23 +0100, Andrew Cooper wrote: On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko >

Re: [PATCH v4 0/7] Static shared memory followup v2 - pt2

2024-06-14 Thread Julien Grall
On 14/06/2024 08:54, Luca Fancellu wrote: Hi Julien, Hi Luca, On 13 Jun 2024, at 12:31, Julien Grall wrote: Hi, On 11/06/2024 13:42, Michal Orzel wrote: We would like this serie to be in Xen 4.19, there was a misunderstanding on our side because we thought that since the serie was sen

[ovmf test] 186346: all pass - PUSHED

2024-06-14 Thread osstest service owner
flight 186346 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186346/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ce91687a1b2d4e03b01abb474b4665629776f588 baseline version: ovmf 712797cf19acd292bf203

[libvirt test] 186343: tolerable all pass - PUSHED

2024-06-14 Thread osstest service owner
flight 186343 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/186343/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186330 test-amd64-amd64-libvirt 15 migrate-s

[XEN PATCH v3] automation/eclair: extend existing deviations of MISRA C Rule 16.3

2024-06-14 Thread Federico Serafini
Update ECLAIR configuration to deviate more cases where an unintentional fallthrough cannot happen. Add Rule 16.3 to the monitored set and tag it as clean for arm. Signed-off-by: Federico Serafini --- Changes from v2: - fixed grammar; - reprhased deviations regarding do-while-false and ASSERT_UN

[XEN PATCH v3] automation/eclair: add deviation for MISRA C Rule 17.7

2024-06-14 Thread Federico Serafini
Update ECLAIR configuration to deviate some cases where not using the return value of a function is not dangerous. Signed-off-by: Federico Serafini --- Changes in v3: - removed unwanted underscores; - grammar fixed; - do not constraint to the first actual argument. Changes in v2: - do not deviate

Re: [PATCH 01/14] ubd: refactor the interrupt handler

2024-06-14 Thread Anton Ivanov
On 31/05/2024 08:47, Christoph Hellwig wrote: Instead of a separate handler function that leaves no work in the interrupt hanler itself, split out a per-request end I/O helper and clean up the coding style and variable naming while we're at it. Signed-off-by: Christoph Hellwig Reviewed-by: M

Re: [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling

2024-06-14 Thread Anton Ivanov
On 31/05/2024 08:47, Christoph Hellwig wrote: Discard and Write Zeroes are different operation and implemented by different fallocate opcodes for ubd. If one fails the other one can work and vice versa. Split the code to disable the operations in ubd_handler to only disable the operation tha

Re: Design session notes: GPU acceleration in Xen

2024-06-14 Thread Roger Pau Monné
On Fri, Jun 14, 2024 at 10:12:40AM +0200, Jan Beulich wrote: > On 14.06.2024 09:21, Roger Pau Monné wrote: > > On Fri, Jun 14, 2024 at 08:38:51AM +0200, Jan Beulich wrote: > >> On 13.06.2024 20:43, Demi Marie Obenour wrote: > >>> GPU acceleration requires that pageable host memory be able to be map

Re: Design session notes: GPU acceleration in Xen

2024-06-14 Thread Jan Beulich
On 14.06.2024 09:21, Roger Pau Monné wrote: > On Fri, Jun 14, 2024 at 08:38:51AM +0200, Jan Beulich wrote: >> On 13.06.2024 20:43, Demi Marie Obenour wrote: >>> GPU acceleration requires that pageable host memory be able to be mapped >>> into a guest. >> >> I'm sure it was explained in the session,

Re: [PATCH v4 0/7] Static shared memory followup v2 - pt2

2024-06-14 Thread Luca Fancellu
Hi Julien, > On 13 Jun 2024, at 12:31, Julien Grall wrote: > > Hi, > > On 11/06/2024 13:42, Michal Orzel wrote: >>> We would like this serie to be in Xen 4.19, there was a misunderstanding on >>> our side because we thought >>> that since the serie was sent before the last posting date, it cou

Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail

2024-06-14 Thread Roger Pau Monné
On Thu, Jun 13, 2024 at 04:05:08PM +0200, Christoph Hellwig wrote: > On Wed, Jun 12, 2024 at 05:56:15PM +0200, Roger Pau Monné wrote: > > Right. AFAICT advertising "feature-barrier" and/or > > "feature-flush-cache" could be done based on whether blkback > > understand those commands, not on whethe

Re: [PATCH v3 0/3] x86/irq: fixes for CPU hot{,un}plug

2024-06-14 Thread Roger Pau Monné
Sorry, forgot to add the for-4.19 tag and Cc Oleksii. Since we have taken the start of the series, we might as well take the remaining patches (if other x86 maintainers agree) and attempt to hopefully fix all the interrupt issues with CPU hotplug/unplug. FTR: there are further issues when doing C

Re: Design session notes: GPU acceleration in Xen

2024-06-14 Thread Roger Pau Monné
On Fri, Jun 14, 2024 at 08:38:51AM +0200, Jan Beulich wrote: > On 13.06.2024 20:43, Demi Marie Obenour wrote: > > GPU acceleration requires that pageable host memory be able to be mapped > > into a guest. > > I'm sure it was explained in the session, which sadly I couldn't attend. > I've been aski