Re: [XEN PATCH 1/5] xen/domain: deviate violation of MISRA C Rule 20.12

2024-06-02 Thread Jan Beulich
On 01.06.2024 12:16, Nicola Vetrini wrote: > MISRA C Rule 20.12 states: "A macro parameter used as an operand to > the # or ## operators, which is itself subject to further macro replacement, > shall only be used as an operand to these operators". > > In this case, builds where CONFIG_DEBUG_LOCK_P

Re: [PATCH v2 07/13] x86/bitops: Improve arch_ffs() in the general case

2024-06-02 Thread Jan Beulich
On 01.06.2024 03:47, Andrew Cooper wrote: > On 28/05/2024 2:12 pm, Jan Beulich wrote: >> On 28.05.2024 14:30, Andrew Cooper wrote: >>> On 27/05/2024 2:37 pm, Jan Beulich wrote: On 27.05.2024 15:27, Jan Beulich wrote: > On 24.05.2024 22:03, Andrew Cooper wrote: >> --- a/xen/arch/x86/inc

Re: [XEN PATCH 4/5] automation/eclair_analysis: address remaining violations of MISRA C Rule 20.12

2024-06-02 Thread Jan Beulich
On 01.06.2024 12:16, Nicola Vetrini wrote: > --- a/automation/eclair_analysis/ECLAIR/deviations.ecl > +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl > @@ -483,6 +483,12 @@ leads to a violation of the Rule are deviated." > -config=MC3R1.R20.12,macros+={deliberate, > "name(GENERATE_CASE)&&l

[PATCH] xen/blkback: add missing MODULE_DESCRIPTION() macro

2024-06-02 Thread Jeff Johnson
ule_exit(xen_blkif_fini); +MODULE_DESCRIPTION("Virtual block device back-end driver"); MODULE_LICENSE("Dual BSD/GPL"); MODULE_ALIAS("xen-backend:vbd"); --- base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586 change-id: 20240602-md-block-xen-blkback-0db494d277af

[linux-linus test] 186232: regressions - FAIL

2024-06-02 Thread osstest service owner
flight 186232 linux-linus real [real] flight 186233 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186232/ http://logs.test-lab.xenproject.org/osstest/logs/186233/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

[PATCH for-4.19? v5 10/10] tools/ocaml: Add altp2m_count parameter

2024-06-02 Thread Petr Beneš
From: Petr Beneš Allow developers using the OCaml bindings to set the altp2m_count parameter. Signed-off-by: Petr Beneš --- tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + tools/ocaml/libs/xc/xenctrl_stubs.c | 19 +++ 3 files changed, 17

[PATCH for-4.19? v5 06/10] x86/altp2m: Introduce accessor functions for safer array indexing

2024-06-02 Thread Petr Beneš
From: Petr Beneš This patch introduces a set of accessor functions for altp2m array operations, and refactoring direct array accesses with them. This approach aims on improving the code clarity and also future-proofing the codebase against potential speculative execution attacks. Signed-off-by:

[PATCH for-4.19? v5 04/10] tools/xl: Add altp2m_count parameter

2024-06-02 Thread Petr Beneš
From: Petr Beneš Introduce a new altp2m_count parameter to control the maximum number of altp2m views a domain can use. By default, if altp2m_count is unspecified and altp2m is enabled, the value is set to 10, reflecting the legacy behavior. This change is preparatory; it establishes the groundw

[PATCH for-4.19? v5 09/10] xen/x86: Disallow creating domains with altp2m enabled and altp2m.nr == 0

2024-06-02 Thread Petr Beneš
From: Petr Beneš Since libxl finally sends the altp2m.nr value, we can remove the previously introduced temporary workaround. Creating domain with enabled altp2m while setting altp2m.nr == 0 doesn't make sense and it's probably not what user wants. Signed-off-by: Petr Beneš --- xen/arch/x86/d

[PATCH for-4.19? v5 01/10] tools/ocaml: Fix mixed tabs/spaces

2024-06-02 Thread Petr Beneš
From: Petr Beneš No functional change. Signed-off-by: Petr Beneš --- tools/ocaml/libs/xc/xenctrl_stubs.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index c6da9bb091..e86c45580

[PATCH for-4.19? v5 02/10] tools/ocaml: Add missing ocaml bindings for altp2m_opts

2024-06-02 Thread Petr Beneš
From: Petr Beneš Fixes: 0291089f6ea8 ("xen: enable altp2m at create domain domctl") Signed-off-by: Petr Beneš --- tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + tools/ocaml/libs/xc/xenctrl_stubs.c | 9 ++--- 3 files changed, 8 insertions(+), 3 deletio

[PATCH for-4.19? v5 08/10] tools/libxl: Activate the altp2m_count feature

2024-06-02 Thread Petr Beneš
From: Petr Beneš This commit activates the previously introduced altp2m_count parameter, establishing the connection between libxl and Xen. Signed-off-by: Petr Beneš --- tools/libs/light/libxl_create.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/libs/light/libxl_create.c b/to

[PATCH for-4.19? v5 05/10] docs/man: Add altp2m_count parameter to the xl.cfg manual

2024-06-02 Thread Petr Beneš
From: Petr Beneš Update manual pages to include detailed information about the altp2m_count configuration parameter. Signed-off-by: Petr Beneš --- docs/man/xl.cfg.5.pod.in | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in in

[PATCH for-4.19? v5 00/10] x86: Make MAX_ALTP2M configurable

2024-06-02 Thread Petr Beneš
From: Petr Beneš This series introduces the ability to configure the maximum number of altp2m tables during domain creation. Previously, the limits were hardcoded to a maximum of 10. This change allows for greater flexibility in environments that require more or fewer altp2m views. This enhancem

[PATCH for-4.19? v5 03/10] xen: Refactor altp2m options into a structured format

2024-06-02 Thread Petr Beneš
From: Petr Beneš Encapsulate the altp2m options within a struct. This change is preparatory and sets the groundwork for introducing additional parameter in subsequent commit. Signed-off-by: Petr Beneš --- tools/libs/light/libxl_create.c | 6 +++--- tools/ocaml/libs/xc/xenctrl_stubs.c | 4 +

[PATCH for-4.19? v5 07/10] xen: Make the maximum number of altp2m views configurable for x86

2024-06-02 Thread Petr Beneš
From: Petr Beneš x86: Make the maximum number of altp2m views configurable This commit introduces the ability to configure the maximum number of altp2m views for the domain during its creation. Previously, the limits were hardcoded to a maximum of 10. This change allows for greater flexibility i

[linux-linus test] 186231: tolerable FAIL - PUSHED

2024-06-02 Thread osstest service owner
flight 186231 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/186231/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 186212 Tests which did not succeed,

[xen-unstable test] 186229: tolerable FAIL

2024-06-02 Thread osstest service owner
flight 186229 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186229/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-vhd 8 xen-boot fail in 186225 pass in 186229 test-amd64-amd64-xl-qemuu-debian

Re: [PATCH 13/14] block: remove unused queue limits API

2024-06-02 Thread Nitesh Shetty
On 31/05/24 09:48AM, Christoph Hellwig wrote: Remove all APIs that are unused now that sd and sr have been converted to the atomic queue limits API. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche --- Reviewed-by: Nitesh Shetty

[linux-linus test] 186226: regressions - FAIL

2024-06-02 Thread osstest service owner
flight 186226 linux-linus real [real] flight 186230 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186226/ http://logs.test-lab.xenproject.org/osstest/logs/186230/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run