[ovmf test] 185701: all pass - PUSHED

2024-04-16 Thread osstest service owner
flight 185701 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185701/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 61185f1d501512f35621d0fdc5f17503c77bf449 baseline version: ovmf fcfdbe29874320e9f876b

[xen-4.18-testing test] 185695: regressions - FAIL

2024-04-16 Thread osstest service owner
flight 185695 xen-4.18-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185695/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 185285 Tests which ar

[xen-4.16-testing bisection] complete test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm

2024-04-16 Thread osstest service owner
branch xen-4.16-testing xenbranch xen-4.16-testing job test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf

[xen-unstable test] 185674: tolerable FAIL - PUSHED

2024-04-16 Thread osstest service owner
flight 185674 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185674/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 12 debian-di-install fail in 185635 pass in 185674 test-amd64-amd64-xl-vhd 12 d

RE: [PATCH] xen/arm: imx8qm: Re-license file to GPL-2.0-only

2024-04-16 Thread Stefano Stabellini
On Tue, 16 Apr 2024, Peng Fan wrote: > > Subject: [PATCH] xen/arm: imx8qm: Re-license file to GPL-2.0-only > > > > New contributions are recommended to be under GPL-2.0-only [1], since this > > code piece originally came from the NXP tree the original license was > > retained. > > > > However, as

Re: [PATCH] xen/efi: Rewrite DOS/PE magic checking without memcmp()

2024-04-16 Thread Stefano Stabellini
On Tue, 16 Apr 2024, Andrew Cooper wrote: > Misra Rule 21.16 doesn't like the use of memcmp() between a string literal and > a UINT8 array. Rewrite using plain compares. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini > --- > CC: Jan Beulich > CC:

[xen-unstable-smoke test] 185684: tolerable all pass - PUSHED

2024-04-16 Thread osstest service owner
flight 185684 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185684/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-4.15-testing bisection] complete test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm

2024-04-16 Thread osstest service owner
branch xen-4.15-testing xenbranch xen-4.15-testing job test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm testid guest-saverestore Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops

docs/misra: add R21.6 R21.14 R21.15 R21.16

2024-04-16 Thread Stefano Stabellini
Also add two specific project-wide deviations for R21.6 and R21.15. Signed-off-by: Stefano Stabellini diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst index 32b02905d1..9123c8edb5 100644 --- a/docs/misra/deviations.rst +++ b/docs/misra/deviations.rst @@ -387,6 +387,22 @@ Deviat

Re: [XEN PATCH v1 06/15] x86/p2m: guard altp2m code with CONFIG_VMX option

2024-04-16 Thread Tamas K Lengyel
On Tue, Apr 16, 2024 at 3:29 AM Andrew Cooper wrote: > > On 16/04/2024 7:31 am, Sergiy Kibrik wrote: > > Instead of using generic CONFIG_HVM option switch to a bit more specific > > CONFIG_VMX option for altp2m support, as it depends on VMX. Also guard > > altp2m routines, so that it can be disabl

[ovmf test] 185671: all pass - PUSHED

2024-04-16 Thread osstest service owner
flight 185671 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185671/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fcfdbe29874320e9f876baa7afebc3fca8f4a7df baseline version: ovmf b6cd5ddce9ade43e42158

[PATCH] xen/efi: Rewrite DOS/PE magic checking without memcmp()

2024-04-16 Thread Andrew Cooper
Misra Rule 21.16 doesn't like the use of memcmp() between a string literal and a UINT8 array. Rewrite using plain compares. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Stefano Stabellini CC: consult...@bugseng.com CC: Roberto Bagnara CC: F

[libvirt test] 185641: tolerable all pass - PUSHED

2024-04-16 Thread osstest service owner
flight 185641 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/185641/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185412 test-amd64-amd64-libvirt-xsm 15 migrate-s

Re: [PATCH] x86/hvm: Allow supplying a dynamic start ASID

2024-04-16 Thread Vaishali Thakkar
On 4/16/24 4:25 PM, Vaishali Thakkar wrote: On 4/16/24 4:12 PM, Andrew Cooper wrote: On 16/04/2024 9:54 am, Vaishali Thakkar wrote: Currently, Xen always starts the ASID allocation at 1. But for SEV technologies the ASID space is divided. This is because it's a security issue if a guest is star

Re: [PATCH] x86/hvm: Allow supplying a dynamic start ASID

2024-04-16 Thread Vaishali Thakkar
On 4/16/24 4:12 PM, Andrew Cooper wrote: On 16/04/2024 9:54 am, Vaishali Thakkar wrote: Currently, Xen always starts the ASID allocation at 1. But for SEV technologies the ASID space is divided. This is because it's a security issue if a guest is started as ES/SNP and is migrated to SEV-only. So

Re: [PATCH] x86/svm: Add flushbyasid in the supported features

2024-04-16 Thread Vaishali Thakkar
On 4/16/24 3:38 PM, Andrew Cooper wrote: On 16/04/2024 10:08 am, Vaishali Thakkar wrote: TLB Flush by ASID is missing in the list of supported features here. So, add it. Signed-off-by: Vaishali Thakkar --- xen/arch/x86/hvm/svm/svm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/ar

Re: [PATCH] x86/hvm: Allow supplying a dynamic start ASID

2024-04-16 Thread Andrew Cooper
On 16/04/2024 9:54 am, Vaishali Thakkar wrote: > Currently, Xen always starts the ASID allocation at 1. But > for SEV technologies the ASID space is divided. This is > because it's a security issue if a guest is started as > ES/SNP and is migrated to SEV-only. So, the types are > tracked explicitly

RE: [PATCH] xen/arm: imx8qm: Re-license file to GPL-2.0-only

2024-04-16 Thread Peng Fan
> Subject: [PATCH] xen/arm: imx8qm: Re-license file to GPL-2.0-only > > New contributions are recommended to be under GPL-2.0-only [1], since this > code piece originally came from the NXP tree the original license was > retained. > > However, as discussed both Peng [2] and I [3] are ok with GPL-2

[PATCH] xen/arm: imx8qm: Re-license file to GPL-2.0-only

2024-04-16 Thread John Ernberg
New contributions are recommended to be under GPL-2.0-only [1], since this code piece originally came from the NXP tree the original license was retained. However, as discussed both Peng [2] and I [3] are ok with GPL-2.0.-only as a license. Change the license. Cc: Peng Fan Link: https://lore.ke

Re: [PATCH] x86/svm: Add flushbyasid in the supported features

2024-04-16 Thread Andrew Cooper
On 16/04/2024 10:08 am, Vaishali Thakkar wrote: > TLB Flush by ASID is missing in the list of supported features > here. So, add it. > > Signed-off-by: Vaishali Thakkar > --- > xen/arch/x86/hvm/svm/svm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arc

Re: [XEN PATCH v1 13/15] x86: wire cpu_has_{svm/vmx}_* to false when svm/vmx not enabled

2024-04-16 Thread Andrew Cooper
On 16/04/2024 7:46 am, Sergiy Kibrik wrote: > From: Xenia Ragiadakou > > To be able to use cpu_has_{svm/vmx}_* macros in common code without enclosing > them inside #ifdef guards when the respective virtualization technology is > not enabled, define corresponding helper routines as false when not

[xen-unstable test] 185635: regressions - FAIL

2024-04-16 Thread osstest service owner
flight 185635 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185635/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 12 debian-di-installfail REGR. vs. 185281 test-amd64-amd64-x

[ovmf test] 185658: all pass - PUSHED

2024-04-16 Thread osstest service owner
flight 185658 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185658/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b6cd5ddce9ade43e4215836f12b43ebbb90eecf2 baseline version: ovmf 6363872629cd586361288

[xen-4.16-testing bisection] complete test-amd64-amd64-xl-pvhv2-intel

2024-04-16 Thread osstest service owner
branch xen-4.16-testing xenbranch xen-4.16-testing job test-amd64-amd64-xl-pvhv2-intel testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://

Re: [XEN PATCH v1 08/15] x86/vpmu: separate amd/intel vPMU code

2024-04-16 Thread Andrew Cooper
On 16/04/2024 7:35 am, Sergiy Kibrik wrote: > diff --git a/xen/arch/x86/cpu/Makefile b/xen/arch/x86/cpu/Makefile > index 35561fe51d..d3d7b8fb2e 100644 > --- a/xen/arch/x86/cpu/Makefile > +++ b/xen/arch/x86/cpu/Makefile > @@ -10,4 +10,6 @@ obj-y += intel.o > obj-y += intel_cacheinfo.o > obj-y += m

Re: [PATCH] Mini-OS: add some macros for asm statements

2024-04-16 Thread Andrew Cooper
On 16/04/2024 8:11 am, Juergen Gross wrote: > diff --git a/arch/x86/sched.c b/arch/x86/sched.c > index dabe6fd6..460dea2e 100644 > --- a/arch/x86/sched.c > +++ b/arch/x86/sched.c > @@ -119,20 +113,12 @@ struct thread* arch_create_thread(char *name, void > (*function)(void *), > > void run_idle_

Re: [PATCH v2 13/13] xen/arm: List static shared memory regions as /memory nodes

2024-04-16 Thread Luca Fancellu
> On 16 Apr 2024, at 10:06, Julien Grall wrote: > > > > On 16/04/2024 09:59, Luca Fancellu wrote: >>> On 16 Apr 2024, at 09:50, Julien Grall wrote: >>> >>> >>> >>> On 16/04/2024 07:27, Luca Fancellu wrote: Hi Julien, >>> >>> Hi Luca, >>> > On 15 Apr 2024, at 19:41, Julien Grall

Re: [XEN PATCH v1 06/15] x86/p2m: guard altp2m code with CONFIG_VMX option

2024-04-16 Thread Andrew Cooper
On 16/04/2024 7:31 am, Sergiy Kibrik wrote: > Instead of using generic CONFIG_HVM option switch to a bit more specific > CONFIG_VMX option for altp2m support, as it depends on VMX. Also guard > altp2m routines, so that it can be disabled completely in the build. > > Signed-off-by: Sergiy Kibrik A

Re: [XEN PATCH v1 15/15] x86/hvm: make AMD-V and Intel VT-x support configurable

2024-04-16 Thread Sergiy Kibrik
16.04.24 12:36, Andrew Cooper: Everything else seems ok, but there's no inherent dependency between VMX/SVM and IOMMUs.  There are certain features (HAP/IOMMU pagetable sharing, posted interrupts) which do depend on both, but the vast majority of functionality is independent. It would be a legi

Re: [XEN PATCH v1 15/15] x86/hvm: make AMD-V and Intel VT-x support configurable

2024-04-16 Thread Sergiy Kibrik
hi Teddy, 16.04.24 11:40, Teddy Astie: Hello Sergiy, Also make INTEL_IOMMU/AMD_IOMMU options dependant on VMX/SVM options. The discussion in the RFC series stated the IOMMU may be used with PV guests, and doesn't rely on VMX/SVM support (in fact, it can be used without HVM support in Xen).

Re: [XEN PATCH v1 15/15] x86/hvm: make AMD-V and Intel VT-x support configurable

2024-04-16 Thread Andrew Cooper
On 16/04/2024 7:50 am, Sergiy Kibrik wrote: > From: Xenia Ragiadakou > > Provide the user with configuration control over the cpu virtualization > support > in Xen by making SVM and VMX options user selectable. > > To preserve the current default behavior, both options depend on HVM and > default

[ovmf test] 185649: all pass - PUSHED

2024-04-16 Thread osstest service owner
flight 185649 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185649/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6363872629cd58636128824977e56eea15b97a15 baseline version: ovmf 70892b13b28cdb0a10c82

[PATCH v2 4/5] x86: Use getopt to handle command line args

2024-04-16 Thread Fouad Hilly
Use getopt_long() to handle command line arguments. Introduce ext_err for common exit with errors. [v2] 1- Removed unnecessary NULL initialization. 2- Used static at the beginning of type struct declaration. 3- Corrected switch\case indentations. 4- Removed redundant checks. 5- Corrected label ind

[PATCH v2 1/5] x86: Update x86 low level version check of microcode

2024-04-16 Thread Fouad Hilly
Update microcode version check at Intel and AMD Level by: Preventing the low level code from sending errors if the microcode version provided is not a newer version. Other errors will be sent like before. When the provided microcode version is the same as the current one, code to point to microcode

[PATCH v2 0/5] x86/xen-ucode: Introduce --force option

2024-04-16 Thread Fouad Hilly
Refactor and introduce --force option to xen-ucode, which skips microcode version check when updating x86 CPU micocode. A new hypercall introduced with flags field to facilitate the new option and allow for future flags as needed. Fouad Hilly (5): x86: Update x86 low level version check of micro

[PATCH v2 5/5] x86: Add --force option to xen-ucode to override microcode version check

2024-04-16 Thread Fouad Hilly
Introduce --force option to xen-ucode to force skipping microcode version check, which allows the user to update x86 microcode even if both versions are the same. [v2] 1- Changed data type from uint32_t to unsigned int. 2- Corrected line length. 3- Removed XENPF_UCODE_FLAG_FORCE_NOT_SET. 4- Correc

[PATCH v2 2/5] x86: Refactor microcode_update() hypercall with flags

2024-04-16 Thread Fouad Hilly
Refactor microcode_update() hypercall by adding flags field. Introduce XENPF_microcode_update2 hypercall to handle flags field. struct xenpf_microcode_update updated to have uint32_t flags at the end of the sturcture. [v2] 1- Update message description to highlight interface change. 2- Removed ext

[PATCH v2 3/5] x86: Add usage() to print out usage message

2024-04-16 Thread Fouad Hilly
Refactor xen-ucode tool by adding usage() to handle usage\help messages As we add more command options this will keep help\usage messages in common block [v2] 1- Improved message description. 2- Fixed formatting and indentation. 3- Error message to print to stderr. Signed-off-by: Fouad Hilly --

[PATCH] x86/svm: Add flushbyasid in the supported features

2024-04-16 Thread Vaishali Thakkar
TLB Flush by ASID is missing in the list of supported features here. So, add it. Signed-off-by: Vaishali Thakkar --- xen/arch/x86/hvm/svm/svm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index a745acd903..4719fffae5 100644 --- a/xe

Re: [PATCH v2 13/13] xen/arm: List static shared memory regions as /memory nodes

2024-04-16 Thread Julien Grall
On 16/04/2024 09:59, Luca Fancellu wrote: On 16 Apr 2024, at 09:50, Julien Grall wrote: On 16/04/2024 07:27, Luca Fancellu wrote: Hi Julien, Hi Luca, On 15 Apr 2024, at 19:41, Julien Grall wrote: Hi Luca, On 09/04/2024 12:45, Luca Fancellu wrote: Currently Xen is not exporting

Re: [PATCH v2 13/13] xen/arm: List static shared memory regions as /memory nodes

2024-04-16 Thread Luca Fancellu
> On 16 Apr 2024, at 09:50, Julien Grall wrote: > > > > On 16/04/2024 07:27, Luca Fancellu wrote: >> Hi Julien, > > Hi Luca, > >>> On 15 Apr 2024, at 19:41, Julien Grall wrote: >>> >>> Hi Luca, >>> >>> On 09/04/2024 12:45, Luca Fancellu wrote: Currently Xen is not exporting the stat

Re: [PATCH v2 13/13] xen/arm: List static shared memory regions as /memory nodes

2024-04-16 Thread Michal Orzel
Hi Julien, On 16/04/2024 10:50, Julien Grall wrote: > > > On 16/04/2024 07:27, Luca Fancellu wrote: >> Hi Julien, > > Hi Luca, > >> >>> On 15 Apr 2024, at 19:41, Julien Grall wrote: >>> >>> Hi Luca, >>> >>> On 09/04/2024 12:45, Luca Fancellu wrote: Currently Xen is not exporting the stat

[PATCH] x86/hvm: Allow supplying a dynamic start ASID

2024-04-16 Thread Vaishali Thakkar
Currently, Xen always starts the ASID allocation at 1. But for SEV technologies the ASID space is divided. This is because it's a security issue if a guest is started as ES/SNP and is migrated to SEV-only. So, the types are tracked explicitly. Thus, in preparation of SEV support in Xen, add min_as

Re: [PATCH v2 13/13] xen/arm: List static shared memory regions as /memory nodes

2024-04-16 Thread Julien Grall
On 16/04/2024 07:27, Luca Fancellu wrote: Hi Julien, Hi Luca, On 15 Apr 2024, at 19:41, Julien Grall wrote: Hi Luca, On 09/04/2024 12:45, Luca Fancellu wrote: Currently Xen is not exporting the static shared memory regions to the device tree as /memory node, this commit is fixing thi

Re: [XEN PATCH v1 15/15] x86/hvm: make AMD-V and Intel VT-x support configurable

2024-04-16 Thread Teddy Astie
Hello Sergiy, > Also make INTEL_IOMMU/AMD_IOMMU options dependant on VMX/SVM options. The discussion in the RFC series stated the IOMMU may be used with PV guests, and doesn't rely on VMX/SVM support (in fact, it can be used without HVM support in Xen). However, in the discussion, posted inter

[PATCH v2 1/1] xen/arm64: entry: Add missing code symbol annotations

2024-04-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use the generic xen/linkage.h macros when and add missing code symbol annotations. Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/arm64/entry.S | 72 +- 1 file changed, 48 insertions(+), 24 deletions(-) diff --git a/xen/arch/arm

[PATCH v2 0/1] xen/arm: Annotate code symbols

2024-04-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" On the way towards Xen safety certification we're evaluating the use of tools to collect code-coverage/profiling information from execution traces. Some tools rely on ELF symbols for code being declared with type FUNC and having a symbol size. We currently annotate some

[xen-4.18-testing test] 185632: regressions - FAIL

2024-04-16 Thread osstest service owner
flight 185632 xen-4.18-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185632/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken in 185427 test-amd64-amd64-xl-vhd

Re: [PATCH v2] docs/misra: add Rule 16.4

2024-04-16 Thread Bertrand Marquis
Hi Stefano, > On 14 Mar 2024, at 22:50, Stefano Stabellini wrote: > > > Signed-off-by: Stefano Stabellini Acked-by: Bertrand Marquis Cheers Bertrand > --- > Changes in v2: > - mention -Werror > - change the position of the in-code comment in the example > - use "notifier pattern" in the ex

Re: [PATCH v3] docs/misra/rules.rst: add rule 5.5

2024-04-16 Thread Bertrand Marquis
Hi Stefano, > On 15 Mar 2024, at 01:35, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini With the semicolon comment from Jan addressed: Acked-by: Bertrand Marquis Cheers Bertrand

[ovmf test] 185643: all pass - PUSHED

2024-04-16 Thread osstest service owner
flight 185643 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185643/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 70892b13b28cdb0a10c82f3d3aca560a38dce5c9 baseline version: ovmf 5ba3602e4580d6b65dacf

[PATCH] Mini-OS: add some macros for asm statements

2024-04-16 Thread Juergen Gross
Instead of having #ifdefs sprinkled around in x86 code, add some macros defining constants for asm statements to address differences between 32- and 64-bit mode. Modify existing code to use those macros. Signed-off-by: Juergen Gross --- arch/x86/sched.c | 32 +--- in