Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

On 13.12.2023 08:14, Chen, Jiqian wrote: > On 2023/12/12 19:39, Roger Pau Monné wrote: >> On Tue, Dec 12, 2023 at 12:19:49PM +0100, Jan Beulich wrote: >>> On 12.12.2023 12:18, Roger Pau Monné wrote: On Tue, Dec 12, 2023 at 10:38:08AM +0100, Jan Beulich wrote: > (I think the Cc list is too

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

On 2023/12/12 19:39, Roger Pau Monné wrote: > On Tue, Dec 12, 2023 at 12:19:49PM +0100, Jan Beulich wrote: >> On 12.12.2023 12:18, Roger Pau Monné wrote: >>> On Tue, Dec 12, 2023 at 10:38:08AM +0100, Jan Beulich wrote: (I think the Cc list is too long here, but then I don't know who to ke

Re: [RFC XEN PATCH v3 2/3] x86/pvh: Add (un)map_pirq and setup_gsi for PVH dom0

On 13.12.2023 03:47, Chen, Jiqian wrote: > On 2023/12/12 17:30, Jan Beulich wrote: >> On 12.12.2023 07:49, Chen, Jiqian wrote: >>> On 2023/12/11 23:31, Roger Pau Monné wrote: On Mon, Dec 11, 2023 at 12:40:08AM +0800, Jiqian Chen wrote: > --- a/xen/arch/x86/hvm/hypercall.c > +++ b/xen/a

Re: [PATCH v2 1/5] system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()

On 2023/12/13 0:39, Stefan Hajnoczi wrote: The Big QEMU Lock (BQL) has many names and they are confusing. The actual QemuMutex variable is called qemu_global_mutex but it's commonly referred to as the BQL in discussions and some code comments. The locking APIs, however, are called qemu_mutex_lock

Re: [PATCH v4 08/12] xen/spinlock: add another function level

On 12.12.23 20:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of introducing rspinlock_t for recursive locks without having to dupli

Re: [PATCH v4 07/12] xen/spinlock: add explicit non-recursive locking functions

On 12.12.23 19:49, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: -#define spin_lock_init_prof(s, l) __spin_lock_init_prof(s, l, spinlock_t) -#define rspin_lock_init_prof(s, l) __spin_lock_init_prof(s, l, rspinlock_t) +#define spin_lock_init_prof(s, l)

Re: [PATCH v4 06/12] xen/spinlock: make struct lock_profile rspinlock_t aware

On 12.12.23 19:42, Julien Grall wrote: Hi, On 12/12/2023 09:47, Juergen Gross wrote: Struct lock_profile contains a pointer to the spinlock it is associated with. Prepare support of differing spinlock_t and rspinlock_t types by adding a type indicator of the pointer. Use the highest bit of the

Re: [RFC KERNEL PATCH v3 3/3] PCI/sysfs: Add gsi sysfs for pci_dev

On 2023/12/12 17:18, Roger Pau Monné wrote: > On Tue, Dec 12, 2023 at 06:34:27AM +, Chen, Jiqian wrote: >> >> On 2023/12/12 01:57, Roger Pau Monné wrote: >>> On Mon, Dec 11, 2023 at 12:15:19AM +0800, Jiqian Chen wrote: There is a need for some scenarios to use gsi sysfs. For example,

Re: [RFC KERNEL PATCH v3 1/3] xen/pci: Add xen_reset_device_state function

On 2023/12/12 16:08, Roger Pau Monné wrote: > On Mon, Dec 11, 2023 at 12:15:17AM +0800, Jiqian Chen wrote: >> When device on dom0 side has been reset, the vpci on Xen side >> won't get notification, so that the cached state in vpci is >> all out of date with the real device state. >> To solve that

Re: [RFC XEN PATCH v3 2/3] x86/pvh: Add (un)map_pirq and setup_gsi for PVH dom0

On 2023/12/12 17:30, Jan Beulich wrote: > On 12.12.2023 07:49, Chen, Jiqian wrote: >> On 2023/12/11 23:31, Roger Pau Monné wrote: >>> On Mon, Dec 11, 2023 at 12:40:08AM +0800, Jiqian Chen wrote: --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -72,8 +72,11 @@

Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

Hi, 在 2023/12/12 21:14, Christoph Hellwig 写道: On Mon, Dec 11, 2023 at 05:52:17PM +0100, Jan Kara wrote: +void bdev_associated_mapping(struct block_device *bdev, +struct address_space *mapping) +{ + mapping->host = bdev->bd_inode; +} Here I'm not sure - is the

Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

Hi, 在 2023/12/12 21:16, Christoph Hellwig 写道: +void invalidate_bdev_range(struct block_device *bdev, pgoff_t start, + pgoff_t end) +{ + invalidate_mapping_pages(bdev->bd_inode->i_mapping, start, end); +} +EXPORT_SYMBOL_GPL(invalidate_bdev_range); Can we have kern

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

On Mon, 11 Dec 2023, Chuck Zmudzinski wrote: > On 11/27/2023 9:28 PM, Stefano Stabellini wrote: > > On Mon, 27 Nov 2023, Chuck Zmudzinski wrote: > >> On 11/27/2023 10:22 AM, Chuck Zmudzinski wrote: > >> > On 11/27/2023 7:45 AM, Mario Marietto wrote: > >> >> @Chuck Zmudzinski

Re: [XEN PATCH v3 3/3] xen/mm: add declaration for first_valid_mfn

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > Such declaration is needed because a compatible declaration > is not visible in xen/common/page_alloc.c, where the variable > is defined. That variable can't yet be static because of the lack of > support from ARM and PPC for NUMA. > > On the occasion,

Re: [XEN PATCH v2] automation/eclair_analysis: file exclusion automation

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > The file exclude-list.json contains files that are classified as > adopted code for MISRA compliance. Therefore, this file is used to > automatically generate a suitable .ecl configuration for ECLAIR. > > As such, many entries in out_of_scope.ecl can be

xen | Failed pipeline for staging | a6a8fe0e

Pipeline #1104313882 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: a6a8fe0e ( https://gitlab.com/xen-project/xen/-/commit/a6a8fe0eb177ca27c9155177e7e60c13fc46e5f6 ) Commit Message: Revert "xen:

Re: [XEN PATCH 4/4] xen/iommu: address leftover violation of MISRA C:2012 Rule 8.2

On Tue, 12 Dec 2023, Federico Serafini wrote: > Add missing parameter name. No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 3/4] xen/drivers: address violations of MISRA C:2012 Rule 8.2

On Tue, 12 Dec 2023, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 2/4] x86/asm: address violations of MISRA C:2012 Rule 8.2

On Tue, 12 Dec 2023, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 1/4] xen/compat: address violations of MISRA C:2012 Rule 8.2

On Tue, 12 Dec 2023, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 6/7] x86/platform: removed break to address MISRA C:2012 Rule 2.1

On Tue, 12 Dec 2023, Jan Beulich wrote: > On 11.12.2023 11:30, Nicola Vetrini wrote: > > The break statement is redundant, hence it can be removed. > > Except ... > > > --- a/xen/arch/x86/platform_hypercall.c > > +++ b/xen/arch/x86/platform_hypercall.c > > @@ -723,7 +723,6 @@ ret_t do_platform_op

[xen-unstable-smoke test] 184112: tolerable all pass - PUSHED

flight 184112 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184112/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[linux-linus test] 184101: regressions - trouble: blocked/broken/fail/pass

flight 184101 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184101/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl broken test-armhf-armhf-xl 5 host-insta

Re: [PATCH 3/3] Mini-OS: cleanup hypervisor.c

Juergen Gross, le lun. 11 déc. 2023 14:48:27 +0100, a ecrit: > Do the following cleanups in hypervisor.c: > > - Let hypervisor.c conform to the coding style. > - Drop the bogus "inline" attributes of exported functions. > - Replace a always zero cpu variable with smp_processor_id() as > elsewher

Re: [PATCH 2/3] Mini-OS: drop in_callback variable

Juergen Gross, le lun. 11 déc. 2023 14:48:26 +0100, a ecrit: > Now that do_hypervisor_callback() is always called with interrupts off > the in_callback variable meant to handle recursive calls of > do_hypervisor_callback() can be dropped. > > As a precaution add a test to do_hypervisor_callback()

Re: [PATCH 1/3] Mini-OS: call event handlers always with interrupts off

Juergen Gross, le lun. 11 déc. 2023 14:48:25 +0100, a ecrit: > When unmasking an event channel the associated event handler can be > called with interrupts enabled when not running as a PV guest. > > This can result in hard to debug races in case e.g. a handler is > registered for multiple events

xen | Successful pipeline for staging-4.16 | e7c3d6ce

Pipeline #1104145725 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging-4.16 ( https://gitlab.com/xen-project/xen/-/commits/staging-4.16 ) Commit: e7c3d6ce ( https://gitlab.com/xen-project/xen/-/commit/e7c3d6ceaf73120098f9213fd12f79fd50e8e588 ) Commit Message: xe

xen | Successful pipeline for staging-4.17 | 958706fd

Pipeline #1104146065 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging-4.17 ( https://gitlab.com/xen-project/xen/-/commits/staging-4.17 ) Commit: 958706fd ( https://gitlab.com/xen-project/xen/-/commit/958706fd2e178ffe8e5597b05b694b494e24258b ) Commit Message: xe

xen | Failed pipeline for staging-4.15 | 6400013f

Pipeline #1104143214 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging-4.15 ( https://gitlab.com/xen-project/xen/-/commits/staging-4.15 ) Commit: 6400013f ( https://gitlab.com/xen-project/xen/-/commit/6400013f07e5c7fec9f68821755aed94683b663c ) Commit Message: xe

xen | Successful pipeline for staging-4.18 | 1792d172

Pipeline #1104134407 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging-4.18 ( https://gitlab.com/xen-project/xen/-/commits/staging-4.18 ) Commit: 1792d172 ( https://gitlab.com/xen-project/xen/-/commit/1792d1723b7fb45a20b145d2de4d233913b22c09 ) Commit Message: x8

Re: [PATCH v4 08/12] xen/spinlock: add another function level

Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of introducing rspinlock_t for recursive locks without having to duplicate all of the locking code. So all t

[xen-unstable test] 184100: regressions - FAIL

flight 184100 xen-unstable real [real] flight 184113 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184100/ http://logs.test-lab.xenproject.org/osstest/logs/184113/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH v4 07/12] xen/spinlock: add explicit non-recursive locking functions

Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: -#define spin_lock_init_prof(s, l) __spin_lock_init_prof(s, l, spinlock_t) -#define rspin_lock_init_prof(s, l) __spin_lock_init_prof(s, l, rspinlock_t) +#define spin_lock_init_prof(s, l) \ +__sp

Re: [PATCH v4 06/12] xen/spinlock: make struct lock_profile rspinlock_t aware

Hi, On 12/12/2023 09:47, Juergen Gross wrote: Struct lock_profile contains a pointer to the spinlock it is associated with. Prepare support of differing spinlock_t and rspinlock_t types by adding a type indicator of the pointer. Use the highest bit of the block_cnt member for this indicator in o

[xen-unstable-smoke test] 184106: regressions - FAIL

flight 184106 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184106/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 184102 Tests which

xen | Failed pipeline for staging | 7fca0463

Pipeline #1104070818 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 7fca0463 ( https://gitlab.com/xen-project/xen/-/commit/7fca0463c71ca5a5b5ba853dbb000a54635c8899 ) Commit Message: xen/spinlock:

Re: [PATCH v2 18/39] xen/riscv: introduce cmpxchg.h

On Tue, 2023-12-12 at 17:51 +0100, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V2: > > - update the comment at the top of the header. > > - change xen/lib.h to xen/bug.h. > > - sort inclusion of headers pr

Re: [PATCH v2 29/39] xen/riscv: add definition of __read_mostly

On 24.11.2023 11:30, Oleksii Kurochko wrote: > The definition of __read_mostly should be removed in: > https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ Andrew, can we settle on what to do with that patch? If you don't like me putting __read_mostly in xen/cache.h (co

Re: [PATCH v2 20/39] xen/riscv: define bug frame tables in xen.lds.S

On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich

Re: [PATCH v2 19/39] xen/riscv: introduce asm/io.h

On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - Nothing changed. Only rebase. > --- > xen/arch/riscv/include/asm/io.h | 134 > 1 file changed, 134 insertions(+) > create mode 100644 xen/arch/riscv/include

Re: [PATCH v2 18/39] xen/riscv: introduce cmpxchg.h

On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - update the comment at the top of the header. > - change xen/lib.h to xen/bug.h. > - sort inclusion of headers properly. > --- > xen/arch/riscv/include/asm/cmpxchg.h | 379 ++

Re: Improving conflict resolution inside the Xen Project

Hi Charles, Thank you for your suggestion. I will factor this into the discussion I am having this week with the conduct/governance team. I will also share the proposed plans with the community and advisory board as soon as I have details. Please rest assured that all members will have a chance t

Re: [PATCH 1/2] xen: make include/xen/unaligned.h usable on all architectures

On 12.12.2023 17:27, Juergen Gross wrote: > Instead of defining get_unaligned() and put_unaligned() in a way that > is only supporting architectures allowing unaligned accesses, use the > same approach as the Linux kernel and let the compiler do the > decision how to generate the code for probably

Re: [PATCH] fix qemu build with xen-4.18.0

On Tue, 12 Dec 2023 at 11:02, Volodymyr Babchuk wrote: > > > Hi Stefan, > > Stefan Hajnoczi writes: > > > On Tue, 12 Dec 2023 at 10:36, Volodymyr Babchuk > > wrote: > >> > >> Hi Anthony > >> > >> Anthony PERARD writes: > >> > >> > On Fri, Dec 08, 2023 at 02:49:27PM -0800, Stefano Stabellini wro

[PATCH 2/2] xen: remove asm/unaligned.h

With include/xen/unaligned.h now dealing properly with unaligned accesses for all architectures, asm/unaligned.h can be removed and users can be switched to include xen/unaligned.h instead. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- xen/arch/x86/include/asm/unaligned.h | 6 --

[PATCH 0/2] xen: have a more generic unaligned.h header (take 2)

Second try for the generic unaligned.h approach. This time including a fix for building stubdom with libxenguest, which is using a cruel hack to reuse the hypervisor's decompressing code. Juergen Gross (2): xen: make include/xen/unaligned.h usable on all architectures xen: remove asm/unaligne

[PATCH 1/2] xen: make include/xen/unaligned.h usable on all architectures

Instead of defining get_unaligned() and put_unaligned() in a way that is only supporting architectures allowing unaligned accesses, use the same approach as the Linux kernel and let the compiler do the decision how to generate the code for probably unaligned data accesses. Update include/xen/unali

xen | Failed pipeline for staging | 0fb4b6b0

Pipeline #1103957927 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 0fb4b6b0 ( https://gitlab.com/xen-project/xen/-/commit/0fb4b6b0ea8505fbd4888faa440212e878002494 ) Commit Message: MAINTAINERS:

Re: [PATCH] fix qemu build with xen-4.18.0

Hi Stefan, Stefan Hajnoczi writes: > On Tue, 12 Dec 2023 at 10:36, Volodymyr Babchuk > wrote: >> >> Hi Anthony >> >> Anthony PERARD writes: >> >> > On Fri, Dec 08, 2023 at 02:49:27PM -0800, Stefano Stabellini wrote: >> >> On Fri, 8 Dec 2023, Daniel P. Berrangé wrote: >> >> > On Thu, Dec 07, 2

Re: Adding MSI support for virtio-pci to QEMU as Xen backend on ARM

Stefano Stabellini writes: > +Stewart > > On Fri, 8 Dec 2023, Mykyta Poturai wrote: >> Hello everyone, >> >> I am currently working on adding MSI support to virtio-pci on ARM with Xen. > > Excellent! > > >> As far as I understand QEMU Xen ARM machine that is used for >> virtio-pci device emulati

Re: [PATCH] fix qemu build with xen-4.18.0

On Tue, Dec 12, 2023 at 03:35:50PM +, Volodymyr Babchuk wrote: > Hi Anthony > > Anthony PERARD writes: > > > On Fri, Dec 08, 2023 at 02:49:27PM -0800, Stefano Stabellini wrote: > >> On Fri, 8 Dec 2023, Daniel P. Berrangé wrote: > >> > On Thu, Dec 07, 2023 at 11:12:48PM +, Michael Young w

Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed

Hi, On 11/12/2023 12:32, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The branches of the switch after a call to 'do_unexpected_trap' cannot return, but there is one path that may return, hence only some clauses are marked with ASSERT_UNREACHABLE(). I don't understand why

Re: [PATCH] fix qemu build with xen-4.18.0

On Tue, 12 Dec 2023 at 10:36, Volodymyr Babchuk wrote: > > Hi Anthony > > Anthony PERARD writes: > > > On Fri, Dec 08, 2023 at 02:49:27PM -0800, Stefano Stabellini wrote: > >> On Fri, 8 Dec 2023, Daniel P. Berrangé wrote: > >> > On Thu, Dec 07, 2023 at 11:12:48PM +, Michael Young wrote: > >>

Re: [RFC PATCH v4 4/6] xen: add option to disable legacy backends

On Sat, Dec 02, 2023 at 01:41:22AM +, Volodymyr Babchuk wrote: > diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c > index 9f9f137f99..03a55f345c 100644 > --- a/hw/xenpv/xen_machine_pv.c > +++ b/hw/xenpv/xen_machine_pv.c > @@ -37,7 +37,9 @@ static void xen_init_pv(MachineState

Re: [PATCH v3 0/3] xen: have a more generic unaligned.h header

On 12/12/2023 11:44, Julien Grall wrote: Hi Juergen, On 11/12/2023 13:16, Juergen Gross wrote: Update Xen's unaligned.h header to support all architectures, allowing to remove the architecture specific variants (x86 only until now). Changes in V2: - new patch 1 (Julien Grall) - adjusted pat

[PATCH v2 5/5] Rename "QEMU global mutex" to "BQL" in comments and docs

The term "QEMU global mutex" is identical to the more widely used Big QEMU Lock ("BQL"). Update the code comments and documentation to use "BQL" instead of "QEMU global mutex". Signed-off-by: Stefan Hajnoczi Acked-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/multi-t

[PATCH v2 2/5] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to BQL_LOCK_GUARD

The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) instead, it is already widely used and unambiguous. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paul Durrant Acked-by: David Woodhouse Reviewed-by: Cédric Le Goater Acked-by: Ilya Leoshkevich --- include/qemu/main-loop.h |

[PATCH v2 4/5] Replace "iothread lock" with "BQL" in comments

The term "iothread lock" is obsolete. The APIs use Big QEMU Lock (BQL) in their names. Update the code comments to use "BQL" instead of "iothread lock". Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/reset.rst | 2 +- hw/display/qxl.h

[PATCH v2 1/5] system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()

The Big QEMU Lock (BQL) has many names and they are confusing. The actual QemuMutex variable is called qemu_global_mutex but it's commonly referred to as the BQL in discussions and some code comments. The locking APIs, however, are called qemu_mutex_lock_iothread() and qemu_mutex_unlock_iothread().

[PATCH v2 0/5] Make Big QEMU Lock naming consistent

v2: - Rename APIs bql_*() [PeterX] - Spell out "Big QEMU Lock (BQL)" in doc comments [PeterX] - Rename "iolock" variables in hw/remote/mpqemu-link.c [Harsh] - Fix bql_auto_lock() indentation in Patch 2 [Ilya] - "with BQL taken" -> "with the BQL taken" [Philippe] - "under BQL" -> "under the BQL" [Ph

[PATCH v2 3/5] qemu/main-loop: rename qemu_cond_wait_iothread() to qemu_cond_wait_bql()

The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL) instead, it is already widely used and unambiguous. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé --- include/qemu/main-loop.h | 10 +- accel/tcg/tcg-accel-op

[XEN PATCH 2/4] x86/asm: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/amd.h | 2 +- xen/arch/x86/include/asm/debugreg.h | 4 ++-- xen/arch/x86/include/asm/flushtlb.h | 3 ++- xen/arch/x86/include/asm/hap.h | 2 +- xen/arch/x86/include/asm/

[XEN PATCH 3/4] xen/drivers: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- xen/drivers/char/ehci-dbgp.c | 4 ++-- xen/drivers/video/vga.c | 2 +- xen/include/xen/video.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/drivers/char/ehci-dbgp.c b/x

[XEN PATCH 4/4] xen/iommu: address leftover violation of MISRA C:2012 Rule 8.2

Add missing parameter name. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/iommu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 69d572543c..f53d045e2c 100644 --- a/xen/include/xen/iommu.h +

[XEN PATCH 1/4] xen/compat: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/compat.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/compat.h b/xen/include/xen/compat.h index 41a5d61eef..7ec9d6567e 100644 --- a/xen/include/xen/

[XEN PATCH 0/4] xen: address violations of MISRA C:2012 Rule 8.2

This patch series adds the missing parameter names to address violations of MISRA C:2012 Rule 8.2. No functional changes are introduced. Federico Serafini (4): xen/compat: address violations of MISRA C:2012 Rule 8.2 x86/asm: address violations of MISRA C:2012 Rule 8.2 xen/drivers: address vi

Re: [PATCH] fix qemu build with xen-4.18.0

Hi Anthony Anthony PERARD writes: > On Fri, Dec 08, 2023 at 02:49:27PM -0800, Stefano Stabellini wrote: >> On Fri, 8 Dec 2023, Daniel P. Berrangé wrote: >> > On Thu, Dec 07, 2023 at 11:12:48PM +, Michael Young wrote: >> > > Builds of qemu-8.2.0rc2 with xen-4.18.0 are currently failing >> > >

[libvirt test] 184099: tolerable FAIL - PUSHED

flight 184099 libvirt real [real] flight 184104 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184099/ http://logs.test-lab.xenproject.org/osstest/logs/184104/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-li

Re: [PATCH] fix qemu build with xen-4.18.0

On Tue, 12 Dec 2023 at 14:20, Anthony PERARD wrote: > Building qemu with something like: > ./configure --enable-xen --cpu=x86_64 > used to work. Can we fix that? It still works with v8.1.0. > At least, it works on x86, I never really try to build qemu for arm. > Notice that there's no "--targe

Re: [PATCH] fix qemu build with xen-4.18.0

On Fri, Dec 08, 2023 at 02:49:27PM -0800, Stefano Stabellini wrote: > On Fri, 8 Dec 2023, Daniel P. Berrangé wrote: > > On Thu, Dec 07, 2023 at 11:12:48PM +, Michael Young wrote: > > > Builds of qemu-8.2.0rc2 with xen-4.18.0 are currently failing > > > with errors like > > > ../hw/arm/xen_arm.c

Re: [PATCH v4 05/12] xen/spinlock: add rspin_[un]lock_irq[save|restore]()

On 12.12.23 14:03, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Instead of special casing rspin_lock_irqsave() and rspin_unlock_irqrestore() for the console lock, add those functions to spinlock handling and use them where needed. Signed-off-by: Juergen Gross ---

Re: [PATCH RFC v2 for-6.8/block 15/18] buffer: add a new helper to read sb block

On Tue 12-12-23 05:25:25, Christoph Hellwig wrote: > On Mon, Dec 11, 2023 at 10:07:53PM +0800, Yu Kuai wrote: > > +static __always_inline int buffer_uptodate_or_error(struct buffer_head *bh) > > +{ > > + /* > > +* If the buffer has the write error flag, data was failed to write > > +* out

Re: [XEN PATCH 7/7] x86/xstate: move BUILD_BUG_ON to address MISRA C:2012 Rule 2.1

On 2023-12-12 15:01, Jan Beulich wrote: On 12.12.2023 14:38, Nicola Vetrini wrote: On 2023-12-12 11:07, Jan Beulich wrote: On 12.12.2023 11:04, Jan Beulich wrote: On 11.12.2023 11:30, Nicola Vetrini wrote: The string literal inside the expansion of BUILD_BUG_ON is considered unreachable code

Re: [PATCH v4 12/12] xen/spinlock: support higher number of cpus

On 12/12/2023 13:08, Juergen Gross wrote: On 12.12.23 13:39, Julien Grall wrote: Hi, On 12/12/2023 09:47, Juergen Gross wrote: Allow 16 bits per cpu number, which is the limit imposed by spinlock_tickets_t. This will allow up to 65535 cpus, while increasing only the size of recursive spinl

Re: [XEN PATCH 7/7] x86/xstate: move BUILD_BUG_ON to address MISRA C:2012 Rule 2.1

On 12.12.2023 14:38, Nicola Vetrini wrote: > On 2023-12-12 11:07, Jan Beulich wrote: >> On 12.12.2023 11:04, Jan Beulich wrote: >>> On 11.12.2023 11:30, Nicola Vetrini wrote: The string literal inside the expansion of BUILD_BUG_ON is considered unreachable code; however, such statement ca

[xen-unstable-smoke test] 184102: tolerable all pass - PUSHED

flight 184102 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184102/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH 7/7] x86/xstate: move BUILD_BUG_ON to address MISRA C:2012 Rule 2.1

On 2023-12-12 11:07, Jan Beulich wrote: On 12.12.2023 11:04, Jan Beulich wrote: On 11.12.2023 11:30, Nicola Vetrini wrote: The string literal inside the expansion of BUILD_BUG_ON is considered unreachable code; however, such statement can be moved earlier with no functional change. First: Why

Re: [PATCH RFC v2 for-6.8/block 15/18] buffer: add a new helper to read sb block

On Mon, Dec 11, 2023 at 10:07:53PM +0800, Yu Kuai wrote: > +static __always_inline int buffer_uptodate_or_error(struct buffer_head *bh) > +{ > + /* > + * If the buffer has the write error flag, data was failed to write > + * out in the block. In this case, set buffer uptodate to preve

Re: [PATCH RFC v2 for-6.8/block 17/18] ext4: remove block_device_ejected()

Looks good: Reviewed-by: Christoph Hellwig

[ovmf test] 184103: all pass - PUSHED

flight 184103 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184103/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cee7ba349c0c1ce489001a338a4e28555728b573 baseline version: ovmf 725acd0b9cc047b20a1b9

Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

> +void invalidate_bdev_range(struct block_device *bdev, pgoff_t start, > +pgoff_t end) > +{ > + invalidate_mapping_pages(bdev->bd_inode->i_mapping, start, end); > +} > +EXPORT_SYMBOL_GPL(invalidate_bdev_range); Can we have kerneldoc comments for the new helpers please?

Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

On Mon, Dec 11, 2023 at 05:52:17PM +0100, Jan Kara wrote: > > +void bdev_associated_mapping(struct block_device *bdev, > > +struct address_space *mapping) > > +{ > > + mapping->host = bdev->bd_inode; > > +} > > Here I'm not sure - is the helper really a win? It seems a bi

Re: [PATCH v4 12/12] xen/spinlock: support higher number of cpus

On 12.12.23 13:39, Julien Grall wrote: Hi, On 12/12/2023 09:47, Juergen Gross wrote: Allow 16 bits per cpu number, which is the limit imposed by spinlock_tickets_t. This will allow up to 65535 cpus, while increasing only the size of recursive spinlocks in debug builds from 8 to 12 bytes. Sign

Re: [PATCH v4 03/12] xen/spinlock: introduce new type for recursive spinlocks

Hi Juergen, On 12/12/2023 13:04, Juergen Gross wrote: On 12.12.23 13:57, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index 1cd9120eac..20d15f34dd 100644 --- a/xen/include/xen/spinlock.h +++ b/xe

Re: [PATCH v4 05/12] xen/spinlock: add rspin_[un]lock_irq[save|restore]()

Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Instead of special casing rspin_lock_irqsave() and rspin_unlock_irqrestore() for the console lock, add those functions to spinlock handling and use them where needed. Signed-off-by: Juergen Gross --- V2: - new patch --- xen/arch/x86/traps

Re: [PATCH v4 03/12] xen/spinlock: introduce new type for recursive spinlocks

On 12.12.23 13:57, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index 1cd9120eac..20d15f34dd 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -45,7 +45,7 @@ union lock_de

Re: [PATCH v4 04/12] xen/spinlock: rename recursive lock functions

Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Rename the recursive spin_lock() functions by replacing the trailing "_recursive" with a leading "r". Switch the parameter to be a pointer to rspinlock_t. Remove the indirection through a macro, as it is adding only complexity without any g

Re: [PATCH v4 03/12] xen/spinlock: introduce new type for recursive spinlocks

Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index 1cd9120eac..20d15f34dd 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -45,7 +45,7 @@ union lock_debug { }; lock profiling on:

xen | Successful pipeline for staging | cf40abbc

Pipeline #1103837091 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: cf40abbc ( https://gitlab.com/xen-project/xen/-/commit/cf40abbc7ff2a73eaaea84e919fc7762354e75ad ) Commit Message: tools/xenstor

Re: [PATCH v4 01/12] xen/spinlock: reduce lock profile ifdefs

Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: With some small adjustments to the LOCK_PROFILE_* macros some #ifdefs can be dropped from spinlock.c. Signed-off-by: Juergen Gross Reviewed-by: Alejandro Vallejo Acked-by: Julien Grall Cheers, -- Julien Grall

Re: [PATCH v4 12/12] xen/spinlock: support higher number of cpus

Hi, On 12/12/2023 09:47, Juergen Gross wrote: Allow 16 bits per cpu number, which is the limit imposed by spinlock_tickets_t. This will allow up to 65535 cpus, while increasing only the size of recursive spinlocks in debug builds from 8 to 12 bytes. Signed-off-by: Juergen Gross --- xen/comm

Re: [PATCH v4 12/12] xen/spinlock: support higher number of cpus

Hi, On 12/12/2023 12:11, Juergen Gross wrote: On 12.12.23 12:40, Julien Grall wrote: Hi Juergen, On 12/12/2023 11:09, Juergen Gross wrote: On 12.12.23 11:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Allow 16 bits per cpu number, which is the limit imposed b

Re: [PATCH v4 12/12] xen/spinlock: support higher number of cpus

On 12.12.23 12:40, Julien Grall wrote: Hi Juergen, On 12/12/2023 11:09, Juergen Gross wrote: On 12.12.23 11:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Allow 16 bits per cpu number, which is the limit imposed by spinlock_tickets_t. This will allow up to 655

Xen Security Advisory 447 v2 (CVE-2023-46837) - arm32: The cache may not be properly cleaned/invalidated (take two)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2023-46837 / XSA-447 version 2 arm32: The cache may not be properly cleaned/invalidated (take two) UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

Re: [OSSTEST PATCH 2/3] create_build_jobs: Enable X86_GENERIC for i386 kernel pvops jobs.

On 12.12.23 12:56, Anthony PERARD wrote: On Tue, Dec 12, 2023 at 09:48:46AM +0100, Juergen Gross wrote: On 12.12.23 09:38, Roger Pau Monné wrote: On Fri, Dec 08, 2023 at 04:02:25PM +, Anthony PERARD wrote: This is following a failure to build "arch/x86/xen/enlighten.c" in build-i386-pvops

Re: [OSSTEST PATCH 2/3] create_build_jobs: Enable X86_GENERIC for i386 kernel pvops jobs.

On Tue, Dec 12, 2023 at 09:48:46AM +0100, Juergen Gross wrote: > On 12.12.23 09:38, Roger Pau Monné wrote: > > On Fri, Dec 08, 2023 at 04:02:25PM +, Anthony PERARD wrote: > > > This is following a failure to build "arch/x86/xen/enlighten.c" in > > > build-i386-pvops jobs with linux 968f35f4ab1c

Re: [XEN PATCH] xen/arm: smmu: move phys_addr_t definition to linux-compat.h

On 11/12/2023 14:54, Federico Serafini wrote: Both smmu and smmu-v3 (ported from Linux) define the typedef name "phys_addr_t": move the type definition to the common header linux-compat.h to address violations of MISRA C:2012 Rule 5.6 ("A typedef name shall be a unique identifier"). No functio

Re: [PATCH] MAINTAINERS: Hand over the release manager role to Oleksii Kurochko

On 07/12/2023 18:46, Julien Grall wrote: Hi, On 07/12/2023 16:20, Henry Wang wrote: I've finished the opportunity to do two releases (4.17 and 4.18) and Oleksii Kurochko has volunteered to be the next release manager. Henry, thanks for your time as release manager. Oleksii, thanks for step

Re: [PATCH v3 0/3] xen: have a more generic unaligned.h header

Hi Juergen, On 11/12/2023 13:16, Juergen Gross wrote: Update Xen's unaligned.h header to support all architectures, allowing to remove the architecture specific variants (x86 only until now). Changes in V2: - new patch 1 (Julien Grall) - adjusted patch 2 (Jan Beulich) Changes in V3: - adjusted

Re: [PATCH v4 12/12] xen/spinlock: support higher number of cpus

Hi Juergen, On 12/12/2023 11:09, Juergen Gross wrote: On 12.12.23 11:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Allow 16 bits per cpu number, which is the limit imposed by spinlock_tickets_t. This will allow up to 65535 cpus, while increasing only the size

  1   2   >