On 2023-11-22 23:20, Andrew Cooper wrote:
On 22/11/2023 10:13 pm, Stefano Stabellini wrote:
On Wed, 22 Nov 2023, Andrew Cooper wrote:
The differences between inline, __inline and __inline__ keywords are
a
vestigial remnant of older C standards, and in Xen we use inline
almost
exclusively.
Re
On 2023-11-22 17:46, Andrew Cooper wrote:
On 22/11/2023 4:39 pm, Nicola Vetrini wrote:
On 2023-11-22 15:27, Andrew Cooper wrote:
The differences between inline, __inline and __inline__ keywords are
a
vestigial remnant of older C standards, and in Xen we use inline
almost
exclusively.
Replace
No functional change.
Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
---
Changes in v2:
- Changed macro name
Changes in v3:
- Changed macro name
---
xen/common/vmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/vmap.c b/xen/common/vmap.c
index 4
This series replaces two instances of the pattern (x & -x) with the
macro ISOLATE_LSB.
Nicola Vetrini (2):
xen/vmap: use ISOLATE_LSB to wrap a violation of Rule 10.1
xen/iommu: use ISOLATE_LSB to wrap a violation of Rule 10.1
xen/common/vmap.c | 2 +-
xen/drivers/passthrough/io
No functional change.
Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
Acked-by: Jan Beulich
---
Changes in v2:
- Changed macro name
Changes in v3:
- Changed macro name
---
xen/drivers/passthrough/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/driv
This series contains the leftover patches from [1] with the rename
s/ISOLATE_LOW_BIT/ISOLATE_LSB/ applied. All the already committed patches from
the aforementioned series are dropped.
[1] https://marc.info/?l=xen-devel&m=169841347803987
Nicola Vetrini (3):
arm/bitops: encapsulate violation of
The definition of PDX_GROUP_COUNT causes violations of
MISRA C:2012 Rule 10.1, therefore the problematic part now uses
the ISOLATE_LSB macro, which encapsulates the pattern.
Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
---
Changes in v4:
- Changed macro name.
Changes in v5:
- Ch
The definitions of ffs{l}? violate Rule 10.1, by using the well-known
pattern (x & -x); its usage is wrapped by the ISOLATE_LSB macro.
No functional change.
Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
---
Changes in v4:
- Changed macro name.
Changes in v5:
- Changed macro name
The various definitions of macro CNT (and the related BUILD_BUG_ON)
can be rewritten using ISOLATE_LSB, encapsulating a violation of
MISRA C:2012 Rule 10.1.
Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
Acked-by: Jan Beulich
---
Changes in v4:
- Changed macro name
Changes in v5:
On 22.11.2023 13:25, Andrew Cooper wrote:
> On 22/11/2023 7:43 am, Jan Beulich wrote:
>> --- a/xen/tools/gen-cpuid.py
>> +++ b/xen/tools/gen-cpuid.py
>> @@ -274,7 +274,7 @@ def crunch_numbers(state):
>> # superpages, PCID and PKU are only available in 4 level paging.
>> # NO_LMSL
On 22.11.2023 14:02, Juergen Gross wrote:
> After a new build on my system (OpenSUSE Leap 15.5) "git status" will
> print out:
>
> Untracked files:
> (use "git add ..." to include in what will be committed)
> tools/pygrub/pygrub.egg-info/
> tools/python/xen.egg-info/
>
> This sm
On 23.11.23 00:07, Stefano Stabellini wrote:
On Wed, 22 Nov 2023, Juergen Gross wrote:
On 22.11.23 04:07, Stefano Stabellini wrote:
On Mon, 20 Nov 2023, Stefano Stabellini wrote:
On Mon, 20 Nov 2023, Juergen Gross wrote:
On 20.11.23 03:21, osstest service owner wrote:
flight 183794 linux-lin
Hi,
> On Nov 23, 2023, at 12:20, Henry Wang wrote:
>
> Hi,
>
>> On Nov 23, 2023, at 02:03, Andrew Cooper wrote:
>>
>> On 22/11/2023 3:49 pm, Luca Fancellu wrote:
>>>
On 21 Nov 2023, at 20:41, Andrew Cooper wrote:
On 21/11/2023 8:33 pm, Luca Fancellu wrote:
> + CC henry
>
Hi,
> On Nov 23, 2023, at 02:03, Andrew Cooper wrote:
>
> On 22/11/2023 3:49 pm, Luca Fancellu wrote:
>>
>>> On 21 Nov 2023, at 20:41, Andrew Cooper wrote:
>>>
>>> On 21/11/2023 8:33 pm, Luca Fancellu wrote:
+ CC henry
> On 21 Nov 2023, at 20:15, Andrew Cooper wrote:
>
>>
Hi David,
David Woodhouse writes:
> [[S/MIME Signed Part:Undecided]]
> On Tue, 2023-11-21 at 22:10 +, Volodymyr Babchuk wrote:
>>
>> --- a/hw/xen/xen-operations.c
>> +++ b/hw/xen/xen-operations.c
>> @@ -300,6 +300,18 @@ static bool libxenstore_create(struct qemu_xs_handle
>> *h, xs_transa
Hi Vikram,
Vikram Garhwal writes:
> Hi Volodymyr,
> Thank you sharing this patch. I have few comments below
> On Wed, Nov 22, 2023 at 02:39:46PM -0800, Stefano Stabellini wrote:
>> +Vikram
>>
>> On Tue, 21 Nov 2023, Volodymyr Babchuk wrote:
>> > From: Oleksandr Tyshchenko
>> >
>> > The brid
Hi,
Volodymyr Babchuk writes:
> Hi Stefano,
>
> Stefano Stabellini writes:
>
>> On Wed, 22 Nov 2023, David Woodhouse wrote:
>>> On Wed, 2023-11-22 at 15:09 -0800, Stefano Stabellini wrote:
>>> > On Wed, 22 Nov 2023, David Woodhouse wrote:
>>> > > On Wed, 2023-11-22 at 14:29 -0800, Stefano Sta
On Wed, 2023-11-22 at 23:49 +, Volodymyr Babchuk wrote:
>
> I can just pull it from this link, if you don't mind.
Please do; thank you!
smime.p7s
Description: S/MIME cryptographic signature
Amazon Development Centre (London) Ltd. Registered in England and Wales with
registration number
Hi David,
"Woodhouse, David" writes:
> On Wed, 2023-11-22 at 17:05 +, Paul Durrant wrote:
>> On 21/11/2023 22:10, Volodymyr Babchuk wrote:
>> > From: David Woodhouse
>> >
>> > This allows a XenDevice implementation to know whether it was created
>> > by QEMU, or merely discovered in XenSt
Hi Stefano,
Stefano Stabellini writes:
> On Wed, 22 Nov 2023, David Woodhouse wrote:
>> On Wed, 2023-11-22 at 15:09 -0800, Stefano Stabellini wrote:
>> > On Wed, 22 Nov 2023, David Woodhouse wrote:
>> > > On Wed, 2023-11-22 at 14:29 -0800, Stefano Stabellini wrote:
>> > > > On Wed, 22 Nov 2023
Hi Volodymyr,
Thank you sharing this patch. I have few comments below
On Wed, Nov 22, 2023 at 02:39:46PM -0800, Stefano Stabellini wrote:
> +Vikram
>
> On Tue, 21 Nov 2023, Volodymyr Babchuk wrote:
> > From: Oleksandr Tyshchenko
> >
> > The bridge is needed for virtio-pci support, as QEMU can em
flight 183821 xen-unstable real [real]
flight 183829 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/183821/
http://logs.test-lab.xenproject.org/osstest/logs/183829/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be r
On Wed, 22 Nov 2023, David Woodhouse wrote:
> On Wed, 2023-11-22 at 15:09 -0800, Stefano Stabellini wrote:
> > On Wed, 22 Nov 2023, David Woodhouse wrote:
> > > On Wed, 2023-11-22 at 14:29 -0800, Stefano Stabellini wrote:
> > > > On Wed, 22 Nov 2023, Paul Durrant wrote:
> > > > > On 21/11/2023 22:1
On Wed, 2023-11-22 at 22:49 +, Volodymyr Babchuk wrote:
>
> > On 21/11/23 23:10, Volodymyr Babchuk wrote:
> > > was created by QEMU
> >
> > Please do not split lines between subject and content. Rewrite the
> > full line. Preferably restrict the subject to 72 chars.
>
> I tried to come with
On Wed, 2023-11-22 at 15:09 -0800, Stefano Stabellini wrote:
> On Wed, 22 Nov 2023, David Woodhouse wrote:
> > On Wed, 2023-11-22 at 14:29 -0800, Stefano Stabellini wrote:
> > > On Wed, 22 Nov 2023, Paul Durrant wrote:
> > > > On 21/11/2023 22:10, Volodymyr Babchuk wrote:
> > > > > From: Oleksandr
On Wed, 22 Nov 2023, David Woodhouse wrote:
> On Wed, 2023-11-22 at 14:29 -0800, Stefano Stabellini wrote:
> > On Wed, 22 Nov 2023, Paul Durrant wrote:
> > > On 21/11/2023 22:10, Volodymyr Babchuk wrote:
> > > > From: Oleksandr Tyshchenko
> > > >
> > > > Instead of forcing the owner to domid 0, u
On Wed, 22 Nov 2023, Juergen Gross wrote:
> On 22.11.23 04:07, Stefano Stabellini wrote:
> > On Mon, 20 Nov 2023, Stefano Stabellini wrote:
> > > On Mon, 20 Nov 2023, Juergen Gross wrote:
> > > > On 20.11.23 03:21, osstest service owner wrote:
> > > > > flight 183794 linux-linus real [real]
> > > >
Hi David,
David Woodhouse writes:
> [[S/MIME Signed Part:Undecided]]
> On Tue, 2023-11-21 at 22:10 +, Volodymyr Babchuk wrote:
>>
>> --- a/hw/xen/xen-operations.c
>> +++ b/hw/xen/xen-operations.c
>> @@ -300,6 +300,18 @@ static bool libxenstore_create(struct qemu_xs_handle
>> *h, xs_transa
On Wed, 2023-11-22 at 22:56 +, Volodymyr Babchuk wrote:
>
>
> Paul Durrant writes:
>
> > On 21/11/2023 22:10, Volodymyr Babchuk wrote:
> > > From: David Woodhouse
> > > This allows a XenDevice implementation to know whether it was
> > > created
> > > by QEMU, or merely discovered in XenSto
On Wed, 2023-11-22 at 14:29 -0800, Stefano Stabellini wrote:
> On Wed, 22 Nov 2023, Paul Durrant wrote:
> > On 21/11/2023 22:10, Volodymyr Babchuk wrote:
> > > From: Oleksandr Tyshchenko
> > >
> > > Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to
> > > inherit the owner of the d
On Tue, 2023-11-21 at 22:10 +, Volodymyr Babchuk wrote:
>
> --- a/hw/xen/xen-operations.c
> +++ b/hw/xen/xen-operations.c
> @@ -300,6 +300,18 @@ static bool libxenstore_create(struct qemu_xs_handle *h,
> xs_transaction_t t,
> return false;
> }
>
> + if (owner == XS_PRESERVE
On Wed, 22 Nov 2023, Simone Ballarin wrote:
> > > diff --git a/automation/gitlab-ci/build.yaml
> > > b/automation/gitlab-ci/build.yaml
> > > index 32af30cced..6b2ac97248 100644
> > > --- a/automation/gitlab-ci/build.yaml
> > > +++ b/automation/gitlab-ci/build.yaml
> > > @@ -1,6 +1,10 @@
> > > .bu
Paul Durrant writes:
> On 21/11/2023 22:10, Volodymyr Babchuk wrote:
>> From: David Woodhouse
>> This allows a XenDevice implementation to know whether it was
>> created
>> by QEMU, or merely discovered in XenStore after the toolstack created
>> it. This will allow us to create frontend/backe
Hi Paul,
Paul Durrant writes:
> On 21/11/2023 22:10, Volodymyr Babchuk wrote:
>> was created by QEMU
>> Xen PV devices in QEMU can be created in two ways: either by QEMU
>> itself, if they were passed via command line, or by Xen toolstack. In
>> the latter case, QEMU scans XenStore entries and
Hi Philippe,
Philippe Mathieu-Daudé writes:
> Hi Volodymyr,
>
> On 21/11/23 23:10, Volodymyr Babchuk wrote:
>> was created by QEMU
>
> Please do not split lines between subject and content. Rewrite the
> full line. Preferably restrict the subject to 72 chars.
I tried to come with shorter descr
On Wed, 2023-11-22 at 17:03 +, Paul Durrant wrote:
>
> > This patch checks presence of xendev->backend to check if Xen PV
> > device is acting as a backend (i.e. it was configured by Xen
>
> Technally *all* XenDevice objects are backends.
Right. The key criterion is whether the backend was c
On Wed, 2023-11-22 at 17:05 +, Paul Durrant wrote:
> On 21/11/2023 22:10, Volodymyr Babchuk wrote:
> > From: David Woodhouse
> >
> > This allows a XenDevice implementation to know whether it was created
> > by QEMU, or merely discovered in XenStore after the toolstack created
> > it. This wil
+Vikram
On Tue, 21 Nov 2023, Volodymyr Babchuk wrote:
> From: Oleksandr Tyshchenko
>
> The bridge is needed for virtio-pci support, as QEMU can emulate the
> whole bridge with any virtio-pci devices connected to it.
>
> This patch provides a flexible way to configure PCIe brige resources
> with
On 06/11/2023 3:05 pm, Alejandro Vallejo wrote:
> Create a wrapper for the new fdopen() function of libfsimage.
>
> Signed-off-by: Alejandro Vallejo
I'd appreciate it if Marek would cast his eye (as python maintainer)
over it.
That said, ...
> diff --git a/tools/pygrub/src/fsimage/fsimage.c
>
On 06/11/2023 3:05 pm, Alejandro Vallejo wrote:
> diff --git a/tools/libfsimage/common/fsimage_priv.h
> b/tools/libfsimage/common/fsimage_priv.h
> index 2274403557..779e433b37 100644
> --- a/tools/libfsimage/common/fsimage_priv.h
> +++ b/tools/libfsimage/common/fsimage_priv.h
> @@ -29,6 +29,7 @@ e
On Wed, 22 Nov 2023, Paul Durrant wrote:
> On 21/11/2023 22:10, Volodymyr Babchuk wrote:
> > From: Oleksandr Tyshchenko
> >
> > Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to
> > inherit the owner of the directory.
>
> Ah... so that's why the previous patch is there.
>
> This
On Wed, 22 Nov 2023, Paul Durrant wrote:
> On 21/11/2023 22:10, Volodymyr Babchuk wrote:
> > Add option to preserve owner when creating an entry in Xen Store. This
> > may be needed in cases when Qemu is working as device model in a
>
> *may* be needed?
>
> I don't undertstand why this patch is n
On Wed, 22 Nov 2023, Federico Serafini wrote:
> Add missing parameter names and uniform the interfaces of
> modify_xen_mappings() and modify_xen_mappings_lite().
>
> No functional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Stefano Stabellini
On 22/11/2023 10:13 pm, Stefano Stabellini wrote:
> On Wed, 22 Nov 2023, Andrew Cooper wrote:
>> The differences between inline, __inline and __inline__ keywords are a
>> vestigial remnant of older C standards, and in Xen we use inline almost
>> exclusively.
>>
>> Replace __inline and __inline__ wi
On Wed, 22 Nov 2023, Federico Serafini wrote:
> The objective is to use parameter name "nf" to denote "new flags"
> in all the modify_xen_mappings* functions.
> Since modify_xen_mappings_lite() is currently using "nf" as identifier
> for a local variable, bad things could happen if new uses of such
On Wed, 22 Nov 2023, Andrew Cooper wrote:
> The differences between inline, __inline and __inline__ keywords are a
> vestigial remnant of older C standards, and in Xen we use inline almost
> exclusively.
>
> Replace __inline and __inline__ with regular inline, and remove their
> exceptions from th
On Wed, 22 Nov 2023, Andrew Cooper wrote:
> Use MSR_X2APIC_FIRST from msr-index.h instead.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Stefano Stabellini
On Wed, 22 Nov 2023, Andrew Cooper wrote:
> The last users were dropped in commit 413e92e9bf13 ("x86/apic: Drop
> workarounds for Pentium/82489DX erratum").
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Stefano Stabellini
> ---
> CC: Jan Beulich
> CC: Roger Pau Monné
> CC: Wei Liu
> ---
>
On 11/17/23 08:33, Roger Pau Monné wrote:
> On Wed, Sep 13, 2023 at 10:35:46AM -0400, Stewart Hildebrand wrote:
>> +int vpci_add_register_mask(struct vpci *vpci, vpci_read_t *read_handler,
>> + vpci_write_t *write_handler, unsigned int offset,
>> +
Two out of three do_multicall definitions/declarations use uint32_t as
type for the "nr_calls" parameters. Change the third one to be
consistent with the other two.
Link:
https://lore.kernel.org/xen-devel/7e3abd4c0ef5127a07a60de1bf090a8aefac8e5c.1692717906.git.federico.seraf...@bugseng.com/
Link
On 22/11/2023 9:27 pm, Olaf Hering wrote:
> Wed, 22 Nov 2023 20:46:15 + Andrew Cooper :
>
>> But that entirely depends on whether you think anyone is using it or not.
> We never got any bugreport, nor have we any indication for actual usage.
> The script was in the sources. Python3 is supposed
Wed, 22 Nov 2023 20:46:15 + Andrew Cooper :
> But that entirely depends on whether you think anyone is using it or not.
We never got any bugreport, nor have we any indication for actual usage.
The script was in the sources. Python3 is supposed to be the default
interpreter since a number of y
On Wed, 22 Nov 2023, Nicola Vetrini wrote:
> > >
> > > Jan, would you be willing to accept that other maintainers have a
> > > preference for having a single MACRO even if suboptimal?
> >
> > I can live with that, even if I'm surprised by this perspective that others
> > take. How can we, in revi
On Wed, 22 Nov 2023, Roger Pau Monné wrote:
> On Tue, Nov 21, 2023 at 05:12:15PM -0800, Stefano Stabellini wrote:
> > On Tue, 20 Nov 2023, Volodymyr Babchuk wrote:
> > > Stefano Stabellini writes:
> > > > On Fri, 17 Nov 2023, Volodymyr Babchuk wrote:
> > > >> > On Fri, 17 Nov 2023, Volodymyr Babch
On 22/11/2023 8:43 pm, Olaf Hering wrote:
> Wed, 22 Nov 2023 20:30:59 + Andrew Cooper :
>
>> Does this mean there are SLES/OpenSUSE users of xenpvboot ?
> We do not know. It is gone by now, in 4.18:
>
> https://build.opensuse.org/request/show/1126897
Yes. The email I replied to was the patch
Wed, 22 Nov 2023 20:30:59 + Andrew Cooper :
> Does this mean there are SLES/OpenSUSE users of xenpvboot ?
We do not know. It is gone by now, in 4.18:
https://build.opensuse.org/request/show/1126897
Olaf
pgp4eQYvj2jrR.pgp
Description: Digitale Signatur von OpenPGP
On 06/10/2023 3:50 pm, Roger Pau Monne wrote:
> The script heavily relies on the urlgrabber python module, which doesn't seem
> to be packaged by all distros, it's missing from newer Debian versions at
> least.
>
> Also the usage of the commands module has been deprecated since Python 2.6,
> and
>
On 11/17/23 07:40, Roger Pau Monné wrote:
> On Wed, Sep 13, 2023 at 10:35:46AM -0400, Stewart Hildebrand wrote:
>> Introduce a handler for the PCI status register, with ability to mask the
>> capabilities bit. The status register contains RsvdZ bits, read-only bits,
>> and
>> write-1-to-clear bits
On 06/11/2023 3:05 pm, Alejandro Vallejo wrote:
> diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub
> index 327cf51774..b96bdfd849 100755
> --- a/tools/pygrub/src/pygrub
> +++ b/tools/pygrub/src/pygrub
> @@ -75,6 +80,11 @@ def downgrade_rlimits():
> resource.setrlimit(resource.RLI
On 06/11/2023 3:05 pm, Alejandro Vallejo wrote:
> The env variable must be interpreted as an integer. As it is, the override
> logic simply causes an exception.
Fixes: e0342ae5556f ("tools/pygrub: Deprivilege pygrub")
> Signed-off-by: Alejandro Vallejo
> ---
> tools/pygrub/src/pygrub | 2 +-
>
This has an identical meaning, and is the more pythonic way of writing it.
Signed-off-by: Andrew Cooper
---
CC: Wei Liu
CC: Anthony PERARD
CC: Alejandro Vallejo
---
tools/pygrub/src/pygrub | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/pygrub/src/pygrub b/tools/pygr
On 22/11/2023 7:46 pm, Andrew Cooper wrote:
> On 06/11/2023 3:05 pm, Alejandro Vallejo wrote:
>> This is important in order for every mount done inside a mount namespace to
>> go away after the namespace itself goes away. The comment referring to
>> unreliability in Linux 4.19 was just wrong.
>>
>>
On 06/11/2023 3:05 pm, Alejandro Vallejo wrote:
> This is important in order for every mount done inside a mount namespace to
> go away after the namespace itself goes away. The comment referring to
> unreliability in Linux 4.19 was just wrong.
>
> This patch sets the story straight and makes the d
On 22/11/2023 4:39 pm, Frediano Ziglio wrote:
> In case it's not possible to enable memory sharing (mem_sharing_control
> fails) we just return the error code without releasing the domain
> acquired some lines above by rcu_lock_live_remote_domain_by_id.
Fixes: 72f8d45d69b8 ("x86/mem_sharing: enabl
Hi Ayan,
On 22/11/2023 20:00, Ayan Kumar Halder wrote:
> Hi Amit/All,
>
> We came across this scenario and would be helpful if you can provide
> some pointers
>
>
> Linux running as Dom0 on Xen hypervisor with HVC_DCC = y and HVC_XEN = y
> on Arm64 platform.
>
> This causes a crash when Dom0
On Wed, 22 Nov 2023, Andrew Cooper wrote:
> On 22/11/2023 3:49 pm, Luca Fancellu wrote:
> >
> >> On 21 Nov 2023, at 20:41, Andrew Cooper wrote:
> >>
> >> On 21/11/2023 8:33 pm, Luca Fancellu wrote:
> >>> + CC henry
> >>>
> On 21 Nov 2023, at 20:15, Andrew Cooper
> wrote:
>
>
On 22/11/2023 4:20 pm, Andrew Cooper wrote:
> On 22/11/2023 9:02 am, Jan Beulich wrote:
>> On 21.11.2023 21:15, Andrew Cooper wrote:
>>> @@ -913,33 +914,30 @@ static struct domain *__init create_dom0(const
>>> module_t *image,
>>> panic("Error creating d%uv0\n", domid);
>>>
>>> /*
Hi Amit/All,
We came across this scenario and would be helpful if you can provide
some pointers
Linux running as Dom0 on Xen hypervisor with HVC_DCC = y and HVC_XEN = y
on Arm64 platform.
This causes a crash when Dom0 tries to access "DBGDTRTX_EL0" register,
it traps to Xen.
Xen does no
Dear Sir or Madam,
I am a firmware developer working on ARM-based SoC. We have recently added
Xen support (v4.17) to our firmware. Now I am trying to find a test
framework for routine testing of Xen on our SoCs.
Unfortunately, wiki.xenproject.org is not very up-to-date, and the
situation with tes
On 22/11/2023 3:49 pm, Luca Fancellu wrote:
>
>> On 21 Nov 2023, at 20:41, Andrew Cooper wrote:
>>
>> On 21/11/2023 8:33 pm, Luca Fancellu wrote:
>>> + CC henry
>>>
On 21 Nov 2023, at 20:15, Andrew Cooper wrote:
-Wwrite-strings is unhappy with assigning "xen" to a mutable pointer,
Hi, while rebasing with something else I noticed that...
On Tue, Nov 07, 2023 at 03:49:20PM +, Alejandro Vallejo wrote:
> Remove all duplication in CPUID and MSR xend-style overrides. They had an
> incredible amount of overhead for no good reason.
>
> After this patch, CPU policy application
On 22/11/23 15:27, Andrew Cooper wrote:
The differences between inline, __inline and __inline__ keywords are a
vestigial remnant of older C standards, and in Xen we use inline almost
exclusively.
Replace __inline and __inline__ with regular inline, and remove their
exceptions from the MISRA conf
On Wed, Nov 22, 2023 at 04:08:17PM +, Alejandro Vallejo wrote:
> Both Intel and AMD manuals agree that on x2APIC mode, the APIC LDR and ID
> registers are derivable from each other through a fixed formula.
>
> Xen uses that formula, but applies it to vCPU IDs (which are sequential)
> rather th
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
From: Oleksandr Tyshchenko
Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to
inherit the owner of the directory.
Ah... so that's why the previous patch is there.
This is not the right way to fix it. The QEMU Xen support is *assumi
flight 183826 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183826/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
Add option to preserve owner when creating an entry in Xen Store. This
may be needed in cases when Qemu is working as device model in a
*may* be needed?
I don't undertstand why this patch is necessary and the commit comment
isn't really helping me
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
From: David Woodhouse
This allows a XenDevice implementation to know whether it was created
by QEMU, or merely discovered in XenStore after the toolstack created
it. This will allow us to create frontend/backend nodes only when we
should, rather tha
On Wed, Nov 22, 2023 at 03:11:52PM +, Alejandro Vallejo wrote:
> On Wed, Nov 22, 2023 at 02:40:02PM +0100, Roger Pau Monné wrote:
> > On Tue, Nov 21, 2023 at 04:26:04PM +, Alejandro Vallejo wrote:
> > > diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
> > > index a8e87c444
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
was created by QEMU
Xen PV devices in QEMU can be created in two ways: either by QEMU
itself, if they were passed via command line, or by Xen toolstack. In
the latter case, QEMU scans XenStore entries and configures devices
accordingly.
In the secon
Minor style change, structure is not changed.
No functional change.
Signed-off-by: Frediano Ziglio
---
xen/arch/x86/acpi/power.c | 2 +-
xen/arch/x86/include/asm/acpi.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/powe
On 22/11/2023 4:39 pm, Nicola Vetrini wrote:
> On 2023-11-22 15:27, Andrew Cooper wrote:
>> The differences between inline, __inline and __inline__ keywords are a
>> vestigial remnant of older C standards, and in Xen we use inline almost
>> exclusively.
>>
>> Replace __inline and __inline__ with re
In case it's not possible to enable memory sharing (mem_sharing_control
fails) we just return the error code without releasing the domain
acquired some lines above by rcu_lock_live_remote_domain_by_id.
Signed-off-by: Frediano Ziglio
--
I didn't manage to check the change, I was just looking at th
On 2023-11-22 15:27, Andrew Cooper wrote:
The differences between inline, __inline and __inline__ keywords are a
vestigial remnant of older C standards, and in Xen we use inline almost
exclusively.
Replace __inline and __inline__ with regular inline, and remove their
exceptions from the MISRA co
On Thu, Nov 16, 2023 at 1:54 PM Roger Pau Monné wrote:
>
> On Thu, Nov 16, 2023 at 01:39:27PM +0100, Jan Beulich wrote:
> > On 16.11.2023 12:58, Roger Pau Monne wrote:
> > > --- a/xen/include/public/sysctl.h
> > > +++ b/xen/include/public/sysctl.h
> > > @@ -991,10 +991,7 @@ struct livepatch_func {
On 22/11/2023 4:26 pm, Frediano Ziglio wrote:
> ambigious -> ambiguous
>
> Signed-off-by: Frediano Ziglio
Acked-by: Andrew Cooper
ambigious -> ambiguous
Signed-off-by: Frediano Ziglio
---
xen/arch/x86/mm/mem_sharing.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index 142258f16a..9647e651f9 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/
flight 183825 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183825/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 8736b8fdca85e02933cdb0a13309de14c9799ece
baseline version:
ovmf 23dbb8a07d108a7b8589e
On 22/11/2023 9:27 am, Jan Beulich wrote:
> On 21.11.2023 21:15, Andrew Cooper wrote:
>> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but all
>> this work is useless; it's making a memory allocation just to prepend the
>> image name which cmdline_cook() intentionally strips
On 22/11/2023 9:02 am, Jan Beulich wrote:
> On 21.11.2023 21:15, Andrew Cooper wrote:
>> There's a confusing mix of variables; a static dom0_cmdline[], and a cmdline
>> pointer which points to image->string before being pointed at the static
>> buffer in order to be passed into construct_dom0(). c
Both Intel and AMD manuals agree that on x2APIC mode, the APIC LDR and ID
registers are derivable from each other through a fixed formula.
Xen uses that formula, but applies it to vCPU IDs (which are sequential)
rather than x2APIC IDs (which are not, at the moment). As I understand it,
this is an
On 22/11/2023 2:27 pm, Andrew Cooper wrote:
> The differences between inline, __inline and __inline__ keywords are a
> vestigial remnant of older C standards, and in Xen we use inline almost
> exclusively.
>
> Replace __inline and __inline__ with regular inline, and remove their
> exceptions from t
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
From: David Woodhouse
This allows a XenDevice implementation to know whether it was created
by QEMU, or merely discovered in XenStore after the toolstack created
it. This will allow us to create frontend/backend nodes only when we
should, rather tha
> On 21 Nov 2023, at 20:41, Andrew Cooper wrote:
>
> On 21/11/2023 8:33 pm, Luca Fancellu wrote:
>> + CC henry
>>
>>> On 21 Nov 2023, at 20:15, Andrew Cooper wrote:
>>>
>>> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but
>>> this
>>> logic looks incorrect. It was
Pipeline #1081610073 has passed!
Project: xen ( https://gitlab.com/xen-project/xen )
Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging )
Commit: c22fe721 (
https://gitlab.com/xen-project/xen/-/commit/c22fe7213c9b1f99cbc64c33e391afa223f9cd08
)
Commit Message: automation: s
On Wed, Nov 22, 2023 at 02:40:02PM +0100, Roger Pau Monné wrote:
> On Tue, Nov 21, 2023 at 04:26:04PM +, Alejandro Vallejo wrote:
> > Both Intel and AMD manuals agree that on x2APIC mode, the APIC LDR and ID
> > registers are derivable from each other through a fixed formula.
> >
> > Xen uses
GICD_CTL_ENABLE is a GICv2 bit. Remove it. The definitions of
GICD_CTL_ENABLE and GICD_CTLR_ENABLE_G1 are identical, so the value
written is unchanged.
Signed-off-by: Stewart Hildebrand
---
xen/arch/arm/gic-v3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm
flight 183819 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183819/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 183808
test-armhf-armhf-libvirt-raw 15 saveresto
Use MSR_X2APIC_FIRST from msr-index.h instead.
Signed-off-by: Andrew Cooper
---
CC: Jan Beulich
CC: Roger Pau Monné
CC: Wei Liu
---
xen/arch/x86/include/asm/apic.h| 4 ++--
xen/arch/x86/include/asm/apicdef.h | 3 ---
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/xen/arch/
Along with two minor pieces of cleanup in x86/apic found while doing this
work.
Gitlab CI:
https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1081682400
Andrew Cooper (3):
x86/apic: Drop atomic accessors
x86/apic: Drop the APIC_MSR_BASE constant
xen/MISRA: Remove nonstandard in
The differences between inline, __inline and __inline__ keywords are a
vestigial remnant of older C standards, and in Xen we use inline almost
exclusively.
Replace __inline and __inline__ with regular inline, and remove their
exceptions from the MISRA configuration.
Signed-off-by: Andrew Cooper
1 - 100 of 164 matches
Mail list logo
